Skip to contentSkip to conversation

sunrpc: fix expiry of auth creds

PATCH New Dan Aloni 1 participant 1 message Jul 11, 2022

Subsystems (3)
lore
Share & tools
lore

Dan Aloni

author
#0 lore raw

PATCH 1/1 sunrpc: fix expiry of auth creds

Before this commit, with a large enough LRU of expired items (100), the loop skipped the expired items and was entirely ineffectual in trimming the LRU list.

Fixes 95cd623250ad ('SUNRPC: Clean up the AUTH cache code')
Cc Trond Myklebust <[email protected]>
---
 net/sunrpc/auth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/sunrpc/auth.c +1 -1
index 682fcd24bf43..2324d1e58f21 100644
@@ -445,7 +445,7 @@ rpcauth_prune_expired(struct list_head *free, int nr_to_scan)
 		 * Enforce a 60 second garbage collection moratorium
 		 * Note that the cred_unused list must be time-ordered.
 		 */
-		if (!time_in_range(cred->cr_expire, expired, jiffies))
+		if (time_in_range(cred->cr_expire, expired, jiffies))
 			continue;
 		if (!rpcauth_unhash_cred(cred))
 			continue;
Signature · 1 line
2.23.0