Skip to contentSkip to conversation

gcc : Bug-105039

PATCH In review [email protected] 2 participants 2 messages Jul 11, 2022 – Jul 14, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gcc : Bug-105039

From: pgowda <[email protected]>

Upstream-Status: Backport [https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=9234cdca6ee88badfc00297e72f13dac4e540c79]

---
 meta/recipes-devtools/gcc/gcc-12.1.inc        |  1 +
 .../gcc/gcc/0026-rust-recursion-limit.patch   | 92 +++++++++++++++++++
 2 files changed, 93 insertions(+)
 create mode 100644 meta/recipes-devtools/gcc/gcc/0026-rust-recursion-limit.patch
meta/recipes-devtools/gcc/gcc-12.1.inc +1 -0
index 250b587e78..8c6c4a0305 100644
@@ -63,6 +63,7 @@ SRC_URI = "${BASEURI} \
            file://0023-libatomic-Do-not-enforce-march-on-aarch64.patch \
            file://0024-Fix-install-path-of-linux64.h.patch \
            file://0025-Move-sched.h-include-ahead-of-user-headers.patch \
+           file://0026-rust-recursion-limit.patch \
 "
 SRC_URI[sha256sum] = "62fd634889f31c02b64af2c468f064b47ad1ca78411c45abe6ac4b5f8dd19c7b"
 
meta/recipes-devtools/gcc/gcc/0026-rust-recursion-limit.patch new file +92 -0

92 lines not on this page · raw message

Signature · 1 line
2.25.1
#1 lore raw
Quoted 10 lines · Pgowda

From: pgowda <[email protected]>

Upstream-Status: Backport [https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=9234cdca6ee88badfc00297e72f13dac4e540c79]

---
 meta/recipes-devtools/gcc/gcc-12.1.inc        |  1 +
 .../gcc/gcc/0026-rust-recursion-limit.patch   | 92 +++++++++++++++++++
 2 files changed, 93 insertions(+)
 create mode 100644 meta/recipes-devtools/gcc/gcc/0026-rust-recursion-limit.patch

The patch is fine but the commit message needs work. The shortlog whitespace is wrong and it needs to say that 105039 is a gcc bug, that it is related to the rust demangler. The commit log should really say why we need this as well. The upstream status should be in the patch itself (which it is), not in the commit log. The URL to the upsteam fix is ok though.

Since we'd tested this, I fixed the commit log in this case so you can have a look at what I merged as an example of how it should look.

Cheers,

Richard