ACPI: skip IRQ override on AMD Zen platforms
PATCH v6 1/1 ACPI: skip IRQ override on AMD Zen platforms
IRQ override isn't needed on modern AMD Zen systems. There's an active low keyboard IRQ on AMD Ryzen 6000 and it will stay this way on newer platforms. This IRQ override breaks keyboards for almost all Ryzen 6000 laptops currently on the market.
Skip this IRQ override for all AMD Zen platforms because this IRQ override is supposed to be a workaround for buggy ACPI DSDT and we can't have a long list of all future AMD CPUs/Laptops in the kernel code. If a device with buggy ACPI DSDT shows up, a separated list containing just them should be created.
---
Change sice v5: reworked
drivers/acpi/resource.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/acpi/resource.c +10 -0
@@ -416,6 +416,16 @@ static bool acpi_dev_irq_override(u32 gsi, u8 triggering, u8 polarity, {int i; +#ifdef CONFIG_X86 +/* +* IRQ override isn't needed on modern AMD Zen systems and +* this override breaks active low IRQs on AMD Ryzen 6000 and +* newer systems. Skip it. +*/ +if (boot_cpu_has (X86_FEATURE_ZEN )) +return false; +#endif +for (i =0 ; i <ARRAY_SIZE (skip_override_table); i++) {const struct irq_override_cmp *entry = &skip_override_table[i];
Signature · 1 line
2.36.1
Rafael J. Wysocki
maintainerQuoted 6 lines · Chuanhong Guo
IRQ override isn't needed on modern AMD Zen systems. There's an active low keyboard IRQ on AMD Ryzen 6000 and it will stay this way on newer platforms. This IRQ override breaks keyboards for almost all Ryzen 6000 laptops currently on the market.
Quoted 8 lines
Skip this IRQ override for all AMD Zen platforms because this IRQ override is supposed to be a workaround for buggy ACPI DSDT and we can't have a long list of all future AMD CPUs/Laptops in the kernel code. If a device with buggy ACPI DSDT shows up, a separated list containing just them should be created.
Suggested-by Mario Limonciello <[email protected]>Signed-off-by Chuanhong Guo <[email protected]>
I need an ACK from Mario here.
Quoted 30 lines
---
Change sice v5: reworkeddrivers/acpi/resource.c | 10 ++++++++++ 1 file changed, 10 insertions(+)drivers/acpi/resource.c +10
-1@@ -416,6 +416,16 @@ static bool acpi_dev_irq_override(u32 gsi, u8 triggering, u8 polarity, {int i; +#ifdef CONFIG_X86 +/* +* IRQ override isn't needed on modern AMD Zen systems and +* this override breaks active low IRQs on AMD Ryzen 6000 and +* newer systems. Skip it. +*/ +if (boot_cpu_has (X86_FEATURE_ZEN )) +return false; +#endif +for (i =0 ; i <ARRAY_SIZE (skip_override_table); i++) {const struct irq_override_cmp *entry = &skip_override_table[i]; --2.36.1
[Public]
Quoted 24 lines
-----Original Message-----
From: Rafael J. Wysocki <[email protected]>
Sent: Thursday, July 14, 2022 13:36
To: Chuanhong Guo <[email protected]>
Cc: ACPI Devel Maling List <[email protected]>; Tighe Donnelly <[email protected]>; Limonciello, Mario <[email protected]>; Rafael J. Wysocki <[email protected]>; Len Brown <[email protected]>; open list <[email protected]>
Subject: Re: [PATCH v6] ACPI: skip IRQ override on AMD Zen platformsQuoted 12 lines · Chuanhong Guo
IRQ override isn't needed on modern AMD Zen systems. There's an active low keyboard IRQ on AMD Ryzen 6000 and it will stay this way on newer platforms. This IRQ override breaks keyboards for almost all Ryzen 6000 laptops currently on the market.
Skip this IRQ override for all AMD Zen platforms because this IRQ override is supposed to be a workaround for buggy ACPI DSDT and we can't have a long list of all future AMD CPUs/Laptops in the kernel code. If a device with buggy ACPI DSDT shows up, a separated list containing just them should be created.
Quoted 4 lines
Quoted 2 lines
Suggested-by Mario Limonciello <[email protected]>Signed-off-by Chuanhong Guo <[email protected]>I need an ACK from Mario here.
I believe this is fine, but give me a few days to check with others. This isn't 5.19 material, and so I think an ack next week should be fine for it.
Quoted 32 lines
drivers/acpi/resource.c static bool acpi_dev_irq_override(u32 gsi, u8
Quoted 12 lines
---
Change sice v5: reworkeddrivers/acpi/resource.c | 10 ++++++++++ 1 file changed, 10 insertions(+)drivers/acpi/resource.c +0
-0@@ -416,6 +416,16 @@ static bool acpi_dev_irq_override(u32 gsi, u8triggering, u8 polarity,
Quoted 19 lines
drivers/acpi/resource.c +10
-1{int i; +#ifdef CONFIG_X86 +/* +* IRQ override isn't needed on modern AMD Zen systems and +* this override breaks active low IRQs on AMD Ryzen 6000 and +* newer systems. Skip it. +*/ +if (boot_cpu_has (X86_FEATURE_ZEN )) +return false; +#endif +for (i =0 ; i <ARRAY_SIZE (skip_override_table); i++) {const struct irq_override_cmp *entry = &skip_override_table[i]; --2.36.1
Quoted 13 lines · Rafael J. Wysocki
Quoted 12 lines · Chuanhong Guo
IRQ override isn't needed on modern AMD Zen systems. There's an active low keyboard IRQ on AMD Ryzen 6000 and it will stay this way on newer platforms. This IRQ override breaks keyboards for almost all Ryzen 6000 laptops currently on the market.
Skip this IRQ override for all AMD Zen platforms because this IRQ override is supposed to be a workaround for buggy ACPI DSDT and we can't have a long list of all future AMD CPUs/Laptops in the kernel code. If a device with buggy ACPI DSDT shows up, a separated list containing just them should be created.
Quoted 4 lines
Quoted 2 lines
Suggested-by Mario Limonciello <[email protected]>Signed-off-by Chuanhong Guo <[email protected]>I need an ACK from Mario here.
Sure. As he mentioned this polarity change is needed going forward.
So if we end up with a similar regression as the Baytrail attempt to make this generic and need to revert we'll need to find a different heuristic to make it generic on RMB and later.
Here's some other tags to pick up too in the commit message.
Quoted 31 lines
Quoted 31 lines
---
Change sice v5: reworkeddrivers/acpi/resource.c | 10 ++++++++++ 1 file changed, 10 insertions(+)drivers/acpi/resource.c +10
-1@@ -416,6 +416,16 @@ static bool acpi_dev_irq_override(u32 gsi, u8 triggering, u8 polarity, {int i; +#ifdef CONFIG_X86 +/* +* IRQ override isn't needed on modern AMD Zen systems and +* this override breaks active low IRQs on AMD Ryzen 6000 and +* newer systems. Skip it. +*/ +if (boot_cpu_has (X86_FEATURE_ZEN )) +return false; +#endif +for (i =0 ; i <ARRAY_SIZE (skip_override_table); i++) {const struct irq_override_cmp *entry = &skip_override_table[i]; --2.36.1
Quoted 25 lines · Mario
Quoted 13 lines · Rafael J. Wysocki
Quoted 12 lines · Chuanhong Guo
IRQ override isn't needed on modern AMD Zen systems. There's an active low keyboard IRQ on AMD Ryzen 6000 and it will stay this way on newer platforms. This IRQ override breaks keyboards for almost all Ryzen 6000 laptops currently on the market.
Skip this IRQ override for all AMD Zen platforms because this IRQ override is supposed to be a workaround for buggy ACPI DSDT and we can't have a long list of all future AMD CPUs/Laptops in the kernel code. If a device with buggy ACPI DSDT shows up, a separated list containing just them should be created.
Quoted 4 lines
Quoted 2 lines
Suggested-by Mario Limonciello <[email protected]>Signed-off-by Chuanhong Guo <[email protected]>I need an ACK from Mario here.
Sure. As he mentioned this polarity change is needed going forward. So if we end up with a similar regression as the Baytrail attempt to make this generic and need to revert we'll need to find a different heuristic to make it generic on RMB and later.
Quoted 6 lines
Here's some other tags to pick up too in the commit message.
Applied as 5.20 material with the above tags added, thanks!
Quoted 31 lines
Quoted 30 lines
Quoted 30 lines
---
Change sice v5: reworkeddrivers/acpi/resource.c | 10 ++++++++++ 1 file changed, 10 insertions(+)drivers/acpi/resource.c +10
-1@@ -416,6 +416,16 @@ static bool acpi_dev_irq_override(u32 gsi, u8 triggering, u8 polarity, {int i; +#ifdef CONFIG_X86 +/* +* IRQ override isn't needed on modern AMD Zen systems and +* this override breaks active low IRQs on AMD Ryzen 6000 and +* newer systems. Skip it. +*/ +if (boot_cpu_has (X86_FEATURE_ZEN )) +return false; +#endif +for (i =0 ; i <ARRAY_SIZE (skip_override_table); i++) {const struct irq_override_cmp *entry = &skip_override_table[i]; --2.36.1
Hi,
Quoted 10 lines · Chuanhong Guo
IRQ override isn't needed on modern AMD Zen systems. There's an active low keyboard IRQ on AMD Ryzen 6000 and it will stay this way on newer platforms. This IRQ override breaks keyboards for almost all Ryzen 6000 laptops currently on the market.
Skip this IRQ override for all AMD Zen platforms because this IRQ override is supposed to be a workaround for buggy ACPI DSDT and we can't have a long list of all future AMD CPUs/Laptops in the kernel code. If a device with buggy ACPI DSDT shows up, a separated list containing just them should be created.
This breaks pads on IdeaPad 5 Flex:
https://bugzilla.suse.com/show_bug.cgi?id=1203794
Quoted 4 lines
[ 1.058135] hid-generic 0020:1022:0001.0001: hidraw0: SENSOR HUB HID v0.00 Device [hid-amdsfh 1022:0001] on pcie_mp2_amd [ 2.038937] i2c_designware AMDI0010:00: controller timed out [ 2.146627] i2c_designware AMDI0010:03: controller timed out [ 6.166859] i2c_hid_acpi i2c-MSFT0001:00: failed to reset device: -61
Quoted 8 lines
[ 8.279604] i2c_designware AMDI0010:03: controller timed out [ 12.310897] i2c_hid_acpi i2c-MSFT0001:00: failed to reset device: -61 [ 14.429372] i2c_designware AMDI0010:03: controller timed out [ 18.462629] i2c_hid_acpi i2c-MSFT0001:00: failed to reset device: -61 [ 20.579183] i2c_designware AMDI0010:03: controller timed out [ 24.598703] i2c_hid_acpi i2c-MSFT0001:00: failed to reset device: -61 [ 25.629071] i2c_hid_acpi i2c-MSFT0001:00: can't add hid device: -61 [ 25.629430] i2c_hid_acpi: probe of i2c-MSFT0001:00 failed with error -61
The diff of good and bad dmesgs:
-ACPI: IRQ 10 override to edge, high
-ACPI: IRQ 6 override to edge, high
The diff of /proc/interrupts:
6: ... IR-IO-APIC [-6-fasteoi-] {+6-edge+} AMDI0010:03
10: ... IR-IO-APIC [-10-fasteoi-] {+10-edge+} AMDI0010:00And:
i2c_designware: /devices/platform/AMDI0010:00
i2c_designware: /devices/platform/AMDI0010:03
So the if needs to be fine-tuned, apparently. Maybe introduce some list as suggested in the commit log. Based on the below?
DMI says:
System Info: #14
Manufacturer: "LENOVO"
Product: "82RA"
Version: "IdeaPad Flex 5 16ALC7"
Serial: "PW02359K"
UUID: 6b2d54d9-cd80-11ec-83eb-e00af665fbac
Wake-up: 0x06 (Power Switch)
Board Info: #15
Manufacturer: "LENOVO"
Product: "LNVNB161216"
Version: "SDK0T76463 WIN"
Serial: "PW02359K"
Asset Tag: "No Asset Tag"
Type: 0x0a (Motherboard)
Features: 0x09
Hosting Board
Replaceable
Location: "Chassis Location Unknown"
Chassis Info: #16
Manufacturer: "LENOVO"
Version: "IdeaPad Flex 5 16ALC7"
Serial: "PW02359K"
Asset Tag: "No Asset Tag"
Type: 0x1f (Other)
Bootup State: 0x03 (Safe)
Power Supply State: 0x03 (Safe)
Thermal State: 0x01 (Other)
Security Status: 0x01 (Other)Quoted 19 lines
Suggested-by Mario Limonciello <[email protected]>Signed-off-by Chuanhong Guo <[email protected]>---
Change sice v5: reworkeddrivers/acpi/resource.c | 10 ++++++++++ 1 file changed, 10 insertions(+)drivers/acpi/resource.c +3
-0@@ -416,6 +416,16 @@ static bool acpi_dev_irq_override(u32 gsi, u8 triggering, u8 polarity, {int i; +#ifdef CONFIG_X86 +/* +* IRQ override isn't needed on modern AMD Zen systems and
drivers/acpi/resource.c static bool acpi_dev_irq_override(u32 gsi, u8 triggering, u8 polarity, · line 431
Quoted 10 lines
drivers/acpi/resource.c +7
-0+* this override breaks active low IRQs on AMD Ryzen 6000 and +* newer systems. Skip it. +*/ +if (boot_cpu_has (X86_FEATURE_ZEN )) +return false; +#endif +for (i =0 ; i <ARRAY_SIZE (skip_override_table); i++) {const struct irq_override_cmp *entry = &skip_override_table[i];
thanks,
Signature · 1 line
js
Quoted 40 lines · Jiri Slaby
Hi,
Quoted 10 lines · Chuanhong Guo
IRQ override isn't needed on modern AMD Zen systems. There's an active low keyboard IRQ on AMD Ryzen 6000 and it will stay this way on newer platforms. This IRQ override breaks keyboards for almost all Ryzen 6000 laptops currently on the market.
Skip this IRQ override for all AMD Zen platforms because this IRQ override is supposed to be a workaround for buggy ACPI DSDT and we can't have a long list of all future AMD CPUs/Laptops in the kernel code. If a device with buggy ACPI DSDT shows up, a separated list containing just them should be created.
This breaks pads on IdeaPad 5 Flex:
https://bugzilla.suse.com/show_bug.cgi?id=1203794Quoted 1 line
[ 1.058135] hid-generic 0020:1022:0001.0001: hidraw0: SENSOR HUB
HID v0.00 Device [hid-amdsfh 1022:0001] on
pcie_mp2_amdQuoted 11 lines
[ 2.038937]
i2c_designwareAMDI0010:00: controller timed out [ 2.146627]i2c_designwareAMDI0010:03: controller timed out [ 6.166859]i2c_hid_acpii2c-MSFT0001:00: failed to reset device: -61 [ 8.279604]i2c_designwareAMDI0010:03: controller timed out [ 12.310897]i2c_hid_acpii2c-MSFT0001:00: failed to reset device: -61 [ 14.429372]i2c_designwareAMDI0010:03: controller timed out [ 18.462629]i2c_hid_acpii2c-MSFT0001:00: failed to reset device: -61 [ 20.579183]i2c_designwareAMDI0010:03: controller timed out [ 24.598703]i2c_hid_acpii2c-MSFT0001:00: failed to reset device: -61 [ 25.629071]i2c_hid_acpii2c-MSFT0001:00: can't add hid device: -61 [ 25.629430]i2c_hid_acpi: probe of i2c-MSFT0001:00 failed witherror -61
The diff of good and bad dmesgs:
(quoted diff) +0
-2-ACPI: IRQ 10 override to edge, high -ACPI: IRQ 6 override to edge, highThe diff of
/proc/interrupts:
6: ... IR-IO-APIC [-6-fasteoi-] {+6-edge+} AMDI0010:03 10: ... IR-IO-APIC [-10-fasteoi-] {+10-edge+} AMDI0010:00
Quoted 6 lines
And:
i2c_designware: /devices/platform/AMDI0010:00
i2c_designware: /devices/platform/AMDI0010:03So the if needs to be fine-tuned, apparently. Maybe introduce some list as suggested in the commit log. Based on the below?
Something like the attached. It's:
1) untested yet
2) contains more debug messaging
3) contains both cases for ACPI_ACTIVE_* as I don't know the original polarity
I don't know how widely this is spread -- maybe it would be worth a commandline parameter so that people can work around this until this is fixed by a DMI entry permanently?
Quoted 60 lines
DMI says:
System Info: #14
Manufacturer: "LENOVO"
Product: "82RA"
Version: "IdeaPad Flex 5 16ALC7"
Serial: "PW02359K"
UUID: 6b2d54d9-cd80-11ec-83eb-e00af665fbac
Wake-up:0x06(Power Switch)
Board Info: #15
Manufacturer: "LENOVO"
Product: "LNVNB161216"
Version: "SDK0T76463 WIN"
Serial: "PW02359K"
Asset Tag: "No Asset Tag"
Type:0x0a(Motherboard)
Features:0x09
Hosting Board
Replaceable
Location: "Chassis Location Unknown"
Chassis Info: #16
Manufacturer: "LENOVO"
Version: "IdeaPad Flex 5 16ALC7"
Serial: "PW02359K"
Asset Tag: "No Asset Tag"
Type:0x1f(Other)
Bootup State:0x03(Safe)
Power Supply State:0x03(Safe)
Thermal State:0x01(Other)
Security Status:0x01(Other)Quoted 18 lines
Suggested-by Mario Limonciello <[email protected]>Signed-off-by Chuanhong Guo <[email protected]>---
Change sice v5: reworked
drivers/acpi/resource.c| 10 ++++++++++1 file changed, 10 insertions(+)drivers/acpi/resource.c +2
-0@@ -416,6 +416,16 @@ static bool acpi_dev_irq_override(u32 gsi, u8 triggering, u8 polarity, { int i; +#ifdef CONFIG_X86 + /*drivers/acpi/resource.c static bool acpi_dev_irq_override(u32 gsi, u8 · line 430
Quoted 10 lines
drivers/acpi/resource.c +8
-0+* IRQ override isn't needed on modern AMD Zen systems and +* this override breaks active low IRQs on AMD Ryzen 6000 and +* newer systems. Skip it. +*/ + if (boot_cpu_has(X86_FEATURE_ZEN)) + return false; +#endif + for (i = 0; i < ARRAY_SIZE(skip_override_table); i++) { const struct irq_override_cmp *entry = &skip_override_table[i];thanks,
Signature · 1 line
js
From 485dd1229b9d2f322879d85731af4a7952b9cc4b Mon Sep 17 00:00:00 2001
From: Jiri Slaby <[email protected]>
Date: Wed, 28 Sep 2022 09:43:05 +0200
Subject: [PATCH] ACPI: resource: do IRQ override on LENOVO IdeaPad
LENOVO IdeaPad Flex 5 is ryzen-5 based and the commit below removed irq overriding for those. This broke touchscreen and trackpad:
i2c_designware AMDI0010:00: controller timed out i2c_designware AMDI0010:03: controller timed out i2c_hid_acpi i2c-MSFT0001:00: failed to reset device: -61 i2c_designware AMDI0010:03: controller timed out
...
i2c_hid_acpi i2c-MSFT0001:00: can't add hid device: -61
i2c_hid_acpi: probe of i2c-MSFT0001:00 failed with error -61
White list this specific model in the override_table.
For this to work, the ZEN test needs to be put below the table walk.
--- drivers/acpi/resource.c | 51 ++++++++++++++++++++++++++++------------- 1 file changed, 35 insertions(+), 16 deletions(-)
drivers/acpi/resource.c +35 -16
@@ -417,17 +417,33 @@ static const struct dmi_system_id asus_laptop[] = { { } }; +static const struct dmi_system_id lenovo_laptop[] = { + { + .ident ="LENOVO IdeaPad Flex 5 16ALC7" , + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), +DMI_MATCH (DMI_PRODUCT_NAME ,"82RA" ), + }, + }, + { } +}; +struct irq_override_cmp {const struct dmi_system_id *system;unsigned char irq;unsigned char triggering;unsigned char polarity;unsigned char shareable; +bool override; }; -static const struct irq_override_cmp skip_override_table[] = { - { medion_laptop,1 ,ACPI_LEVEL_SENSITIVE ,ACPI_ACTIVE_LOW ,0 }, - { asus_laptop,1 ,ACPI_LEVEL_SENSITIVE ,ACPI_ACTIVE_LOW ,0 }, +static const struct irq_override_cmp override_table[] = { + { medion_laptop,1 ,ACPI_LEVEL_SENSITIVE ,ACPI_ACTIVE_LOW ,0 , false }, + { asus_laptop,1 ,ACPI_LEVEL_SENSITIVE ,ACPI_ACTIVE_LOW ,0 , false }, + { lenovo_laptop,6 ,ACPI_EDGE_SENSITIVE ,ACPI_ACTIVE_LOW ,0 , true }, + { lenovo_laptop,10 ,ACPI_EDGE_SENSITIVE ,ACPI_ACTIVE_LOW ,0 , true }, + { lenovo_laptop,6 ,ACPI_EDGE_SENSITIVE ,ACPI_ACTIVE_HIGH ,0 , true }, + { lenovo_laptop,10 ,ACPI_EDGE_SENSITIVE ,ACPI_ACTIVE_HIGH ,0 , true }, }; static bool acpi_dev_irq_override(u32 gsi, u8 triggering, u8 polarity,
@@ -435,6 +451,17 @@ static bool acpi_dev_irq_override(u32 gsi, u8 triggering, u8 polarity, {int i; +for (i =0 ; i <ARRAY_SIZE (override_table); i++) { +const struct irq_override_cmp *entry = &override_table[i]; + +if (dmi_check_system (entry->system) && + entry->irq == gsi && + entry->triggering == triggering && + entry->polarity == polarity && + entry->shareable == shareable) +return entry->override; + } +#ifdef CONFIG_X86 /* * IRQ override isn't needed on modern AMD Zen systems and
@@ -445,17 +472,6 @@ static bool acpi_dev_irq_override(u32 gsi, u8 triggering, u8 polarity,return false;#endif -for (i =0 ; i <ARRAY_SIZE (skip_override_table); i++) { -const struct irq_override_cmp *entry = &skip_override_table[i]; - -if (dmi_check_system (entry->system) && - entry->irq == gsi && - entry->triggering == triggering && - entry->polarity == polarity && - entry->shareable == shareable) -return false; - } -return true; }
@@ -487,8 +503,11 @@ static void acpi_dev_get_irqresource(struct resource *res, u32 gsi,u8 pol = p ?ACPI_ACTIVE_LOW :ACPI_ACTIVE_HIGH ;if (triggering != trig || polarity != pol) { -pr_warn ("ACPI: IRQ %d override to %s, %s\n" , gsi, - t ?"level" :"edge" , p ?"low" :"high" ); +pr_warn ("ACPI: IRQ %d override to %s%s, %s%s\n" , gsi, + t ?"level" :"edge" , + trig == triggering ?"" :"(!)" , + p ?"low" :"high" , + pol == polarity ?"" :"(!)" ); triggering = trig; polarity = pol; }
Signature · 1 line
2.37.3
Quoted 4 lines · Jiri Slaby
Something like the attached. It's:
1) untested yet
2) contains more debug messaging
3) contains both cases for ACPI_ACTIVE_* as I don't know the original polarity
Now, I have DSDT which says for both of them:
IRQ (Level, ActiveLow, ExclusiveAndWake, )
So the patch should actually have:
{ lenovo_laptop, 6, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0,
true },
{ lenovo_laptop, 10, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0,
true },
thanks,
Signature · 1 line
js
Hi!
Quoted 22 lines · Jiri Slaby
Quoted 22 lines
This breaks pads on IdeaPad 5 Flex:
https://bugzilla.suse.com/show_bug.cgi?id=1203794Quoted 1 line
[ 1.058135] hid-generic 0020:1022:0001.0001: hidraw0: SENSOR HUBHID v0.00 Device [hid-amdsfh 1022:0001] on
pcie_mp2_amdQuoted 11 lines
[ 2.038937] i2c_designware AMDI0010:00: controller timed out [ 2.146627] i2c_designware AMDI0010:03: controller timed out [ 6.166859] i2c_hid_acpi i2c-MSFT0001:00: failed to reset device: -61 [ 8.279604] i2c_designware AMDI0010:03: controller timed out [ 12.310897] i2c_hid_acpi i2c-MSFT0001:00: failed to reset device: -61 [ 14.429372] i2c_designware AMDI0010:03: controller timed out [ 18.462629] i2c_hid_acpi i2c-MSFT0001:00: failed to reset device: -61 [ 20.579183] i2c_designware AMDI0010:03: controller timed out [ 24.598703] i2c_hid_acpi i2c-MSFT0001:00: failed to reset device: -61 [ 25.629071] i2c_hid_acpi i2c-MSFT0001:00: can't add hid device: -61 [ 25.629430] i2c_hid_acpi: probe of i2c-MSFT0001:00 failed witherror -61
The diff of good and bad dmesgs:
(quoted diff) +0
-2-ACPI: IRQ 10 override to edge, high -ACPI: IRQ 6 override to edge, high
Quoted 7 lines
Quoted 7 lines
The diff of
/proc/interrupts:6: ... IR-IO-APIC [-6-fasteoi-] {+6-edge+} AMDI0010:03 10: ... IR-IO-APIC [-10-fasteoi-] {+10-edge+} AMDI0010:00And:
i2c_designware: /devices/platform/AMDI0010:00 i2c_designware: /devices/platform/AMDI0010:03
Oops...
Quoted 8 lines
Quoted 2 lines
So the if needs to be fine-tuned, apparently. Maybe introduce some list as suggested in the commit log. Based on the below?
Something like the attached. It's:
1) untested yet
2) contains more debug messaging
3) contains both cases for ACPI_ACTIVE_* as I don't know the original polarity
The patch in your attachment looks good to me. But I think "lenovo_laptop" is a bit too generic. Maybe name it lenovo_82ra instead?
Quoted 4 lines
I don't know how widely this is spread -- maybe it would be worth a commandline parameter so that people can work around this until this is fixed by a DMI entry permanently?
That's a good idea :)
--
Regards,
Chuanhong Guo