Skip to contentSkip to conversation

ice: Fix VSI configuration for non-PF network devices

PATCH In review Benjamin Mikailenko 2 participants 4 messages Jul 12, 2022 – Jul 15, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 ice: Fix VSI configuration for non-PF network devices

This fixes an issue for a failing loopback test
"ethtool -t offline ethx". Do not set Rx mode
and VSI VLAN for non-PF network devices.

Fixes c7f2c42b80ed ("ice: Fix a few null pointer dereference issues")
---
 drivers/net/ethernet/intel/ice/ice_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/ice/ice_main.c +1 -1
index 752bd8a10495..e4ae67da5b77 100644
@@ -6010,7 +6010,7 @@ int ice_vsi_cfg(struct ice_vsi *vsi)
 {
 	int err;
 
-	if (vsi->netdev) {
+	if (vsi->netdev && vsi->type == ICE_VSI_PF) {
 		ice_set_rx_mode(vsi->netdev);
 
 		err = ice_vsi_vlan_setup(vsi);
Signature · 6 lines
2.34.3

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
maintainer
#1 lore raw
Quoted 3 lines · Benjamin Mikailenko

This fixes an issue for a failing loopback test
"ethtool -t offline ethx". Do not set Rx mode
and VSI VLAN for non-PF network devices.

This sounds very much like this patch/issue [1]. Can you test that and see if it fixes this issue.

Quoted 2 lines
Fixes c7f2c42b80ed ("ice: Fix a few null pointer dereference issues")

[1] https://lore.kernel.org/intel-wired-lan/[email protected]/T/#u
_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

#2 lore raw
Quoted 8 lines · Tony Nguyen
Quoted 3 lines · Benjamin Mikailenko

This fixes an issue for a failing loopback test
"ethtool -t offline ethx". Do not set Rx mode
and VSI VLAN for non-PF network devices.

This sounds very much like this patch/issue [1]. Can you test that and see if it fixes this issue.

Yes, issue is fixed. Tested on current next-queue dev-queue.

Quoted 5 lines
Quoted 3 lines
Fixes c7f2c42b80ed ("ice: Fix a few null pointer dereference issues")

[1] https://lore.kernel.org/intel-wired-lan/[email protected]/T/#u

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

maintainer
#3 lore raw
Quoted 5 lines · Benjamin Mikailenko
Quoted 2 lines · Tony Nguyen
Quoted 8 lines
Quoted 6 lines · Benjamin Mikailenko
Quoted 3 lines

This fixes an issue for a failing loopback test
"ethtool -t offline ethx". Do not set Rx mode
and VSI VLAN for non-PF network devices.

This sounds very much like this patch/issue [1]. Can you test that and see if it fixes this issue.

Yes, issue is fixed. Tested on current next-queue dev-queue.

Thanks for the quick check. I'll keep the existing patch and not use this one then.

Quoted 5 lines
Quoted 5 lines
Quoted 3 lines
Fixes c7f2c42b80ed ("ice: Fix a few null pointer dereference issues")

[1] https://lore.kernel.org/intel-wired-lan/[email protected]/T/#u

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan