Skip to contentSkip to conversation

PCI/ASPM: Unexport pcie_aspm_support_enabled()

PATCH In review Bjorn Helgaas 2 participants 3 messages Jul 11, 2022 – Jul 12, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI/ASPM: Unexport pcie_aspm_support_enabled()

From: Bjorn Helgaas <[email protected]>

pcie_aspm_support_enabled() is used only by the acpi/pci_root.c driver, which cannot be built as a module, so it does not need to be exported. Unexport it.

---
 drivers/pci/pcie/aspm.c | 1 -
 1 file changed, 1 deletion(-)
drivers/pci/pcie/aspm.c +0 -1
index 7f76a5875feb..a8aec190986c 100644
@@ -1347,4 +1347,3 @@ bool pcie_aspm_support_enabled(void)
 {
 	return aspm_support_enabled;
 }
-EXPORT_SYMBOL(pcie_aspm_support_enabled);
Signature · 1 line
2.25.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Bjorn Helgaas

From: Bjorn Helgaas <[email protected]>

pcie_aspm_support_enabled() is used only by the acpi/pci_root.c driver, which cannot be built as a module, so it does not need to be exported. Unexport it.

Quoted 16 lines
---
 drivers/pci/pcie/aspm.c | 1 -
 1 file changed, 1 deletion(-)
drivers/pci/pcie/aspm.c +0 -2
index 7f76a5875feb..a8aec190986c 100644
@@ -1347,4 +1347,3 @@ bool pcie_aspm_support_enabled(void)
 {
        return aspm_support_enabled;
 }
-EXPORT_SYMBOL(pcie_aspm_support_enabled);
--

2.25.1

author Applied
#2 lore raw
Quoted 11 lines · Rafael J. Wysocki
Quoted 8 lines · Bjorn Helgaas

From: Bjorn Helgaas <[email protected]>

pcie_aspm_support_enabled() is used only by the acpi/pci_root.c driver, which cannot be built as a module, so it does not need to be exported. Unexport it.

Thanks, applied with your Reviewed-by to pci/aspm for v5.20.

Quoted 16 lines
Quoted 16 lines
---
 drivers/pci/pcie/aspm.c | 1 -
 1 file changed, 1 deletion(-)
drivers/pci/pcie/aspm.c +0 -2
index 7f76a5875feb..a8aec190986c 100644
@@ -1347,4 +1347,3 @@ bool pcie_aspm_support_enabled(void)
 {
        return aspm_support_enabled;
 }
-EXPORT_SYMBOL(pcie_aspm_support_enabled);
--

2.25.1