fpga: Convert some options to Kconfig
v2 cover fpga: Convert some options to Kconfig
Hei hei,
rebased this on recent master. One patch dropped. See changelog below.
Greets
Alex
(implicit) v1 -> v2:
- dropped patch 3, same kconfig symbol addressed with commit
60d45642fe0673514aced37e6cc95d4f0fe02a19 ("fpga: Remove
CONFIG_FPGA_COUNT")Alexander Dahl (2):
fpga: Convert SYS_FPGA_CHECK_CTRLC to Kconfig
fpga: Convert SYS_FPGA_PROG_FEEDBACK to Kconfig
README | 7 ------- configs/astro_mcf5373l_defconfig | 1 + drivers/fpga/Kconfig | 10 ++++++++++ include/configs/astro_mcf5373l.h | 1 - scripts/config_whitelist.txt | 1 - 5 files changed, 11 insertions(+), 9 deletions(-)
base-commit: 36b661dc919da318c163a45f4a220d2e3d9db608
Signature · 1 line
2.30.2
PATCH v2 1/2 fpga: Convert SYS_FPGA_CHECK_CTRLC to Kconfig
From: Alexander Dahl <[email protected]>
After commit 8cca60a2cbf2 ("Kconfig: Remove some symbols from the whitelist") downstream builds failed for boards setting this in include/configs/…
Two FPGA drivers consider this definition.
--- README | 3 --- drivers/fpga/Kconfig | 4 ++++ 2 files changed, 4 insertions(+), 3 deletions(-)
README +0 -3
@@ -1346,9 +1346,6 @@ The following options need to be configured: If defined, a function that provides delays in the FPGA configuration driver. - CONFIG_SYS_FPGA_CHECK_CTRLC - Allow Control-C to interrupt FPGA configuration - CONFIG_SYS_FPGA_CHECK_ERROR Check for configuration errors during FPGA bitfile
drivers/fpga/Kconfig +4 -0
@@ -91,4 +91,8 @@ config FPGA_ZYNQPL Enable FPGA driver for loading bitstream in BIT and BIN format on Xilinx Zynq devices. +config SYS_FPGA_CHECK_CTRLC + bool "Allow Control-C to interrupt FPGA configuration" + depends on FPGA + endmenu
Signature · 1 line
2.30.2
Re: [PATCH v2 1/2] fpga: Convert SYS_FPGA_CHECK_CTRLC to Kconfig
Quoted 7 lines · Alexander Dahl
From: Alexander Dahl <[email protected]>
After commit
8cca60a2cbf2("Kconfig: Remove some symbols from the whitelist") downstream builds failed for boards setting this in include/configs/…Two FPGA drivers consider this definition.
2?board/astro/mcf5373l/fpga.cdrivers/fpga/ACEX1K.cdrivers/fpga/virtex2.c
Quoted 26 lines
Signed-off-by Alexander Dahl <[email protected]>--- README | 3 --- drivers/fpga/Kconfig | 4 ++++ 2 files changed, 4 insertions(+), 3 deletions(-)README +0
-3@@ -1346,9 +1346,6 @@ The following options need to be configured: If defined, a function that provides delays in the FPGA configuration driver. - CONFIG_SYS_FPGA_CHECK_CTRLC - Allow Control-C to interrupt FPGA configuration - CONFIG_SYS_FPGA_CHECK_ERROR Check for configuration errors during FPGA bitfiledrivers/fpga/Kconfig +0
-0
drivers/fpga/Kconfig config FPGA_ZYNQPL · line 96
Quoted 6 lines
drivers/fpga/Kconfig +3
-0@@ -91,4 +91,8 @@ config FPGA_ZYNQPL Enable FPGA driver for loading bitstream in BIT and BIN format on Xilinx Zynq devices. +config SYS_FPGA_CHECK_CTRLC + bool "Allow Control-C to interrupt FPGA configuration" + depends on FPGA
Please write help message.
drivers/fpga/Kconfig config FPGA_ZYNQPL · line 98
Quoted 2 lines
drivers/fpga/Kconfig +1
-0+ endmenu
And can you please remove this code from drivers/fpga/virtex2.c
48 /*
49 * Don't allow config cycle to be interrupted
50 */
51 #ifndef CONFIG_SYS_FPGA_CHECK_CTRLC
52 #undef CONFIG_SYS_FPGA_CHECK_CTRLC
53 #endif
it doesn't make any sense.
And with 2/2 please also remove drivers/fpga/spartan2.c:18:#undef CONFIG_SYS_FPGA_PROG_FEEDBACK drivers/fpga/virtex2.c:44:#ifndef CONFIG_SYS_FPGA_PROG_FEEDBACK drivers/fpga/virtex2.c:45:#define CONFIG_SYS_FPGA_PROG_FEEDBACK
Thanks,
Michal
Re: [PATCH v2 1/2] fpga: Convert SYS_FPGA_CHECK_CTRLC to Kconfig
Hello Michal,
Quoted 9 lines · Michal Simek
Quoted 6 lines · Alexander Dahl
From: Alexander Dahl <[email protected]>
After commit
8cca60a2cbf2("Kconfig: Remove some symbols from the whitelist") downstream builds failed for boards setting this in include/configs/…
Quoted 6 lines
Quoted 1 line
Two FPGA drivers consider this definition.
2?
board/astro/mcf5373l/fpga.cdrivers/fpga/ACEX1K.cdrivers/fpga/virtex2.c
These are one board and two drivers. What is your question?
Greets
Alex
Quoted 24 lines
Quoted 24 lines
Signed-off-by Alexander Dahl <[email protected]>--- README | 3 --- drivers/fpga/Kconfig | 4 ++++ 2 files changed, 4 insertions(+), 3 deletions(-)README +0
-3@@ -1346,9 +1346,6 @@ The following options need to be configured: If defined, a function that provides delays in the FPGA configuration driver. - CONFIG_SYS_FPGA_CHECK_CTRLC - Allow Control-C to interrupt FPGA configuration - CONFIG_SYS_FPGA_CHECK_ERROR Check for configuration errors during FPGA bitfiledrivers/fpga/Kconfig +0
-0
Quoted 8 lines
drivers/fpga/Kconfig config FPGA_ZYNQPL · line 95
Quoted 6 lines
drivers/fpga/Kconfig +3
-0@@ -91,4 +91,8 @@ config FPGA_ZYNQPL Enable FPGA driver for loading bitstream in BIT and BIN format on Xilinx Zynq devices. +config SYS_FPGA_CHECK_CTRLC + bool "Allow Control-C to interrupt FPGA configuration" + depends on FPGAPlease write help message.
Okay, I'll have to invent a new message here, if the prompt is not self explaining enough. Since this is not conversion, but adding a new message we did not have before, should this go into a separate patch?
Quoted 7 lines
drivers/fpga/Kconfig config FPGA_ZYNQPL · line 98
Quoted 3 lines
drivers/fpga/Kconfig +1
-0+ endmenuAnd can you please remove this code from
drivers/fpga/virtex2.c
Quoted 8 lines
48 /*
49 * Don't allow config cycle to be interrupted
50 */
51 #ifndefCONFIG_SYS_FPGA_CHECK_CTRLC
52 #undefCONFIG_SYS_FPGA_CHECK_CTRLC
53 #endifit doesn't make any sense.
I have no hardware to test this and this is out of scope of the conversion patch itself.
Quoted 8 lines
And with 2/2 please also remove drivers/fpga/spartan2.c:18:#undef
CONFIG_SYS_FPGA_PROG_FEEDBACKdrivers/fpga/virtex2.c:44:#ifndefCONFIG_SYS_FPGA_PROG_FEEDBACKdrivers/fpga/virtex2.c:45:#defineCONFIG_SYS_FPGA_PROG_FEEDBACKThanks,
Michal
I may be able to add an additional patch or two, but those are all FPGAs I have no experience with and I can not test those. This would be more or less guessing based on code reading. I can try next week, not able to do this currently.
Thanks for your review.
Greets
Alex
Signature · 4 lines
/"\ ASCII RIBBON | »With the first link, the chain is forged. The first \ / CAMPAIGN | speech censured, the first thought forbidden, the X AGAINST | first freedom denied, chains us all irrevocably.« / \ HTML MAIL | (Jean-Luc Picard, quoting Judge Aaron Satie)
Re: [PATCH v2 1/2] fpga: Convert SYS_FPGA_CHECK_CTRLC to Kconfig
Quoted 12 lines · Alexander Dahl
Hello Michal,
Quoted 9 lines · Michal Simek
Quoted 6 lines · Alexander Dahl
From: Alexander Dahl <[email protected]>
After commit
8cca60a2cbf2("Kconfig: Remove some symbols from the whitelist") downstream builds failed for boards setting this in include/configs/…
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Two FPGA drivers consider this definition.
2?
board/astro/mcf5373l/fpga.cdrivers/fpga/ACEX1K.cdrivers/fpga/virtex2.cThese are one board and two drivers. What is your question?
The first one looks like spartan3 fpga driver in board folder (incorrect location). It means I consider this as 3 fpga drivers not 2.
But at the end of day just remove that sentence and that's it. Everybody sees what you have changed.
Thanks,
Michal
Re: [PATCH v2 1/2] fpga: Convert SYS_FPGA_CHECK_CTRLC to Kconfig
In reply to Alexander DahlHello Michal,
Quoted 19 lines · Alexander Dahl
Hello Michal,
Quoted 9 lines · Michal Simek
Quoted 6 lines · Alexander Dahl
From: Alexander Dahl <[email protected]>
After commit
8cca60a2cbf2("Kconfig: Remove some symbols from the whitelist") downstream builds failed for boards setting this in include/configs/…Quoted 6 lines
Quoted 1 line
Two FPGA drivers consider this definition.
2?
board/astro/mcf5373l/fpga.cdrivers/fpga/ACEX1K.cdrivers/fpga/virtex2.c
Quoted 4 lines
These are one board and two drivers. What is your question?
Greets
Alex
I'm sorry, this was misleading. I added some more comments below and forgot to remove this line indicating end of message. Considering your answer I guess you stopped reading here?
Quoted 67 lines
Quoted 25 lines
Quoted 25 lines
Signed-off-by Alexander Dahl <[email protected]>--- README | 3 --- drivers/fpga/Kconfig | 4 ++++ 2 files changed, 4 insertions(+), 3 deletions(-)README +0
-3@@ -1346,9 +1346,6 @@ The following options need to be configured: If defined, a function that provides delays in the FPGA configuration driver. - CONFIG_SYS_FPGA_CHECK_CTRLC - Allow Control-C to interrupt FPGA configuration - CONFIG_SYS_FPGA_CHECK_ERROR Check for configuration errors during FPGA bitfiledrivers/fpga/Kconfig +0
-0Quoted 8 lines
drivers/fpga/Kconfig config FPGA_ZYNQPL · line 95
Quoted 6 lines
drivers/fpga/Kconfig +3
-0@@ -91,4 +91,8 @@ config FPGA_ZYNQPL Enable FPGA driver for loading bitstream in BIT and BIN format on Xilinx Zynq devices. +config SYS_FPGA_CHECK_CTRLC + bool "Allow Control-C to interrupt FPGA configuration" + depends on FPGAPlease write help message.
Okay, I'll have to invent a new message here, if the prompt is not self explaining enough. Since this is not conversion, but adding a new message we did not have before, should this go into a separate patch?
Quoted 7 lines
drivers/fpga/Kconfig config FPGA_ZYNQPL · line 98
Quoted 3 lines
drivers/fpga/Kconfig +1
-0+ endmenuAnd can you please remove this code from
drivers/fpga/virtex2.cQuoted 8 lines
48 /*
49 * Don't allow config cycle to be interrupted
50 */
51 #ifndefCONFIG_SYS_FPGA_CHECK_CTRLC
52 #undefCONFIG_SYS_FPGA_CHECK_CTRLC
53 #endifit doesn't make any sense.
I have no hardware to test this and this is out of scope of the conversion patch itself.
Quoted 8 lines
And with 2/2 please also remove drivers/fpga/spartan2.c:18:#undef
CONFIG_SYS_FPGA_PROG_FEEDBACKdrivers/fpga/virtex2.c:44:#ifndefCONFIG_SYS_FPGA_PROG_FEEDBACKdrivers/fpga/virtex2.c:45:#defineCONFIG_SYS_FPGA_PROG_FEEDBACKThanks,
Michal
Quoted 6 lines
I may be able to add an additional patch or two, but those are all FPGAs I have no experience with and I can not test those. This would be more or less guessing based on code reading. I can try next week, not able to do this currently.
Thanks for your review.
I'll look into all this next week again.
Greets
Alex
Quoted 9 lines
Greets
AlexSignature · 4 lines
/"\ ASCII RIBBON | »With the first link, the chain is forged. The first \ / CAMPAIGN | speech censured, the first thought forbidden, the X AGAINST | first freedom denied, chains us all irrevocably.« / \ HTML MAIL | (Jean-Luc Picard, quoting Judge Aaron Satie)
Signature · 4 lines
/"\ ASCII RIBBON | »With the first link, the chain is forged. The first \ / CAMPAIGN | speech censured, the first thought forbidden, the X AGAINST | first freedom denied, chains us all irrevocably.« / \ HTML MAIL | (Jean-Luc Picard, quoting Judge Aaron Satie)
Re: [PATCH v2 1/2] fpga: Convert SYS_FPGA_CHECK_CTRLC to Kconfig
Quoted 22 lines · Alexander Dahl
Hello Michal,
Quoted 19 lines · Alexander Dahl
Hello Michal,
Quoted 15 lines · Michal Simek
Quoted 7 lines · Alexander Dahl
From: Alexander Dahl <[email protected]>
After commit
8cca60a2cbf2("Kconfig: Remove some symbols from the whitelist") downstream builds failed for boards setting this in include/configs/…Two FPGA drivers consider this definition.
2?
board/astro/mcf5373l/fpga.cdrivers/fpga/ACEX1K.cdrivers/fpga/virtex2.c
Quoted 8 lines
Quoted 4 lines
These are one board and two drivers. What is your question?
Greets
AlexI'm sorry, this was misleading. I added some more comments below and forgot to remove this line indicating end of message. Considering your answer I guess you stopped reading here?
yes I did.
Quoted 34 lines
Quoted 34 lines
Quoted 33 lines
Quoted 26 lines
Signed-off-by Alexander Dahl <[email protected]>--- README | 3 --- drivers/fpga/Kconfig | 4 ++++ 2 files changed, 4 insertions(+), 3 deletions(-)README +0
-3@@ -1346,9 +1346,6 @@ The following options need to be configured: If defined, a function that provides delays in the FPGA configuration driver. - CONFIG_SYS_FPGA_CHECK_CTRLC - Allow Control-C to interrupt FPGA configuration - CONFIG_SYS_FPGA_CHECK_ERROR Check for configuration errors during FPGA bitfiledrivers/fpga/Kconfig +0
-0drivers/fpga/Kconfig config FPGA_ZYNQPL · line 95
Quoted 5 lines
drivers/fpga/Kconfig +3
-0@@ -91,4 +91,8 @@ config FPGA_ZYNQPL Enable FPGA driver for loading bitstream in BIT and BIN format on Xilinx Zynq devices. +config SYS_FPGA_CHECK_CTRLC + bool "Allow Control-C to interrupt FPGA configuration" + depends on FPGAPlease write help message.
Quoted 4 lines
Quoted 4 lines
Okay, I'll have to invent a new message here, if the prompt is not self explaining enough. Since this is not conversion, but adding a new message we did not have before, should this go into a separate patch?
I can't see any reason to have it in separate patch. And maybe CTRL+C is better then Control-C
Quoted 15 lines
Quoted 15 lines
Quoted 15 lines
drivers/fpga/Kconfig config FPGA_ZYNQPL · line 98
Quoted 4 lines
drivers/fpga/Kconfig +1
-0+ endmenuAnd can you please remove this code from
drivers/fpga/virtex2.c48 /*
49 * Don't allow config cycle to be interrupted 50 */
51 #ifndefCONFIG_SYS_FPGA_CHECK_CTRLC52 #undefCONFIG_SYS_FPGA_CHECK_CTRLC
53 #endif
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
it doesn't make any sense.
I have no hardware to test this and this is out of scope of the conversion patch itself.
likely none has virtex2 around to test it. When you are converting that symbol it is good to fix this. Separate patch is fine to get rid of this.
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
And with 2/2 please also remove drivers/fpga/spartan2.c:18:#undef
CONFIG_SYS_FPGA_PROG_FEEDBACKdrivers/fpga/virtex2.c:44:#ifndefCONFIG_SYS_FPGA_PROG_FEEDBACKdrivers/fpga/virtex2.c:45:#defineCONFIG_SYS_FPGA_PROG_FEEDBACKThanks,
Michal
Quoted 8 lines
Quoted 6 lines
I may be able to add an additional patch or two, but those are all FPGAs I have no experience with and I can not test those. This would be more or less guessing based on code reading. I can try next week, not able to do this currently.
Thanks for your review.
I'll look into all this next week again.
None really has spartan2/virtex2 hw around. I personally started with Spartan3 but didn't power it up for a lot of years. It is just about that there is no reason to undefine something if we have Kconfig symbol for it. Just enable it or disable it. That's it. No need to test it on any HW.
Thanks,
Michal
Re: [PATCH v2 1/2] fpga: Convert SYS_FPGA_CHECK_CTRLC to Kconfig
In reply to Alexander DahlQuoted 3 lines · Alexander Dahl
Hello Michal,
On Wed, Jul 13, 2022 at 02:56:08PM +0200, Michal Simek wrote:
[snip]
Quoted 13 lines
Quoted 4 lines
Quoted 4 lines
drivers/fpga/Kconfig +0
-0Quoted 8 lines
drivers/fpga/Kconfig config FPGA_ZYNQPL · line 95
Quoted 6 lines
drivers/fpga/Kconfig +3
-0@@ -91,4 +91,8 @@ config FPGA_ZYNQPL Enable FPGA driver for loading bitstream in BIT and BIN format on Xilinx Zynq devices. +config SYS_FPGA_CHECK_CTRLC + bool "Allow Control-C to interrupt FPGA configuration" + depends on FPGAPlease write help message.
Quoted 4 lines
Okay, I'll have to invent a new message here, if the prompt is not self explaining enough. Since this is not conversion, but adding a new message we did not have before, should this go into a separate patch?
If you understand things well enough to add a line or two under "help", that would be appreciated. It may be a little redundant soundiing, and if it's not long enough checkpatch might still complain (but can be ignored).
Quoted 9 lines
Quoted 9 lines
And can you please remove this code from
drivers/fpga/virtex2.c48 /*
49 * Don't allow config cycle to be interrupted
50 */
51 #ifndefCONFIG_SYS_FPGA_CHECK_CTRLC
52 #undefCONFIG_SYS_FPGA_CHECK_CTRLC
53 #endif
Quoted 4 lines
Quoted 1 line
it doesn't make any sense.
I have no hardware to test this and this is out of scope of the conversion patch itself.
This kind of code logic needs to be enforced in Kconfig instead with depends lines. We can make sure it's size-neutral.
Quoted 5 lines
Quoted 5 lines
And with 2/2 please also remove drivers/fpga/spartan2.c:18:#undef
CONFIG_SYS_FPGA_PROG_FEEDBACKdrivers/fpga/virtex2.c:44:#ifndefCONFIG_SYS_FPGA_PROG_FEEDBACKdrivers/fpga/virtex2.c:45:#defineCONFIG_SYS_FPGA_PROG_FEEDBACK
Quoted 7 lines
Quoted 2 lines
Thanks,
MichalI may be able to add an additional patch or two, but those are all FPGAs I have no experience with and I can not test those. This would be more or less guessing based on code reading. I can try next week, not able to do this currently.
Thanks. It's OK to just check the logic by inspection, one of the tests I end up running is making sure the code size doesn't change so that'll catch bad migrations.
Signature · 1 line
Tom
PATCH v2 2/2 fpga: Convert SYS_FPGA_PROG_FEEDBACK to Kconfig
In reply to Alexander DahlFrom: Alexander Dahl <[email protected]>
--- README | 4 ---- configs/astro_mcf5373l_defconfig | 1 + drivers/fpga/Kconfig | 6 ++++++ include/configs/astro_mcf5373l.h | 1 - scripts/config_whitelist.txt | 1 - 5 files changed, 7 insertions(+), 6 deletions(-)
README +0 -4
@@ -1330,10 +1330,6 @@ The following options need to be configured: Enables support for FPGA family. (SPARTAN2, SPARTAN3, VIRTEX2, CYCLONE2, ACEX1K, ACEX) - CONFIG_SYS_FPGA_PROG_FEEDBACK - - Enable printing of hash marks during FPGA configuration. - CONFIG_SYS_FPGA_CHECK_BUSY Enable checks on FPGA configuration interface busy
configs/astro_mcf5373l_defconfig +1 -0
@@ -33,6 +33,7 @@ CONFIG_FPGA_ALTERA=y CONFIG_FPGA_CYCLON2=y CONFIG_FPGA_XILINX=y CONFIG_FPGA_SPARTAN3=y +CONFIG_SYS_FPGA_PROG_FEEDBACK=y CONFIG_SYS_I2C_LEGACY=y CONFIG_SYS_I2C_FSL=y CONFIG_SYS_FSL_I2C_OFFSET=0x58000
drivers/fpga/Kconfig +6 -0
@@ -95,4 +95,10 @@ config SYS_FPGA_CHECK_CTRLC bool "Allow Control-C to interrupt FPGA configuration" depends on FPGA +config SYS_FPGA_PROG_FEEDBACK + bool "Progress output during FPGA configuration" + depends on FPGA + help + Enable printing of hash marks during FPGA configuration. + endmenu
include/configs/astro_mcf5373l.h +0 -1
@@ -131,7 +131,6 @@* it needs non-blocking CFI routines. */ -#define CONFIG_SYS_FPGA_PROG_FEEDBACK #define CONFIG_SYS_FPGA_WAIT 1000/* End of user parameters to be customized */
scripts/config_whitelist.txt +0 -1
@@ -743,7 +743,6 @@ CONFIG_SYS_FPGA_FTIM0 CONFIG_SYS_FPGA_FTIM1 CONFIG_SYS_FPGA_FTIM2 CONFIG_SYS_FPGA_FTIM3 -CONFIG_SYS_FPGA_PROG_FEEDBACK CONFIG_SYS_FPGA_SIZE CONFIG_SYS_FPGA_WAIT CONFIG_SYS_FSL_BMAN_ADDR
Signature · 1 line
2.30.2
Re: [PATCH v2 2/2] fpga: Convert SYS_FPGA_PROG_FEEDBACK to Kconfig
Quoted 1 line · Alexander Dahl
From: Alexander Dahl <[email protected]>
WARNING: please write a paragraph that describes the config symbol fully
We don't allow patches with empty commit message.
Quoted 8 lines
Signed-off-by Alexander Dahl <[email protected]>--- README | 4 ---- configs/astro_mcf5373l_defconfig | 1 + drivers/fpga/Kconfig | 6 ++++++ include/configs/astro_mcf5373l.h | 1 - scripts/config_whitelist.txt | 1 -
Tom can confirm this but IIRC you don't need to remove this from this file. Tom is doing sync up time to time. It is enough to do conversion only.
M
Re: [PATCH v2 2/2] fpga: Convert SYS_FPGA_PROG_FEEDBACK to Kconfig
Hei hei,
Quoted 9 lines · Michal Simek
Quoted 1 line · Alexander Dahl
From: Alexander Dahl <[email protected]>
WARNING: please write a paragraph that describes the config symbol fully
We don't allow patches with empty commit message.
In general I would agree. However several of Tom's patches addressing kconfig migration have a commit message like this:
This converts the following to Kconfig: FOO_BAR
This is redundant to the subject saying exactly the same. I can add this if you want, but I saw no sense in it.
Quoted 11 lines
Quoted 10 lines
Signed-off-by Alexander Dahl <[email protected]>--- README | 4 ---- configs/astro_mcf5373l_defconfig | 1 + drivers/fpga/Kconfig | 6 ++++++ include/configs/astro_mcf5373l.h | 1 - scripts/config_whitelist.txt | 1 -
Quoted 2 lines
Tom can confirm this but IIRC you don't need to remove this from this file. Tom is doing sync up time to time. It is enough to do conversion only.
This was done by the script ./tools/moveconfig.py where I just hit enter with defaults presented. The other Kconfig patches change defconfig, but not whitelist. Seems a little inconsistent to me. But I can remove that part, sure.
Greets
Alex
Quoted 2 lines
M
Signature · 4 lines
/"\ ASCII RIBBON | »With the first link, the chain is forged. The first \ / CAMPAIGN | speech censured, the first thought forbidden, the X AGAINST | first freedom denied, chains us all irrevocably.« / \ HTML MAIL | (Jean-Luc Picard, quoting Judge Aaron Satie)
Re: [PATCH v2 2/2] fpga: Convert SYS_FPGA_PROG_FEEDBACK to Kconfig
Quoted 13 lines · Alexander Dahl
Hei hei,
Quoted 9 lines · Michal Simek
Quoted 1 line · Alexander Dahl
From: Alexander Dahl <[email protected]>
WARNING: please write a paragraph that describes the config symbol fully
We don't allow patches with empty commit message.
Quoted 7 lines
In general I would agree. However several of Tom's patches addressing kconfig migration have a commit message like this:
This converts the following to
Kconfig:FOO_BARThis is redundant to the subject saying exactly the same. I can add this if you want, but I saw no sense in it.
Yes, the moveconfig.py tool adds that and it's a little redundant sometimes, but is (a) a starting point for the times when the conversion required a little extra work or (b) lists all the symbols when you migrate more than one at a time.
Quoted 8 lines
Quoted 8 lines
Quoted 7 lines
Signed-off-by Alexander Dahl <[email protected]>--- README | 4 ---- configs/astro_mcf5373l_defconfig | 1 + drivers/fpga/Kconfig | 6 ++++++ include/configs/astro_mcf5373l.h | 1 - scripts/config_whitelist.txt | 1 -
Quoted 7 lines
Quoted 2 lines
Tom can confirm this but IIRC you don't need to remove this from this file. Tom is doing sync up time to time. It is enough to do conversion only.
This was done by the script
./tools/moveconfig.pywhere I just hit enter with defaults presented. The otherKconfigpatches change defconfig, but not whitelist. Seems a little inconsistent to me. But I can remove that part, sure.
So, I usually run "-yC" with moveconfig.py as that gives the commit message. It's not a problem, really, to touch scripts/config_whitelist.txt it just also can conflict easily. Omitting it makes it easier to "git am", fixing up / dropping that hunk if it conflicts later is also fine.
Signature · 1 line
Tom