systemd: add usrmerge to REQUIRED_DISTRO_FEATURES
PATCH 1/1 systemd: add usrmerge to REQUIRED_DISTRO_FEATURES
From: Luca Boccassi <[email protected]>
Support for unmerged-usr is deprecated upstream, taints the system and will be removed in the near future.
Enforce building merged-usr images when using systemd.
---
We intend to deprecate unmerged-usr at some point, and we are doing the rounds ensuring distros are moving along so that there are no surprises when the time comes.
See:
https://lists.freedesktop.org/archives/systemd-devel/2022-April/047673.html
meta/recipes-core/systemd/systemd.inc | 5 +++++ 1 file changed, 5 insertions(+)
meta/recipes-core/systemd/systemd.inc +5 -0
@@ -21,3 +21,8 @@ SRC_URI = "git://github.com/systemd/systemd-stable.git;protocol=https;branch=${S " S = "${WORKDIR}/git" + +# unmerged-usr support is deprecated upstream, taints the system and will be +# removed in the near future. Fail the build if it is not enabled. +inherit features_check +REQUIRED_DISTRO_FEATURES = "usrmerge"
Signature · 1 line
2.34.1
Quoted 23 lines · Luca Bocassi
From: Luca Boccassi <[email protected]>
Support for unmerged-usr is deprecated upstream, taints the system and will be removed in the near future.
Enforce building merged-usr images when using systemd.Signed-off-by Luca Boccassi <[email protected]>---
We intend to deprecate unmerged-usr at some point, and we are doing the rounds ensuring distros are moving along so that there are no surprises when the time comes.See:
https://lists.freedesktop.org/archives/systemd-devel/2022-April/047673.htmlmeta/recipes-core/systemd/systemd.inc | 5 +++++ 1 file changed, 5 insertions(+)meta/recipes-core/systemd/systemd.inc +0
-0
meta/recipes-core/systemd/systemd.inc SRC_URI = "git://github.com/systemd/systemd-stable.git;protocol=https;branch=${S · line 28
Quoted 8 lines
meta/recipes-core/systemd/systemd.inc +5
-0@@ -21,3 +21,8 @@ SRC_URI = "git://github.com/systemd/systemd-stable.git;protocol=https;branch=${S " S = "${WORKDIR}/git" + +# unmerged-usr support is deprecated upstream, taints the system and will be +# removed in the near future. Fail the build if it is not enabled. +inherit features_check +REQUIRED_DISTRO_FEATURES = "usrmerge"
Given none of our systemd testing on the autobuilder is done under usrmerge and we've never mentioned this requirement to any of our userbase before, this is going to come as a bit of a surprise to people. The above change will break the autobuilder as things stand :(.
Cheers,
Richard
Quoted 27 lines · Richard Purdie
Quoted 25 lines · Luca Bocassi
From: Luca Boccassi <[email protected]>
Support for unmerged-usr is deprecated upstream, taints the system and will be removed in the near future.
Enforce building merged-usr images when using systemd.Signed-off-by Luca Boccassi <[email protected]>---
We intend to deprecate unmerged-usr at some point, and we are doing the rounds ensuring distros are moving along so that there are no surprises when the time comes.See:
https://lists.freedesktop.org/archives/systemd-devel/2022-April/047673.htmlmeta/recipes-core/systemd/systemd.inc | 5 +++++ 1 file changed, 5 insertions(+)meta/recipes-core/systemd/systemd.inc +0
-0@@ -21,3 +21,8 @@ SRC_URI = "git://github.com/systemd/systemd-stable.git;protocol=https;branch=${S "
Quoted 11 lines
meta/recipes-core/systemd/systemd.inc SRC_URI = "git://github.com/systemd/systemd-stable.git;protocol=https;branch=${S · line 28
Quoted 6 lines
meta/recipes-core/systemd/systemd.inc +5
-0S = "${WORKDIR}/git" + +# unmerged-usr support is deprecated upstream, taints the system and will be +# removed in the near future. Fail the build if it is not enabled. +inherit features_check +REQUIRED_DISTRO_FEATURES = "usrmerge"Given none of our systemd testing on the autobuilder is done under usrmerge and we've never mentioned this requirement to any of our userbase before, this is going to come as a bit of a surprise to people. The above change will break the autobuilder as things stand :(.
Yes I was expecting there would be these kind of issues, the purpose of sending this was mainly to find out about them.
So where are these configurations stored? How can we get them updated? Also is a deprecation notification needed? How is it handled usually?
Aside from process details, I assume there's no problem with doing the change in principle?
Thanks!
Kind regards,
Luca Boccassi
Quoted 41 lines · Luca Boccassi
Quoted 27 lines · Richard Purdie
Quoted 25 lines · Luca Bocassi
From: Luca Boccassi <[email protected]>
Support for unmerged-usr is deprecated upstream, taints the system and will be removed in the near future.
Enforce building merged-usr images when using systemd.Signed-off-by Luca Boccassi <[email protected]>---
We intend to deprecate unmerged-usr at some point, and we are doing the rounds ensuring distros are moving along so that there are no surprises when the time comes.See:
https://lists.freedesktop.org/archives/systemd-devel/2022-April/047673.htmlmeta/recipes-core/systemd/systemd.inc | 5 +++++ 1 file changed, 5 insertions(+)meta/recipes-core/systemd/systemd.inc +0
-0@@ -21,3 +21,8 @@ SRC_URI = "git://github.com/systemd/systemd-stable.git;protocol=https;branch=${S "Quoted 11 lines
meta/recipes-core/systemd/systemd.inc SRC_URI = "git://github.com/systemd/systemd-stable.git;protocol=https;branch=${S · line 28
Quoted 6 lines
meta/recipes-core/systemd/systemd.inc +5
-0S = "${WORKDIR}/git" + +# unmerged-usr support is deprecated upstream, taints the system and will be +# removed in the near future. Fail the build if it is not enabled. +inherit features_check +REQUIRED_DISTRO_FEATURES = "usrmerge"Given none of our systemd testing on the autobuilder is done under usrmerge and we've never mentioned this requirement to any of our userbase before, this is going to come as a bit of a surprise to people. The above change will break the autobuilder as things stand :(.
Quoted 3 lines
Yes I was expecting there would be these kind of issues, the purpose of sending this was mainly to find out about them.
So where are these configurations stored? How can we get them updated?
The configuration is yocto-autobuilder-helper but the best place to start is probably the poky-altcfg distro config.
Once we change that we'll have to run through the testing, see how much breaks and then find someone to try and fix any issues if/as needed. There is a lot of work just in pulling things together for testing and triaging the result and I'm depressed it will probably end up on my plate when I personally disagree with the decision.
I was asked earlier today if we should just make the systemd include files force usrmerge on. The challenge is that OE/YP give users choice to configure their system how they wish, we don't just force configurations upon them. Or only real option is therefore to throw errors and have them decide what to do (which basically amounts to submitting to the upstream decision).
Quoted 1 line
Also is a deprecation notification needed? How is it handled usually?
Do we have time for such a notification or are we in the situation where we just throw errors to the user and let them agree to the usrmerge change? The timescale is unclear but if the systems are already throwing deprecation warnings at runtime, this isn't a good experience for our users.
Quoted 2 lines
Aside from process details, I assume there's no problem with doing the change in principle?
There is, but it appears a done deal which we just have to accept so I'm trying not to start a discussion which I don't think can go anywhere productive. If this isn't a done deal, then let me know as that would be different.
Cheers,
Richard
Quoted 47 lines · Richard Purdie
Quoted 41 lines · Luca Boccassi
Quoted 27 lines · Richard Purdie
Quoted 25 lines · Luca Bocassi
From: Luca Boccassi <[email protected]>
Support for unmerged-usr is deprecated upstream, taints the system and will be removed in the near future.
Enforce building merged-usr images when using systemd.Signed-off-by Luca Boccassi <[email protected]>---
We intend to deprecate unmerged-usr at some point, and we are doing the rounds ensuring distros are moving along so that there are no surprises when the time comes.See:
https://lists.freedesktop.org/archives/systemd-devel/2022-April/047673.htmlmeta/recipes-core/systemd/systemd.inc | 5 +++++ 1 file changed, 5 insertions(+)meta/recipes-core/systemd/systemd.inc +0
-0@@ -21,3 +21,8 @@ SRC_URI = "git://github.com/systemd/systemd-stable.git;protocol=https;branch=${S "Quoted 11 lines
meta/recipes-core/systemd/systemd.inc SRC_URI = "git://github.com/systemd/systemd-stable.git;protocol=https;branch=${S · line 28
Quoted 6 lines
meta/recipes-core/systemd/systemd.inc +5
-0S = "${WORKDIR}/git" + +# unmerged-usr support is deprecated upstream, taints the system and will be +# removed in the near future. Fail the build if it is not enabled. +inherit features_check +REQUIRED_DISTRO_FEATURES = "usrmerge"Given none of our systemd testing on the autobuilder is done under usrmerge and we've never mentioned this requirement to any of our userbase before, this is going to come as a bit of a surprise to people. The above change will break the autobuilder as things stand :(.
Quoted 3 lines
Yes I was expecting there would be these kind of issues, the purpose of sending this was mainly to find out about them.
So where are these configurations stored? How can we get them updated?
Quoted 8 lines
The configuration is yocto-autobuilder-helper but the best place to start is probably the poky-altcfg distro config.
Once we change that we'll have to run through the testing, see how much breaks and then find someone to try and fix any issues if/as needed. There is a lot of work just in pulling things together for testing and triaging the result and I'm depressed it will probably end up on my plate when I personally disagree with the decision.
We've been running this configuration internally for ~3 years in our Yocto downstream, never seen any issue, not even at the beginning, it just worked.
Nowadays most major distros have switched over, Gentoo's the other one left but it's planned for this year.
Any issues in upstream softwares should have been fixed years ago when Fedora started the process.
So hopefully it shouldn't be too bad?
Quoted 7 lines
I was asked earlier today if we should just make the systemd include files force usrmerge on. The challenge is that OE/YP give users choice to configure their system how they wish, we don't just force configurations upon them. Or only real option is therefore to throw errors and have them decide what to do (which basically amounts to submitting to the upstream decision).
Quoted 7 lines
Quoted 1 line
Also is a deprecation notification needed? How is it handled usually?
Do we have time for such a notification or are we in the situation where we just throw errors to the user and let them agree to the usrmerge change? The timescale is unclear but if the systems are already throwing deprecation warnings at runtime, this isn't a good experience for our users.
It's not urgent. But the build-time warning has been in place for a couple of years now, you should have already seen it.
The runtime is a taint flag in 'systemctl status', and was introduced in the most recent release.
There is no timeline as of now for dropping legacy compat code and configuration, as the runtime taint was just added. Certainly won't be this year. I've been doing the rounds ensuring everyone who hasn't switched already is aware with plenty of time to spare.
Quoted 7 lines
Quoted 2 lines
Aside from process details, I assume there's no problem with doing the change in principle?
There is, but it appears a done deal which we just have to accept so I'm trying not to start a discussion which I don't think can go anywhere productive. If this isn't a done deal, then let me know as that would be different.
It is a done deal as far as we are concerned upstream, matter of 'when' not 'if'.
Kind regards,
Luca Boccassi
Quoted 11 lines · Luca Boccassi
Quoted 8 lines · Richard Purdie
The configuration is yocto-autobuilder-helper but the best place to start is probably the poky-altcfg distro config.
Once we change that we'll have to run through the testing, see how much breaks and then find someone to try and fix any issues if/as needed. There is a lot of work just in pulling things together for testing and triaging the result and I'm depressed it will probably end up on my plate when I personally disagree with the decision.
Quoted 8 lines
We've been running this configuration internally for ~3 years in our Yocto downstream, never seen any issue, not even at the beginning, it just worked.
Nowadays most major distros have switched over, Gentoo's the other one left but it's planned for this year.
Any issues in upstream softwares should have been fixed years ago when Fedora started the process.
So hopefully it shouldn't be too bad?
My worry is the QA framework and tests likely haven't been used with it. It may be fine or it may not. I do know how much of my time this stuff takes up with other issues.
Quoted 9 lines
Quoted 9 lines
I was asked earlier today if we should just make the systemd include files force usrmerge on. The challenge is that OE/YP give users choice to configure their system how they wish, we don't just force configurations upon them. Or only real option is therefore to throw errors and have them decide what to do (which basically amounts to submitting to the upstream decision).
Quoted 1 line
Also is a deprecation notification needed? How is it handled usually?
Quoted 8 lines
Quoted 5 lines
Do we have time for such a notification or are we in the situation where we just throw errors to the user and let them agree to the usrmerge change? The timescale is unclear but if the systems are already throwing deprecation warnings at runtime, this isn't a good experience for our users.
It's not urgent. But the build-time warning has been in place for a couple of years now, you should have already seen it.
I haven't :(.
Quoted 7 lines
The runtime is a taint flag in 'systemctl status', and was introduced in the most recent release.
There is no timeline as of now for dropping legacy compat code and configuration, as the runtime taint was just added. Certainly won't be this year. I've been doing the rounds ensuring everyone who hasn't switched already is aware with plenty of time to spare.
Well, it is good to have the warning, thanks.
Quoted 11 lines
Quoted 8 lines
Quoted 3 lines
Aside from process details, I assume there's no problem with doing the change in principle?
There is, but it appears a done deal which we just have to accept so I'm trying not to start a discussion which I don't think can go anywhere productive. If this isn't a done deal, then let me know as that would be different.
It is a done deal as far as we are concerned upstream, matter of 'when' not 'if'.
This is not going to help systemd's reputation. Basically, we have to do what Fedora does and look as we're told to, which does go against our configurability objective. We already have tensions around musl and this will further demonstrate our direction and systemd's are not aligned. I do understand why systemd is doing what it is doing and that it really doesn't care about our use cases. That doesn't stop some users wanting it (but also wanting other things we have like musl).
Cheers,
Richard
Quoted 22 lines · Richard Purdie
Quoted 11 lines · Luca Boccassi
Quoted 8 lines · Richard Purdie
The configuration is yocto-autobuilder-helper but the best place to start is probably the poky-altcfg distro config.
Once we change that we'll have to run through the testing, see how much breaks and then find someone to try and fix any issues if/as needed. There is a lot of work just in pulling things together for testing and triaging the result and I'm depressed it will probably end up on my plate when I personally disagree with the decision.
Quoted 8 lines
We've been running this configuration internally for ~3 years in our Yocto downstream, never seen any issue, not even at the beginning, it just worked.
Nowadays most major distros have switched over, Gentoo's the other one left but it's planned for this year.
Any issues in upstream softwares should have been fixed years ago when Fedora started the process.
So hopefully it shouldn't be too bad?
Quoted 3 lines
My worry is the QA framework and tests likely haven't been used with it. It may be fine or it may not. I do know how much of my time this stuff takes up with other issues.
I have sent v2 with the poky-altcfg configuration change.
Quoted 42 lines
Quoted 9 lines
Quoted 9 lines
I was asked earlier today if we should just make the systemd include files force usrmerge on. The challenge is that OE/YP give users choice to configure their system how they wish, we don't just force configurations upon them. Or only real option is therefore to throw errors and have them decide what to do (which basically amounts to submitting to the upstream decision).
Quoted 1 line
Also is a deprecation notification needed? How is it handled usually?
Quoted 8 lines
Quoted 5 lines
Do we have time for such a notification or are we in the situation where we just throw errors to the user and let them agree to the usrmerge change? The timescale is unclear but if the systems are already throwing deprecation warnings at runtime, this isn't a good experience for our users.
It's not urgent. But the build-time warning has been in place for a couple of years now, you should have already seen it.
I haven't :(.
Quoted 7 lines
The runtime is a taint flag in 'systemctl status', and was introduced in the most recent release.
There is no timeline as of now for dropping legacy compat code and configuration, as the runtime taint was just added. Certainly won't be this year. I've been doing the rounds ensuring everyone who hasn't switched already is aware with plenty of time to spare.Well, it is good to have the warning, thanks.
Quoted 11 lines
Quoted 8 lines
Quoted 3 lines
Aside from process details, I assume there's no problem with doing the change in principle?
There is, but it appears a done deal which we just have to accept so I'm trying not to start a discussion which I don't think can go anywhere productive. If this isn't a done deal, then let me know as that would be different.
It is a done deal as far as we are concerned upstream, matter of 'when' not 'if'.
Quoted 7 lines
This is not going to help systemd's reputation. Basically, we have to do what Fedora does and look as we're told to, which does go against our configurability objective. We already have tensions around musl and this will further demonstrate our direction and systemd's are not aligned. I do understand why systemd is doing what it is doing and that it really doesn't care about our use cases. That doesn't stop some users wanting it (but also wanting other things we have like musl).
Well, it's not just Fedora nowadays, it's Fedora, RHEL, CentOS, Alma, Rocky, SUSE, Archlinux, Debian, Ubuntu, Mint, PopOS, Endless, OpenMandriva, Mariner... and Gentoo is planning it. There's probably more, those are the ones I know off the top of my head. Whether to do this change or not was discussed at length almost ten years ago. We can't keep reopening the same things again and again, it's discussed once (or twice...) and then the decision is documented and slowly implemented, like any other project does. Every project has breaking changes every now and then, Yocto included. We're doing our best to document and notify and spread the word, and sending patches too in some cases.
Kind regards,
Luca Boccassi
It’s been in the news that lennart has left red hat and moved to Microsoft recently and will continue with systemd there. Which is rather worrying, as Microsoft by and large is only interested In linux on azure or wsl.
I can help iron out the issues once we have a list.
Alex
Quoted 111 lines · Luca Bocassi
Quoted 8 lines · Richard Purdie
Quoted 6 lines · Luca Boccassi
Quoted 4 lines · Richard Purdie
The configuration is yocto-autobuilder-helper but the best place to start is probably the poky-altcfg distro config.
Once we change that we'll have to run through the testing, see how
much
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
breaks and then find someone to try and fix any issues if/as needed. There is a lot of work just in pulling things together for testing
and
Quoted 12 lines
Quoted 11 lines
Quoted 2 lines
triaging the result and I'm depressed it will probably end up on my plate when I personally disagree with the decision.
We've been running this configuration internally for ~3 years in our Yocto downstream, never seen any issue, not even at the beginning, it just worked.
Nowadays most major distros have switched over, Gentoo's the other one left but it's planned for this year.
Any issues in upstream softwares should have been fixed years ago when Fedora started the process.
So hopefully it shouldn't be too bad?Quoted 3 lines
My worry is the QA framework and tests likely haven't been used with it. It may be fine or it may not. I do know how much of my time this stuff takes up with other issues.
I have sent v2 with the poky-altcfg configuration change.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
I was asked earlier today if we should just make the systemd include files force usrmerge on. The challenge is that OE/YP give users
choice
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
to configure their system how they wish, we don't just force configurations upon them. Or only real option is therefore to throw errors and have them decide what to do (which basically amounts to submitting to the upstream decision).
Quoted 1 line
Also is a deprecation notification needed? How is it handled
usually?
Quoted 20 lines
Quoted 9 lines
Quoted 6 lines
Do we have time for such a notification or are we in the situation where we just throw errors to the user and let them agree to the usrmerge change? The timescale is unclear but if the systems are already throwing deprecation warnings at runtime, this isn't a good experience for our users.
It's not urgent. But the build-time warning has been in place for a couple of years now, you should have already seen it.
I haven't :(.
Quoted 7 lines
The runtime is a taint flag in 'systemctl status', and was introduced in the most recent release.
There is no timeline as of now for dropping legacy compat code and configuration, as the runtime taint was just added. Certainly won't be this year. I've been doing the rounds ensuring everyone who hasn't switched already is aware with plenty of time to spare.Quoted 4 lines
Well, it is good to have the warning, thanks.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Aside from process details, I assume there's no problem with doing
the
Quoted 10 lines
Quoted 9 lines
Quoted 6 lines
Quoted 1 line
change in principle?
There is, but it appears a done deal which we just have to accept so I'm trying not to start a discussion which I don't think can go anywhere productive. If this isn't a done deal, then let me know as that would be different.
It is a done deal as far as we are concerned upstream, matter of 'when' not 'if'.
Quoted 7 lines
This is not going to help systemd's reputation. Basically, we have to do what Fedora does and look as we're told to, which does go against our configurability objective. We already have tensions around musl and this will further demonstrate our direction and systemd's are not aligned. I do understand why systemd is doing what it is doing and that it really doesn't care about our use cases. That doesn't stop some users wanting it (but also wanting other things we have like musl).
Well, it's not just Fedora nowadays, it's Fedora, RHEL, CentOS, Alma, Rocky, SUSE, Archlinux, Debian, Ubuntu, Mint, PopOS, Endless, OpenMandriva, Mariner... and Gentoo is planning it. There's probably more, those are the ones I know off the top of my head. Whether to do this change or not was discussed at length almost ten years ago. We can't keep reopening the same things again and again, it's discussed once (or twice...) and then the decision is documented and slowly implemented, like any other project does. Every project has breaking changes every now and then, Yocto included. We're doing our best to document and notify and spread the word, and sending patches too in some cases.
Kind regards,
Luca Boccassi-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#167961):
https://lists.openembedded.org/g/openembedded-core/message/167961
Mute This Topic: https://lists.openembedded.org/mt/92319509/1686489
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Quoted 83 lines · Luca Boccassi
Quoted 47 lines · Richard Purdie
Quoted 41 lines · Luca Boccassi
Quoted 27 lines · Richard Purdie
Quoted 25 lines · Luca Bocassi
From: Luca Boccassi <[email protected]>
Support for unmerged-usr is deprecated upstream, taints the system and will be removed in the near future.
Enforce building merged-usr images when using systemd.Signed-off-by Luca Boccassi <[email protected]>---
We intend to deprecate unmerged-usr at some point, and we are doing the rounds ensuring distros are moving along so that there are no surprises when the time comes.See:
https://lists.freedesktop.org/archives/systemd-devel/2022-April/047673.htmlmeta/recipes-core/systemd/systemd.inc | 5 +++++ 1 file changed, 5 insertions(+)meta/recipes-core/systemd/systemd.inc +0
-0@@ -21,3 +21,8 @@ SRC_URI = "git://github.com/systemd/systemd-stable.git;protocol=https;branch=${S "Quoted 11 lines
meta/recipes-core/systemd/systemd.inc SRC_URI = "git://github.com/systemd/systemd-stable.git;protocol=https;branch=${S · line 28
Quoted 6 lines
meta/recipes-core/systemd/systemd.inc +5
-0S = "${WORKDIR}/git" + +# unmerged-usr support is deprecated upstream, taints the system and will be +# removed in the near future. Fail the build if it is not enabled. +inherit features_check +REQUIRED_DISTRO_FEATURES = "usrmerge"Given none of our systemd testing on the autobuilder is done under usrmerge and we've never mentioned this requirement to any of our userbase before, this is going to come as a bit of a surprise to people. The above change will break the autobuilder as things stand :(.
Quoted 3 lines
Yes I was expecting there would be these kind of issues, the purpose of sending this was mainly to find out about them.
So where are these configurations stored? How can we get them updated?Quoted 8 lines
The configuration is yocto-autobuilder-helper but the best place to start is probably the poky-altcfg distro config.
Once we change that we'll have to run through the testing, see how much breaks and then find someone to try and fix any issues if/as needed. There is a lot of work just in pulling things together for testing and triaging the result and I'm depressed it will probably end up on my plate when I personally disagree with the decision.
We've been running this configuration internally for ~3 years in our Yocto downstream, never seen any issue, not even at the beginning, it just worked.
Nowadays most major distros have switched over, Gentoo's the other one left but it's planned for this year.
Any issues in upstream softwares should have been fixed years ago when Fedora started the process.
So hopefully it shouldn't be too bad?Quoted 7 lines
I was asked earlier today if we should just make the systemd include files force usrmerge on. The challenge is that OE/YP give users choice to configure their system how they wish, we don't just force configurations upon them. Or only real option is therefore to throw errors and have them decide what to do (which basically amounts to submitting to the upstream decision).
Quoted 7 lines
Quoted 1 line
Also is a deprecation notification needed? How is it handled usually?
Do we have time for such a notification or are we in the situation where we just throw errors to the user and let them agree to the usrmerge change? The timescale is unclear but if the systems are already throwing deprecation warnings at runtime, this isn't a good experience for our users.
Quoted 9 lines
It's not urgent. But the build-time warning has been in place for a couple of years now, you should have already seen it.
The runtime is a taint flag in 'systemctl status', and was introduced in the most recent release.
There is no timeline as of now for dropping legacy compat code and configuration, as the runtime taint was just added. Certainly won't be this year. I've been doing the rounds ensuring everyone who hasn't switched already is aware with plenty of time to spare.
FYI, we now have a tentative timeline: first release of H2 2023 will drop support for split-usr and unmerged-usr:
https://github.com/systemd/systemd/blob/v252-rc2/NEWS#L14
Kind regards,
Luca Boccassi
PATCH v2 1/2 poky-altcfg: enable usrmerge
In reply to [email protected]From: Luca Boccassi <[email protected]>
Ensure it gets tested by the CI
--- meta-poky/conf/distro/poky-altcfg.conf | 2 ++ 1 file changed, 2 insertions(+)
meta-poky/conf/distro/poky-altcfg.conf +2 -0
@@ -9,6 +9,8 @@ DISTROOVERRIDES = "poky:poky-altcfg" #DISTROOVERRIDES = "poky:linuxstdbase" INIT_MANAGER:poky-altcfg = "systemd" +# systemd will soon require usrmerge +DISTRO_FEATURES:poky-altcfg += "usrmerge" # systemd isn't suitable with musl INIT_MANAGER:poky-altcfg:libc-musl = "sysvinit"
Signature · 1 line
2.34.1
PATCH v2 2/2 systemd: add usrmerge to REQUIRED_DISTRO_FEATURES
From: Luca Boccassi <[email protected]>
Support for unmerged-usr is deprecated upstream, taints the system and will be removed in the near future.
Enforce building merged-usr images when using systemd.
---
v2: use :append in each recipe
meta/recipes-core/systemd/systemd-compat-units.bb | 2 +- meta/recipes-core/systemd/systemd-serialgetty.bb | 2 +- meta/recipes-core/systemd/systemd.inc | 5 +++++ meta/recipes-core/systemd/systemd_251.2.bb | 2 +- 4 files changed, 8 insertions(+), 3 deletions(-)
meta/recipes-core/systemd/systemd-compat-units.bb +1 -1
@@ -14,7 +14,7 @@ INHIBIT_DEFAULT_DEPS = "1" ALLOW_EMPTY:${PN} = "1" -REQUIRED_DISTRO_FEATURES = "systemd" +REQUIRED_DISTRO_FEATURES:append += "systemd" SYSTEMD_DISABLED_SYSV_SERVICES = " \ busybox-udhcpc \
meta/recipes-core/systemd/systemd-serialgetty.bb +1 -1
@@ -14,7 +14,7 @@ S = "${WORKDIR}" # As this package is tied to systemd, only build it when we're also building systemd. inherit features_check -REQUIRED_DISTRO_FEATURES = "systemd" +REQUIRED_DISTRO_FEATURES:append += "systemd" do_install() { if [ ! -z "${SERIAL_CONSOLES}" ] ; then
meta/recipes-core/systemd/systemd.inc +5 -0
@@ -21,3 +21,8 @@ SRC_URI = "git://github.com/systemd/systemd-stable.git;protocol=https;branch=${S " S = "${WORKDIR}/git" + +# unmerged-usr support is deprecated upstream, taints the system and will be +# removed in the near future. Fail the build if it is not enabled. +inherit features_check +REQUIRED_DISTRO_FEATURES = "usrmerge"
meta/recipes-core/systemd/systemd_251.2.bb +1 -1
@@ -12,7 +12,7 @@ inherit useradd pkgconfig meson perlnative update-rc.d update-alternatives qemu # As this recipe builds udev, respect systemd being in DISTRO_FEATURES so # that we don't build both udev and systemd in world builds. -REQUIRED_DISTRO_FEATURES = "systemd" +REQUIRED_DISTRO_FEATURES:append += "systemd" SRC_URI += "file://touchscreen.rules \ file://00-create-volatile.conf \
Signature · 1 line
2.34.1
Don't use :append together with +=, just add the leading space in the value.
Wasn't there a warning when these 2 are used together?
Quoted 93 lines · Luca Bocassi
From: Luca Boccassi <[email protected]>
Support for unmerged-usr is deprecated upstream, taints the system and will be
removed in the near future.
Enforce building merged-usr images when using systemd.Signed-off-by Luca Boccassi <[email protected]>---
v2: use :append in each recipemeta/recipes-core/systemd/systemd-compat-units.bb | 2 +- meta/recipes-core/systemd/systemd-serialgetty.bb | 2 +- meta/recipes-core/systemd/systemd.inc | 5 +++++ meta/recipes-core/systemd/systemd_251.2.bb | 2 +- 4 files changed, 8 insertions(+), 3 deletions(-)meta/recipes-core/systemd/systemd-compat-units.bb +1
-1@@ -14,7 +14,7 @@ INHIBIT_DEFAULT_DEPS = "1" ALLOW_EMPTY:${PN} = "1" -REQUIRED_DISTRO_FEATURES = "systemd" +REQUIRED_DISTRO_FEATURES:append += "systemd" SYSTEMD_DISABLED_SYSV_SERVICES = " \ busybox-udhcpc \meta/recipes-core/systemd/systemd-serialgetty.bb +0
-0@@ -14,7 +14,7 @@ S = "${WORKDIR}" # As this package is tied to systemd, only build it when we're alsobuilding systemd.
inheritfeatures_checkmeta/recipes-core/systemd/systemd-serialgetty.bb +1
-1-REQUIRED_DISTRO_FEATURES = "systemd" +REQUIRED_DISTRO_FEATURES:append += "systemd" do_install() { if [ ! -z "${SERIAL_CONSOLES}" ] ; thenmeta/recipes-core/systemd/systemd.inc +0
-0@@ -21,3 +21,8 @@ SRC_URI = "git://github.com/systemd/systemd-stable.git;protocol=https;branch=${S
<http://github.com/systemd/systemd-stable.git;protocol=https;branch=$%7BS>
"S = "${WORKDIR}/git"
meta/recipes-core/systemd/systemd.inc +2
-0+ +# unmerged-usr support is deprecated upstream, taints the system and willbe
meta/recipes-core/systemd/systemd.inc +3
-0+# removed in the near future. Fail the build if it is not enabled. +inherit features_check +REQUIRED_DISTRO_FEATURES = "usrmerge"meta/recipes-core/systemd/systemd_251.2.bb +0
-0@@ -12,7 +12,7 @@ inherit useradd pkgconfig meson perlnative update-rc.dupdate-alternatives qemu
# As this recipe builds udev, respect systemd being in
DISTRO_FEATURESso# that we don't build both udev and systemd in world builds.meta/recipes-core/systemd/systemd_251.2.bb +1
-2-REQUIRED_DISTRO_FEATURES = "systemd" +REQUIRED_DISTRO_FEATURES:append += "systemd" SRC_URI += "file://touchscreen.rules \ file://00-create-volatile.conf \ --2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#167960):
https://lists.openembedded.org/g/openembedded-core/message/167960
Mute This Topic: https://lists.openembedded.org/mt/92360228/3617156
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 5 lines · Martin Jansa via lists.openembedded.org
Don't use :append together with +=, just add the leading space in the value.
Wasn't there a warning when these 2 are used together?
There should be a warning since:
https://git.openembedded.org/bitbake/commit/?id=8c31e75557dc6a8d8f407b5d24d6327889a3e3b1
Quoted 60 lines · Luca Bocassi
From: Luca Boccassi <[email protected]>
Support for unmerged-usr is deprecated upstream, taints the system and will be removed in the near future.
Enforce building merged-usr images when using systemd.Signed-off-by Luca Boccassi <[email protected]>---
v2: use :append in each recipemeta/recipes-core/systemd/systemd-compat-units.bb | 2 +- meta/recipes-core/systemd/systemd-serialgetty.bb | 2 +- meta/recipes-core/systemd/systemd.inc | 5 +++++ meta/recipes-core/systemd/systemd_251.2.bb | 2 +- 4 files changed, 8 insertions(+), 3 deletions(-)meta/recipes-core/systemd/systemd-compat-units.bb +1
-1@@ -14,7 +14,7 @@ INHIBIT_DEFAULT_DEPS = "1" ALLOW_EMPTY:${PN} = "1" -REQUIRED_DISTRO_FEATURES = "systemd" +REQUIRED_DISTRO_FEATURES:append += "systemd" SYSTEMD_DISABLED_SYSV_SERVICES = " \ busybox-udhcpc \meta/recipes-core/systemd/systemd-serialgetty.bb +1
-1@@ -14,7 +14,7 @@ S = "${WORKDIR}" # As this package is tied to systemd, only build it when we're also building systemd. inherit features_check -REQUIRED_DISTRO_FEATURES = "systemd" +REQUIRED_DISTRO_FEATURES:append += "systemd" do_install() { if [ ! -z "${SERIAL_CONSOLES}" ] ; thenmeta/recipes-core/systemd/systemd.inc +5
-0@@ -21,3 +21,8 @@ SRC_URI = "git://github.com/systemd/systemd-stable.git;protocol=https;branch=${S " S = "${WORKDIR}/git" + +# unmerged-usr support is deprecated upstream, taints the system and will be +# removed in the near future. Fail the build if it is not enabled. +inherit features_check +REQUIRED_DISTRO_FEATURES = "usrmerge"meta/recipes-core/systemd/systemd_251.2.bb +0
-0
meta/recipes-core/systemd/systemd_251.2.bb inherit useradd pkgconfig meson perlnative update-rc.d update-alternatives qemu · line 16
Quoted 6 lines
meta/recipes-core/systemd/systemd_251.2.bb +1
-1@@ -12,7 +12,7 @@ inherit useradd pkgconfig meson perlnative update-rc.d update-alternatives qemu # As this recipe builds udev, respect systemd being in DISTRO_FEATURES so # that we don't build both udev and systemd in world builds. -REQUIRED_DISTRO_FEATURES = "systemd" +REQUIRED_DISTRO_FEATURES:append += "systemd"
We shouldn't need :append here, just go with += "systemd".
Cheers,
Richard
Quoted 63 lines · Richard Purdie
Quoted 61 lines · Luca Bocassi
From: Luca Boccassi <[email protected]>
Support for unmerged-usr is deprecated upstream, taints the system and will be removed in the near future.
Enforce building merged-usr images when using systemd.Signed-off-by Luca Boccassi <[email protected]>---
v2: use :append in each recipemeta/recipes-core/systemd/systemd-compat-units.bb | 2 +- meta/recipes-core/systemd/systemd-serialgetty.bb | 2 +- meta/recipes-core/systemd/systemd.inc | 5 +++++ meta/recipes-core/systemd/systemd_251.2.bb | 2 +- 4 files changed, 8 insertions(+), 3 deletions(-)meta/recipes-core/systemd/systemd-compat-units.bb +1
-1@@ -14,7 +14,7 @@ INHIBIT_DEFAULT_DEPS = "1" ALLOW_EMPTY:${PN} = "1" -REQUIRED_DISTRO_FEATURES = "systemd" +REQUIRED_DISTRO_FEATURES:append += "systemd" SYSTEMD_DISABLED_SYSV_SERVICES = " \ busybox-udhcpc \meta/recipes-core/systemd/systemd-serialgetty.bb +1
-1@@ -14,7 +14,7 @@ S = "${WORKDIR}" # As this package is tied to systemd, only build it when we're also building systemd. inherit features_check -REQUIRED_DISTRO_FEATURES = "systemd" +REQUIRED_DISTRO_FEATURES:append += "systemd" do_install() { if [ ! -z "${SERIAL_CONSOLES}" ] ; thenmeta/recipes-core/systemd/systemd.inc +5
-0@@ -21,3 +21,8 @@ SRC_URI = "git://github.com/systemd/systemd-stable.git;protocol=https;branch=${S " S = "${WORKDIR}/git" + +# unmerged-usr support is deprecated upstream, taints the system and will be +# removed in the near future. Fail the build if it is not enabled. +inherit features_check +REQUIRED_DISTRO_FEATURES = "usrmerge"meta/recipes-core/systemd/systemd_251.2.bb +0
-0@@ -12,7 +12,7 @@ inherit useradd pkgconfig meson perlnative update-rc.d update-alternatives qemu
Quoted 7 lines
meta/recipes-core/systemd/systemd_251.2.bb inherit useradd pkgconfig meson perlnative update-rc.d update-alternatives qemu · line 16
Quoted 5 lines
meta/recipes-core/systemd/systemd_251.2.bb +1
-1# As this recipe builds udev, respect systemd being in DISTRO_FEATURES so # that we don't build both udev and systemd in world builds. -REQUIRED_DISTRO_FEATURES = "systemd" +REQUIRED_DISTRO_FEATURES:append += "systemd"We shouldn't need :append here, just go with += "systemd".
Mh I could swear with that I was getting:
missing required distro feature 'usrmergesystemd' (not in DISTRO_FEATURES)
It's in the scrollback, but now it doesn't happen anymore, so I probably had borken it in a different way. One day I'll get the appends right on first try, one day...
Kind regards,
Luca Boccassi
There was one issue so far:
https://autobuilder.yoctoproject.org/typhoon/#/builders/101/builds/4303/steps/13/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/131/builds/882/steps/14/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/131/builds/882
and probably more of that one occurring, the build is still in progress.
The build does have other patches under test in it and those also have issues but I'm pretty sure the ones above are usrmerge related.
Cheers,
Richard
PATCH v3 1/2 poky-altcfg: enable usrmerge
In reply to [email protected]From: Luca Boccassi <[email protected]>
Ensure it gets tested by the CI
--- meta-poky/conf/distro/poky-altcfg.conf | 2 ++ 1 file changed, 2 insertions(+)
meta-poky/conf/distro/poky-altcfg.conf +2 -0
@@ -9,6 +9,8 @@ DISTROOVERRIDES = "poky:poky-altcfg" #DISTROOVERRIDES = "poky:linuxstdbase" INIT_MANAGER:poky-altcfg = "systemd" +# systemd will soon require usrmerge +DISTRO_FEATURES:poky-altcfg += "usrmerge" # systemd isn't suitable with musl INIT_MANAGER:poky-altcfg:libc-musl = "sysvinit"
Signature · 1 line
2.34.1
PATCH v3 2/2 systemd: add usrmerge to REQUIRED_DISTRO_FEATURES
From: Luca Boccassi <[email protected]>
Support for unmerged-usr is deprecated upstream, taints the system and will be removed in the near future.
Enforce building merged-usr images when using systemd.
---
v3: use += without :append
meta/recipes-core/systemd/systemd-compat-units.bb | 2 +- meta/recipes-core/systemd/systemd-serialgetty.bb | 2 +- meta/recipes-core/systemd/systemd.inc | 5 +++++ meta/recipes-core/systemd/systemd_251.2.bb | 2 +- 4 files changed, 8 insertions(+), 3 deletions(-)
meta/recipes-core/systemd/systemd-compat-units.bb +1 -1
@@ -14,7 +14,7 @@ INHIBIT_DEFAULT_DEPS = "1" ALLOW_EMPTY:${PN} = "1" -REQUIRED_DISTRO_FEATURES = "systemd" +REQUIRED_DISTRO_FEATURES += "systemd" SYSTEMD_DISABLED_SYSV_SERVICES = " \ busybox-udhcpc \
meta/recipes-core/systemd/systemd-serialgetty.bb +1 -1
@@ -14,7 +14,7 @@ S = "${WORKDIR}" # As this package is tied to systemd, only build it when we're also building systemd. inherit features_check -REQUIRED_DISTRO_FEATURES = "systemd" +REQUIRED_DISTRO_FEATURES += "systemd" do_install() { if [ ! -z "${SERIAL_CONSOLES}" ] ; then
meta/recipes-core/systemd/systemd.inc +5 -0
@@ -21,3 +21,8 @@ SRC_URI = "git://github.com/systemd/systemd-stable.git;protocol=https;branch=${S " S = "${WORKDIR}/git" + +# unmerged-usr support is deprecated upstream, taints the system and will be +# removed in the near future. Fail the build if it is not enabled. +inherit features_check +REQUIRED_DISTRO_FEATURES = "usrmerge"
meta/recipes-core/systemd/systemd_251.2.bb +1 -1
@@ -12,7 +12,7 @@ inherit useradd pkgconfig meson perlnative update-rc.d update-alternatives qemu # As this recipe builds udev, respect systemd being in DISTRO_FEATURES so # that we don't build both udev and systemd in world builds. -REQUIRED_DISTRO_FEATURES = "systemd" +REQUIRED_DISTRO_FEATURES += "systemd" SRC_URI += "file://touchscreen.rules \ file://00-create-volatile.conf \
Signature · 1 line
2.34.1
Re: [OE-core] [PATCH v3 1/2] poky-altcfg: enable usrmerge
In reply to [email protected]Quoted 14 lines · Luca Bocassi
From: Luca Boccassi <[email protected]>
Ensure it gets tested by the CI
Signed-off-by Luca Boccassi <[email protected]>--- meta-poky/conf/distro/poky-altcfg.conf | 2 ++ 1 file changed, 2 insertions(+)meta-poky/conf/distro/poky-altcfg.conf +0
-0
meta-poky/conf/distro/poky-altcfg.conf DISTROOVERRIDES = "poky:poky-altcfg" · line 16
Quoted 8 lines
meta-poky/conf/distro/poky-altcfg.conf +2
-0@@ -9,6 +9,8 @@ DISTROOVERRIDES = "poky:poky-altcfg" #DISTROOVERRIDES = "poky:linuxstdbase" INIT_MANAGER:poky-altcfg = "systemd" +# systemd will soon require usrmerge +DISTRO_FEATURES:poky-altcfg += "usrmerge" # systemd isn't suitable with musl INIT_MANAGER:poky-altcfg:libc-musl = "sysvinit"
This blew up builds since it clears everything else out of DISTRO_FEATURES which isn't what was intended. I've tweaked the patch and re-queued.
Cheers,
Richard
Re: [OE-core] [PATCH v3 1/2] poky-altcfg: enable usrmerge
Quoted 18 lines · Richard Purdie
Quoted 16 lines · Luca Bocassi
From: Luca Boccassi <[email protected]>
Ensure it gets tested by the CI
Signed-off-by Luca Boccassi <[email protected]>--- meta-poky/conf/distro/poky-altcfg.conf | 2 ++ 1 file changed, 2 insertions(+)meta-poky/conf/distro/poky-altcfg.conf +0
-0@@ -9,6 +9,8 @@ DISTROOVERRIDES = "poky:poky-altcfg" #DISTROOVERRIDES = "poky:linuxstdbase"
Quoted 10 lines
meta-poky/conf/distro/poky-altcfg.conf DISTROOVERRIDES = "poky:poky-altcfg" · line 16
Quoted 6 lines
meta-poky/conf/distro/poky-altcfg.conf +2
-0INIT_MANAGER:poky-altcfg = "systemd" +# systemd will soon require usrmerge +DISTRO_FEATURES:poky-altcfg += "usrmerge" # systemd isn't suitable with musl INIT_MANAGER:poky-altcfg:libc-musl = "sysvinit"This blew up builds since it clears everything else out of
DISTRO_FEATURESwhich isn't what was intended. I've tweaked the patch and re-queued.
Sorry, did I get something wrong? The diff between my local branch and the master-next branch is empty, can't quite see it:
$ git diff upstream/master-next meta-poky/conf/distro/poky-altcfg.conf $
Kind regards,
Luca Boccassi
Re: [OE-core] [PATCH v3 1/2] poky-altcfg: enable usrmerge
Quoted 31 lines · Luca Boccassi
Quoted 18 lines · Richard Purdie
Quoted 16 lines · Luca Bocassi
From: Luca Boccassi <[email protected]>
Ensure it gets tested by the CI
Signed-off-by Luca Boccassi <[email protected]>--- meta-poky/conf/distro/poky-altcfg.conf | 2 ++ 1 file changed, 2 insertions(+)meta-poky/conf/distro/poky-altcfg.conf +0
-0@@ -9,6 +9,8 @@ DISTROOVERRIDES = "poky:poky-altcfg" #DISTROOVERRIDES = "poky:linuxstdbase"Quoted 10 lines
meta-poky/conf/distro/poky-altcfg.conf DISTROOVERRIDES = "poky:poky-altcfg" · line 16
Quoted 6 lines
meta-poky/conf/distro/poky-altcfg.conf +2
-0INIT_MANAGER:poky-altcfg = "systemd" +# systemd will soon require usrmerge +DISTRO_FEATURES:poky-altcfg += "usrmerge" # systemd isn't suitable with musl INIT_MANAGER:poky-altcfg:libc-musl = "sysvinit"This blew up builds since it clears everything else out of
DISTRO_FEATURESwhich isn't what was intended. I've tweaked the patch and re-queued.
Quoted 5 lines
Sorry, did I get something wrong? The diff between my local branch and the master-next branch is empty, can't quite see it:
$ git diff upstream/master-next meta-poky/conf/distro/poky-altcfg.conf $
My fault, I'm trying to restart the build from a different environment to usual and I messed up the change. It should be there now (and build restarted).
Cheers,
Richard
Re: [OE-core] [PATCH v3 1/2] poky-altcfg: enable usrmerge
Quoted 36 lines · Richard Purdie
Quoted 34 lines · Luca Boccassi
Quoted 18 lines · Richard Purdie
Quoted 16 lines · Luca Bocassi
From: Luca Boccassi <[email protected]>
Ensure it gets tested by the CI
Signed-off-by Luca Boccassi <[email protected]>--- meta-poky/conf/distro/poky-altcfg.conf | 2 ++ 1 file changed, 2 insertions(+)meta-poky/conf/distro/poky-altcfg.conf +0
-0@@ -9,6 +9,8 @@ DISTROOVERRIDES = "poky:poky-altcfg" #DISTROOVERRIDES = "poky:linuxstdbase"Quoted 10 lines
meta-poky/conf/distro/poky-altcfg.conf DISTROOVERRIDES = "poky:poky-altcfg" · line 16
Quoted 6 lines
meta-poky/conf/distro/poky-altcfg.conf +2
-0INIT_MANAGER:poky-altcfg = "systemd" +# systemd will soon require usrmerge +DISTRO_FEATURES:poky-altcfg += "usrmerge" # systemd isn't suitable with musl INIT_MANAGER:poky-altcfg:libc-musl = "sysvinit"This blew up builds since it clears everything else out of
DISTRO_FEATURESwhich isn't what was intended. I've tweaked the patch and re-queued.Sorry, did I get something wrong? The diff between my local branch and the master-next branch is empty, can't quite see it:
Quoted 6 lines
Quoted 2 lines
$ git diff upstream/master-next meta-poky/conf/distro/poky-altcfg.conf $My fault, I'm trying to restart the build from a different environment to usual and I messed up the change. It should be there now (and build restarted).
No worries - I see, in this case the append was the right thing. One day I'll get these right on the first try. One day! Thanks for the fix.
Kind regards,
Luca Boccassi
Re: [OE-core] [PATCH v3 1/2] poky-altcfg: enable usrmerge
Quoted 41 lines · Luca Boccassi
Quoted 39 lines · Richard Purdie
Quoted 36 lines · Luca Boccassi
Quoted 18 lines · Richard Purdie
Quoted 16 lines · Luca Bocassi
From: Luca Boccassi <[email protected]>
Ensure it gets tested by the CI
Signed-off-by Luca Boccassi <[email protected]>--- meta-poky/conf/distro/poky-altcfg.conf | 2 ++ 1 file changed, 2 insertions(+)meta-poky/conf/distro/poky-altcfg.conf +0
-0@@ -9,6 +9,8 @@ DISTROOVERRIDES = "poky:poky-altcfg" #DISTROOVERRIDES = "poky:linuxstdbase"Quoted 10 lines
meta-poky/conf/distro/poky-altcfg.conf DISTROOVERRIDES = "poky:poky-altcfg" · line 16
Quoted 6 lines
meta-poky/conf/distro/poky-altcfg.conf +2
-0INIT_MANAGER:poky-altcfg = "systemd" +# systemd will soon require usrmerge +DISTRO_FEATURES:poky-altcfg += "usrmerge" # systemd isn't suitable with musl INIT_MANAGER:poky-altcfg:libc-musl = "sysvinit"This blew up builds since it clears everything else out of
DISTRO_FEATURESwhich isn't what was intended. I've tweaked the patch and re-queued.Sorry, did I get something wrong? The diff between my local branch and the master-next branch is empty, can't quite see it:
$ git diff upstream/master-next meta-poky/conf/distro/poky-altcfg.conf $
Quoted 7 lines
Quoted 3 lines
My fault, I'm trying to restart the build from a different environment to usual and I messed up the change. It should be there now (and build restarted).
No worries - I see, in this case the append was the right thing. One day I'll get these right on the first try. One day! Thanks for the fix.
It really depends how complex the variable is and how you're making the assignment. In this case you're using an override to make the assignment and you want to add to the existing values so append is the only way.
Cheers,
Richard
Re: [OE-core] [PATCH v3 1/2] poky-altcfg: enable usrmerge
In reply to Luca BoccassiQuoted 42 lines · Luca Bocassi
Quoted 39 lines · Richard Purdie
Quoted 36 lines · Luca Boccassi
Quoted 18 lines · Richard Purdie
Quoted 16 lines · Luca Bocassi
From: Luca Boccassi <[email protected]>
Ensure it gets tested by the CI
Signed-off-by Luca Boccassi <[email protected]>--- meta-poky/conf/distro/poky-altcfg.conf | 2 ++ 1 file changed, 2 insertions(+)meta-poky/conf/distro/poky-altcfg.conf +0
-0@@ -9,6 +9,8 @@ DISTROOVERRIDES = "poky:poky-altcfg" #DISTROOVERRIDES = "poky:linuxstdbase"Quoted 10 lines
meta-poky/conf/distro/poky-altcfg.conf DISTROOVERRIDES = "poky:poky-altcfg" · line 16
Quoted 6 lines
meta-poky/conf/distro/poky-altcfg.conf +2
-0INIT_MANAGER:poky-altcfg = "systemd" +# systemd will soon require usrmerge +DISTRO_FEATURES:poky-altcfg += "usrmerge" # systemd isn't suitable with musl INIT_MANAGER:poky-altcfg:libc-musl = "sysvinit"This blew up builds since it clears everything else out of
DISTRO_FEATURESwhich isn't what was intended. I've tweaked the patch and re-queued.Sorry, did I get something wrong? The diff between my local branch and the master-next branch is empty, can't quite see it:
$ git diff upstream/master-next meta-poky/conf/distro/poky-altcfg.conf $
Quoted 7 lines
Quoted 3 lines
My fault, I'm trying to restart the build from a different environment to usual and I messed up the change. It should be there now (and build restarted).
No worries - I see, in this case the append was the right thing. One day I'll get these right on the first try. One day! Thanks for the fix.
Yeah... += with an over-ride is intuitive but 99.9% of the time is completely wrong.
There was a discussion some time ago about having the parser reject it with an error because it repeatedly trips up new (and some not so new...) developers, but it never came to anything.
Quoted 11 lines
Kind regards,
Luca Boccassi-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#167984): https://lists.openembedded.org/g/openembedded-core/message/167984
Mute This Topic: https://lists.openembedded.org/mt/92361983/3619030
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH v3 1/2] poky-altcfg: enable usrmerge
In reply to Richard PurdieQuoted 17 lines · Richard Purdie
Quoted 16 lines · Luca Bocassi
From: Luca Boccassi <[email protected]>
Ensure it gets tested by the CI
Signed-off-by Luca Boccassi <[email protected]>--- meta-poky/conf/distro/poky-altcfg.conf | 2 ++ 1 file changed, 2 insertions(+)meta-poky/conf/distro/poky-altcfg.conf +0
-0@@ -9,6 +9,8 @@ DISTROOVERRIDES = "poky:poky-altcfg" #DISTROOVERRIDES = "poky:linuxstdbase"
Quoted 11 lines
meta-poky/conf/distro/poky-altcfg.conf DISTROOVERRIDES = "poky:poky-altcfg" · line 16
Quoted 6 lines
meta-poky/conf/distro/poky-altcfg.conf +2
-0INIT_MANAGER:poky-altcfg = "systemd" +# systemd will soon require usrmerge +DISTRO_FEATURES:poky-altcfg += "usrmerge" # systemd isn't suitable with musl INIT_MANAGER:poky-altcfg:libc-musl = "sysvinit"This blew up builds since it clears everything else out of
DISTRO_FEATURESwhich isn't what was intended. I've tweaked the patch and re-queued.
Maybe I'm missing something, but what is the benefit in introducing and using the "poky-altcfg" override in this file ? If DISTRO_FEATURES was just appended with
DISTRO_FEATURES += "usrmerge"
it would all be fine, since it is after the
require conf/distro/poky.conf
line, right ? And if someone wants to base a distro in "poky-altcfg.conf", they would include "poky-altcfg.conf" first in the same way, then do customizations.
Jacob