Skip to contentSkip to conversation

soc: qcom: icc-bwmon: Remove unnecessary print function dev_err()

PATCH RESEND Applied Yang Li 3 participants 3 messages Jul 14, 2022 – Jul 19, 2022

Subsystems (3)
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH RESEND 1/1 soc: qcom: icc-bwmon: Remove unnecessary print function dev_err()

Eliminate the follow coccicheck warning:
./drivers/soc/qcom/icc-bwmon.c:349:2-9: line 349 is redundant because platform_get_irq() already prints an error

---
 drivers/soc/qcom/icc-bwmon.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/soc/qcom/icc-bwmon.c +1 -3
index bea3ea1de7a4..7f8aca533cd3 100644
@@ -345,10 +345,8 @@ static int bwmon_probe(struct platform_device *pdev)
 	}
 
 	bwmon->irq = platform_get_irq(pdev, 0);
-	if (bwmon->irq < 0) {
-		dev_err(dev, "failed to acquire bwmon IRQ\n");
+	if (bwmon->irq < 0)
 		return bwmon->irq;
-	}
 
 	ret = devm_pm_opp_of_add_table(dev);
 	if (ret)
Signature · 1 line
2.20.1.7.g153144c
#2 lore raw

Re: (subset) [PATCH -next RESEND] soc: qcom: icc-bwmon: Remove unnecessary print function dev_err()

In reply to Yang Li
Quoted 4 lines · Yang Li

Eliminate the follow coccicheck warning:
./drivers/soc/qcom/icc-bwmon.c:349:2-9: line 349 is redundant because platform_get_irq() already prints an error

Applied, thanks!

[1/1] soc: qcom: icc-bwmon: Remove unnecessary print function dev_err()

      commit: 947bb0d16576bdac27f3355f268f51acfe29bfa7

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>