zsmalloc: zs_malloc: Return ERR_PTR if fail
PATCH 1/1 zsmalloc: zs_malloc: Return ERR_PTR if fail
From: Hui Zhu <[email protected]>
zs_malloc return 0 if it fail. zs_zpool_malloc will return -1 when zs_malloc return 0.
But -1 make the return value unclear.
For example:
when zswap_frontswap_store call zs_malloc through zs_zpool_malloc, it will return -1 to its caller.
The other return value is -EINVAL, -ENODEV or something else.
This commit change zs_malloc to return ERR_PTR if fail. It didn't just let zs_zpool_malloc -ENOMEM becaue zs_malloc has two types of failures.
size is not OK return -EINVAL and memory alloc fail return -ENOMEM.
Signed-off-by Hui Zhu <[email protected]>
--- drivers/block/zram/zram_drv.c | 4 ++-- mm/zsmalloc.c | 13 ++++++++----- 2 files changed, 10 insertions(+), 7 deletions(-)
drivers/block/zram/zram_drv.c +2 -2
@@ -1387,9 +1387,9 @@ static int __zram_bvec_write(struct zram *zram, struct bio_vec *bvec, __GFP_HIGHMEM | __GFP_MOVABLE); -if (unlikely (!handle)) { +if (IS_ERR ((void *)handle)) {zcomp_stream_put (zram->comp); -return -ENOMEM ; +return PTR_ERR ((void *)handle); } alloced_pages =zs_get_total_pages (zram->mem_pool);
mm/zsmalloc.c +8 -5
@@ -399,7 +399,10 @@ static int zs_zpool_malloc(void *pool, size_t size, gfp_t gfp, unsigned long *handle) { *handle =zs_malloc (pool, size, gfp); -return *handle ?0 :-1 ; + +if (IS_ERR ((void *)(*handle))) +return PTR_ERR ((void *)*handle); +return 0 ; }static void zs_zpool_free (void *pool,unsigned long handle) {
@@ -1400,7 +1403,7 @@ static unsigned long obj_malloc(struct zs_pool *pool,* @gfp: gfp flags when allocating object * * On success, handle to the allocated object is returned, -* otherwise 0. +* otherwise an ERR_PTR(). * Allocation requests with size > ZS_MAX_ALLOC_SIZE will fail. */ unsigned long zs_malloc (struct zs_pool *pool,size_t size,gfp_t gfp)
@@ -1411,11 +1414,11 @@ unsigned long zs_malloc(struct zs_pool *pool, size_t size, gfp_t gfp)struct zspage *zspage;if (unlikely (!size || size >ZS_MAX_ALLOC_SIZE )) -return 0 ; +return (unsigned long )ERR_PTR (-EINVAL ); handle =cache_alloc_handle (pool, gfp);if (!handle) -return 0 ; +return (unsigned long )ERR_PTR (-ENOMEM );/* extra space in chunk to keep the handle */ size +=ZS_HANDLE_SIZE ;
@@ -1440,7 +1443,7 @@ unsigned long zs_malloc(struct zs_pool *pool, size_t size, gfp_t gfp) zspage =alloc_zspage (pool, class, gfp);if (!zspage) {cache_free_handle (pool, handle); -return 0 ; +return (unsigned long )ERR_PTR (-ENOMEM ); }spin_lock (&class->lock);
Signature · 1 line
1.8.3.1