Skip to contentSkip to conversation

kernel: watchdog: fix missing space coding style issue

PATCH In review Gavin Keusch 3 participants 3 messages Jul 14, 2022 – Jul 17, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel: watchdog: fix missing space coding style issue

Fixed missing space causing coding style error

---
 kernel/watchdog.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/watchdog.c +1 -1
index ecb0e8346e65..b6b150c4b179 100644
@@ -306,7 +306,7 @@ static int is_softlockup(unsigned long touch_ts,
 			 unsigned long period_ts,
 			 unsigned long now)
 {
-	if ((watchdog_enabled & SOFT_WATCHDOG_ENABLED) && watchdog_thresh){
+	if ((watchdog_enabled & SOFT_WATCHDOG_ENABLED) && watchdog_thresh) {
 		/* Warn about unreasonable delays. */
 		if (time_after(now, period_ts + get_softlockup_thresh()))
 			return now - touch_ts;
Signature · 1 line
2.34.1
#1 lore raw

Adding Andrew into Cc who usually takes patches for kernel/watchdog.c.

Best Regards,
Petr

Quoted 22 lines · Gavin Keusch

Fixed missing space causing coding style error

---
 kernel/watchdog.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/watchdog.c +1 -1
index ecb0e8346e65..b6b150c4b179 100644
@@ -306,7 +306,7 @@ static int is_softlockup(unsigned long touch_ts,
 			 unsigned long period_ts,
 			 unsigned long now)
 {
-	if ((watchdog_enabled & SOFT_WATCHDOG_ENABLED) && watchdog_thresh){
+	if ((watchdog_enabled & SOFT_WATCHDOG_ENABLED) && watchdog_thresh) {
 		/* Warn about unreasonable delays. */
 		if (time_after(now, period_ts + get_softlockup_thresh()))
 			return now - touch_ts;
Signature · 1 line
2.34.1
#2 lore raw
Quoted 13 lines · On Thu, 14 Jul 2022 10:31:49 +0200 Petr Mladek <[email protected]> wrote:

Adding Andrew into Cc who usually takes patches for kernel/watchdog.c.

Best Regards,
Petr

Quoted 7 lines · Gavin Keusch

Fixed missing space causing coding style error

---
 kernel/watchdog.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines

kernel/watchdog.c static int is_softlockup(unsigned long touch_ts, · line 312

Quoted 13 lines
kernel/watchdog.c +1 -1
index ecb0e8346e65..b6b150c4b179 100644
@@ -306,7 +306,7 @@ static int is_softlockup(unsigned long touch_ts,
 			 unsigned long period_ts,
 			 unsigned long now)
 {
-	if ((watchdog_enabled & SOFT_WATCHDOG_ENABLED) && watchdog_thresh){
+	if ((watchdog_enabled & SOFT_WATCHDOG_ENABLED) && watchdog_thresh) {
 		/* Warn about unreasonable delays. */
 		if (time_after(now, period_ts + get_softlockup_thresh()))
 			return now - touch_ts;

Patch is too minor to justify merging, sorry. If it fixed 15 coding-style errors then maybe. But this way just leads to too much noise.