bpf: add endian modifiers to fix endian warnings
Subsystems (4)
PATCH 1/1 bpf: add endian modifiers to fix endian warnings
A couple of the syscalls which load values (bpf_skb_load_helper_16 and bpf_skb_load_helper_32) are using u16/u32 types which are triggering warnings as they are then converted from big-endian to cpu-endian. Fix these by making the types __be instead.
Fixes the following sparse warnings:
net/core/filter.c:246:32: warning: cast to restricted __be16 net/core/filter.c:246:32: warning: cast to restricted __be16 net/core/filter.c:246:32: warning: cast to restricted __be16 net/core/filter.c:246:32: warning: cast to restricted __be16 net/core/filter.c:273:32: warning: cast to restricted __be32 net/core/filter.c:273:32: warning: cast to restricted __be32 net/core/filter.c:273:32: warning: cast to restricted __be32 net/core/filter.c:273:32: warning: cast to restricted __be32 net/core/filter.c:273:32: warning: cast to restricted __be32 net/core/filter.c:273:32: warning: cast to restricted __be32
--- net/core/filter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
net/core/filter.c +2 -2
@@ -237,7 +237,7 @@ BPF_CALL_2(bpf_skb_load_helper_8_no_cache, const struct sk_buff *, skb, BPF_CALL_4(bpf_skb_load_helper_16, const struct sk_buff *, skb, const void *, data, int, headlen, int, offset) { -u16 tmp, *ptr; +__be16 tmp, *ptr;const int len =sizeof (tmp);if (offset >=0 ) {
@@ -264,7 +264,7 @@ BPF_CALL_2(bpf_skb_load_helper_16_no_cache, const struct sk_buff *, skb, BPF_CALL_4(bpf_skb_load_helper_32, const struct sk_buff *, skb, const void *, data, int, headlen, int, offset) { -u32 tmp, *ptr; +__be32 tmp, *ptr;const int len =sizeof (tmp);if (likely (offset >=0 )) {
Signature · 1 line
2.35.1
This patch was applied to bpf/bpf-next.git (master) by Daniel Borkmann <[email protected]>:
Hello:
This patch was applied to bpf/bpf-next.git (master) by Daniel Borkmann <[email protected]>:
Quoted 8 lines · On Thu, 14 Jul 2022 11:51:01 +0100 you wrote:
A couple of the syscalls which load values (
bpf_skb_load_helper_16andbpf_skb_load_helper_32) are using u16/u32 types which are triggering warnings as they are then converted from big-endian to cpu-endian. Fix these by making the types__beinstead.Fixes the following sparse warnings:
[...]
Here is the summary with links:
- bpf: add endian modifiers to fix endian warnings
https://git.kernel.org/bpf/bpf-next/c/96a233e600df
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html