Skip to contentSkip to conversation

arm64: make ARCH_BCM4908 select ARCH_BCMBCA

PATCH Applied Rafał Miłecki 4 participants 10 messages Jul 14, 2022 – Jul 15, 2022 arm64

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: make ARCH_BCM4908 select ARCH_BCMBCA

From: Rafał Miłecki <[email protected]>

BCA is a big set / family of devices sharing multiple hardware blocks. It covers BCM4908, BCM63xx, BCM68xx devices and more.

Most of drivers that depend on ARCH_BCM4908 should actually depend on ARCH_BCMBCA. To make such transition easier, cleaner and breakage-free add a proper "select".

Later on - if we decide to keep ARCH_BCM4908 - it may be moved under ARCH_BCMBCA menu. Keeping it may be helpful for limited compiling of DTS files and "default" Kconfig entires. Or we may just decide to drop it.

---
 arch/arm64/Kconfig.platforms | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/Kconfig.platforms +1 -0
index 88ddc2e5b152..7fea6955944e 100644
@@ -49,6 +49,7 @@ config ARCH_BCM2835
 
 config ARCH_BCM4908
 	bool "Broadcom BCM4908 family"
+	select ARCH_BCMBCA
 	select GPIOLIB
 	help
 	  This enables support for the Broadcom BCM4906, BCM4908 and
Signature · 7 lines
2.34.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw
Quoted 23 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

BCA is a big set / family of devices sharing multiple hardware blocks. It covers BCM4908, BCM63xx, BCM68xx devices and more.

Most of drivers that depend on ARCH_BCM4908 should actually depend on ARCH_BCMBCA. To make such transition easier, cleaner and breakage-free add a proper "select".

Later on - if we decide to keep ARCH_BCM4908 - it may be moved under ARCH_BCMBCA menu. Keeping it may be helpful for limited compiling of DTS files and "default" Kconfig entires. Or we may just decide to drop it.

---
  arch/arm64/Kconfig.platforms | 1 +
  1 file changed, 1 insertion(+)
arch/arm64/Kconfig.platforms +0 -0
index 88ddc2e5b152..7fea6955944e 100644

arch/arm64/Kconfig.platforms config ARCH_BCM2835 · line 55

Quoted 7 lines
arch/arm64/Kconfig.platforms +1 -0
@@ -49,6 +49,7 @@ config ARCH_BCM2835
 
  config ARCH_BCM4908
      bool "Broadcom BCM4908 family"
+     select ARCH_BCMBCA
      select GPIOLIB
      help
        This enables support for the Broadcom BCM4906, BCM4908 and

Thank you Rafal for adding this! Our proposal is to replace with BCMBCA (and I have a WIP patchset for that). Agree there are pros and cons using single general config versus individual chip config(we have 15 BCA chip now in the kernel) as you and Florian were discussing in another thread. But we feel
single config has more advantage as it can produce the same image to test all the chips and it is easier to maintain. That is why we moved BCM63138 ARCH_BCM_63XX to ARCH_BCMBCA.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#2 lore raw
Quoted 25 lines · William Zhang
Quoted 24 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

BCA is a big set / family of devices sharing multiple hardware blocks. It covers BCM4908, BCM63xx, BCM68xx devices and more.

Most of drivers that depend on ARCH_BCM4908 should actually depend on ARCH_BCMBCA. To make such transition easier, cleaner and breakage-free add a proper "select".

Later on - if we decide to keep ARCH_BCM4908 - it may be moved under ARCH_BCMBCA menu. Keeping it may be helpful for limited compiling of DTS files and "default" Kconfig entires. Or we may just decide to drop it.

---
   arch/arm64/Kconfig.platforms | 1 +
   1 file changed, 1 insertion(+)
arch/arm64/Kconfig.platforms +0 -0
index 88ddc2e5b152..7fea6955944e 100644
@@ -49,6 +49,7 @@ config ARCH_BCM2835
 
Quoted 14 lines

arch/arm64/Kconfig.platforms config ARCH_BCM2835 · line 55

Quoted 6 lines
arch/arm64/Kconfig.platforms +1 -0
   config ARCH_BCM4908
       bool "Broadcom BCM4908 family"
+     select ARCH_BCMBCA
       select GPIOLIB
       help
         This enables support for the Broadcom BCM4906, BCM4908 and

Thank you Rafal for adding this! Our proposal is to replace with BCMBCA (and I have a WIP patchset for that). Agree there are pros and cons using single general config versus individual chip config(we have 15 BCA chip now in the kernel) as you and Florian were discussing in another thread. But we feel
single config has more advantage as it can produce the same image to test all the chips and it is easier to maintain. That is why we moved BCM63138 ARCH_BCM_63XX to ARCH_BCMBCA.

Agreed, I would prefer that we consolidate on the ARCH_BCMBCA Kconfig symbol and remove ARCH_BCM4908. We ought to be able to do that in a single release after v5.20-rc1 contains our pull request.

Signature · 6 lines
Florian

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#3 lore raw

Hi William, Florian,

Quoted 42 lines · Florian Fainelli
Quoted 25 lines · William Zhang
Quoted 24 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

BCA is a big set / family of devices sharing multiple hardware blocks. It covers BCM4908, BCM63xx, BCM68xx devices and more.

Most of drivers that depend on ARCH_BCM4908 should actually depend on ARCH_BCMBCA. To make such transition easier, cleaner and breakage-free add a proper "select".

Later on - if we decide to keep ARCH_BCM4908 - it may be moved under ARCH_BCMBCA menu. Keeping it may be helpful for limited compiling of DTS files and "default" Kconfig entires. Or we may just decide to drop it.

---
   arch/arm64/Kconfig.platforms | 1 +
   1 file changed, 1 insertion(+)
arch/arm64/Kconfig.platforms +0 -0
index 88ddc2e5b152..7fea6955944e 100644
@@ -49,6 +49,7 @@ config ARCH_BCM2835
 
Quoted 14 lines

arch/arm64/Kconfig.platforms config ARCH_BCM2835 · line 55

Quoted 6 lines
arch/arm64/Kconfig.platforms +1 -0
   config ARCH_BCM4908
       bool "Broadcom BCM4908 family"
+     select ARCH_BCMBCA
       select GPIOLIB
       help
         This enables support for the Broadcom BCM4906, BCM4908 and

Thank you Rafal for adding this! Our proposal is to replace with BCMBCA (and I have a WIP patchset for that). Agree there are pros and cons using single general config versus individual chip config(we have 15 BCA chip now in the kernel) as you and Florian were discussing in another thread. But we feel
single config has more advantage as it can produce the same image to test all the chips and it is easier to maintain. That is why we moved BCM63138 ARCH_BCM_63XX to ARCH_BCMBCA.

Quoted 3 lines

Agreed, I would prefer that we consolidate on the ARCH_BCMBCA Kconfig symbol and remove ARCH_BCM4908. We ought to be able to do that in a single release after v5.20-rc1 contains our pull request.

You could take Rafal's change, adding a "deprecated / will be removed" note to the ARCH_BCM4908 Kconfig text and postpone the removal for a cycle or two? Maybe overly cautious but just a thought.

Quoted 2 lines

--
Florian

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#4 lore raw
Quoted 43 lines · Kursad Oney
Quoted 42 lines · Florian Fainelli
Quoted 39 lines · William Zhang
Quoted 23 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

BCA is a big set / family of devices sharing multiple hardware blocks. It covers BCM4908, BCM63xx, BCM68xx devices and more.

Most of drivers that depend on ARCH_BCM4908 should actually depend on ARCH_BCMBCA. To make such transition easier, cleaner and breakage-free add a proper "select".

Later on - if we decide to keep ARCH_BCM4908 - it may be moved under ARCH_BCMBCA menu. Keeping it may be helpful for limited compiling of DTS files and "default" Kconfig entires. Or we may just decide to drop it.

---
    arch/arm64/Kconfig.platforms | 1 +
    1 file changed, 1 insertion(+)
arch/arm64/Kconfig.platforms +0 -0
index 88ddc2e5b152..7fea6955944e 100644

arch/arm64/Kconfig.platforms config ARCH_BCM2835 · line 55

Quoted 7 lines
arch/arm64/Kconfig.platforms +1 -0
@@ -49,6 +49,7 @@ config ARCH_BCM2835
 
    config ARCH_BCM4908
        bool "Broadcom BCM4908 family"
+     select ARCH_BCMBCA
        select GPIOLIB
        help
          This enables support for the Broadcom BCM4906, BCM4908 and

Thank you Rafal for adding this! Our proposal is to replace with BCMBCA (and I have a WIP patchset for that). Agree there are pros and cons using single general config versus individual chip config(we have 15 BCA chip now in the kernel) as you and Florian were discussing in another thread. But we feel
single config has more advantage as it can produce the same image to test all the chips and it is easier to maintain. That is why we moved BCM63138 ARCH_BCM_63XX to ARCH_BCMBCA.

Quoted 7 lines
Quoted 3 lines

Agreed, I would prefer that we consolidate on the ARCH_BCMBCA Kconfig symbol and remove ARCH_BCM4908. We ought to be able to do that in a single release after v5.20-rc1 contains our pull request.

You could take Rafal's change, adding a "deprecated / will be removed" note to the ARCH_BCM4908 Kconfig text and postpone the removal for a cycle or two? Maybe overly cautious but just a thought.

The point of my patch was to make sure that users switching from 5.19 to 5.20 will get ARCH_BCMBCA=y in their config automatically. That's meant to avoid at least some breakages and keep kernel easily bisectable.

I wrote that *later* we can leave or drop ARCH_BCM4908 to *avoid* discussing it right now. That should ideally be considered once we see all patches actually dropping ARCH_BCM4908.

Of couse my intention didn't work and I actually started a blind discussion now ;)

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#5 lore raw
In reply to Rafał Miłecki
Quoted 9 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

BCA is a big set / family of devices sharing multiple hardware blocks. It covers BCM4908, BCM63xx, BCM68xx devices and more.

Most of drivers that depend on ARCH_BCM4908 should actually depend on ARCH_BCMBCA. To make such transition easier, cleaner and breakage-free add a proper "select".

Quoted 5 lines

Later on - if we decide to keep ARCH_BCM4908 - it may be moved under ARCH_BCMBCA menu. Keeping it may be helpful for limited compiling of DTS files and "default" Kconfig entires. Or we may just decide to drop it.

OK, so in an effort to have a smoother transition of ARCH_BCM4908 towards ARCH_BCMBCA, I am inclined to take this patch right now, put it in a part2 of our recent ARM SoC pull request and try to get it in v5.20-rc1.

Then William can go ahead and do a treewide s/ARCH_BCM4908/ARCH_BCMBCA/g which we would be queuing up *against* v5.20-rc1 for 5.21. This ought to assure a smooth transition for "make oldconfig".

Sounds good? If so, William, Kursad, do you want to ack that patch?

Signature · 6 lines
Florian

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#6 lore raw
Quoted 14 lines · Florian Fainelli
Quoted 13 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

BCA is a big set / family of devices sharing multiple hardware blocks. It covers BCM4908, BCM63xx, BCM68xx devices and more.

Most of drivers that depend on ARCH_BCM4908 should actually depend on ARCH_BCMBCA. To make such transition easier, cleaner and breakage-free add a proper "select".

Later on - if we decide to keep ARCH_BCM4908 - it may be moved under ARCH_BCMBCA menu. Keeping it may be helpful for limited compiling of DTS files and "default" Kconfig entires. Or we may just decide to drop it.

Quoted 8 lines
Quoted 1 line

OK, so in an effort to have a smoother transition of ARCH_BCM4908 towards ARCH_BCMBCA, I am inclined to take this patch right now, put it in a part2 of our recent ARM SoC pull request and try to get it in v5.20-rc1.

Then William can go ahead and do a treewide s/ARCH_BCM4908/ARCH_BCMBCA/g which we would be queuing up *against* v5.20-rc1 for 5.21. This ought to assure a smooth transition for "make oldconfig".

Sounds good? If so, William, Kursad, do you want to ack that patch?

Sounds good to me. Thanks Florian!

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#7 lore raw
In reply to Florian Fainelli
Quoted 14 lines · Florian Fainelli
Quoted 13 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

BCA is a big set / family of devices sharing multiple hardware blocks. It covers BCM4908, BCM63xx, BCM68xx devices and more.

Most of drivers that depend on ARCH_BCM4908 should actually depend on ARCH_BCMBCA. To make such transition easier, cleaner and breakage-free add a proper "select".

Later on - if we decide to keep ARCH_BCM4908 - it may be moved under ARCH_BCMBCA menu. Keeping it may be helpful for limited compiling of DTS files and "default" Kconfig entires. Or we may just decide to drop it.

Quoted 7 lines
Quoted 1 line

OK, so in an effort to have a smoother transition of ARCH_BCM4908 towards ARCH_BCMBCA, I am inclined to take this patch right now, put it in a part2 of our recent ARM SoC pull request and try to get it in v5.20-rc1.

Then William can go ahead and do a treewide s/ARCH_BCM4908/ARCH_BCMBCA/g which we would be queuing up *against* v5.20-rc1 for 5.21. This ought to assure a smooth transition for "make oldconfig".

Sounds good? If so, William, Kursad, do you want to ack that patch?

Sounds good, thanks a lot!

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Acked-by on v1 1/1
#8 lore raw
In reply to Rafał Miłecki
Quoted 24 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

BCA is a big set / family of devices sharing multiple hardware blocks. It covers BCM4908, BCM63xx, BCM68xx devices and more.

Most of drivers that depend on ARCH_BCM4908 should actually depend on ARCH_BCMBCA. To make such transition easier, cleaner and breakage-free add a proper "select".

Later on - if we decide to keep ARCH_BCM4908 - it may be moved under ARCH_BCMBCA menu. Keeping it may be helpful for limited compiling of DTS files and "default" Kconfig entires. Or we may just decide to drop it.

---
  arch/arm64/Kconfig.platforms | 1 +
  1 file changed, 1 insertion(+)
arch/arm64/Kconfig.platforms +0 -0
index 88ddc2e5b152..7fea6955944e 100644

arch/arm64/Kconfig.platforms config ARCH_BCM2835 · line 55

Quoted 7 lines
arch/arm64/Kconfig.platforms +1 -0
@@ -49,6 +49,7 @@ config ARCH_BCM2835
 
  config ARCH_BCM4908
  	bool "Broadcom BCM4908 family"
+	select ARCH_BCMBCA
  	select GPIOLIB
  	help
  	  This enables support for the Broadcom BCM4906, BCM4908 and

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#9 lore raw
In reply to Rafał Miłecki
Quoted 9 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

BCA is a big set / family of devices sharing multiple hardware blocks. It covers BCM4908, BCM63xx, BCM68xx devices and more.

Most of drivers that depend on ARCH_BCM4908 should actually depend on ARCH_BCMBCA. To make such transition easier, cleaner and breakage-free add a proper "select".

Quoted 6 lines

Later on - if we decide to keep ARCH_BCM4908 - it may be moved under ARCH_BCMBCA menu. Keeping it may be helpful for limited compiling of DTS files and "default" Kconfig entires. Or we may just decide to drop it.

---

Applied to https://github.com/Broadcom/stblinux/commits/devicetree-arm64/next, thanks! --
Florian

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel