Skip to contentSkip to conversation

python3-antlr4-runtime: Inherit setuptools3 instead of python_setuptools_build_meta

PATCH In review Khem Raj 2 participants 7 messages Jul 16, 2022 – Jul 18, 2022

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/3 python3-antlr4-runtime: Inherit setuptools3 instead of python_setuptools_build_meta

Adds missing dependency on python3-picobuild-native

---
 .../recipes-devtools/python/python3-antlr4-runtime_4.10.bb      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-python/recipes-devtools/python/python3-antlr4-runtime_4.10.bb +1 -1
index 01f17207c6..7b69b9edba 100644
@@ -6,6 +6,6 @@ SRC_URI[sha256sum] = "061a49bc72ae05a35d9b61c0ba0ac36c0397708819f02fbfb20a80e47d
 
 PYPI_PACKAGE = "antlr4-python3-runtime"
 
-inherit pypi python_setuptools_build_meta
+inherit pypi setuptools3
 
 BBCLASSEXTEND = "nativesdk native"
Signature · 1 line
2.37.1
author
#1 lore raw

PATCH 2/3 catfish: Inherit setuptools3 instead of python_setuptools_build_meta

Adds missing dependency on python3-picobuild-native

---
 meta-xfce/recipes-apps/catfish/catfish_4.16.3.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-xfce/recipes-apps/catfish/catfish_4.16.3.bb +1 -1
index 98cd251d2d..bffaa1f8cb 100644
@@ -3,7 +3,7 @@ SECTION = "x11/application"
 LICENSE = "GPL-2.0-only"
 LIC_FILES_CHKSUM = "file://COPYING;md5=4325afd396febcb659c36b49533135d4"
 
-inherit xfce-app python_setuptools_build_meta gtk-icon-cache mime-xdg
+inherit xfce-app setuptools3 gtk-icon-cache mime-xdg
 
 DEPENDS += "python3-distutils-extra-native"
 
Signature · 1 line
2.37.1
author
#2 lore raw

PATCH 3/3 python3-pycups: Inherit setuptools3 instead of python_setuptools_build_meta

In reply to Khem Raj

Adds missing dependency on python3-picobuild-native

---
 meta-oe/recipes-devtools/python/python3-pycups_2.0.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-devtools/python/python3-pycups_2.0.1.bb +1 -1
index 1508273009..67cd1a2277 100644
@@ -16,4 +16,4 @@ DEPENDS += "cups"
 # See https://pypi.org/project/pycups/ for data
 SRC_URI[sha256sum] = "57434ce5f62548eb12949ca8217f066f4eeb21a5d6ab8b13471dce350e380c90"
 
-inherit pypi python_setuptools_build_meta
+inherit pypi setuptools3
Signature · 1 line
2.37.1
#3 lore raw

Re: [oe] [meta-oe][PATCH 3/3] python3-pycups: Inherit setuptools3 instead of python_setuptools_build_meta

Quoted 5 lines · Khem Raj via lists.openembedded.org

Adds missing dependency on python3-picobuild-native

Erm, no.

python_setuptools_build_meta inherits python_pep517 which does DEPENDS:append = " python3-picobuild-native python3-installer-native”

The right fix may be using the setuptools3 class as the build isn’t pep compliant, but the comment isn’t accurate, and the picobuild 0.2 upgrade queued for oe-core improves “legacy” setuptools builds too.

Ross

#4 lore raw

Re: [oe] [meta-oe][PATCH 3/3] python3-pycups: Inherit setuptools3 instead of python_setuptools_build_meta

Quoted 1 line

the picobuild 0.2 upgrade queued for oe-core improves “legacy” setuptools builds too.

I’ve just looked at the logs and this is the correct fix. Don’t merge these, just wait for picobuild 0.2 to land.

Ross

author
#5 lore raw

Re: [oe] [meta-oe][PATCH 3/3] python3-pycups: Inherit setuptools3 instead of python_setuptools_build_meta

Quoted 7 lines · Ross Burton

*> *the picobuild 0.2 upgrade queued for oe-core improves “legacy” setuptools builds too.

I’ve just looked at the logs and this is the correct fix. Don’t merge these, just wait for picobuild 0.2 to land.

Ah a bit late but we can apply the new fixes once it lands on core

Quoted 3 lines

Ross

#6 lore raw

Re: [oe] [meta-oe][PATCH 3/3] python3-pycups: Inherit setuptools3 instead of python_setuptools_build_meta

It’s already in core, can you just revert these please.

Ross

From: Khem Raj <[email protected]>
Date: Monday, 18 July 2022 at 15:46
To: Ross Burton <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [oe] [meta-oe][PATCH 3/3] python3-pycups: Inherit setuptools3 instead of python_setuptools_build_meta

Quoted 1 line · On Mon, Jul 18, 2022 at 8:09 AM Ross Burton…

the picobuild 0.2 upgrade queued for oe-core improves “legacy” setuptools builds too.

I’ve just looked at the logs and this is the correct fix. Don’t merge these, just wait for picobuild 0.2 to land.

Ah a bit late but we can apply the new fixes once it lands on core

Ross