Skip to contentSkip to conversation

leds-bcm63138: post apply/review fixes

PATCH Applied Rafał Miłecki 2 participants 5 messages Jul 17, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover leds-bcm63138: post apply/review fixes

From: Rafał Miłecki <[email protected]>

Hi Pavel,

Thanks a lot for accepting my patches. I'm sending those small fixups to address your comments.

I still have to figure out how to simplify fls() code you pointed out.

Rafał Miłecki (3):
dt-bindings: leds: leds-bcm63138: unify full stops in descriptions
leds: add help info about BCM63138 module name
leds: leds-bcm63138: get rid of LED_OFF

 Documentation/devicetree/bindings/leds/leds-bcm63138.yaml | 2 +-
 drivers/leds/blink/Kconfig                                | 2 ++
 drivers/leds/blink/leds-bcm63138.c                        | 3 +--
 3 files changed, 4 insertions(+), 3 deletions(-)
Signature · 1 line
2.34.1
#1 lore raw

PATCH 1/3 dt-bindings: leds: leds-bcm63138: unify full stops in descriptions

From: Rafał Miłecki <[email protected]>

Description of "reg" doesn't have full stop at the end. It makes sense as it's a one-sentence only. Use the same style for "active-low".

---
 Documentation/devicetree/bindings/leds/leds-bcm63138.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/leds/leds-bcm63138.yaml +1 -1
index 99cd4ba9b0ca..52252fb6bb32 100644
@@ -54,7 +54,7 @@ patternProperties:
 
       active-low:
         type: boolean
-        description: Makes LED active low.
+        description: Makes LED active low
 
     required:
       - reg
Signature · 1 line
2.34.1
#2 lore raw

PATCH 2/3 leds: add help info about BCM63138 module name

In reply to Rafał Miłecki

From: Rafał Miłecki <[email protected]>

It's what we do for all other LEDs drivers.

---
 drivers/leds/blink/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/leds/blink/Kconfig +2 -0
index c680af01b5a9..945c84286a4e 100644
@@ -10,6 +10,8 @@ config LEDS_BCM63138
 	  BCM63138 SoC. The same hardware block is known to be also used
 	  in BCM4908, BCM6848, BCM6858, BCM63148, BCM63381 and BCM68360.
 
+	  If compiled as module it will be called leds-bcm63138.
+
 config LEDS_LGM
        tristate "LED support for LGM SoC series"
        depends on X86 || COMPILE_TEST
Signature · 1 line
2.34.1
#3 lore raw

PATCH 3/3 leds: leds-bcm63138: get rid of LED_OFF

In reply to Rafał Miłecki

From: Rafał Miłecki <[email protected]>

The whole "enum led_brightness" is marked as obsolete. Replace it with a (non-)zero check.

---
 drivers/leds/blink/leds-bcm63138.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/leds/blink/leds-bcm63138.c +1 -2
index c083cb1332cb..2cf2761e4914 100644
@@ -113,8 +113,7 @@ static void bcm63138_leds_enable_led(struct bcm63138_leds *leds,
 {
 	u32 bit = BIT(led->pin);
 
-	bcm63138_leds_update_bits(leds, BCM63138_SW_DATA, bit,
-				  value == LED_OFF ? 0 : bit);
+	bcm63138_leds_update_bits(leds, BCM63138_SW_DATA, bit, value ? bit : 0);
 }
 
 /*
Signature · 1 line
2.34.1
Applied
#4 lore raw
In reply to Rafał Miłecki

Hi!

Quoted 4 lines

Hi Pavel,

Thanks a lot for accepting my patches. I'm sending those small fixups to address your comments.

Thank you, applied.

Best regards,
Pavel

Signature · 1 line
People of Russia, stop Putin before his war on Ukraine escalates.