apparmor: Fix some kernel-doc comments
Subsystems (2)
PATCH 1/1 apparmor: Fix some kernel-doc comments
Remove warnings found by running scripts/kernel-doc, which is caused by
using 'make W=1'.security/apparmor/policy_ns.c:65: warning: Function parameter or member 'curr' not described in 'aa_ns_name' security/apparmor/policy_ns.c:65: warning: Function parameter or member 'view' not described in 'aa_ns_name' security/apparmor/policy_ns.c:65: warning: Function parameter or member 'subns' not described in 'aa_ns_name' security/apparmor/policy_ns.c:65: warning: expecting prototype for aa_na_name(). Prototype was for aa_ns_name() instead security/apparmor/policy_ns.c:214: warning: Function parameter or member 'view' not described in '__aa_lookupn_ns' security/apparmor/policy_ns.c:214: warning: Excess function parameter 'base' description in '__aa_lookupn_ns' security/apparmor/policy_ns.c:297: warning: expecting prototype for aa_create_ns(). Prototype was for __aa_find_or_create_ns() instead
--- security/apparmor/policy_ns.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
security/apparmor/policy_ns.c +6 -6
@@ -54,10 +54,10 @@ bool aa_ns_visible(struct aa_ns *curr, struct aa_ns *view, bool subns) }/** -* aa_na_name - Find the ns name to display for @view from @curr -* @curr - current namespace (NOT NULL) -* @view - namespace attempting to view (NOT NULL) -* @subns - are subns visible +* aa_ns_name - Find the ns name to display for @view from @curr +* @curr: current namespace (NOT NULL) +* @view: namespace attempting to view (NOT NULL) +* @subns: are subns visible * * Returns: name of @view visible from @curr */
@@ -200,7 +200,7 @@ struct aa_ns *aa_find_ns(struct aa_ns *root, const char *name)/** * __aa_lookupn_ns - lookup the namespace matching @hname -* @base: base list to start looking up profile name from (NOT NULL) +* @view: namespace to search in (NOT NULL) * @hname: hierarchical ns name (NOT NULL) * @n: length of @hname *
@@ -285,7 +285,7 @@ static struct aa_ns *__aa_create_ns(struct aa_ns *parent, const char *name, }/** -* aa_create_ns - create an ns, fail if it already exists +* __aa_find_or_create_ns - create an ns, fail if it already exists * @parent: the parent of the namespace being created * @name: the name of the namespace * @dir: if not null the dir to put the ns entries in
Signature · 1 line
2.20.1.7.g153144c
Quoted 10 lines · Yang Li
Remove warnings found by running
scripts/kernel-doc, which is caused by
using 'make W=1'.security/apparmor/policy_ns.c:65: warning: Function parameter or member 'curr' not described in 'aa_ns_name'security/apparmor/policy_ns.c:65: warning: Function parameter or member 'view' not described in 'aa_ns_name'security/apparmor/policy_ns.c:65: warning: Function parameter or member 'subns' not described in 'aa_ns_name'security/apparmor/policy_ns.c:65: warning: expecting prototype foraa_na_name(). Prototype was foraa_ns_name()insteadsecurity/apparmor/policy_ns.c:214: warning: Function parameter or member 'view' not described in '__aa_lookupn_ns'security/apparmor/policy_ns.c:214: warning: Excess function parameter 'base' description in '__aa_lookupn_ns'security/apparmor/policy_ns.c:297: warning: expecting prototype foraa_create_ns(). Prototype was for__aa_find_or_create_ns()instead
Quoted 2 lines
Reported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>
thanks I have pulled this into apparmor-next
Quoted 41 lines
--- security/apparmor/policy_ns.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)security/apparmor/policy_ns.c +6
-6@@ -54,10 +54,10 @@ bool aa_ns_visible(struct aa_ns *curr, struct aa_ns *view, bool subns) }/** -* aa_na_name - Find the ns name to display for @view from @curr -* @curr - current namespace (NOT NULL) -* @view - namespace attempting to view (NOT NULL) -* @subns - are subns visible +* aa_ns_name - Find the ns name to display for @view from @curr +* @curr: current namespace (NOT NULL) +* @view: namespace attempting to view (NOT NULL) +* @subns: are subns visible * * Returns: name of @view visible from @curr */ @@ -200,7 +200,7 @@ struct aa_ns *aa_find_ns(struct aa_ns *root, const char *name)/** * __aa_lookupn_ns - lookup the namespace matching @hname -* @base: base list to start looking up profile name from (NOT NULL) +* @view: namespace to search in (NOT NULL) * @hname: hierarchical ns name (NOT NULL) * @n: length of @hname * @@ -285,7 +285,7 @@ static struct aa_ns *__aa_create_ns(struct aa_ns *parent, const char *name, }/** -* aa_create_ns - create an ns, fail if it already exists +* __aa_find_or_create_ns - create an ns, fail if it already exists * @parent: the parent of the namespace being created * @name: the name of the namespace * @dir: if not null the dir to put the ns entries in