Skip to contentSkip to conversation

m68k:do not initialise statics to 0.

PATCH In review Xin Gao 2 participants 2 messages Jul 18, 2022 – Jan 22, 2023 m68k architecture

lore
Share & tools
lore

Xin Gao

author
#0 lore raw

PATCH 1/1 m68k:do not initialise statics to 0.

Delete static variables initialized to 0.

---
 arch/m68k/q40/q40ints.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/m68k/q40/q40ints.c +2 -2
index 6886a5d0007b..dfb307ba1185 100644
@@ -201,8 +201,8 @@ static int ccleirq=60;    /* ISA dev IRQs*/
 #define DEBUG_Q40INT
 /*#define IP_USE_DISABLE *//* would be nice, but crashes ???? */
 
-static int mext_disabled=0;  /* ext irq disabled by master chip? */
-static int aliased_irq=0;  /* how many times inside handler ?*/
+static int mext_disabled;  /* ext irq disabled by master chip? */
+static int aliased_irq;  /* how many times inside handler ?*/
 
 
 /* got interrupt, dispatch to ISA or keyboard/timer IRQs */
Signature · 1 line
2.30.2
maintainer Reviewed-by on v1 1/1
#1 lore raw

Hi Xin,

Quoted 3 lines · Xin Gao

Delete static variables initialized to 0.

Thanks for your patch!

arch/m68k/q40/q40ints.c static int ccleirq=60; /* ISA dev IRQs*/ · line 208

Quoted 13 lines
arch/m68k/q40/q40ints.c +2 -2
@@ -201,8 +201,8 @@ static int ccleirq=60;    /* ISA dev IRQs*/
 #define DEBUG_Q40INT
 /*#define IP_USE_DISABLE *//* would be nice, but crashes ???? */
 
-static int mext_disabled=0;  /* ext irq disabled by master chip? */
-static int aliased_irq=0;  /* how many times inside handler ?*/
+static int mext_disabled;  /* ext irq disabled by master chip? */
+static int aliased_irq;  /* how many times inside handler ?*/
 
 
 /* got interrupt, dispatch to ISA or keyboard/timer IRQs */

i.e. will queue in the m68k for-v6.3 branch.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds