AM62x watchdog support
Subsystems (2)
cover AM62x watchdog support
This patch series adds support for AM62x watchdog.
Changes since v0:
- Mark MCU & WKUP watchdogs as reserved
Julien Panis (2):
arm64: dts: ti: k3-am62: add watchdog nodes
arm64: dts: ti: k3-am625-sk: mark MCU and WKUP watchdogs as reserved
arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 45 ++++++++++++++++++++++ arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi | 9 +++++ arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi | 9 +++++ arch/arm64/boot/dts/ti/k3-am625-sk.dts | 10 +++++ 4 files changed, 73 insertions(+)
Signature · 1 line
2.25.1
PATCH 1/2 arm64: dts: ti: k3-am62: add watchdog nodes
Add nodes for watchdogs :
- 5 in main domain
- 1 in MCU domain
- 1 in wakeup domain
--- arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 45 ++++++++++++++++++++++ arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi | 9 +++++ arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi | 9 +++++ 3 files changed, 63 insertions(+)
arch/arm64/boot/dts/ti/k3-am62-main.dtsi +45 -0
@@ -572,4 +572,49 @@ main_mcan0: can@20701000 { interrupt-names = "int0", "int1"; bosch,mram-cfg = <0x0 128 64 64 64 64 32 32>; }; + + main_rti0: watchdog@e000000 { + compatible = "ti,j7-rti-wdt"; + reg = <0x00 0x0e000000 0x00 0x100>; + clocks = <&k3_clks 125 0>; + power-domains = <&k3_pds 125 TI_SCI_PD_EXCLUSIVE>; + assigned-clocks = <&k3_clks 125 0>; + assigned-clock-parents = <&k3_clks 125 2>; + }; + + main_rti1: watchdog@e010000 { + compatible = "ti,j7-rti-wdt"; + reg = <0x00 0x0e010000 0x00 0x100>; + clocks = <&k3_clks 126 0>; + power-domains = <&k3_pds 126 TI_SCI_PD_EXCLUSIVE>; + assigned-clocks = <&k3_clks 126 0>; + assigned-clock-parents = <&k3_clks 126 2>; + }; + + main_rti2: watchdog@e020000 { + compatible = "ti,j7-rti-wdt"; + reg = <0x00 0x0e020000 0x00 0x100>; + clocks = <&k3_clks 127 0>; + power-domains = <&k3_pds 127 TI_SCI_PD_EXCLUSIVE>; + assigned-clocks = <&k3_clks 127 0>; + assigned-clock-parents = <&k3_clks 127 2>; + }; + + main_rti3: watchdog@e030000 { + compatible = "ti,j7-rti-wdt"; + reg = <0x00 0x0e030000 0x00 0x100>; + clocks = <&k3_clks 128 0>; + power-domains = <&k3_pds 128 TI_SCI_PD_EXCLUSIVE>; + assigned-clocks = <&k3_clks 128 0>; + assigned-clock-parents = <&k3_clks 128 2>; + }; + + main_rti15: watchdog@e0f0000 { + compatible = "ti,j7-rti-wdt"; + reg = <0x00 0x0e0f0000 0x00 0x100>; + clocks = <&k3_clks 130 0>; + power-domains = <&k3_pds 130 TI_SCI_PD_EXCLUSIVE>; + assigned-clocks = <&k3_clks 130 0>; + assigned-clock-parents = <&k3_clks 130 2>; + }; };
arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi +9 -0
@@ -81,4 +81,13 @@ mcu_gpio0: gpio@4201000 { clocks = <&k3_clks 79 0>; clock-names = "gpio"; }; + + mcu_rti0: watchdog@4880000 { + compatible = "ti,j7-rti-wdt"; + reg = <0x00 0x04880000 0x00 0x100>; + clocks = <&k3_clks 131 0>; + power-domains = <&k3_pds 131 TI_SCI_PD_EXCLUSIVE>; + assigned-clocks = <&k3_clks 131 0>; + assigned-clock-parents = <&k3_clks 131 2>; + }; };
arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi +9 -0
@@ -38,4 +38,13 @@ wkup_i2c0: i2c@2b200000 { clocks = <&k3_clks 107 4>; clock-names = "fck"; }; + + wkup_rti0: watchdog@2b000000 { + compatible = "ti,j7-rti-wdt"; + reg = <0x00 0x2b000000 0x00 0x100>; + clocks = <&k3_clks 132 0>; + power-domains = <&k3_pds 132 TI_SCI_PD_EXCLUSIVE>; + assigned-clocks = <&k3_clks 132 0>; + assigned-clock-parents = <&k3_clks 132 2>; + }; };
Signature · 1 line
2.25.1
PATCH 2/2 arm64: dts: ti: k3-am625-sk: mark MCU and WKUP watchdogs as reserved
In reply to Julien PanisMCU wdt is typically used by M4F.
Wake up wdt is typically used by DM (R5) firmware.
--- arch/arm64/boot/dts/ti/k3-am625-sk.dts | 10 ++++++++++ 1 file changed, 10 insertions(+)
arch/arm64/boot/dts/ti/k3-am625-sk.dts +10 -0
@@ -493,3 +493,13 @@ &ecap2 { &main_mcan0 { status = "disabled"; }; + +&mcu_rti0 { + /* MCU RTI0 is used by M4F firmware */ + status = "reserved"; +}; + +&wkup_rti0 { + /* WKUP RTI0 is used by DM firmware */ + status = "reserved"; +};
Signature · 1 line
2.25.1
Hi Julien!
On July 18, 2022 thus sayeth Julien Panis:
Quoted 9 lines
This patch series adds support for AM62x watchdog.
Changes since v0:
- Mark MCU & WKUP watchdogs as reservedJulien Panis (2):
arm64: dts: ti: k3-am62: add watchdog nodes
arm64: dts: ti: k3-am625-sk: mark MCU and WKUP watchdogs as reserved
Quoted 6 lines
arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 45 ++++++++++++++++++++++ arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi | 9 +++++ arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi | 9 +++++ arch/arm64/boot/dts/ti/k3-am625-sk.dts | 10 +++++ 4 files changed, 73 insertions(+)
These patches look great to me!
~Bryan
Nishanth Menon
maintainerQuoted 9 lines · Julien Panis
This patch series adds support for AM62x watchdog.
Changes since v0:
- Mark MCU & WKUP watchdogs as reservedJulien Panis (2):
arm64: dts: ti: k3-am62: add watchdog nodes
arm64: dts: ti: k3-am625-sk: mark MCU and WKUP watchdogs as reserved
Quoted 6 lines
arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 45 ++++++++++++++++++++++ arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi | 9 +++++ arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi | 9 +++++ arch/arm64/boot/dts/ti/k3-am625-sk.dts | 10 +++++ 4 files changed, 73 insertions(+)
Could you rebase the series to the latest next?
Also, cosmetics:
a) Patches are of the order [PATCH] indicating v1, [PATCH V2] indicating v2 etc.. Also when sending subsequent versions, it is a good practise to keep links (typically lore or patchworks) to the previous versions of the patches along with change log. See comments such as [1]. Change logs and lore links help new reviewers quickly catchup on the discussions so far.
b) please keep lkml in CC.
[1] https://lore.kernel.org/all/[email protected]/
Signature · 3 lines
Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D