x86: cpu: Error out if memory exceeds addressable range
PATCH 1/1 x86: cpu: Error out if memory exceeds addressable range
Currently it is possible to start a guest with memory that is beyond the addressable range of CPU and QEMU does not even warn about it. The default phys_bits is 40 and can address 1TB. However it allows to start a guest with greater than 1TB memory.
Prevent this by erroring out in such a scenario.
--- target/i386/cpu.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
target/i386/cpu.c +10 -0
@@ -6376,6 +6376,7 @@ static void x86_cpu_hyperv_realize(X86CPU *cpu)static void x86_cpu_realizefn (DeviceState *dev,Error **errp) { +MachineState *machine =MACHINE (qdev_get_machine ());CPUState *cs =CPU (dev);X86CPU *cpu =X86_CPU (dev);X86CPUClass *xcc =X86_CPU_GET_CLASS (dev);
@@ -6541,6 +6542,15 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp) } } +if (BIT_ULL (cpu->phys_bits) < machine->maxram_size) { +error_setg (&local_err,"cannot setup guest memory: " +"%s memory(%lu MiB) exceeds addressable limit(%llu MiB)" , + machine->maxram_size == machine->ram_size ?"" :"max" , + machine->maxram_size / MiB, +BIT_ULL (cpu->phys_bits) / MiB); + goto out; + } +/* Cache information initialization */ if (!cpu->legacy_cache) {if (!xcc->model || !xcc->model->cpudef->cache_info) {
Signature · 1 line
2.32.0
Quoted 9 lines · On Mon, 18 Jul 2022 13:47:34 +0530 Nikunj A Dadhania <[email protected]> wrote:
Currently it is possible to start a guest with memory that is beyond the addressable range of CPU and QEMU does not even warn about it. The default
phys_bitsis 40 and can address 1TB. However it allows to start a guest with greater than 1TB memory.Prevent this by erroring out in such a scenario.
Reported-by Shaju Abraham <[email protected]>Signed-off-by Nikunj A Dadhania <[email protected]>
Following shall care of your issue:
https://www.mail-archive.com/[email protected]/msg900136.html
Quoted 32 lines
--- target/i386/cpu.c | 10 ++++++++++ 1 file changed, 10 insertions(+)target/i386/cpu.c +10
-0@@ -6376,6 +6376,7 @@ static void x86_cpu_hyperv_realize(X86CPU *cpu)static void x86_cpu_realizefn (DeviceState *dev,Error **errp) { +MachineState *machine =MACHINE (qdev_get_machine ());CPUState *cs =CPU (dev);X86CPU *cpu =X86_CPU (dev);X86CPUClass *xcc =X86_CPU_GET_CLASS (dev);@@ -6541,6 +6542,15 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp) } } +if (BIT_ULL (cpu->phys_bits) < machine->maxram_size) { +error_setg (&local_err,"cannot setup guest memory: " +"%s memory(%lu MiB) exceeds addressable limit(%llu MiB)" , + machine->maxram_size == machine->ram_size ?"" :"max" , + machine->maxram_size / MiB, +BIT_ULL (cpu->phys_bits) / MiB); + goto out; + } +/* Cache information initialization */ if (!cpu->legacy_cache) {if (!xcc->model || !xcc->model->cpudef->cache_info) {
Quoted 8 lines · Igor Mammedov
Quoted 5 lines · On Mon, 18 Jul 2022 13:47:34 +0530 Nikunj A Dadhania <[email protected]> wrote:
Currently it is possible to start a guest with memory that is beyond the addressable range of CPU and QEMU does not even warn about it. The default
phys_bitsis 40 and can address 1TB. However it allows to start a guest with greater than 1TB memory.
Quoted 8 lines
Quoted 4 lines
Prevent this by erroring out in such a scenario.
Reported-by Shaju Abraham <[email protected]>Signed-off-by Nikunj A Dadhania <[email protected]>Following shall care of your issue:
https://www.mail-archive.com/[email protected]/msg900136.html
Thanks, I tried out the patch series, I could start guest till 978G (not sure why this magic number yet) and after that I start getting errors:
$ ./build/qemu-system-x86_64 -enable-kvm -machine q35 -m 979G -kernel bzImage -initrd initramfs.cpio -vga none -nographic -append "console=ttyS0,115200n8 earlyprintk=serial,ttyS0,115200 debug=1 " -nodefaults -serial stdio qemu-system-x86_64: Address space limit 0xffffffffff < 0x1fc3fffffff phys-bits too low (40)
Regards
Nikunj
Quoted 15 lines · Nikunj A. Dadhania
Quoted 14 lines · Igor Mammedov
Quoted 9 lines · On Mon, 18 Jul 2022 13:47:34 +0530 Nikunj A Dadhania <[email protected]> wrote:
Currently it is possible to start a guest with memory that is beyond the addressable range of CPU and QEMU does not even warn about it. The default
phys_bitsis 40 and can address 1TB. However it allows to start a guest with greater than 1TB memory.Prevent this by erroring out in such a scenario.
Reported-by Shaju Abraham <[email protected]>Signed-off-by Nikunj A Dadhania <[email protected]>
Quoted 5 lines
Quoted 2 lines
Following shall care of your issue:
https://www.mail-archive.com/[email protected]/msg900136.htmlThanks, I tried out the patch series, I could start guest till 978G (not sure why this magic number yet) and after that I start getting errors:
It's expected. The point of the series is meant to avoid attempting at DMA mapping over the HyperTransport region. Before it would just fail to either hotplug/boot with VFIO devices on kernels >= 5.4 (even if older kernels or other configs let you go through you might still see IOMMU errors at some point). So what we essentially do is to have the region above 4G to instead start at 1T, thus requiring 1 more phys-bit on cases like this where the max gpa hits the Hyper Transport reserved region.
The cover-letter and this patch
(https://lore.kernel.org/qemu-devel/[email protected]/)
should clarify on the logic.
The check you're adding here is essentially patch 9 of the series.
Quoted 6 lines
$ ./build/qemu-system-x86_64 -enable-kvm -machine q35 -m 979G -kernel bzImage -initrd initramfs.cpio -vga none -nographic -append "console=ttyS0,115200n8 earlyprintk=serial,ttyS0,115200 debug=1 " -nodefaults -serial stdio qemu-system-x86_64: Address space limit 0xffffffffff < 0x1fc3fffffff phys-bits too low (40)Regards
Nikunj
Quoted 29 lines · Joao Martins
Quoted 15 lines · Nikunj A. Dadhania
Quoted 14 lines · Igor Mammedov
Quoted 9 lines · On Mon, 18 Jul 2022 13:47:34 +0530 Nikunj A Dadhania <[email protected]> wrote:
Currently it is possible to start a guest with memory that is beyond the addressable range of CPU and QEMU does not even warn about it. The default
phys_bitsis 40 and can address 1TB. However it allows to start a guest with greater than 1TB memory.Prevent this by erroring out in such a scenario.
Reported-by Shaju Abraham <[email protected]>Signed-off-by Nikunj A Dadhania <[email protected]>Quoted 5 lines
Quoted 2 lines
Following shall care of your issue:
https://www.mail-archive.com/[email protected]/msg900136.htmlThanks, I tried out the patch series, I could start guest till 978G (not sure why this magic number yet) and after that I start getting errors:
It's expected. The point of the series is meant to avoid attempting at DMA mapping over the HyperTransport region. Before it would just fail to either hotplug/boot with VFIO devices on kernels >= 5.4 (even if older kernels or other configs let you go through you might still see IOMMU errors at some point). So what we essentially do is to have the region above 4G to instead start at 1T, thus requiring 1 more phys-bit on cases like this where the max gpa hits the Hyper Transport reserved region.
Quoted 3 lines
The cover-letter and this patch
(https://lore.kernel.org/qemu-devel/[email protected]/
should clarify on the logic.
Thanks looks good !
Quoted 1 line
The check you're adding here is essentially patch 9 of the series.
Yes, saw that change.
Regards
Nikunj