Skip to contentSkip to conversation

package/sudo: fix SUDO_ENABLE_SUDO_GROUP_RULE following version bump

PATCH Applied Thomas Petazzoni via buildroot 2 participants 2 messages Jul 18, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/sudo: fix SUDO_ENABLE_SUDO_GROUP_RULE following version bump

Since the version bump of sudo to v1.9.11p2 in commit 9b7f8da96b, the sed magic in SUDO_ENABLE_SUDO_GROUP_RULE no longer does its job, due to a slight change in the example sudoers file provided by upstream sudo.

This commit fixes the regexp to match the new sudoers file.

Fixes bug #14891 (https://bugs.busybox.net/show_bug.cgi?id=14891)

---
 package/sudo/sudo.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/sudo/sudo.mk +1 -1
index 2b9ba76a51..4f9fdb4b2c 100644
@@ -80,7 +80,7 @@ define SUDO_USERS
 endef
 
 define SUDO_ENABLE_SUDO_GROUP_RULE
-	$(SED) '/^# \%sudo\tALL=(ALL) ALL/s/^# //' $(TARGET_DIR)/etc/sudoers
+	$(SED) '/^# \%sudo\tALL=(ALL:ALL) ALL/s/^# //' $(TARGET_DIR)/etc/sudoers
 endef
 SUDO_POST_INSTALL_TARGET_HOOKS += SUDO_ENABLE_SUDO_GROUP_RULE
 
Signature · 6 lines
2.36.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Thomas, All,

On 2022-07-18 23:51 +0200, Thomas Petazzoni via buildroot spake thusly:

Quoted 11 lines

Since the version bump of sudo to v1.9.11p2 in commit 9b7f8da96b, the sed magic in SUDO_ENABLE_SUDO_GROUP_RULE no longer does its job, due to a slight change in the example sudoers file provided by upstream sudo.

This commit fixes the regexp to match the new sudoers file.

Fixes bug #14891 (https://bugs.busybox.net/show_bug.cgi?id=14891)

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 24 lines
---
 package/sudo/sudo.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/sudo/sudo.mk +1 -1
index 2b9ba76a51..4f9fdb4b2c 100644
@@ -80,7 +80,7 @@ define SUDO_USERS
 endef
 
 define SUDO_ENABLE_SUDO_GROUP_RULE
-	$(SED) '/^# \%sudo\tALL=(ALL) ALL/s/^# //' $(TARGET_DIR)/etc/sudoers
+	$(SED) '/^# \%sudo\tALL=(ALL:ALL) ALL/s/^# //' $(TARGET_DIR)/etc/sudoers
 endef
 SUDO_POST_INSTALL_TARGET_HOOKS += SUDO_ENABLE_SUDO_GROUP_RULE
 
Signature · 6 lines
2.36.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot