Skip to contentSkip to conversation

readahead01.c: turn comment into docparse and reword

PATCH In review Avinesh Kumar 2 participants 2 messages Jul 19, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 readahead01.c: turn comment into docparse and reword

---
 testcases/kernel/syscalls/readahead/readahead01.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
testcases/kernel/syscalls/readahead/readahead01.c +7 -2
index 4355457e9..ac762aa3e 100644
@@ -3,8 +3,13 @@
  * Copyright (C) 2012 Linux Test Project, Inc.
  */
 
-/*
- * errno tests for readahead() syscall
+/*\
+ * [Description]
+ *
+ * Verify that readahead() syscall fails with
+ * - EBADF when fd is not a valid file descriptor or is not open for reading.
+ * - EINVAL when fd does not refer to a file type to which readahead()
+ * can be applied.
  */
 #define _GNU_SOURCE
 #include <errno.h>
Signature · 5 lines
2.36.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

Hi!
Pushed with fixes, thanks.

Quoted 7 lines
testcases/kernel/syscalls/readahead/readahead01.c +0 -0
index 4355457e9..ac762aa3e 100644
@@ -3,8 +3,13 @@
  * Copyright (C) 2012 Linux Test Project, Inc.
  */

testcases/kernel/syscalls/readahead/readahead01.c line 12

Quoted 10 lines
testcases/kernel/syscalls/readahead/readahead01.c +7 -2
 
-/*
- * errno tests for readahead() syscall
+/*\
+ * [Description]
+ *
+ * Verify that readahead() syscall fails with
+ * - EBADF when fd is not a valid file descriptor or is not open for reading.
+ * - EINVAL when fd does not refer to a file type to which readahead()
+ * can be applied.

This does not render as a list unless there is empty line between the "Verify that..." and the rest.

I've also added colon (:) after the "... with" as we usually do.

Please always check the resulting html pages to check if the end result is rendered properly.

Signature · 5 lines
Cyril Hrubis
[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp