Skip to contentSkip to conversation

ata:do not initialise statics to 0

PATCH In review Xin Gao 2 participants 2 messages Jul 19, 2022 libata

lore
Share & tools
lore

Xin Gao

author
#0 lore raw

PATCH 1/1 ata:do not initialise statics to 0

do not initialise statics to 0

---
 drivers/ata/libata-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/libata-core.c +1 -1
index 40e816419f48..bbb98433d160 100644
@@ -119,7 +119,7 @@ static int atapi_enabled = 1;
 module_param(atapi_enabled, int, 0444);
 MODULE_PARM_DESC(atapi_enabled, "Enable discovery of ATAPI devices (0=off, 1=on [default])");
 
-static int atapi_dmadir = 0;
+static int atapi_dmadir;
 module_param(atapi_dmadir, int, 0444);
 MODULE_PARM_DESC(atapi_dmadir, "Enable ATAPI DMADIR bridge support (0=off [default], 1=on)");
 
Signature · 1 line
2.30.2
#1 lore raw
Quoted 12 lines · Xin Gao

do not initialise statics to 0

---
 drivers/ata/libata-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/libata-core.c +0 -0
index 40e816419f48..bbb98433d160 100644

drivers/ata/libata-core.c static int atapi_enabled = 1; · line 125

Quoted 8 lines
drivers/ata/libata-core.c +1 -1
@@ -119,7 +119,7 @@ static int atapi_enabled = 1;
 module_param(atapi_enabled, int, 0444);
 MODULE_PARM_DESC(atapi_enabled, "Enable discovery of ATAPI devices (0=off, 1=on [default])");
 
-static int atapi_dmadir = 0;
+static int atapi_dmadir;
 module_param(atapi_dmadir, int, 0444);
 MODULE_PARM_DESC(atapi_dmadir, "Enable ATAPI DMADIR bridge support (0=off [default], 1=on)");
 

Is this solving any static analyzer or compiler warning ? If not, this is not a very useful change.

Signature · 2 lines
Damien Le Moal
Western Digital Research