Skip to contentSkip to conversation

HID: alps: Declare U1_UNICORN_LEGACY support

PATCH Applied Artem Borisov 2 participants 2 messages Jul 19, 2022 – Jul 22, 2022 HID

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 HID: alps: Declare U1_UNICORN_LEGACY support

U1_UNICORN_LEGACY id was added to the driver, but was not declared in the device id table, making it impossible to use.

Fixes 640e403 ("HID: alps: Add AUI1657 device ID")
---
 drivers/hid/hid-alps.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/hid/hid-alps.c +2 -0
index 2b986d0dbde4..db146d0f7937 100644
@@ -830,6 +830,8 @@ static const struct hid_device_id alps_id[] = {
 		USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_U1_DUAL) },
 	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY,
 		USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_U1) },
+	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY,
+		USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_U1_UNICORN_LEGACY) },
 	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY,
 		USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_T4_BTNLESS) },
 	{ }
Signature · 1 line
2.20.1
maintainer Applied
#1 lore raw
Quoted 14 lines · Artem Borisov

U1_UNICORN_LEGACY id was added to the driver, but was not declared in the device id table, making it impossible to use.

Fixes 640e403 ("HID: alps: Add AUI1657 device ID")
---
 drivers/hid/hid-alps.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/hid/hid-alps.c +0 -0
index 2b986d0dbde4..db146d0f7937 100644

drivers/hid/hid-alps.c static const struct hid_device_id alps_id[] = { · line 837

Quoted 8 lines
drivers/hid/hid-alps.c +2 -0
@@ -830,6 +830,8 @@ static const struct hid_device_id alps_id[] = {
 		USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_U1_DUAL) },
 	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY,
 		USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_U1) },
+	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY,
+		USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_U1_UNICORN_LEGACY) },
 	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY,
 		USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_T4_BTNLESS) },
 	{ }

Applied, thanks.

Signature · 2 lines
Jiri Kosina
SUSE Labs