Skip to contentSkip to conversation

.cirrus.yml: Change winsymlinks to 'native'

PATCH In review Bin Meng 4 participants 5 messages Jul 19, 2022 – Jul 25, 2022

lore
Share & tools
lore

Bin Meng

author
#0 lore raw

PATCH 1/1 .cirrus.yml: Change winsymlinks to 'native'

From: Bin Meng <[email protected]>

At present winsymlinks is set to 'nativestrict', and its behavior is:

a) if native symlinks are enabled and <target> exists, creates

     <destination> as a native Windows symlink;

b) else if native symlinks are not enabled or if <target> does not exist, 'ln -s' fails.

This causes the following error message was seen during the configure:

"ln: failed to create symbolic link 'x86_64-softmmu/qemu-system-x86_64.exe': No such file or directory"

Change winsymlinks to 'native' whose behavior is most similar to the behavior of 'ln -s' on *nix, that is:

a) if native symlinks are enabled, and whether <target> exists

     or not, creates <destination> as a native Windows symlink;

b) else if native symlinks are not enabled, and whether <target> exists or not, 'ln -s' creates as a Windows shortcut file.

---

 .cirrus.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
.cirrus.yml +1 -1
index 20843a420c..eac39024f2 100644
@@ -10,7 +10,7 @@ windows_msys2_task:
     memory: 8G
   env:
     CIRRUS_SHELL: powershell
-    MSYS: winsymlinks:nativestrict
+    MSYS: winsymlinks:native
     MSYSTEM: MINGW64
     MSYS2_URL: https://github.com/msys2/msys2-installer/releases/download/2022-05-03/msys2-base-x86_64-20220503.sfx.exe
     MSYS2_FINGERPRINT: 0
Signature · 1 line
2.34.1
author
#1 lore raw
Quoted 20 lines · Bin Meng

From: Bin Meng <[email protected]>

At present winsymlinks is set to 'nativestrict', and its behavior is:

a) if native symlinks are enabled and <target> exists, creates

     <destination> as a native Windows symlink;

b) else if native symlinks are not enabled or if <target> does not exist, 'ln -s' fails.

This causes the following error message was seen during the configure:

"ln: failed to create symbolic link 'x86_64-softmmu/qemu-system-x86_64.exe': No such file or directory"

Change winsymlinks to 'native' whose behavior is most similar to the behavior of 'ln -s' on *nix, that is:

a) if native symlinks are enabled, and whether <target> exists

     or not, creates <destination> as a native Windows symlink;
Quoted 9 lines

b) else if native symlinks are not enabled, and whether <target> exists or not, 'ln -s' creates as a Windows shortcut file.

---

 .cirrus.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Ping?

#2 lore raw
Quoted 25 lines · Bin Meng
Quoted 23 lines · Bin Meng

From: Bin Meng <[email protected]>

At present winsymlinks is set to 'nativestrict', and its behavior is:

a) if native symlinks are enabled and <target> exists, creates

     <destination> as a native Windows symlink;

b) else if native symlinks are not enabled or if <target> does not exist, 'ln -s' fails.

This causes the following error message was seen during the configure:

"ln: failed to create symbolic link 'x86_64-softmmu/qemu-system-x86_64.exe': No such file or directory"

Change winsymlinks to 'native' whose behavior is most similar to the behavior of 'ln -s' on *nix, that is:

a) if native symlinks are enabled, and whether <target> exists

     or not, creates <destination> as a native Windows symlink;

b) else if native symlinks are not enabled, and whether <target> exists or not, 'ln -s' creates as a Windows shortcut file.

Quoted 8 lines
Quoted 6 lines

---

 .cirrus.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Ping?

--
此致
礼
罗勇刚
Yours
sincerely,
Yonggang Luo

Acked-by on v1 1/1
#3 lore raw
In reply to Bin Meng
Quoted 33 lines · Bin Meng

From: Bin Meng <[email protected]>

At present winsymlinks is set to 'nativestrict', and its behavior is:

a) if native symlinks are enabled and <target> exists, creates

      <destination> as a native Windows symlink;

b) else if native symlinks are not enabled or if <target> does not exist, 'ln -s' fails.

This causes the following error message was seen during the configure:

"ln: failed to create symbolic link 'x86_64-softmmu/qemu-system-x86_64.exe': No such file or directory"

Change winsymlinks to 'native' whose behavior is most similar to the behavior of 'ln -s' on *nix, that is:

a) if native symlinks are enabled, and whether <target> exists

      or not, creates <destination> as a native Windows symlink;

b) else if native symlinks are not enabled, and whether <target> exists or not, 'ln -s' creates as a Windows shortcut file.

---

  .cirrus.yml | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
.cirrus.yml +0 -0
index 20843a420c..eac39024f2 100644

.cirrus.yml windows_msys2_task: · line 16

Quoted 8 lines
.cirrus.yml +1 -1
@@ -10,7 +10,7 @@ windows_msys2_task:
      memory: 8G
    env:
      CIRRUS_SHELL: powershell
-    MSYS: winsymlinks:nativestrict
+    MSYS: winsymlinks:native
      MSYSTEM: MINGW64
      MSYS2_URL: https://github.com/msys2/msys2-installer/releases/download/2022-05-03/msys2-base-x86_64-20220503.sfx.exe
      MSYS2_FINGERPRINT: 0

Alex, if I've got that right, you're currently assembling a "testing" pull request - could you please pick up this patch for that, too? ... I currently don't have anything else pending right now, so I don't plan any new pull request soon.

Thomas

#4 lore raw
In reply to Bin Meng
Quoted 17 lines · Bin Meng

From: Bin Meng <[email protected]>

At present winsymlinks is set to 'nativestrict', and its behavior is:

a) if native symlinks are enabled and <target> exists, creates

     <destination> as a native Windows symlink;

b) else if native symlinks are not enabled or if <target> does not exist, 'ln -s' fails.

This causes the following error message was seen during the configure:

"ln: failed to create symbolic link 'x86_64-softmmu/qemu-system-x86_64.exe': No such file or directory"

Change winsymlinks to 'native' whose behavior is most similar to the behavior of 'ln -s' on *nix, that is:

Quoted 6 lines

a) if native symlinks are enabled, and whether <target> exists

     or not, creates <destination> as a native Windows symlink;

b) else if native symlinks are not enabled, and whether <target> exists or not, 'ln -s' creates as a Windows shortcut file.

Queued to testing/next, thanks.

Signature · 1 line
Alex Bennée