drm/amd/display: Disable dmcu fw loading for dcn314
Subsystems (3)
PATCH 1/2 drm/amd/display: Disable dmcu fw loading for dcn314
From: Roman Li <[email protected]>
[Why]
DCN 3.1.4 uses dmub not dmcu. Attempt to identify dmcu firmware for dcn314 results in dm init error:
"Unsupported ASIC type"
[How]
Add dcn314 to the list of asics that don't require dmcu
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1 -0
@@ -1893,6 +1893,7 @@ static int load_dmcu_fw(struct amdgpu_device *adev)case IP_VERSION (3 ,0 ,1 ):case IP_VERSION (3 ,1 ,2 ):case IP_VERSION (3 ,1 ,3 ): +case IP_VERSION (3 ,1 ,4 ):case IP_VERSION (3 ,1 ,5 ):case IP_VERSION (3 ,1 ,6 ):case IP_VERSION (3 ,2 ,0 ):
Signature · 1 line
2.17.1
PATCH 2/2 drm/amdgpu: add dm ip block for dcn 3.1.4
From: Roman Li <[email protected]>
Adding dm ip block to enable display on dcn 3.1.4.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c +1 -0
@@ -1716,6 +1716,7 @@ static int amdgpu_discovery_set_display_ip_blocks(struct amdgpu_device *adev)case IP_VERSION (3 ,0 ,1 ):case IP_VERSION (3 ,1 ,2 ):case IP_VERSION (3 ,1 ,3 ): +case IP_VERSION (3 ,1 ,4 ):case IP_VERSION (3 ,1 ,5 ):case IP_VERSION (3 ,1 ,6 ):case IP_VERSION (3 ,2 ,0 ):
Signature · 1 line
2.17.1
Re: [PATCH 2/2] drm/amdgpu: add dm ip block for dcn 3.1.4
Series is:
Quoted 25 lines · On Tue, Jul 19, 2022 at 2:26 PM <[email protected]> wrote:
From: Roman Li <[email protected]>
Adding dm ip block to enable display on dcn 3.1.4.
Signed-off-by Roman Li <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c +1
-1@@ -1716,6 +1716,7 @@ static int amdgpu_discovery_set_display_ip_blocks(struct amdgpu_device *adev)case IP_VERSION (3 ,0 ,1 ):case IP_VERSION (3 ,1 ,2 ):case IP_VERSION (3 ,1 ,3 ): +case IP_VERSION (3 ,1 ,4 ):case IP_VERSION (3 ,1 ,5 ):case IP_VERSION (3 ,1 ,6 ):case IP_VERSION (3 ,2 ,0 ): --2.17.1
Quoted 11 lines · On 2022-07-19 14:26, [email protected] wrote:
From: Roman Li <[email protected]>
[Why]
DCN 3.1.4 uses dmub not dmcu. Attempt to identify dmcu firmware for dcn314 results in dm init error:
"Unsupported ASIC type"[How]
Add dcn314 to the list of asics that don't require dmcuSigned-off-by Roman Li <[email protected]>
Might be easier going forward if we simply return 0 in the outside case statement instead of explicitly calling out IPs that don't support DMCU. The default (any new ASIC) won't support DMCU.
Harry
Quoted 16 lines
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1
-0@@ -1893,6 +1893,7 @@ static int load_dmcu_fw(struct amdgpu_device *adev)case IP_VERSION (3 ,0 ,1 ):case IP_VERSION (3 ,1 ,2 ):case IP_VERSION (3 ,1 ,3 ): +case IP_VERSION (3 ,1 ,4 ):case IP_VERSION (3 ,1 ,5 ):case IP_VERSION (3 ,1 ,6 ):case IP_VERSION (3 ,2 ,0 ):