Skip to contentSkip to conversation

nvmet-auth: select the intended CRYPTO_DH_RFC7919_GROUPS

PATCH Applied Lukas Bulwahn 3 participants 3 messages Jul 20, 2022 – Jul 21, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nvmet-auth: select the intended CRYPTO_DH_RFC7919_GROUPS

Commit 71ebe3842ebe ("nvmet-auth: Diffie-Hellman key exchange support") intends to select 'Support for RFC 7919 FFDHE group parameters' for using FFDHE groups for NVMe In-Band Authentication.

It however selects CRYPTO_DH_GROUPS_RFC7919, instead of the intended CRYPTO_DH_RFC7919_GROUPS; notice the swapping of words here.

Correct the select to the intended config option.

---
 drivers/nvme/target/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/target/Kconfig +1 -1
index f0c91f7686a3..79fc64035ee3 100644
@@ -93,7 +93,7 @@ config NVME_TARGET_AUTH
 	select CRYPTO_SHA256
 	select CRYPTO_SHA512
 	select CRYPTO_DH
-	select CRYPTO_DH_GROUPS_RFC7919
+	select CRYPTO_DH_RFC7919_GROUPS
 	help
 	  This enables support for NVMe over Fabrics In-band Authentication
 
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 19 lines · Lukas Bulwahn

Commit 71ebe3842ebe ("nvmet-auth: Diffie-Hellman key exchange support") intends to select 'Support for RFC 7919 FFDHE group parameters' for using FFDHE groups for NVMe In-Band Authentication.

It however selects CRYPTO_DH_GROUPS_RFC7919, instead of the intended CRYPTO_DH_RFC7919_GROUPS; notice the swapping of words here.

Correct the select to the intended config option.

---
  drivers/nvme/target/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/target/Kconfig +0 -0
index f0c91f7686a3..79fc64035ee3 100644

drivers/nvme/target/Kconfig config NVME_TARGET_AUTH · line 99

Quoted 8 lines
drivers/nvme/target/Kconfig +1 -1
@@ -93,7 +93,7 @@ config NVME_TARGET_AUTH
  	select CRYPTO_SHA256
  	select CRYPTO_SHA512
  	select CRYPTO_DH
-	select CRYPTO_DH_GROUPS_RFC7919
+	select CRYPTO_DH_RFC7919_GROUPS
  	help
  	  This enables support for NVMe over Fabrics In-band Authentication
 

Cheers,

Hannes