Skip to contentSkip to conversation

dma-mapping: update comment after dmabounce removal

PATCH Applied Lukas Bulwahn 3 participants 4 messages Jul 20, 2022 – Jul 22, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dma-mapping: update comment after dmabounce removal

Commit e3217540c271 ("ARM/dma-mapping: remove dmabounce") removes the config DMABOUNCE. A comment to the function __dma_page_cpu_to_dev() refers to this removed config DMABOUNCE.

Remove the obsolete explanation, but keep the recommendation not to use __dma_page_cpu_to_dev() and use dma_sync_* functions instead.

---
 arch/arm/mm/dma-mapping.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm/mm/dma-mapping.c +1 -2
index e68d1d2ac4be..16c2cdd04639 100644
@@ -679,8 +679,7 @@ static void dma_cache_maint_page(struct page *page, unsigned long offset,
 
 /*
  * Make an area consistent for devices.
- * Note: Drivers should NOT use this function directly, as it will break
- * platforms with CONFIG_DMABOUNCE.
+ * Note: Drivers should NOT use this function directly.
  * Use the driver DMA support - see dma-mapping.h (dma_sync_*)
  */
 static void __dma_page_cpu_to_dev(struct page *page, unsigned long off,
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Lukas Bulwahn

Commit e3217540c271 ("ARM/dma-mapping: remove dmabounce") removes the config DMABOUNCE. A comment to the function __dma_page_cpu_to_dev() refers to this removed config DMABOUNCE.

Remove the obsolete explanation, but keep the recommendation not to use __dma_page_cpu_to_dev() and use dma_sync_* functions instead.

---

Thanks!

The e3217540c271 commit is only in Christoph's dma-mapping tree, so this would ideally get applied on top before the merge window.

Arnd

#2 lore raw
Quoted 2 lines · Arnd Bergmann

The e3217540c271 commit is only in Christoph's dma-mapping tree, so this would ideally get applied on top before the merge window.

I'll pick it up.