Skip to contentSkip to conversation

b43:do not initialise statics to 0.

PATCH In review Xin Gao 3 participants 3 messages Jul 20, 2022 – Jul 27, 2022

Subsystems (3)
lore
Share & tools
lore

Xin Gao

author
#0 lore raw

PATCH 1/1 b43:do not initialise statics to 0.

do not initialise statics to 0.

---
 drivers/net/wireless/broadcom/b43/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/broadcom/b43/main.c +1 -1
index 17bcec5f3ff7..5e233d0e06c0 100644
@@ -105,7 +105,7 @@ int b43_modparam_verbose = B43_VERBOSITY_DEFAULT;
 module_param_named(verbose, b43_modparam_verbose, int, 0644);
 MODULE_PARM_DESC(verbose, "Log message verbosity: 0=error, 1=warn, 2=info(default), 3=debug");
 
-static int b43_modparam_pio = 0;
+static int b43_modparam_pio;
 module_param_named(pio, b43_modparam_pio, int, 0644);
 MODULE_PARM_DESC(pio, "Use PIO accesses by default: 0=DMA, 1=PIO");
 
Signature · 7 lines
2.30.2


_______________________________________________
b43-dev mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/b43-dev
Acked-by on v1 1/1
#1 lore raw
Quoted 12 lines · Xin Gao

do not initialise statics to 0.

---
  drivers/net/wireless/broadcom/b43/main.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/broadcom/b43/main.c +0 -0
index 17bcec5f3ff7..5e233d0e06c0 100644

drivers/net/wireless/broadcom/b43/main.c int b43_modparam_verbose = B43_VERBOSITY_DEFAULT; · line 110

Quoted 7 lines
drivers/net/wireless/broadcom/b43/main.c +1 -1
@@ -105,7 +105,7 @@ int b43_modparam_verbose = B43_VERBOSITY_DEFAULT;
  module_param_named(verbose, b43_modparam_verbose, int, 0644);
  MODULE_PARM_DESC(verbose, "Log message verbosity: 0=error, 1=warn, 2=info(default), 3=debug");
 
-static int b43_modparam_pio = 0;
+static int b43_modparam_pio;
  module_param_named(pio, b43_modparam_pio, int, 0644);
  MODULE_PARM_DESC(pio, "Use PIO accesses by default: 0=DMA, 1=PIO");

Thanks.

Larry

#2 lore raw

Re: wifi: b43: do not initialise static variable to 0

In reply to Xin Gao
Quoted 5 lines · Xin Gao

No need to initialise static variables to zero.

Patch applied to wireless-next.git, thanks.

dbf8cd368a47 wifi: b43: do not initialise static variable to 0

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches