Skip to contentSkip to conversation

drm/amdkfd: Correct mmu_notifier_get failure handling

PATCH In review Philip Yang 2 participants 2 messages Jul 21, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdkfd: Correct mmu_notifier_get failure handling

If process has signal pending, mmu_notifier_get_locked fails and calls ops->free_notifier, kfd_process_free_notifier will schedule kfd_process_wq_release as process refcount is 1, but process structure is already freed. This use after free bug causes system crash with different backtrace.

The fix is to increase process refcount and then decrease the refcount after mmu_notifier_get success.

---
 drivers/gpu/drm/amd/amdkfd/kfd_process.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/gpu/drm/amd/amdkfd/kfd_process.c +6 -0
index fc38a4d81420..d8591721270b 100644
@@ -1405,6 +1405,11 @@ static struct kfd_process *create_process(const struct task_struct *thread)
 	hash_add_rcu(kfd_processes_table, &process->kfd_processes,
 			(uintptr_t)process->mm);
 
+	/* Avoid free_notifier to start kfd_process_wq_release if
+	 * mmu_notifier_get failed because of pending signal.
+	 */
+	kref_get(&process->ref);
+
 	/* MMU notifier registration must be the last call that can fail
 	 * because after this point we cannot unwind the process creation.
 	 * After this point, mmu_notifier_put will trigger the cleanup by
@@ -1417,6 +1422,7 @@ static struct kfd_process *create_process(const struct task_struct *thread)
 	}
 	BUG_ON(mn != &process->mmu_notifier);
 
+	kfd_unref_process(process);
 	get_task_struct(process->lead_thread);
 
 	return process;
Signature · 1 line
2.35.1
maintainer Reviewed-by on v1 1/1
#1 lore raw

Am 2022-07-21 um 09:44 schrieb Philip Yang:

Quoted 10 lines

If process has signal pending, mmu_notifier_get_locked fails and calls ops->free_notifier, kfd_process_free_notifier will schedule kfd_process_wq_release as process refcount is 1, but process structure is already freed. This use after free bug causes system crash with different backtrace.

The fix is to increase process refcount and then decrease the refcount after mmu_notifier_get success.

Quoted 28 lines
---
  drivers/gpu/drm/amd/amdkfd/kfd_process.c | 6 ++++++
  1 file changed, 6 insertions(+)
drivers/gpu/drm/amd/amdkfd/kfd_process.c +6 -0
index fc38a4d81420..d8591721270b 100644
@@ -1405,6 +1405,11 @@ static struct kfd_process *create_process(const struct task_struct *thread)
  	hash_add_rcu(kfd_processes_table, &process->kfd_processes,
  			(uintptr_t)process->mm);
 
+	/* Avoid free_notifier to start kfd_process_wq_release if
+	 * mmu_notifier_get failed because of pending signal.
+	 */
+	kref_get(&process->ref);
+
  	/* MMU notifier registration must be the last call that can fail
  	 * because after this point we cannot unwind the process creation.
  	 * After this point, mmu_notifier_put will trigger the cleanup by
@@ -1417,6 +1422,7 @@ static struct kfd_process *create_process(const struct task_struct *thread)
  	}
  	BUG_ON(mn != &process->mmu_notifier);
 
+	kfd_unref_process(process);
  	get_task_struct(process->lead_thread);
 
  	return process;