Skip to contentSkip to conversation

dt-bindings: vendor-prefixes: add Densitron

PATCH Applied Marek Vasut 3 participants 6 messages Jul 21, 2022 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: vendor-prefixes: add Densitron

Densitron is a manufacturer of LCD panels.
https://www.densitron.com

Cc Guido Günther <[email protected]>
Cc Jagan Teki <[email protected]>
Cc Laurent Pinchart <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Rob Herring <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Thierry Reding <[email protected]>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
index 88859dd4040ee..6277240536b44 100644
@@ -312,6 +312,8 @@ patternProperties:
     description: Dell Inc.
   "^delta,.*":
     description: Delta Electronics, Inc.
+  "^densitron,.*":
+    description: Densitron Technologies Ltd
   "^denx,.*":
     description: Denx Software Engineering
   "^devantech,.*":
Signature · 1 line
2.35.1
#1 lore raw

Hi Marek,

Thank you for the patch.

Quoted 20 lines · Marek Vasut

Densitron is a manufacturer of LCD panels.
https://www.densitron.com

Cc Guido Günther <[email protected]>
Cc Jagan Teki <[email protected]>
Cc Laurent Pinchart <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Rob Herring <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Thierry Reding <[email protected]>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +0 -0
index 88859dd4040ee..6277240536b44 100644

Documentation/devicetree/bindings/vendor-prefixes.yaml patternProperties: · line 315

Quoted 4 lines
Documentation/devicetree/bindings/vendor-prefixes.yaml +1 -0
@@ -312,6 +312,8 @@ patternProperties:
     description: Dell Inc.
   "^delta,.*":
     description: Delta Electronics, Inc.
+  "^densitron,.*":

How about "dsn", to follow the practice of using stock names as vendor prefixes ?

Quoted 4 lines
Documentation/devicetree/bindings/vendor-prefixes.yaml +1 -0
+    description: Densitron Technologies Ltd
   "^denx,.*":
     description: Denx Software Engineering
   "^devantech,.*":
Signature · 3 lines
Regards,

Laurent Pinchart
#2 lore raw
Quoted 20 lines · Laurent Pinchart

Hi Marek,

Thank you for the patch.

Quoted 15 lines · Marek Vasut

Densitron is a manufacturer of LCD panels.
https://www.densitron.com

Cc Guido Günther <[email protected]>
Cc Jagan Teki <[email protected]>
Cc Laurent Pinchart <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Rob Herring <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Thierry Reding <[email protected]>
---
  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
  1 file changed, 2 insertions(+)
Quoted 12 lines

Documentation/devicetree/bindings/vendor-prefixes.yaml patternProperties: · line 315

Quoted 9 lines
Documentation/devicetree/bindings/vendor-prefixes.yaml +1 -0
index 88859dd4040ee..6277240536b44 100644
@@ -312,6 +312,8 @@ patternProperties:
      description: Dell Inc.
    "^delta,.*":
      description: Delta Electronics, Inc.
+  "^densitron,.*":

How about "dsn", to follow the practice of using stock names as vendor prefixes ?

Is there any benefit to that ? All I can see is that it's making DTS less clear and more difficult to read. It is easy to map "densitron" to "densitron" when it is spelled out like so in the DT, but it sure isn't immediately obvious that "dsn" means "densitron" without extra look up. And even that extra look up of "dsn" does not return densitron, but some woodworking company and other totally unrelated results.

#3 lore raw

Hi Marek,

Quoted 30 lines · Marek Vasut
Quoted 16 lines · Laurent Pinchart
Quoted 15 lines · Marek Vasut

Densitron is a manufacturer of LCD panels.
https://www.densitron.com

Cc Guido Günther <[email protected]>
Cc Jagan Teki <[email protected]>
Cc Laurent Pinchart <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Rob Herring <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Thierry Reding <[email protected]>
---
  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
  1 file changed, 2 insertions(+)
Quoted 12 lines

Documentation/devicetree/bindings/vendor-prefixes.yaml patternProperties: · line 315

Quoted 9 lines
Documentation/devicetree/bindings/vendor-prefixes.yaml +1 -0
index 88859dd4040ee..6277240536b44 100644
@@ -312,6 +312,8 @@ patternProperties:
      description: Dell Inc.
    "^delta,.*":
      description: Delta Electronics, Inc.
+  "^densitron,.*":

How about "dsn", to follow the practice of using stock names as vendor prefixes ?

Quoted 6 lines

Is there any benefit to that ? All I can see is that it's making DTS less clear and more difficult to read. It is easy to map "densitron" to "densitron" when it is spelled out like so in the DT, but it sure isn't immediately obvious that "dsn" means "densitron" without extra look up. And even that extra look up of "dsn" does not return densitron, but some woodworking company and other totally unrelated results.

I don't know where that practice originates from, and if it's still the recommended naming scheme these days. All I know is that it was the recommended scheme at some point. I expect Rob will be able to tell which name is best.

Signature · 3 lines
Regards,

Laurent Pinchart
maintainer
#4 lore raw
Quoted 40 lines · Laurent Pinchart

Hi Marek,

Quoted 30 lines · Marek Vasut
Quoted 16 lines · Laurent Pinchart
Quoted 15 lines · Marek Vasut

Densitron is a manufacturer of LCD panels.
https://www.densitron.com

Cc Guido Günther <[email protected]>
Cc Jagan Teki <[email protected]>
Cc Laurent Pinchart <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Rob Herring <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Thierry Reding <[email protected]>
---
  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
  1 file changed, 2 insertions(+)
Quoted 12 lines

Documentation/devicetree/bindings/vendor-prefixes.yaml patternProperties: · line 315

Quoted 9 lines
Documentation/devicetree/bindings/vendor-prefixes.yaml +1 -0
index 88859dd4040ee..6277240536b44 100644
@@ -312,6 +312,8 @@ patternProperties:
      description: Dell Inc.
    "^delta,.*":
      description: Delta Electronics, Inc.
+  "^densitron,.*":

How about "dsn", to follow the practice of using stock names as vendor prefixes ?

Quoted 6 lines

Is there any benefit to that ? All I can see is that it's making DTS less clear and more difficult to read. It is easy to map "densitron" to "densitron" when it is spelled out like so in the DT, but it sure isn't immediately obvious that "dsn" means "densitron" without extra look up. And even that extra look up of "dsn" does not return densitron, but some woodworking company and other totally unrelated results.

Quoted 4 lines

I don't know where that practice originates from, and if it's still the recommended naming scheme these days. All I know is that it was the recommended scheme at some point. I expect Rob will be able to tell which name is best.

The other practice is using the website name minus .com or whatever. I would stick with that here.

Rob

maintainer Applied
#5 lore raw
In reply to Marek Vasut
Quoted 11 lines · Marek Vasut

Densitron is a manufacturer of LCD panels.
https://www.densitron.com

Cc Guido Günther <[email protected]>
Cc Jagan Teki <[email protected]>
Cc Laurent Pinchart <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Rob Herring <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Thierry Reding <[email protected]>
Quoted 4 lines
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

Applied, thanks!