Skip to contentSkip to conversation

arm64: dts: arm: juno: Remove legacy Coresight 'slave-mode' property

PATCH Applied Rob Herring 3 participants 3 messages Jul 21, 2022 – Aug 15, 2022

Subsystems (2)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 arm64: dts: arm: juno: Remove legacy Coresight 'slave-mode' property

The 'slave-mode' property is not valid under 'in-ports' as it was the legacy way to find input ports. Warnings are generated from the Coresight schema:

arch/arm64/boot/dts/arm/juno-r1.dtb: funnel@20150000: in-ports:port@0:endpoint: Unevaluated properties are not allowed ('slave-mode' was unexpected)
From schema: Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml

---
 arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi | 2 --
 1 file changed, 2 deletions(-)
arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi +0 -2
index 2e43f4531308..fbcdf63ad56d 100644
@@ -67,7 +67,6 @@ in-ports {
 			port@0 {
 				reg = <0>;
 				csys2_funnel_in_port0: endpoint {
-					slave-mode;
 					remote-endpoint = <&etf0_out_port>;
 				};
 			};
@@ -75,7 +74,6 @@ csys2_funnel_in_port0: endpoint {
 			port@1 {
 				reg = <1>;
 				csys2_funnel_in_port1: endpoint {
-					slave-mode;
 					remote-endpoint = <&etf1_out_port>;
 				};
 			};
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 25 lines · Rob Herring

The 'slave-mode' property is not valid under 'in-ports' as it was the legacy way to find input ports. Warnings are generated from the Coresight schema:

arch/arm64/boot/dts/arm/juno-r1.dtb: funnel@20150000: in-ports:port@0:endpoint: Unevaluated properties are not allowed ('slave-mode' was unexpected)
From schema: Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml

---
  arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi | 2 --
  1 file changed, 2 deletions(-)
arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi +0 -1
index 2e43f4531308..fbcdf63ad56d 100644
@@ -67,7 +67,6 @@ in-ports {
  			port@0 {
  				reg = <0>;
  				csys2_funnel_in_port0: endpoint {
-					slave-mode;
  					remote-endpoint = <&etf0_out_port>;
  				};
  			};

arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi csys2_funnel_in_port0: endpoint { · line 79

Quoted 7 lines
arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi +0 -1
@@ -75,7 +74,6 @@ csys2_funnel_in_port0: endpoint {
  			port@1 {
  				reg = <1>;
  				csys2_funnel_in_port1: endpoint {
-					slave-mode;
  					remote-endpoint = <&etf1_out_port>;
  				};
  			};
Applied
#2 lore raw
In reply to Rob Herring
Quoted 8 lines · Rob Herring

The 'slave-mode' property is not valid under 'in-ports' as it was the legacy way to find input ports. Warnings are generated from the Coresight schema:

arch/arm64/boot/dts/arm/juno-r1.dtb: funnel@20150000: in-ports:port@0:endpoint: Unevaluated properties are not allowed ('slave-mode' was unexpected)
From schema: Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml

[...]

Applied to sudeep.holla/linux (for-next/juno), thanks!

[1/1] arm64: dts: arm: juno: Remove legacy Coresight 'slave-mode' property

      https://git.kernel.org/sudeep.holla/c/2a9eb57e20e6

--
Regards,
Sudeep