Skip to contentSkip to conversation

Add MediaTek MT6370 PMIC support

PATCH Superseded ChiaEn Wu 8 participants 52 messages Jul 22, 2022 – Aug 4, 2022

Subsystems (12)

v6 of 9 Superseded Latest is v9 →

lore
Share & tools
lore

ChiaEn Wu

author
#0 lore raw

v6 cover Add MediaTek MT6370 PMIC support

From: ChiaEn Wu <[email protected]>

This patch series add MediaTek MT6370 PMIC support. The MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

In this series of patches, we based on Andy Shevchenko's mfd patch used to adjust the Makefile order.
(https://lore.kernel.org/all/[email protected]/)
Among with this, we took some changes for MT6370 and refined the MT6370 device tree files to comply with DT specifications.

"[PATCH v6 06/13] dt-bindings: mfd: Add MediaTek MT6370" depends on previous DT binding patches, so before applying this patch, please apply other DT patches first. Thanks!

Thank you,
ChiaEn Wu

---
Changes in v6:
- In Patch 03/13:
- Add 'reg' property of led of multi-led to prevent checking error.

- In Patch 08/13:
- Convert tcpci as device resource managed with 'devm_add_action_or_reset' api.
- Refine remvoe callback.
- Refine the commit text from 'this commit add' to 'add'.

- In Patch 09/13:
- Using 'struct device *dev = &pdev->dev' in probe()
- Revise the sixth parameter of regmap_read_poll_timeout() by replacing '1000' with 'MILLI'
- Revise the units of three macros
- MT6370_AICR_400MA --> MT6370_AICR_400_mA
- MT6370_ICHG_500MA --> MT6370_ICHG_500_mA
- MT6370_ICHG_900MA --> MT6370_ICHG_900_mA

- In patch 10/13:
- Remove the varable (*psy_desc) of struct mt6370_priv
- Remove the deprecated usb type (POWER_SUPPLY_TYPE_USB_CDP and POWER_SUPPLY_TYPE_USB_DCP)
- Remove useless remove()
- Revise all units from mini- to micro-
- Revise get/set power_supply_prop (change to directly return get/set regmap_field)
- Revise probe() and use devm_add_action_or_reset() for handling of the workqueue/delayed_work/mutex
- Revise mt6370_chg_psy_desc
- Add '.name = "mt6370-charger"'
- Use 'static const'

- In patch 11/13:
- Remove the 'ko' from mt6370 led Kconfig description.
- Add both authors for Alice and ChiYuan.
- Use pdata to distinguish the code from mt6370/71 to mt6372.
- Instead of 'state' define, use the 'state' enum.
- Fix the typo for 'MT6372_PMW_DUTY'.
- For pwm_duty define, replace with bit macro - 1.
- Refine all the labels from 'out' to 'out_unlock'.
- Use struct 'dev' variable and 'dev_err_probe' to optimize the LOC.
- Revise for the array initialization from {0} to {}.
- Move into rgb folder and rename file name to 'leds-mt6370-rgb'.
- Refine the 'comma' usage in struct/enum.

- In patch 12/13:
- Use 'GENMASK' instead of 'BIT'.
- Use dev_err_probe to decrease LOC.
- Use 'dev' variable to make probe function more clean.
- Refine the return of _mt6370_flash_brightness_set function.
- Refine the descriptions.
- Use mt6370_clamp() instead of clamp_align().
- Use device resource managed API for v4l2 flash_release.

Changes in v5:
- In patch 07/13:
- Add the comma in the last REGMAP_IRQ_REG_LINE(), DEFINE_RES_IRQ_NAMED() and MFD_CELL_RES()
- Add the prefix in the first parameter of all mfd_cell
- Move enum and struct mt6370_info to mt6370.h
- Remove struct device *dev in struct mt6370_info
- Revise the description of Kconfig help text
- Revise MODULE_DESCRIPTION()

- In patch 08/13:
- Add comma for the last index of mt6370_reg_init.
- Use dev_err_probe to decrease LOC.
- Use 'dev' variable to make probe function more clean.
- Refine kconfig text.
- Remove both 'else' in set_vbus callback.
- Remove comma for of_device_id if the assigned member is only one.

- In patch 09/13:
- Replace using snprintf() with sysfs_emit() in mt6370_adc_read_label()
- Remove macro ADC_CONV_TIME_US
- Revise all variable ordering
- Revise the description of Kconfig help text
- Revise MODULE_DESCRIPTION()

- In patch 10/13:
- Replace unsigned int type of pwr_rdy with bool in mt6370_chg_set_online()
- Remove redundant 'else' in mt6370_chg_field_get()
- Revise 'if-else' in mt6370_chg_field_set()
- Revise 'if' condition in mt6370_chg_enable_irq()
- Revise all text 'otg' --> 'OTG'
- Revise MT6370_MIVR_IBUS_TH_100_MA --> MT6370_MIVR_IBUS_TH_100_mA
- Revise the description of Kconfig help text

- In patch 12/13:
- Refine the coding style.
- Use "dev" instead of "&pdev->dev".

- In patch 13/13:
- Add missed <mod_devicetable.h>
- Add struct device *dev in probe() to make code cleaning
- Remove useless including header file <gpio/driver.h>, <of.h>
- Remove useless variable uasage in mt6370_init_backlight_properties()
- Remove redundant checking enable_gpio in mt6370_bl_update_status()
- Remove redundant parentheses in mt6370_bl_get_brightness()
- Revise the description of Kconfig help text
- Revise the calculation of hys_th_steps

Changes in v4:
- In patch 02/13:
- Add minItems of "io-channel-names"
- Replace text "Mediatek" with "MediaTek"

- In patch 06/13:
- Roll back all "$ref: " to v2 patch style (using "/schemas/...")

- In patch 07/13:
- Replace text "Mediatek" with "MediaTek" in Kconfig
- Replace "first break and then return" with "return directly" in "mt6370_check_vendor_info()"
- Add module name related description in Kconfig helptext
- Add Copyright in the source code
- Add header file "mt6370.h" for all "#define IRQ"
- Adjust Makefile order of MT6370
- Refine "bank_idx" and "bank_addr" in "mt6375_regmap_read()" / "mt6375_regmap_write()"
- Refine redundant "else if" in "mt6370_regmap_read()"

- In patch 08/13:
- Replace text "Mediatek" with "MediaTek" in Kconfig
- Replace "first ret=regulator_(dis/en)able and then return" with "return directly" in "mt6370_tcpc_set_vbus()"
- Replace header file <linux/of.h> with <linux/mod_devicetable.h>
- Add Copyright in the source code
- Add module name related description in Kconfig helptext
- Remove header file <linux/of.h>
- Refine all probe error by using dev_err_probe()

- In patch 09/13:
- Replace text "Mediatek" with "MediaTek"
- Replace all "first dev_err() and then return" with "return dev_err_probe()"
- Add Copyright in the source code
- Add module name related description in Kconfig
- Add unit suffix of macro "ADC_CONV_POLLING_TIME"
- Add new macro "ADC_CONV_TIME_MS"
- Adjust the position of include file <mediatek,mt6370_adc.h>
- Adjust the postions between <linux/module.h> and <linux/mod_devicetable.h>
- Fix some incorrect characters

- In patch 10/13:
- Replace text "Mediatek" with "MediaTek" in Kconfig and MODULE_DESCRIPTION()
- Replace "mt6370_chg_val_to_reg" and "mt6370_chg_reg_to_val" with "linear_range" API
- Replace "first break and then return" with "return directly" in all cases of get/set power_supply_property
- Replace all "first dev_err() and then return" with "return dev_err_probe()"
- Replace all "return IS_ERR(priv->rdev) ? PTR_ERR(priv->rdev) : 0" with "PTR_ERR_OR_ZERO()"
- Replace "priv->dev->of_node" with "dev_of_node()"
- Add Copyright in the source code
- Add module name related description in Kconfig helptext
- Add proper unit of "MT6370_MIVR_IBUS_TH"
- Add error check in "mt6370_chg_get_status"
- Remove including <mediatek,mt6370_adc.h> header file
- Remove redundant comma of every enum terminator line
- Remove unwanted blank lines
- Remove the useless label (toggle_cfo_exit:)
- Remove using atomic
- Remove using of_match_ptr()
- Fix some incorrect characters
- Fix updating wrong bits when using ena_gpiod of OTG regulator
- Adjust the probe order in probe()

- In patch 11/13:
- Replace text "Mediatek" with "MediaTek" in Kconfig
- Replace text "const" with "constant" in Kconfig
- Add Copyright in the source code

- In patch 12/13:
- Replace text "Mediatek" with "MediaTek" in Kconfig
- Add Copyright in the source code

- In patch 13/13:
- Replace text "Mediatek" with "MediaTek" in Kconfig
- Add Copyright in the source code
- Revise the comment of "PWM HYS STEPS"

Changes in v3:
- Remove ADC ABI file, which is added in v2 Patch 7
- In patch 02/14:
- Add items and remove maxItems of io-channels
- Add io-channel-names and describe each item
- Add "unevaluatedProperties: false" in "usb-otg-vbus-regulator"
- Rename "enable-gpio" to "enable-gpios" in "usb-otg-vbus-regulator"
- In patch 03/14:
- Use leds-class-multicolor.yaml instead of common.yaml.
- Split multi-led and led node.
- Add subdevice "led" in "multi-led".
- In patch 04/14:
- Remove the description of enum.
- In patch 05/14:
- Rename "mediatek,bled-pwm-hys-input-threshold-steps" to "mediatek,bled-pwm-hys-input-th-steps"
- Refine "bled-pwm-hys-input-th-steps", "bled-ovp-microvolt", "bled-ocp-microamp" enum values
- In patch 06/14:
- Use " in entire patchset
- Refine ADC description
- Rename "enable-gpio" to "enable-gpios" in "regualtor"
- In patch 07/14:
- Refine Kconfig help text
- Refine error message of unknown vendor ID in mt6370_check_vendor_info()
- Refine return value handling of mt6370_regmap_read()
- Refine all probe error by using dev_err_probe()
- Refine "bank_idx" and "bank_addr" in mt6370_regmap_read() and mt6370_regmap_write()
- Add "#define VENID*" and drop the comments in mt6370_check_vendor_info()
- Drop "MFD" in MODULE_DESCRIPTION()
- In patch 09/14:
- Refine Kconfig help text
- In patch 10/14:
- Refine Kconfig help text
- Refine all channel value in read_scale()
a. current: uA --> mA
b. voltage: uV --> mV
c. temperature: degrees Celsius --> milli degrees Celsius
- Add "default:" condition of switch statement in read_scale() and read_raw()
- Add error message for reading ADC register failed
- Add the comment for adc_lock
- Add <linux/mod_devicetable.h> header file for struct of_device_id
- Replace "adc" text with "ADC" in all of the error messages
- In patch 12/14:
- Refine the grammer of the Kconfig.
- Change reg mode to the const current mode.
- In patch 14/14:
- Refine bool properties parsing (pwm-enable, ovp-shutdown, ocp-shutdown) in DT parsing function
- Refine u32 and u8 properties parsing (pwm-hys-input-th-steps, ovp-microvolt, ocp-microamp), from using register value to using actual value
- Refine error string of "channle-use" parsing failed
- Refine Kconfig help text

Changes in v2:
- In patch 01/15:
- Add "unevaluatedProperties: false".
- Delete "DT bindings".
- Refine the description to fit in 80 columns.
- Skip the connector description.
- In patch 02/15:
- Refine items description of interrupt-name
- Rename "usb-otg-vbus" to "usb-otg-vbus-regulator"
- Add constraint properties for ADC
- In patch 03/15:
- Skip not useful description of "^(multi-)?led@[0-3]$" and reg.
- Due to the dependency, remove the mention of mfd document directory.
- Delete Soft-start property. In design aspect, we think soft-restart should always be enabled, our new chip has deleted the related setting register , also, we don’t allow user adjust this parameter in this chip.
- Refine the commit message.
- In patch 04/15:
- Skip not useful description of "^led@[0-1]$" and reg.
- Add apace after '#'.
- Refine the commit message.
- In patch 05/15:
- Remove "binding documentation" in subject title
- Refine description of mt6370 backlight binding document
- Refine properties name(bled-pwm-hys-input-bit, bled-ovp-microvolt, bled-ocp-microamp) and their description
- In patch 06/15:
- Refine ADC and Regulator descriptions
- Refine include header usage in example
- Refine node name to generic node name("pmic@34")
- Refine led example indentation
- Refine license of mediatek,mt6370_adc.h
- Rename the dts example from IRQ define to number.
- Remove mediatek,mt6370.h
- In patch 07/15:
- Add ABI documentation for mt6370 non-standard ADC sysfs interfaces.
- In patch 08/15:
- Add all IRQ define into mt6370.c.
- Refine include header usage
- In patch 09/15:
- No changes.
- In patch 10/15:
- Use 'gpiod_get_from_of_node' to replace 'fwnode_gpiod_get_index'.
- In patch 11/15:
- Refine Kconfig mt6370 help text
- Refine mask&shift to FIELD_PREP()
- Refine mutex lock name ("lock" -> "adc_lock")
- Refine mt6370_adc_read_scale()
- Refine mt6370_adc_read_offset()
- Refine mt6370_channel_labels[] by using enum to index chan spec
- Refine MT6370_ADC_CHAN()
- Refine indio_dev->name
- Remove useless include header files
- In patch 12/15:

	- Refine mt6370_chg_otg_rdesc.of_match
	  ("mt6370,otg-vbus" -> "usb-otg-vbus-regulator") to match
	  DT binding

- In patch 13/15:
- Refine Kconfig description.
- Remove include "linux/of.h" and use "linux/mod_devicetable.h".
- Place a comma for the last element of the const unsigned int array.
- Add a comment line for the mutex 'lock'.
- In probe function, use 'dev_err_probe' in some judgement to reduce the LOC.
- Refine include header usage.
BIT/GENMASK -> linux/bits.h
FIELD_GET -> linux/bitfield.h
- In patch 14/15:
- Add blank line.
- Replace container_of() with to_mt6370_led() .
- Refine description of ramping.
- Refine the mt6370_init_common_properties function.
- Refine the probe return.
- In patch 15/15:
- Refine MT6370 help text in Kconfig
- Refine DT Parse function
- Remove useless enum
- Add comment for 6372 backward compatible in bl_update_status() and
check_vendor_info()
- Using dev_err_probe(); insteads dev_err()&return; in the probe()

Alice Chen (2):
dt-bindings: leds: Add MediaTek MT6370 flashlight
leds: flash: mt6370: Add MediaTek MT6370 flashlight support

ChiYuan Huang (7):
dt-bindings: usb: Add MediaTek MT6370 TCPC
dt-bindings: leds: mt6370: Add MediaTek MT6370 current sink type LED
indicator
dt-bindings: backlight: Add MediaTek MT6370 backlight
dt-bindings: mfd: Add MediaTek MT6370
mfd: mt6370: Add MediaTek MT6370 support
usb: typec: tcpci_mt6370: Add MediaTek MT6370 tcpci driver
leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator
support

ChiaEn Wu (4):
dt-bindings: power: supply: Add MediaTek MT6370 Charger
iio: adc: mt6370: Add MediaTek MT6370 support
power: supply: mt6370: Add MediaTek MT6370 charger driver
video: backlight: mt6370: Add MediaTek MT6370 support

 .../leds/backlight/mediatek,mt6370-backlight.yaml  |   92 ++
 .../bindings/leds/mediatek,mt6370-flashlight.yaml  |   41 +
 .../bindings/leds/mediatek,mt6370-indicator.yaml   |   81 ++
 .../devicetree/bindings/mfd/mediatek,mt6370.yaml   |  280 ++++++
 .../power/supply/mediatek,mt6370-charger.yaml      |   88 ++
 .../bindings/usb/mediatek,mt6370-tcpc.yaml         |   36 +
 drivers/iio/adc/Kconfig                            |   12 +
 drivers/iio/adc/Makefile                           |    1 +
 drivers/iio/adc/mt6370-adc.c                       |  274 ++++++
 drivers/leds/flash/Kconfig                         |   12 +
 drivers/leds/flash/Makefile                        |    1 +
 drivers/leds/flash/leds-mt6370-flash.c             |  633 ++++++++++++
 drivers/leds/rgb/Kconfig                           |   13 +
 drivers/leds/rgb/Makefile                          |    1 +
 drivers/leds/rgb/leds-mt6370-rgb.c                 | 1004 ++++++++++++++++++++
 drivers/mfd/Kconfig                                |   16 +
 drivers/mfd/Makefile                               |    1 +
 drivers/mfd/mt6370.c                               |  281 ++++++
 drivers/mfd/mt6370.h                               |   99 ++
 drivers/power/supply/Kconfig                       |   14 +
 drivers/power/supply/Makefile                      |    1 +
 drivers/power/supply/mt6370-charger.c              |  973 +++++++++++++++++++
 drivers/usb/typec/tcpm/Kconfig                     |   11 +
 drivers/usb/typec/tcpm/Makefile                    |    1 +
 drivers/usb/typec/tcpm/tcpci_mt6370.c              |  208 ++++
 drivers/video/backlight/Kconfig                    |   12 +
 drivers/video/backlight/Makefile                   |    1 +
 drivers/video/backlight/mt6370-backlight.c         |  339 +++++++
 include/dt-bindings/iio/adc/mediatek,mt6370_adc.h  |   18 +
 29 files changed, 4544 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml
 create mode 100644 Documentation/devicetree/bindings/leds/mediatek,mt6370-flashlight.yaml
 create mode 100644 Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml
 create mode 100644 Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml
 create mode 100644 Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
 create mode 100644 Documentation/devicetree/bindings/usb/mediatek,mt6370-tcpc.yaml
 create mode 100644 drivers/iio/adc/mt6370-adc.c
 create mode 100644 drivers/leds/flash/leds-mt6370-flash.c
 create mode 100644 drivers/leds/rgb/leds-mt6370-rgb.c
 create mode 100644 drivers/mfd/mt6370.c
 create mode 100644 drivers/mfd/mt6370.h
 create mode 100644 drivers/power/supply/mt6370-charger.c
 create mode 100644 drivers/usb/typec/tcpm/tcpci_mt6370.c
 create mode 100644 drivers/video/backlight/mt6370-backlight.c
 create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6370_adc.h
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH v6 1/13 dt-bindings: usb: Add MediaTek MT6370 TCPC

From: ChiYuan Huang <[email protected]>

Add MediaTek MT6370 TCPC binding documentation.

---
 .../bindings/usb/mediatek,mt6370-tcpc.yaml         | 36 ++++++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/usb/mediatek,mt6370-tcpc.yaml
Documentation/devicetree/bindings/usb/mediatek,mt6370-tcpc.yaml new file +36 -0
new file mode 100644
index 0000000..72f56cc
@@ -0,0 +1,36 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/usb/mediatek,mt6370-tcpc.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: MediatTek MT6370 Type-C Port Switch and Power Delivery controller
+
+maintainers:
+  - ChiYuan Huang <[email protected]>
+
+description: |
+  MediaTek MT6370 is a multi-functional device.
+  It integrates charger, ADC, flash, RGB indicators,
+  regulators (DSV/VIBLDO), and TypeC Port Switch with Power Delivery controller.
+  This document only describes MT6370 Type-C Port Switch and
+  Power Delivery controller.
+
+properties:
+  compatible:
+    enum:
+      - mediatek,mt6370-tcpc
+
+  interrupts:
+    maxItems: 1
+
+  connector:
+    type: object
+    $ref: /schemas/connector/usb-connector.yaml#
+    unevaluatedProperties: false
+
+additionalProperties: false
+
+required:
+  - compatible
+  - interrupts
Signature · 1 line
2.7.4
author
#2 lore raw

PATCH v6 2/13 dt-bindings: power: supply: Add MediaTek MT6370 Charger

In reply to ChiaEn Wu

From: ChiaEn Wu <[email protected]>

Add MediaTek MT6370 Charger binding documentation.

---
 .../power/supply/mediatek,mt6370-charger.yaml      | 88 ++++++++++++++++++++++
 1 file changed, 88 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml new file +88 -0
new file mode 100644
index 0000000..bd09a0a
@@ -0,0 +1,88 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/power/supply/mediatek,mt6370-charger.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek MT6370 Battery Charger
+
+maintainers:
+  - ChiaEn Wu <[email protected]>
+
+description: |
+  This module is part of the MT6370 MFD device.
+  Provides Battery Charger, Boost for OTG devices and BC1.2 detection.
+
+properties:
+  compatible:
+    const: mediatek,mt6370-charger
+
+  interrupts:
+    description: |
+      Specify what irqs are needed to be handled by MT6370 Charger driver. IRQ
+      "MT6370_IRQ_CHG_MIVR", "MT6370_IRQ_ATTACH" and "MT6370_IRQ_OVPCTRL_UVP_D"
+      are required.
+    items:
+      - description: BC1.2 done irq
+      - description: usb plug in irq
+      - description: mivr irq
+
+  interrupt-names:
+    items:
+      - const: attach_i
+      - const: uvp_d_evt
+      - const: mivr
+
+  io-channels:
+    description: |
+      Use ADC channel to read VBUS, IBUS, IBAT, etc., info.
+    minItems: 1
+    items:
+      - description: |
+          VBUS voltage with lower accuracy (+-75mV) but higher measure
+          range (1~22V)
+      - description: |
+          VBUS voltage with higher accuracy (+-30mV) but lower measure
+          range (1~9.76V)
+      - description: the main system input voltage
+      - description: battery voltage
+      - description: battery temperature-sense input voltage
+      - description: IBUS current (required)
+      - description: battery current
+      - description: |
+          regulated output voltage to supply for the PWM low-side gate driver
+          and the bootstrap capacitor
+      - description: IC junction temperature
+
+  io-channel-names:
+    minItems: 1
+    items:
+      - const: vbusdiv5
+      - const: vbusdiv2
+      - const: vsys
+      - const: vbat
+      - const: ts_bat
+      - const: ibus
+      - const: ibat
+      - const: chg_vddp
+      - const: temp_jc
+
+  usb-otg-vbus-regulator:
+    type: object
+    description: OTG boost regulator.
+    unevaluatedProperties: false
+    $ref: /schemas/regulator/regulator.yaml#
+
+    properties:
+      enable-gpios:
+        maxItems: 1
+
+required:
+  - compatible
+  - interrupts
+  - interrupt-names
+  - io-channels
+
+additionalProperties: false
+
+...
Signature · 1 line
2.7.4
author
#3 lore raw

PATCH v6 3/13 dt-bindings: leds: mt6370: Add MediaTek MT6370 current sink type LED indicator

In reply to ChiaEn Wu

From: ChiYuan Huang <[email protected]>

Add MediaTek MT6370 current sink type LED indicator binding documentation.

---

v6
- Add 'reg' property of led of multi-led to prevent checking error.

---
 .../bindings/leds/mediatek,mt6370-indicator.yaml   | 81 ++++++++++++++++++++++
 1 file changed, 81 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml
Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml new file +81 -0
new file mode 100644
index 0000000..204b103
@@ -0,0 +1,81 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/mediatek,mt6370-indicator.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: LED driver for MT6370 PMIC from MediaTek Integrated.
+
+maintainers:
+  - Alice Chen <[email protected]>
+
+description: |
+  This module is part of the MT6370 MFD device.
+  Add MT6370 LED driver include 4-channel RGB LED support Register/PWM/Breath Mode
+
+allOf:
+  - $ref: leds-class-multicolor.yaml#
+
+properties:
+  compatible:
+    const: mediatek,mt6370-indicator
+
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 0
+
+patternProperties:
+  "^multi-led@[0-3]$":
+    type: object
+
+    properties:
+      reg:
+        enum: [0, 1, 2, 3]
+
+      "#address-cells":
+        const: 1
+
+      "#size-cells":
+        const: 0
+
+    patternProperties:
+      "^led@[0-2]$":
+        type: object
+        $ref: common.yaml#
+        unevaluatedProperties: false
+
+        properties:
+          reg:
+            enum: [0, 1, 2]
+
+        required:
+          - reg
+          - color
+
+    required:
+      - reg
+      - color
+      - "#address-cells"
+      - "#size-cells"
+
+  "^led@[0-3]$":
+    type: object
+    $ref: common.yaml#
+    unevaluatedProperties: false
+
+    properties:
+      reg:
+        enum: [0, 1, 2, 3]
+
+    required:
+      - reg
+      - color
+
+required:
+  - compatible
+  - "#address-cells"
+  - "#size-cells"
+
+additionalProperties: false
Signature · 1 line
2.7.4
author
#4 lore raw

PATCH v6 4/13 dt-bindings: leds: Add MediaTek MT6370 flashlight

In reply to ChiaEn Wu

From: Alice Chen <[email protected]>

Add MediaTek MT6370 flashlight binding documentation.

---
 .../bindings/leds/mediatek,mt6370-flashlight.yaml  | 41 ++++++++++++++++++++++
 1 file changed, 41 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/mediatek,mt6370-flashlight.yaml
Documentation/devicetree/bindings/leds/mediatek,mt6370-flashlight.yaml new file +41 -0
new file mode 100644
index 0000000..e9d02ed
@@ -0,0 +1,41 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/mediatek,mt6370-flashlight.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Flash LED driver for MT6370 PMIC from MediaTek Integrated.
+
+maintainers:
+  - Alice Chen <[email protected]>
+
+description: |
+  This module is part of the MT6370 MFD device.
+  Add MT6370 flash LED driver include 2-channel flash LED support Torch/Strobe Mode.
+
+properties:
+  compatible:
+    const: mediatek,mt6370-flashlight
+
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 0
+
+patternProperties:
+  "^led@[0-1]$":
+    type: object
+    $ref: common.yaml#
+    unevaluatedProperties: false
+
+    properties:
+      reg:
+        enum: [0, 1]
+
+required:
+  - compatible
+  - "#address-cells"
+  - "#size-cells"
+
+additionalProperties: false
Signature · 1 line
2.7.4
#5 lore raw

Re: [PATCH v6 04/13] dt-bindings: leds: Add MediaTek MT6370 flashlight

Quoted 6 lines · ChiaEn Wu

From: Alice Chen <[email protected]>

Add MediaTek MT6370 flashlight binding documentation.

You'll need to get sign-offs right... And review from dt people before this can be applied.

Best regards,

								Pavel
								-- 

People of Russia, stop Putin before his war on Ukraine escalates.

author
#6 lore raw

PATCH v6 5/13 dt-bindings: backlight: Add MediaTek MT6370 backlight

In reply to ChiaEn Wu

From: ChiYuan Huang <[email protected]>

Add MT6370 backlight binding documentation.

---
 .../leds/backlight/mediatek,mt6370-backlight.yaml  | 92 ++++++++++++++++++++++
 1 file changed, 92 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml
Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml new file +92 -0
new file mode 100644
index 0000000..d674212
@@ -0,0 +1,92 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/backlight/mediatek,mt6370-backlight.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek MT6370 Backlight
+
+maintainers:
+  - ChiaEn Wu <[email protected]>
+
+description: |
+  This module is part of the MT6370 MFD device.
+  The MT6370 Backlight WLED driver supports up to a 29V output voltage for
+  4 channels of 8 series WLEDs. Each channel supports up to 30mA of current
+  capability with 2048 current steps (11 bits) in exponential or linear
+  mapping curves.
+
+allOf:
+  - $ref: common.yaml#
+
+properties:
+  compatible:
+    const: mediatek,mt6370-backlight
+
+  default-brightness:
+    minimum: 0
+    maximum: 2048
+
+  max-brightness:
+    minimum: 0
+    maximum: 2048
+
+  enable-gpios:
+    description: External backlight 'enable' pin
+    maxItems: 1
+
+  mediatek,bled-pwm-enable:
+    description: |
+      Enable external PWM input for backlight dimming
+    type: boolean
+
+  mediatek,bled-pwm-hys-enable:
+    description: |
+      Enable the backlight input-hysteresis for PWM mode
+    type: boolean
+
+  mediatek,bled-pwm-hys-input-th-steps:
+    $ref: /schemas/types.yaml#/definitions/uint8
+    enum: [1, 4, 16, 64]
+    description: |
+      The selection of the upper and lower bounds threshold of backlight
+      PWM resolution. If we choose selection 64, the variation of PWM
+      resolution needs more than 64 steps.
+
+  mediatek,bled-ovp-shutdown:
+    description: |
+      Enable the backlight shutdown when OVP level triggered
+    type: boolean
+
+  mediatek,bled-ovp-microvolt:
+    enum: [17000000, 21000000, 25000000, 29000000]
+    description: |
+      Backlight OVP level selection.
+
+  mediatek,bled-ocp-shutdown:
+    description: |
+      Enable the backlight shutdown when OCP level triggerred.
+    type: boolean
+
+  mediatek,bled-ocp-microamp:
+    enum: [900000, 1200000, 1500000, 1800000]
+    description: |
+      Backlight OC level selection.
+
+  mediatek,bled-channel-use:
+    $ref: /schemas/types.yaml#/definitions/uint8
+    description: |
+      Backlight LED channel to be used.
+      Each bit mapping to:
+        - 0: CH4
+        - 1: CH3
+        - 2: CH2
+        - 3: CH1
+    minimum: 1
+    maximum: 15
+
+required:
+  - compatible
+  - mediatek,bled-channel-use
+
+additionalProperties: false
Signature · 1 line
2.7.4
author
#7 lore raw

Re: [PATCH v6 05/13] dt-bindings: backlight: Add MediaTek MT6370 backlight

Quoted 4 lines · ChiaEn Wu

---

[snip]

Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml line 33

Quoted 11 lines
Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml new file +11 -0
+  compatible:
+    const: mediatek,mt6370-backlight
+
+  default-brightness:
+    minimum: 0
+    maximum: 2048
+
+  max-brightness:
+    minimum: 0
+    maximum: 2048
+

Hi Rob, Krzysztof,

First, I'm so sorry for our SoB writing wrong, I'll fix it in the next patch. Because of this mail thread
(https://lore.kernel.org/all/[email protected]/),
I would like to discuss with you that I may change the following in this DT document, I am not sure whether you agree or not.

1. Add some descriptions about MT6372, which supports 16384 steps (14 bits) and is different from MT6370/MT6371 (2048 steps, 11 bits)
2. Modify the format of 'compatible' as follows to distinguish between MT6370/MT6371 or MT6372
------------------------------------------
properties:
compatible:
enum:
- mediatek,mt6370-backlight
- mediatek,mt6372-backlight
------------------------------------------

3. Remove the 'maximum' value of 'default-brightness' and 'max-brightness', and add "if-else" to determine the "maximum" value as follows
------------------------------------------
default-brightness:
minimum: 0

max-brightness:
minimum: 0

...

if:
properties:
compatible:
contains:
const: mediatek,mt6372-backlight

then:
properties:

    default-brightness:
      maximum: 16384

    max-brightness:
      maximum: 16384

else:
properties:

    default-brightness:
      maximum: 2048

    max-brightness:
      maximum: 2048

------------------------------------------

4. Add a new boolean property to allow the user to determine whether to enable the exponential mode of backlight brightness or not. Like this,
------------------------------------------
mediatek,bled-exponential-mode-enable:
description: |
Enable the exponential mode of backlight brightness. If this property is not enabled, the default is to use linear mode.
type: boolean
------------------------------------------

I hope these changes I have added will meet your expectations. And I'm not sure if I should remove 'Reviewed-By' first until it passes your review.
Thanks.

Signature · 2 lines
Best Regards,
ChiaEn Wu
author
#8 lore raw

PATCH v6 6/13 dt-bindings: mfd: Add MediaTek MT6370

In reply to ChiaEn Wu

From: ChiYuan Huang <[email protected]>

Add MediaTek MT6370 binding documentation.

---
 .../devicetree/bindings/mfd/mediatek,mt6370.yaml   | 280 +++++++++++++++++++++
 include/dt-bindings/iio/adc/mediatek,mt6370_adc.h  |  18 ++
 2 files changed, 298 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml
 create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6370_adc.h
Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml new file +280 -0
new file mode 100644
index 0000000..410e2d4
@@ -0,0 +1,280 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/mediatek,mt6370.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek MT6370 SubPMIC
+
+maintainers:
+  - ChiYuan Huang <[email protected]>
+
+description: |
+  MT6370 is a highly-integrated smart power management IC, which includes a
+  single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C &
+  Power Delivery (PD) controller, dual flash LED current sources, a RGB LED
+  driver, a backlight WLED driver, a display bias driver and a general LDO for
+  portable devices.
+
+properties:
+  compatible:
+    const: mediatek,mt6370
+
+  reg:
+    maxItems: 1
+
+  wakeup-source: true
+
+  interrupts:
+    maxItems: 1
+
+  interrupt-controller: true
+
+  "#interrupt-cells":
+    const: 1
+
+  adc:
+    type: object
+    description: |
+      Provides 9 channels for system monitoring, including VBUSDIV5 (lower
+      accuracy, higher measure range), VBUSDIV2 (higher accuracy, lower
+      measure range), VBAT, VSYS, CHG_VDDP, TS_BAT, IBUS, IBAT, and TEMP_JC.
+
+    properties:
+      compatible:
+        const: mediatek,mt6370-adc
+
+      "#io-channel-cells":
+        const: 1
+
+    required:
+      - compatible
+      - "#io-channel-cells"
+
+  backlight:
+    type: object
+    $ref: /schemas/leds/backlight/mediatek,mt6370-backlight.yaml#
+
+  charger:
+    type: object
+    $ref: /schemas/power/supply/mediatek,mt6370-charger.yaml#
+
+  tcpc:
+    type: object
+    $ref: /schemas/usb/mediatek,mt6370-tcpc.yaml#
+
+  indicator:
+    type: object
+    $ref: /schemas/leds/mediatek,mt6370-indicator.yaml#
+
+  flashlight:
+    type: object
+    $ref: /schemas/leds/mediatek,mt6370-flashlight.yaml#
+
+  regulators:
+    type: object
+    description: |
+      List all supported regulators, which support the control for DisplayBias
+      voltages and one general purpose LDO which commonly used to drive the
+      vibrator.
+
+    patternProperties:
+      "^(dsvbst|vibldo)$":
+        $ref: /schemas/regulator/regulator.yaml#
+        type: object
+        unevaluatedProperties: false
+
+      "^(dsvpos|dsvneg)$":
+        $ref: /schemas/regulator/regulator.yaml#
+        type: object
+        unevaluatedProperties: false
+
+        properties:
+          enable-gpios:
+            maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - interrupt-controller
+  - "#interrupt-cells"
+  - regulators
+  - adc
+  - backlight
+  - indicator
+  - tcpc
+  - charger
+  - flashlight
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/leds/common.h>
+    #include <dt-bindings/iio/adc/mediatek,mt6370_adc.h>
+    #include <dt-bindings/usb/pd.h>
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+        pmic@34 {
+        compatible = "mediatek,mt6370";
+        reg = <0x34>;
+        wakeup-source;
+        interrupts-extended = <&gpio26 3 IRQ_TYPE_LEVEL_LOW>;
+        interrupt-controller;
+        #interrupt-cells = <1>;
+
+        mt6370_adc: adc {
+          compatible = "mediatek,mt6370-adc";
+          #io-channel-cells = <1>;
+        };
+
+        backlight {
+          compatible = "mediatek,mt6370-backlight";
+          mediatek,bled-channel-use = /bits/ 8 <15>;
+        };
+
+        charger {
+          compatible = "mediatek,mt6370-charger";
+          interrupts = <48>, <68>, <6>;
+          interrupt-names = "attach_i", "uvp_d_evt", "mivr";
+          io-channels = <&mt6370_adc MT6370_CHAN_IBUS>;
+
+          mt6370_otg_vbus: usb-otg-vbus-regulator {
+            regulator-name = "mt6370-usb-otg-vbus";
+            regulator-min-microvolt = <4350000>;
+            regulator-max-microvolt = <5800000>;
+            regulator-min-microamp = <500000>;
+            regulator-max-microamp = <3000000>;
+          };
+        };
+
+        indicator {
+          compatible = "mediatek,mt6370-indicator";
+          #address-cells = <1>;
+          #size-cells = <0>;
+
+          multi-led@0 {
+            reg = <0>;
+            function = LED_FUNCTION_INDICATOR;
+            color = <LED_COLOR_ID_RGB>;
+            led-max-microamp = <24000>;
+            #address-cells = <1>;
+            #size-cells = <0>;
+            led@0 {
+              reg = <0>;
+              color = <LED_COLOR_ID_RED>;
+            };
+            led@1 {
+              reg = <1>;
+              color = <LED_COLOR_ID_GREEN>;
+            };
+            led@2 {
+              reg = <2>;
+              color = <LED_COLOR_ID_BLUE>;
+            };
+          };
+          led@3 {
+            reg = <3>;
+            function = LED_FUNCTION_INDICATOR;
+            color = <LED_COLOR_ID_WHITE>;
+            led-max-microamp = <6000>;
+          };
+        };
+
+        flashlight {
+          compatible = "mediatek,mt6370-flashlight";
+          #address-cells = <1>;
+          #size-cells = <0>;
+          led@0 {
+            reg = <0>;
+            led-sources = <0>;
+            function = LED_FUNCTION_FLASH;
+            color = <LED_COLOR_ID_WHITE>;
+            function-enumerator = <1>;
+            led-max-microamp = <200000>;
+            flash-max-microamp = <500000>;
+            flash-max-timeout-us = <1248000>;
+          };
+          led@1 {
+            reg = <1>;
+            led-sources = <1>;
+            function = LED_FUNCTION_FLASH;
+            color = <LED_COLOR_ID_WHITE>;
+            function-enumerator = <2>;
+            led-max-microamp = <200000>;
+            flash-max-microamp = <500000>;
+            flash-max-timeout-us = <1248000>;
+          };
+        };
+
+        tcpc {
+          compatible = "mediatek,mt6370-tcpc";
+          interrupts-extended = <&gpio26 4 IRQ_TYPE_LEVEL_LOW>;
+
+          connector {
+            compatible = "usb-c-connector";
+            label = "USB-C";
+            vbus-supply = <&mt6370_otg_vbus>;
+            data-role = "dual";
+            power-role = "dual";
+            try-power-role = "sink";
+            source-pdos = <PDO_FIXED(5000, 1000, PDO_FIXED_DUAL_ROLE | PDO_FIXED_DATA_SWAP)>;
+            sink-pdos = <PDO_FIXED(5000, 2000, PDO_FIXED_DUAL_ROLE | PDO_FIXED_DATA_SWAP)>;
+            op-sink-microwatt = <10000000>;
+
+            ports {
+              #address-cells = <1>;
+              #size-cells = <0>;
+
+              port@0 {
+                reg = <0>;
+                endpoint {
+                  remote-endpoint = <&usb_hs>;
+                };
+              };
+              port@1 {
+                reg = <1>;
+                endpoint {
+                  remote-endpoint = <&usb_ss>;
+                };
+              };
+              port@2 {
+                reg = <2>;
+                endpoint {
+                  remote-endpoint = <&dp_aux>;
+                };
+              };
+            };
+          };
+        };
+
+        regulators {
+          dsvbst {
+            regulator-name = "mt6370-dsv-vbst";
+            regulator-min-microvolt = <4000000>;
+            regulator-max-microvolt = <6200000>;
+          };
+          dsvpos {
+            regulator-name = "mt6370-dsv-vpos";
+            regulator-min-microvolt = <4000000>;
+            regulator-max-microvolt = <6000000>;
+            regulator-boot-on;
+          };
+          dsvneg {
+            regulator-name = "mt6370-dsv-vneg";
+            regulator-min-microvolt = <4000000>;
+            regulator-max-microvolt = <6000000>;
+            regulator-boot-on;
+          };
+          vibldo {
+            regulator-name = "mt6370-vib-ldo";
+            regulator-min-microvolt = <1600000>;
+            regulator-max-microvolt = <4000000>;
+          };
+        };
+      };
+    };
include/dt-bindings/iio/adc/mediatek,mt6370_adc.h new file +18 -0
new file mode 100644
index 0000000..6ee7255
@@ -0,0 +1,18 @@
+/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */
+
+#ifndef __DT_BINDINGS_MEDIATEK_MT6370_ADC_H__
+#define __DT_BINDINGS_MEDIATEK_MT6370_ADC_H__
+
+/* ADC Channel Index */
+#define MT6370_CHAN_VBUSDIV5	0
+#define MT6370_CHAN_VBUSDIV2	1
+#define MT6370_CHAN_VSYS	2
+#define MT6370_CHAN_VBAT	3
+#define MT6370_CHAN_TS_BAT	4
+#define MT6370_CHAN_IBUS	5
+#define MT6370_CHAN_IBAT	6
+#define MT6370_CHAN_CHG_VDDP	7
+#define MT6370_CHAN_TEMP_JC	8
+#define MT6370_CHAN_MAX		9
+
+#endif
Signature · 1 line
2.7.4
author
#9 lore raw

PATCH v6 7/13 mfd: mt6370: Add MediaTek MT6370 support

In reply to ChiaEn Wu

From: ChiYuan Huang <[email protected]>

This adds support for the MediaTek MT6370 SubPMIC. MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight driver, display bias voltage supply, one general purpose LDO, and the USB Type-C & PD controller complies with the latest USB Type-C and PD standards.

---
 drivers/mfd/Kconfig  |  16 +++
 drivers/mfd/Makefile |   1 +
 drivers/mfd/mt6370.c | 281 +++++++++++++++++++++++++++++++++++++++++++++++++++
 drivers/mfd/mt6370.h |  99 ++++++++++++++++++
 4 files changed, 397 insertions(+)
 create mode 100644 drivers/mfd/mt6370.c
 create mode 100644 drivers/mfd/mt6370.h
drivers/mfd/Kconfig +16 -0
index 3b59456..a9bcae3 100644
@@ -937,6 +937,22 @@ config MFD_MT6360
 	  PMIC part includes 2-channel BUCKs and 2-channel LDOs
 	  LDO part includes 4-channel LDOs
 
+config MFD_MT6370
+	tristate "MediaTek MT6370 SubPMIC"
+	select MFD_CORE
+	select REGMAP_I2C
+	select REGMAP_IRQ
+	depends on I2C
+	help
+	  Say Y here to enable MT6370 SubPMIC functional support.
+	  It consists of a single cell battery charger with ADC monitoring, RGB
+	  LEDs, dual channel flashlight, WLED backlight driver, display bias
+	  voltage supply, one general purpose LDO, and the USB Type-C & PD
+	  controller complies with the latest USB Type-C and PD standards.
+
+	  This driver can also be built as a module. If so, the module
+	  will be called "mt6370".
+
 config MFD_MT6397
 	tristate "MediaTek MT6397 PMIC Support"
 	select MFD_CORE
drivers/mfd/Makefile +1 -0
index 8c69867..81dbed3 100644
@@ -173,6 +173,7 @@ obj-$(CONFIG_MFD_MAX8998)	+= max8998.o max8998-irq.o
 obj-$(CONFIG_MFD_MP2629)	+= mp2629.o
 
 obj-$(CONFIG_MFD_MT6360)	+= mt6360-core.o
+obj-$(CONFIG_MFD_MT6370)	+= mt6370.o
 mt6397-objs			:= mt6397-core.o mt6397-irq.o mt6358-irq.o
 obj-$(CONFIG_MFD_MT6397)	+= mt6397.o
 
drivers/mfd/mt6370.c new file +281 -0

281 lines not on this page · raw message

drivers/mfd/mt6370.h new file +99 -0

99 lines not on this page · raw message

Signature · 1 line
2.7.4
#10 lore raw

Re: [PATCH v6 07/13] mfd: mt6370: Add MediaTek MT6370 support

Quoted 8 lines · ChiaEn Wu

From: ChiYuan Huang <[email protected]>

This adds support for the MediaTek MT6370 SubPMIC. MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight driver, display bias voltage supply, one general purpose LDO, and the USB Type-C & PD controller complies with the latest USB Type-C and PD standards.

...

drivers/mfd/mt6370.c line 28

Quoted 11 lines
drivers/mfd/mt6370.c new file +10 -0
+#define MT6370_REG_DEV_INFO    0x100
+#define MT6370_REG_CHG_IRQ1    0x1C0
+#define MT6370_REG_CHG_MASK1   0x1E0
+
+#define MT6370_VENID_MASK      GENMASK(7, 4)
+
+#define MT6370_NUM_IRQREGS     16
+#define MT6370_USBC_I2CADDR    0x4E
 
+#define MT6370_REG_ADDRLEN     2
+#define MT6370_REG_MAXADDR     0x1FF

These two more logically to have near to other _REG_* definitions above.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
author
#11 lore raw

Re: [PATCH v6 07/13] mfd: mt6370: Add MediaTek MT6370 support

Quoted 1 line · Andy Shevchenko

...

Quoted 10 lines
Quoted 9 lines
drivers/mfd/mt6370.c new file +8 -0
+#define MT6370_REG_DEV_INFO    0x100
+#define MT6370_REG_CHG_IRQ1    0x1C0
+#define MT6370_REG_CHG_MASK1   0x1E0
+
+#define MT6370_VENID_MASK      GENMASK(7, 4)
+
+#define MT6370_NUM_IRQREGS     16
+#define MT6370_USBC_I2CADDR    0x4E
Quoted 4 lines

drivers/mfd/mt6370.c line 28

Quoted 2 lines
drivers/mfd/mt6370.c new file +2 -0
+#define MT6370_REG_ADDRLEN     2
+#define MT6370_REG_MAXADDR     0x1FF

These two more logically to have near to other _REG_* definitions above.

Hi Andy,
Thanks for your review.
Do you mean that we should move '#define MT6370_USBC_I2CADDR' and '#define MT6370_REG_MAXADDR' after the line '#define MT6370_REG_CHG_MASK1'?
-------------------------------------------------------------------

#define MT6370_REG_DEV_INFO    0x100
#define MT6370_REG_CHG_IRQ1    0x1C0
#define MT6370_REG_CHG_MASK1   0x1E0
#define MT6370_USBC_I2CADDR    0x4E
#define MT6370_REG_MAXADDR     0x1FF

#define MT6370_VENID_MASK GENMASK(7, 4)

#define MT6370_NUM_IRQREGS 16
#define MT6370_REG_ADDRLEN 2
-------------------------------------------------------------------
Like this?

Quoted 4 lines

--
With Best Regards,
Andy Shevchenko

Signature · 2 lines
Best Regards,
ChiaEn Wu
#12 lore raw

Re: [PATCH v6 07/13] mfd: mt6370: Add MediaTek MT6370 support

Quoted 2 lines · ChiaEn Wu

On Mon, Jul 25, 2022 at 4:00 PM Andy Shevchenko
<[email protected]> wrote:

...

Quoted 26 lines
Quoted 9 lines
Quoted 8 lines
drivers/mfd/mt6370.c new file +8 -0
+#define MT6370_REG_DEV_INFO    0x100
+#define MT6370_REG_CHG_IRQ1    0x1C0
+#define MT6370_REG_CHG_MASK1   0x1E0
+
+#define MT6370_VENID_MASK      GENMASK(7, 4)
+
+#define MT6370_NUM_IRQREGS     16
+#define MT6370_USBC_I2CADDR    0x4E
Quoted 4 lines

drivers/mfd/mt6370.c line 28

Quoted 2 lines
drivers/mfd/mt6370.c new file +2 -0
+#define MT6370_REG_ADDRLEN     2
+#define MT6370_REG_MAXADDR     0x1FF

These two more logically to have near to other _REG_* definitions above.

Hi Andy,
Thanks for your review.
Do you mean that we should move '#define MT6370_USBC_I2CADDR' and '#define MT6370_REG_MAXADDR' after the line '#define MT6370_REG_CHG_MASK1'?
-------------------------------------------------------------------

#define MT6370_REG_DEV_INFO    0x100
#define MT6370_REG_CHG_IRQ1    0x1C0
#define MT6370_REG_CHG_MASK1   0x1E0
#define MT6370_USBC_I2CADDR    0x4E
#define MT6370_REG_MAXADDR     0x1FF
Quoted 6 lines

#define MT6370_VENID_MASK GENMASK(7, 4)

#define MT6370_NUM_IRQREGS 16
#define MT6370_REG_ADDRLEN 2
-------------------------------------------------------------------
Like this?

You lost me. Namespace has a meaning, i.e. grouping items of a kind. In your proposal I don't see that. If REG_MAXADDR and REG_ADDRLEN are _not_ of the _REG_ kind as per above, why do they have this namespace in the first place?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
author
#13 lore raw

Re: [PATCH v6 07/13] mfd: mt6370: Add MediaTek MT6370 support

Quoted 17 lines · Andy Shevchenko

...

Quoted 14 lines
Quoted 13 lines

drivers/mfd/mt6370.c line 28

Quoted 11 lines
drivers/mfd/mt6370.c new file +10 -0
+#define MT6370_REG_DEV_INFO    0x100
+#define MT6370_REG_CHG_IRQ1    0x1C0
+#define MT6370_REG_CHG_MASK1   0x1E0
+
+#define MT6370_VENID_MASK      GENMASK(7, 4)
+
+#define MT6370_NUM_IRQREGS     16
+#define MT6370_USBC_I2CADDR    0x4E
 
+#define MT6370_REG_ADDRLEN     2
+#define MT6370_REG_MAXADDR     0x1FF

These two more logically to have near to other _REG_* definitions above.

...

Quoted 5 lines

You lost me. Namespace has a meaning, i.e. grouping items of a kind. In your proposal I don't see that. If REG_MAXADDR and REG_ADDRLEN are _not_ of the _REG_ kind as per above, why do they have this namespace in the first place?

oh... Sorry, I just got the wrong meaning
maybe it should be revised like this, right??
-------------------------------------------------------------------

#define MT6370_REG_DEV_INFO    0x100
#define MT6370_REG_CHG_IRQ1    0x1C0
#define MT6370_REG_CHG_MASK1   0x1E0
#define MT6370_REG_MAXADDR     0x1FF // Move it to here

#define MT6370_VENID_MASK GENMASK(7, 4)

#define MT6370_NUM_IRQREGS 16
#define MT6370_USBC_I2CADDR 0x4E

#define MT6370_MAX_ADDRLEN 2 // Rename
-------------------------------------------------------------------

Thanks!

Signature · 2 lines
Best Regards,
ChiaEn Wu
#14 lore raw

Re: [PATCH v6 07/13] mfd: mt6370: Add MediaTek MT6370 support

Quoted 2 lines · ChiaEn Wu

On Mon, Jul 25, 2022 at 4:43 PM Andy Shevchenko
<[email protected]> wrote:

...

Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines

drivers/mfd/mt6370.c line 28

Quoted 11 lines
drivers/mfd/mt6370.c new file +10 -0
+#define MT6370_REG_DEV_INFO    0x100
+#define MT6370_REG_CHG_IRQ1    0x1C0
+#define MT6370_REG_CHG_MASK1   0x1E0
+
+#define MT6370_VENID_MASK      GENMASK(7, 4)
+
+#define MT6370_NUM_IRQREGS     16
+#define MT6370_USBC_I2CADDR    0x4E
 
+#define MT6370_REG_ADDRLEN     2
+#define MT6370_REG_MAXADDR     0x1FF

These two more logically to have near to other _REG_* definitions above.

...

Quoted 7 lines
Quoted 4 lines

You lost me. Namespace has a meaning, i.e. grouping items of a kind. In your proposal I don't see that. If REG_MAXADDR and REG_ADDRLEN are _not_ of the _REG_ kind as per above, why do they have this namespace in the first place?

oh... Sorry, I just got the wrong meaning
maybe it should be revised like this, right??

I don't know. I am not an author of the code, I do not have access (and don't want to) to the hardware datasheets, all up to you. From the style perspective below looks good.

Quoted 12 lines

-------------------------------------------------------------------

#define MT6370_REG_DEV_INFO    0x100
#define MT6370_REG_CHG_IRQ1    0x1C0
#define MT6370_REG_CHG_MASK1   0x1E0
#define MT6370_REG_MAXADDR     0x1FF // Move it to here

#define MT6370_VENID_MASK GENMASK(7, 4)

#define MT6370_NUM_IRQREGS 16
#define MT6370_USBC_I2CADDR 0x4E

#define MT6370_MAX_ADDRLEN 2 // Rename

Signature · 2 lines
With Best Regards,
Andy Shevchenko
author
#15 lore raw

PATCH v6 8/13 usb: typec: tcpci_mt6370: Add MediaTek MT6370 tcpci driver

In reply to ChiaEn Wu

From: ChiYuan Huang <[email protected]>

The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

Add support for the Type-C & Power Delivery controller in MediaTek MT6370 IC.

---

v6
- Convert tcpci as device resource managed with 'devm_add_action_or_reset' API.
- Refine remvoe callback.
- Refine the commit text from 'This commit add' to 'Add'.

---
 drivers/usb/typec/tcpm/Kconfig        |  11 ++
 drivers/usb/typec/tcpm/Makefile       |   1 +
 drivers/usb/typec/tcpm/tcpci_mt6370.c | 208 ++++++++++++++++++++++++++++++++++
 3 files changed, 220 insertions(+)
 create mode 100644 drivers/usb/typec/tcpm/tcpci_mt6370.c
drivers/usb/typec/tcpm/Kconfig +11 -0
index 073fd2e..e6b88ca 100644
@@ -35,6 +35,17 @@ config TYPEC_MT6360
 	  USB Type-C. It works with Type-C Port Controller Manager
 	  to provide USB PD and USB Type-C functionalities.
 
+config TYPEC_TCPCI_MT6370
+	tristate "MediaTek MT6370 Type-C driver"
+	depends on MFD_MT6370
+	help
+	  MediaTek MT6370 is a multi-functional IC that includes
+	  USB Type-C. It works with Type-C Port Controller Manager
+	  to provide USB PD and USB Type-C functionalities.
+
+	  This driver can also be built as a module. The module
+	  will be called "tcpci_mt6370".
+
 config TYPEC_TCPCI_MAXIM
 	tristate "Maxim TCPCI based Type-C chip driver"
 	help
drivers/usb/typec/tcpm/Makefile +1 -0
index 7d499f3..906d9dc 100644
@@ -6,4 +6,5 @@ typec_wcove-y				:= wcove.o
 obj-$(CONFIG_TYPEC_TCPCI)		+= tcpci.o
 obj-$(CONFIG_TYPEC_RT1711H)		+= tcpci_rt1711h.o
 obj-$(CONFIG_TYPEC_MT6360)		+= tcpci_mt6360.o
+obj-$(CONFIG_TYPEC_TCPCI_MT6370)	+= tcpci_mt6370.o
 obj-$(CONFIG_TYPEC_TCPCI_MAXIM)		+= tcpci_maxim.o
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +208 -0

208 lines not on this page · raw message

Signature · 1 line
2.7.4
Reviewed-by on v6 8/13
#16 lore raw

Re: [PATCH v6 08/13] usb: typec: tcpci_mt6370: Add MediaTek MT6370 tcpci driver

Quoted 8 lines · ChiaEn Wu

From: ChiYuan Huang <[email protected]>

The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

Quoted 5 lines

Add support for the Type-C & Power Delivery controller in MediaTek MT6370 IC.

Quoted 259 lines

---

v6
- Convert tcpci as device resource managed with 'devm_add_action_or_reset' API.
- Refine remvoe callback.
- Refine the commit text from 'This commit add' to 'Add'.

---
  drivers/usb/typec/tcpm/Kconfig        |  11 ++
  drivers/usb/typec/tcpm/Makefile       |   1 +
  drivers/usb/typec/tcpm/tcpci_mt6370.c | 208 ++++++++++++++++++++++++++++++++++
  3 files changed, 220 insertions(+)

create mode 100644 drivers/usb/typec/tcpm/tcpci_mt6370.c

drivers/usb/typec/tcpm/Kconfig +11 -0
index 073fd2e..e6b88ca 100644
@@ -35,6 +35,17 @@ config TYPEC_MT6360
  	  USB Type-C. It works with Type-C Port Controller Manager
  	  to provide USB PD and USB Type-C functionalities.
 
+config TYPEC_TCPCI_MT6370
+	tristate "MediaTek MT6370 Type-C driver"
+	depends on MFD_MT6370
+	help
+	  MediaTek MT6370 is a multi-functional IC that includes
+	  USB Type-C. It works with Type-C Port Controller Manager
+	  to provide USB PD and USB Type-C functionalities.
+
+	  This driver can also be built as a module. The module
+	  will be called "tcpci_mt6370".
+
  config TYPEC_TCPCI_MAXIM
  	tristate "Maxim TCPCI based Type-C chip driver"
  	help
drivers/usb/typec/tcpm/Makefile +1 -0
index 7d499f3..906d9dc 100644
@@ -6,4 +6,5 @@ typec_wcove-y				:= wcove.o
  obj-$(CONFIG_TYPEC_TCPCI)		+= tcpci.o
  obj-$(CONFIG_TYPEC_RT1711H)		+= tcpci_rt1711h.o
  obj-$(CONFIG_TYPEC_MT6360)		+= tcpci_mt6360.o
+obj-$(CONFIG_TYPEC_TCPCI_MT6370)	+= tcpci_mt6370.o
  obj-$(CONFIG_TYPEC_TCPCI_MAXIM)		+= tcpci_maxim.o
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +208 -0
new file mode 100644
index 0000000..4f53319
@@ -0,0 +1,208 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2022 Richtek Technology Corp.
+ *
+ * Author: ChiYuan Huang <[email protected]>
+ */
+
+#include <linux/bits.h>
+#include <linux/interrupt.h>
+#include <linux/kernel.h>
+#include <linux/mod_devicetable.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/pm_wakeup.h>
+#include <linux/pm_wakeirq.h>
+#include <linux/regmap.h>
+#include <linux/regulator/consumer.h>
+#include <linux/usb/tcpm.h>
+#include "tcpci.h"
+
+#define MT6370_REG_SYSCTRL8	0x9B
+
+#define MT6370_AUTOIDLE_MASK	BIT(3)
+
+#define MT6370_VENDOR_ID	0x29CF
+#define MT6370_TCPC_DID_A	0x2170
+
+struct mt6370_priv {
+	struct device *dev;
+	struct regulator *vbus;
+	struct tcpci *tcpci;
+	struct tcpci_data tcpci_data;
+};
+
+static const struct reg_sequence mt6370_reg_init[] = {
+	REG_SEQ(0xA0, 0x1, 1000),
+	REG_SEQ(0x81, 0x38, 0),
+	REG_SEQ(0x82, 0x82, 0),
+	REG_SEQ(0xBA, 0xFC, 0),
+	REG_SEQ(0xBB, 0x50, 0),
+	REG_SEQ(0x9E, 0x8F, 0),
+	REG_SEQ(0xA1, 0x5, 0),
+	REG_SEQ(0xA2, 0x4, 0),
+	REG_SEQ(0xA3, 0x4A, 0),
+	REG_SEQ(0xA4, 0x01, 0),
+	REG_SEQ(0x95, 0x01, 0),
+	REG_SEQ(0x80, 0x71, 0),
+	REG_SEQ(0x9B, 0x3A, 1000),
+};
+
+static int mt6370_tcpc_init(struct tcpci *tcpci, struct tcpci_data *data)
+{
+	u16 did;
+	int ret;
+
+	ret = regmap_register_patch(data->regmap, mt6370_reg_init,
+				    ARRAY_SIZE(mt6370_reg_init));
+	if (ret)
+		return ret;
+
+	ret = regmap_raw_read(data->regmap, TCPC_BCD_DEV, &did, sizeof(u16));
+	if (ret)
+		return ret;
+
+	if (did == MT6370_TCPC_DID_A)
+		return regmap_write(data->regmap, TCPC_FAULT_CTRL, 0x80);
+
+	return 0;
+}
+
+static int mt6370_tcpc_set_vconn(struct tcpci *tcpci, struct tcpci_data *data,
+				 bool enable)
+{
+	return regmap_update_bits(data->regmap, MT6370_REG_SYSCTRL8,
+				  MT6370_AUTOIDLE_MASK,
+				  !enable ? MT6370_AUTOIDLE_MASK : 0);
+}
+
+static int mt6370_tcpc_set_vbus(struct tcpci *tcpci, struct tcpci_data *data,
+				bool source, bool sink)
+{
+	struct mt6370_priv *priv = container_of(data, struct mt6370_priv,
+						tcpci_data);
+	int ret;
+
+	ret = regulator_is_enabled(priv->vbus);
+	if (ret < 0)
+		return ret;
+
+	if (ret && !source)
+		return regulator_disable(priv->vbus);
+
+	if (!ret && source)
+		return regulator_enable(priv->vbus);
+
+	return 0;
+}
+
+static irqreturn_t mt6370_irq_handler(int irq, void *dev_id)
+{
+	struct mt6370_priv *priv = dev_id;
+
+	return tcpci_irq(priv->tcpci);
+}
+
+static int mt6370_check_vendor_info(struct mt6370_priv *priv)
+{
+	struct regmap *regmap = priv->tcpci_data.regmap;
+	u16 vid;
+	int ret;
+
+	ret = regmap_raw_read(regmap, TCPC_VENDOR_ID, &vid, sizeof(u16));
+	if (ret)
+		return ret;
+
+	if (vid != MT6370_VENDOR_ID)
+		return dev_err_probe(priv->dev, -ENODEV,
+				     "Vendor ID not correct 0x%02x\n", vid);
+
+	return 0;
+}
+
+static void mt6370_unregister_tcpci_port(void *tcpci)
+{
+	tcpci_unregister_port(tcpci);
+}
+
+static int mt6370_tcpc_probe(struct platform_device *pdev)
+{
+	struct mt6370_priv *priv;
+	struct device *dev = &pdev->dev;
+	int irq, ret;
+
+	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
+	if (!priv)
+		return -ENOMEM;
+
+	priv->dev = dev;
+
+	priv->tcpci_data.regmap = dev_get_regmap(dev->parent, NULL);
+	if (!priv->tcpci_data.regmap)
+		return dev_err_probe(dev, -ENODEV, "Failed to init regmap\n");
+
+	ret = mt6370_check_vendor_info(priv);
+	if (ret)
+		return ret;
+
+	irq = platform_get_irq(pdev, 0);
+	if (irq < 0)
+		return dev_err_probe(dev, irq, "Failed to get irq\n");
+
+	/* Assign TCPCI feature and ops */
+	priv->tcpci_data.auto_discharge_disconnect = 1;
+	priv->tcpci_data.init = mt6370_tcpc_init;
+	priv->tcpci_data.set_vconn = mt6370_tcpc_set_vconn;
+
+	priv->vbus = devm_regulator_get_optional(dev, "vbus");
+	if (!IS_ERR(priv->vbus))
+		priv->tcpci_data.set_vbus = mt6370_tcpc_set_vbus;
+
+	priv->tcpci = tcpci_register_port(dev, &priv->tcpci_data);
+	if (IS_ERR(priv->tcpci))
+		return dev_err_probe(dev, PTR_ERR(priv->tcpci),
+				     "Failed to register tcpci port\n");
+
+	ret = devm_add_action_or_reset(dev, mt6370_unregister_tcpci_port,
+				       priv->tcpci);
+	if (ret)
+		return ret;
+
+	ret = devm_request_threaded_irq(dev, irq, NULL, mt6370_irq_handler,
+					IRQF_ONESHOT, dev_name(dev), priv);
+	if (ret)
+		return dev_err_probe(dev, ret, "Failed to allocate irq\n");
+
+	device_init_wakeup(dev, true);
+	dev_pm_set_wake_irq(dev, irq);
+
+	return 0;
+}
+
+static int mt6370_tcpc_remove(struct platform_device *pdev)
+{
+	dev_pm_clear_wake_irq(&pdev->dev);
+	device_init_wakeup(&pdev->dev, false);
+
+	return 0;
+}
+
+static const struct of_device_id mt6370_tcpc_devid_table[] = {
+	{ .compatible = "mediatek,mt6370-tcpc" },
+	{}
+};
+MODULE_DEVICE_TABLE(of, mt6370_tcpc_devid_table);
+
+static struct platform_driver mt6370_tcpc_driver = {
+	.driver = {
+		.name = "mt6370-tcpc",
+		.of_match_table = mt6370_tcpc_devid_table,
+	},
+	.probe = mt6370_tcpc_probe,
+	.remove = mt6370_tcpc_remove,
+};
+module_platform_driver(mt6370_tcpc_driver);
+
+MODULE_AUTHOR("ChiYuan Huang <[email protected]>");
+MODULE_DESCRIPTION("MT6370 USB Type-C Port Controller Interface Driver");
+MODULE_LICENSE("GPL v2");
maintainer
#17 lore raw

Re: [PATCH v6 08/13] usb: typec: tcpci_mt6370: Add MediaTek MT6370 tcpci driver

In reply to ChiaEn Wu
Quoted 154 lines · ChiaEn Wu

From: ChiYuan Huang <[email protected]>

The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

Add support for the Type-C & Power Delivery controller in MediaTek MT6370 IC.

Reviewed-by AngeloGioacchino Del Regno <

[email protected]>
---

v6
- Convert tcpci as device resource managed with 'devm_add_action_or_reset' API.
- Refine remvoe callback.
- Refine the commit text from 'This commit add' to 'Add'.

---
 drivers/usb/typec/tcpm/Kconfig        |  11 ++
 drivers/usb/typec/tcpm/Makefile       |   1 +
 drivers/usb/typec/tcpm/tcpci_mt6370.c | 208
++++++++++++++++++++++++++++++++++
 3 files changed, 220 insertions(+)
 create mode 100644 drivers/usb/typec/tcpm/tcpci_mt6370.c
drivers/usb/typec/tcpm/Kconfig +11 -0
index 073fd2e..e6b88ca 100644
@@ -35,6 +35,17 @@ config TYPEC_MT6360
 	  USB Type-C. It works with Type-C Port Controller Manager
 	  to provide USB PD and USB Type-C functionalities.
 
+config TYPEC_TCPCI_MT6370
+	tristate "MediaTek MT6370 Type-C driver"
+	depends on MFD_MT6370
+	help
+	  MediaTek MT6370 is a multi-functional IC that includes
+	  USB Type-C. It works with Type-C Port Controller Manager
+	  to provide USB PD and USB Type-C functionalities.
+
+	  This driver can also be built as a module. The module
+	  will be called "tcpci_mt6370".
+
 config TYPEC_TCPCI_MAXIM
 	tristate "Maxim TCPCI based Type-C chip driver"
 	help
drivers/usb/typec/tcpm/Makefile +1 -0
index 7d499f3..906d9dc 100644
@@ -6,4 +6,5 @@ typec_wcove-y				:= wcove.o
 obj-$(CONFIG_TYPEC_TCPCI)		+= tcpci.o
 obj-$(CONFIG_TYPEC_RT1711H)		+= tcpci_rt1711h.o
 obj-$(CONFIG_TYPEC_MT6360)		+= tcpci_mt6360.o
+obj-$(CONFIG_TYPEC_TCPCI_MT6370)	+= tcpci_mt6370.o
 obj-$(CONFIG_TYPEC_TCPCI_MAXIM)		+= tcpci_maxim.o
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +51 -0
new file mode 100644
index 0000000..4f53319
@@ -0,0 +1,208 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2022 Richtek Technology Corp.
+ *
+ * Author: ChiYuan Huang <[email protected]>
+ */
+
+#include <linux/bits.h>
+#include <linux/interrupt.h>
+#include <linux/kernel.h>
+#include <linux/mod_devicetable.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/pm_wakeup.h>
+#include <linux/pm_wakeirq.h>
+#include <linux/regmap.h>
+#include <linux/regulator/consumer.h>
+#include <linux/usb/tcpm.h>
+#include "tcpci.h"
+
+#define MT6370_REG_SYSCTRL8	0x9B
+
+#define MT6370_AUTOIDLE_MASK	BIT(3)
+
+#define MT6370_VENDOR_ID	0x29CF
+#define MT6370_TCPC_DID_A	0x2170
+
+struct mt6370_priv {
+	struct device *dev;
+	struct regulator *vbus;
+	struct tcpci *tcpci;
+	struct tcpci_data tcpci_data;
+};
+
+static const struct reg_sequence mt6370_reg_init[] = {
+	REG_SEQ(0xA0, 0x1, 1000),
+	REG_SEQ(0x81, 0x38, 0),
+	REG_SEQ(0x82, 0x82, 0),
+	REG_SEQ(0xBA, 0xFC, 0),
+	REG_SEQ(0xBB, 0x50, 0),
+	REG_SEQ(0x9E, 0x8F, 0),
+	REG_SEQ(0xA1, 0x5, 0),
+	REG_SEQ(0xA2, 0x4, 0),
+	REG_SEQ(0xA3, 0x4A, 0),
+	REG_SEQ(0xA4, 0x01, 0),
+	REG_SEQ(0x95, 0x01, 0),
+	REG_SEQ(0x80, 0x71, 0),
+	REG_SEQ(0x9B, 0x3A, 1000),
+};
+
+static int mt6370_tcpc_init(struct tcpci *tcpci, struct tcpci_data

*data)

drivers/usb/typec/tcpm/tcpci_mt6370.c new file +10 -0
+{
+	u16 did;
+	int ret;
+
+	ret = regmap_register_patch(data->regmap, mt6370_reg_init,
+				    ARRAY_SIZE(mt6370_reg_init));
+	if (ret)
+		return ret;
+
+	ret = regmap_raw_read(data->regmap, TCPC_BCD_DEV, &did,

sizeof(u16));

drivers/usb/typec/tcpm/tcpci_mt6370.c new file +5 -0
+	if (ret)
+		return ret;
+
+	if (did == MT6370_TCPC_DID_A)
+		return regmap_write(data->regmap, TCPC_FAULT_CTRL,

0x80);

drivers/usb/typec/tcpm/tcpci_mt6370.c new file +5 -0
+
+	return 0;
+}
+
+static int mt6370_tcpc_set_vconn(struct tcpci *tcpci, struct

tcpci_data *data,

drivers/usb/typec/tcpm/tcpci_mt6370.c new file +8 -0
+				 bool enable)
+{
+	return regmap_update_bits(data->regmap, MT6370_REG_SYSCTRL8,
+				  MT6370_AUTOIDLE_MASK,
+				  !enable ? MT6370_AUTOIDLE_MASK : 0);
+}
+
+static int mt6370_tcpc_set_vbus(struct tcpci *tcpci, struct

tcpci_data *data,

drivers/usb/typec/tcpm/tcpci_mt6370.c line 80

Quoted 1 line
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +1 -0
+				bool source, bool sink)

@sink is not used in this function?

Quoted 138 lines
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +2 -0
+{
+	struct mt6370_priv *priv = container_of(data, struct

mt6370_priv,

drivers/usb/typec/tcpm/tcpci_mt6370.c new file +30 -0
+						tcpci_data);
+	int ret;
+
+	ret = regulator_is_enabled(priv->vbus);
+	if (ret < 0)
+		return ret;
+
+	if (ret && !source)
+		return regulator_disable(priv->vbus);
+
+	if (!ret && source)
+		return regulator_enable(priv->vbus);
+
+	return 0;
+}
+
+static irqreturn_t mt6370_irq_handler(int irq, void *dev_id)
+{
+	struct mt6370_priv *priv = dev_id;
+
+	return tcpci_irq(priv->tcpci);
+}
+
+static int mt6370_check_vendor_info(struct mt6370_priv *priv)
+{
+	struct regmap *regmap = priv->tcpci_data.regmap;
+	u16 vid;
+	int ret;
+
+	ret = regmap_raw_read(regmap, TCPC_VENDOR_ID, &vid,

sizeof(u16));

drivers/usb/typec/tcpm/tcpci_mt6370.c new file +6 -0
+	if (ret)
+		return ret;
+
+	if (vid != MT6370_VENDOR_ID)
+		return dev_err_probe(priv->dev, -ENODEV,
+				     "Vendor ID not correct 0x%02x\n",

vid);

drivers/usb/typec/tcpm/tcpci_mt6370.c new file +24 -0
+
+	return 0;
+}
+
+static void mt6370_unregister_tcpci_port(void *tcpci)
+{
+	tcpci_unregister_port(tcpci);
+}
+
+static int mt6370_tcpc_probe(struct platform_device *pdev)
+{
+	struct mt6370_priv *priv;
+	struct device *dev = &pdev->dev;
+	int irq, ret;
+
+	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
+	if (!priv)
+		return -ENOMEM;
+
+	priv->dev = dev;
+
+	priv->tcpci_data.regmap = dev_get_regmap(dev->parent, NULL);
+	if (!priv->tcpci_data.regmap)
+		return dev_err_probe(dev, -ENODEV, "Failed to init

regmap\n");

drivers/usb/typec/tcpm/tcpci_mt6370.c new file +22 -0
+
+	ret = mt6370_check_vendor_info(priv);
+	if (ret)
+		return ret;
+
+	irq = platform_get_irq(pdev, 0);
+	if (irq < 0)
+		return dev_err_probe(dev, irq, "Failed to get irq\n");
+
+	/* Assign TCPCI feature and ops */
+	priv->tcpci_data.auto_discharge_disconnect = 1;
+	priv->tcpci_data.init = mt6370_tcpc_init;
+	priv->tcpci_data.set_vconn = mt6370_tcpc_set_vconn;
+
+	priv->vbus = devm_regulator_get_optional(dev, "vbus");
+	if (!IS_ERR(priv->vbus))
+		priv->tcpci_data.set_vbus = mt6370_tcpc_set_vbus;
+
+	priv->tcpci = tcpci_register_port(dev, &priv->tcpci_data);
+	if (IS_ERR(priv->tcpci))
+		return dev_err_probe(dev, PTR_ERR(priv->tcpci),
+				     "Failed to register tcpci

port\n");

drivers/usb/typec/tcpm/tcpci_mt6370.c new file +2 -0
+
+	ret = devm_add_action_or_reset(dev,

mt6370_unregister_tcpci_port,

drivers/usb/typec/tcpm/tcpci_mt6370.c new file +5 -0
+				       priv->tcpci);
+	if (ret)
+		return ret;
+
+	ret = devm_request_threaded_irq(dev, irq, NULL,

mt6370_irq_handler,

drivers/usb/typec/tcpm/tcpci_mt6370.c new file +1 -0
+					IRQF_ONESHOT, dev_name(dev),

priv);

drivers/usb/typec/tcpm/tcpci_mt6370.c new file +2 -0
+	if (ret)
+		return dev_err_probe(dev, ret, "Failed to allocate

irq\n");

drivers/usb/typec/tcpm/tcpci_mt6370.c new file +33 -0
+
+	device_init_wakeup(dev, true);
+	dev_pm_set_wake_irq(dev, irq);
+
+	return 0;
+}
+
+static int mt6370_tcpc_remove(struct platform_device *pdev)
+{
+	dev_pm_clear_wake_irq(&pdev->dev);
+	device_init_wakeup(&pdev->dev, false);
+
+	return 0;
+}
+
+static const struct of_device_id mt6370_tcpc_devid_table[] = {
+	{ .compatible = "mediatek,mt6370-tcpc" },
+	{}
+};
+MODULE_DEVICE_TABLE(of, mt6370_tcpc_devid_table);
+
+static struct platform_driver mt6370_tcpc_driver = {
+	.driver = {
+		.name = "mt6370-tcpc",
+		.of_match_table = mt6370_tcpc_devid_table,
+	},
+	.probe = mt6370_tcpc_probe,
+	.remove = mt6370_tcpc_remove,
+};
+module_platform_driver(mt6370_tcpc_driver);
+
+MODULE_AUTHOR("ChiYuan Huang <[email protected]>");
+MODULE_DESCRIPTION("MT6370 USB Type-C Port Controller Interface

Driver");
+MODULE_LICENSE("GPL v2");

author
#18 lore raw

Re: [PATCH v6 08/13] usb: typec: tcpci_mt6370: Add MediaTek MT6370 tcpci driver

Quoted 150 lines · Chunfeng Yun
Quoted 148 lines · ChiaEn Wu

From: ChiYuan Huang <[email protected]>

The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

Add support for the Type-C & Power Delivery controller in MediaTek MT6370 IC.

Reviewed-by AngeloGioacchino Del Regno <

[email protected]>
---

v6
- Convert tcpci as device resource managed with 'devm_add_action_or_reset' API.
- Refine remvoe callback.
- Refine the commit text from 'This commit add' to 'Add'.

---
 drivers/usb/typec/tcpm/Kconfig        |  11 ++
 drivers/usb/typec/tcpm/Makefile       |   1 +
 drivers/usb/typec/tcpm/tcpci_mt6370.c | 208
++++++++++++++++++++++++++++++++++
 3 files changed, 220 insertions(+)
 create mode 100644 drivers/usb/typec/tcpm/tcpci_mt6370.c
drivers/usb/typec/tcpm/Kconfig +11 -0
index 073fd2e..e6b88ca 100644
@@ -35,6 +35,17 @@ config TYPEC_MT6360
        USB Type-C. It works with Type-C Port Controller Manager
        to provide USB PD and USB Type-C functionalities.
 
+config TYPEC_TCPCI_MT6370
+     tristate "MediaTek MT6370 Type-C driver"
+     depends on MFD_MT6370
+     help
+       MediaTek MT6370 is a multi-functional IC that includes
+       USB Type-C. It works with Type-C Port Controller Manager
+       to provide USB PD and USB Type-C functionalities.
+
+       This driver can also be built as a module. The module
+       will be called "tcpci_mt6370".
+
 config TYPEC_TCPCI_MAXIM
      tristate "Maxim TCPCI based Type-C chip driver"
      help
drivers/usb/typec/tcpm/Makefile +1 -0
index 7d499f3..906d9dc 100644
@@ -6,4 +6,5 @@ typec_wcove-y                         := wcove.o
 obj-$(CONFIG_TYPEC_TCPCI)            += tcpci.o
 obj-$(CONFIG_TYPEC_RT1711H)          += tcpci_rt1711h.o
 obj-$(CONFIG_TYPEC_MT6360)           += tcpci_mt6360.o
+obj-$(CONFIG_TYPEC_TCPCI_MT6370)     += tcpci_mt6370.o
 obj-$(CONFIG_TYPEC_TCPCI_MAXIM)              += tcpci_maxim.o
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +51 -0
new file mode 100644
index 0000000..4f53319
@@ -0,0 +1,208 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2022 Richtek Technology Corp.
+ *
+ * Author: ChiYuan Huang <[email protected]>
+ */
+
+#include <linux/bits.h>
+#include <linux/interrupt.h>
+#include <linux/kernel.h>
+#include <linux/mod_devicetable.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/pm_wakeup.h>
+#include <linux/pm_wakeirq.h>
+#include <linux/regmap.h>
+#include <linux/regulator/consumer.h>
+#include <linux/usb/tcpm.h>
+#include "tcpci.h"
+
+#define MT6370_REG_SYSCTRL8  0x9B
+
+#define MT6370_AUTOIDLE_MASK BIT(3)
+
+#define MT6370_VENDOR_ID     0x29CF
+#define MT6370_TCPC_DID_A    0x2170
+
+struct mt6370_priv {
+     struct device *dev;
+     struct regulator *vbus;
+     struct tcpci *tcpci;
+     struct tcpci_data tcpci_data;
+};
+
+static const struct reg_sequence mt6370_reg_init[] = {
+     REG_SEQ(0xA0, 0x1, 1000),
+     REG_SEQ(0x81, 0x38, 0),
+     REG_SEQ(0x82, 0x82, 0),
+     REG_SEQ(0xBA, 0xFC, 0),
+     REG_SEQ(0xBB, 0x50, 0),
+     REG_SEQ(0x9E, 0x8F, 0),
+     REG_SEQ(0xA1, 0x5, 0),
+     REG_SEQ(0xA2, 0x4, 0),
+     REG_SEQ(0xA3, 0x4A, 0),
+     REG_SEQ(0xA4, 0x01, 0),
+     REG_SEQ(0x95, 0x01, 0),
+     REG_SEQ(0x80, 0x71, 0),
+     REG_SEQ(0x9B, 0x3A, 1000),
+};
+
+static int mt6370_tcpc_init(struct tcpci *tcpci, struct tcpci_data

*data)

drivers/usb/typec/tcpm/tcpci_mt6370.c new file +10 -0
+{
+     u16 did;
+     int ret;
+
+     ret = regmap_register_patch(data->regmap, mt6370_reg_init,
+                                 ARRAY_SIZE(mt6370_reg_init));
+     if (ret)
+             return ret;
+
+     ret = regmap_raw_read(data->regmap, TCPC_BCD_DEV, &did,

sizeof(u16));

drivers/usb/typec/tcpm/tcpci_mt6370.c new file +5 -0
+     if (ret)
+             return ret;
+
+     if (did == MT6370_TCPC_DID_A)
+             return regmap_write(data->regmap, TCPC_FAULT_CTRL,

0x80);

drivers/usb/typec/tcpm/tcpci_mt6370.c new file +5 -0
+
+     return 0;
+}
+
+static int mt6370_tcpc_set_vconn(struct tcpci *tcpci, struct

tcpci_data *data,

drivers/usb/typec/tcpm/tcpci_mt6370.c new file +3 -0
+                              bool enable)
+{
+     return regmap_update_bits(data->regmap, MT6370_REG_SYSCTRL8,
Quoted 8 lines
Quoted 7 lines
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +5 -0
+                               MT6370_AUTOIDLE_MASK,
+                               !enable ? MT6370_AUTOIDLE_MASK : 0);
+}
+
+static int mt6370_tcpc_set_vbus(struct tcpci *tcpci, struct

tcpci_data *data,
+ bool source, bool sink)

@sink is not used in this function?

Hi Chunfeng,
The default HW binding is using the mt6370 switching charger. Due to the switching charger design, 'src usb boost' and 'sink battery charger', only one can be used at the same time.
Thanks.

Quoted 140 lines
Quoted 139 lines
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +2 -0
+{
+     struct mt6370_priv *priv = container_of(data, struct

mt6370_priv,

drivers/usb/typec/tcpm/tcpci_mt6370.c new file +30 -0
+                                             tcpci_data);
+     int ret;
+
+     ret = regulator_is_enabled(priv->vbus);
+     if (ret < 0)
+             return ret;
+
+     if (ret && !source)
+             return regulator_disable(priv->vbus);
+
+     if (!ret && source)
+             return regulator_enable(priv->vbus);
+
+     return 0;
+}
+
+static irqreturn_t mt6370_irq_handler(int irq, void *dev_id)
+{
+     struct mt6370_priv *priv = dev_id;
+
+     return tcpci_irq(priv->tcpci);
+}
+
+static int mt6370_check_vendor_info(struct mt6370_priv *priv)
+{
+     struct regmap *regmap = priv->tcpci_data.regmap;
+     u16 vid;
+     int ret;
+
+     ret = regmap_raw_read(regmap, TCPC_VENDOR_ID, &vid,

sizeof(u16));

drivers/usb/typec/tcpm/tcpci_mt6370.c new file +6 -0
+     if (ret)
+             return ret;
+
+     if (vid != MT6370_VENDOR_ID)
+             return dev_err_probe(priv->dev, -ENODEV,
+                                  "Vendor ID not correct 0x%02x\n",

vid);

drivers/usb/typec/tcpm/tcpci_mt6370.c new file +24 -0
+
+     return 0;
+}
+
+static void mt6370_unregister_tcpci_port(void *tcpci)
+{
+     tcpci_unregister_port(tcpci);
+}
+
+static int mt6370_tcpc_probe(struct platform_device *pdev)
+{
+     struct mt6370_priv *priv;
+     struct device *dev = &pdev->dev;
+     int irq, ret;
+
+     priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
+     if (!priv)
+             return -ENOMEM;
+
+     priv->dev = dev;
+
+     priv->tcpci_data.regmap = dev_get_regmap(dev->parent, NULL);
+     if (!priv->tcpci_data.regmap)
+             return dev_err_probe(dev, -ENODEV, "Failed to init

regmap\n");

drivers/usb/typec/tcpm/tcpci_mt6370.c new file +22 -0
+
+     ret = mt6370_check_vendor_info(priv);
+     if (ret)
+             return ret;
+
+     irq = platform_get_irq(pdev, 0);
+     if (irq < 0)
+             return dev_err_probe(dev, irq, "Failed to get irq\n");
+
+     /* Assign TCPCI feature and ops */
+     priv->tcpci_data.auto_discharge_disconnect = 1;
+     priv->tcpci_data.init = mt6370_tcpc_init;
+     priv->tcpci_data.set_vconn = mt6370_tcpc_set_vconn;
+
+     priv->vbus = devm_regulator_get_optional(dev, "vbus");
+     if (!IS_ERR(priv->vbus))
+             priv->tcpci_data.set_vbus = mt6370_tcpc_set_vbus;
+
+     priv->tcpci = tcpci_register_port(dev, &priv->tcpci_data);
+     if (IS_ERR(priv->tcpci))
+             return dev_err_probe(dev, PTR_ERR(priv->tcpci),
+                                  "Failed to register tcpci

port\n");

drivers/usb/typec/tcpm/tcpci_mt6370.c new file +2 -0
+
+     ret = devm_add_action_or_reset(dev,

mt6370_unregister_tcpci_port,

drivers/usb/typec/tcpm/tcpci_mt6370.c new file +5 -0
+                                    priv->tcpci);
+     if (ret)
+             return ret;
+
+     ret = devm_request_threaded_irq(dev, irq, NULL,

mt6370_irq_handler,
+ IRQF_ONESHOT, dev_name(dev),
priv);

drivers/usb/typec/tcpm/tcpci_mt6370.c new file +2 -0
+     if (ret)
+             return dev_err_probe(dev, ret, "Failed to allocate

irq\n");

drivers/usb/typec/tcpm/tcpci_mt6370.c new file +33 -0
+
+     device_init_wakeup(dev, true);
+     dev_pm_set_wake_irq(dev, irq);
+
+     return 0;
+}
+
+static int mt6370_tcpc_remove(struct platform_device *pdev)
+{
+     dev_pm_clear_wake_irq(&pdev->dev);
+     device_init_wakeup(&pdev->dev, false);
+
+     return 0;
+}
+
+static const struct of_device_id mt6370_tcpc_devid_table[] = {
+     { .compatible = "mediatek,mt6370-tcpc" },
+     {}
+};
+MODULE_DEVICE_TABLE(of, mt6370_tcpc_devid_table);
+
+static struct platform_driver mt6370_tcpc_driver = {
+     .driver = {
+             .name = "mt6370-tcpc",
+             .of_match_table = mt6370_tcpc_devid_table,
+     },
+     .probe = mt6370_tcpc_probe,
+     .remove = mt6370_tcpc_remove,
+};
+module_platform_driver(mt6370_tcpc_driver);
+
+MODULE_AUTHOR("ChiYuan Huang <[email protected]>");
+MODULE_DESCRIPTION("MT6370 USB Type-C Port Controller Interface

Driver");
+MODULE_LICENSE("GPL v2");

Signature · 2 lines
Best Regards,
ChiaEn Wu
#19 lore raw

Re: [PATCH v6 08/13] usb: typec: tcpci_mt6370: Add MediaTek MT6370 tcpci driver

In reply to ChiaEn Wu
Quoted 11 lines · ChiaEn Wu

From: ChiYuan Huang <[email protected]>

The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

Add support for the Type-C & Power Delivery controller in MediaTek MT6370 IC.

...

drivers/usb/typec/tcpm/tcpci_mt6370.c line 76

Quoted 6 lines
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +6 -0
+static int mt6370_tcpc_set_vconn(struct tcpci *tcpci, struct tcpci_data *data,
+                                bool enable)
+{
+       return regmap_update_bits(data->regmap, MT6370_REG_SYSCTRL8,
+                                 MT6370_AUTOIDLE_MASK,
+                                 !enable ? MT6370_AUTOIDLE_MASK : 0);

Why not positive conditional?

enable ? 0 : mask

Quoted 1 line

+}

...

drivers/usb/typec/tcpm/tcpci_mt6370.c line 167

Quoted 2 lines
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +2 -0
+       ret = devm_add_action_or_reset(dev, mt6370_unregister_tcpci_port,
+                                      priv->tcpci);

I believe nothing bad will happen if you put it on one line.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
author
#20 lore raw

PATCH v6 9/13 iio: adc: mt6370: Add MediaTek MT6370 support

In reply to ChiaEn Wu

From: ChiaEn Wu <[email protected]>

MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight driver, display bias voltage supply, one general purpose LDO, and the USB Type-C & PD controller complies with the latest USB Type-C and PD standards.

Add a support the MT6370 ADC driver for system monitoring, including charger current, voltage, and temperature.

---

v6
- Using 'struct device *dev = &pdev->dev' in probe()
- Revise the sixth parameter of regmap_read_poll_timeout() by replacing '1000' with 'MILLI'
- Revise the units of three macros
- MT6370_AICR_400MA --> MT6370_AICR_400_mA
- MT6370_ICHG_500MA --> MT6370_ICHG_500_mA
- MT6370_ICHG_900MA --> MT6370_ICHG_900_mA

---
 drivers/iio/adc/Kconfig      |  12 ++
 drivers/iio/adc/Makefile     |   1 +
 drivers/iio/adc/mt6370-adc.c | 274 +++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 287 insertions(+)
 create mode 100644 drivers/iio/adc/mt6370-adc.c
drivers/iio/adc/Kconfig +12 -0
index 48ace74..60bcc28 100644
@@ -737,6 +737,18 @@ config MEDIATEK_MT6360_ADC
 	  is used in smartphones and tablets and supports a 11 channel
 	  general purpose ADC.
 
+config MEDIATEK_MT6370_ADC
+	tristate "MediaTek MT6370 ADC driver"
+	depends on MFD_MT6370
+	help
+	  Say yes here to enable MediaTek MT6370 ADC support.
+
+	  This ADC driver provides 9 channels for system monitoring (charger
+	  current, voltage, and temperature).
+
+	  This driver can also be built as a module. If so, the module
+	  will be called "mt6370-adc".
+
 config MEDIATEK_MT6577_AUXADC
 	tristate "MediaTek AUXADC driver"
 	depends on ARCH_MEDIATEK || COMPILE_TEST
drivers/iio/adc/Makefile +1 -0
index 39d806f..0ce285c 100644
@@ -68,6 +68,7 @@ obj-$(CONFIG_MCP320X) += mcp320x.o
 obj-$(CONFIG_MCP3422) += mcp3422.o
 obj-$(CONFIG_MCP3911) += mcp3911.o
 obj-$(CONFIG_MEDIATEK_MT6360_ADC) += mt6360-adc.o
+obj-$(CONFIG_MEDIATEK_MT6370_ADC) += mt6370-adc.o
 obj-$(CONFIG_MEDIATEK_MT6577_AUXADC) += mt6577_auxadc.o
 obj-$(CONFIG_MEN_Z188_ADC) += men_z188_adc.o
 obj-$(CONFIG_MESON_SARADC) += meson_saradc.o
drivers/iio/adc/mt6370-adc.c new file +274 -0

274 lines not on this page · raw message

Signature · 1 line
2.7.4
#21 lore raw

Re: [PATCH v6 09/13] iio: adc: mt6370: Add MediaTek MT6370 support

Quoted 10 lines · ChiaEn Wu

From: ChiaEn Wu <[email protected]>

MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight driver, display bias voltage supply, one general purpose LDO, and the USB Type-C & PD controller complies with the latest USB Type-C and PD standards.

Add a support the MT6370 ADC driver for system monitoring, including

support for the

Quoted 1 line

charger current, voltage, and temperature.

...

drivers/iio/adc/mt6370-adc.c line 33

Quoted 3 lines
drivers/iio/adc/mt6370-adc.c new file +3 -0
+#define MT6370_AICR_400_mA             0x6
+#define MT6370_ICHG_500_mA             0x4
+#define MT6370_ICHG_900_mA             0x8

^^^^ (Note this and read below)

...

drivers/iio/adc/mt6370-adc.c line 110

Quoted 5 lines
drivers/iio/adc/mt6370-adc.c new file +5 -0
+               reg_val = FIELD_GET(MT6370_AICR_ICHG_MASK, reg_val);
+               if (reg_val < MT6370_AICR_400_mA)
+                       *val1 = 3350;
+               else
+                       *val1 = 5000;

Here...

...

drivers/iio/adc/mt6370-adc.c line 127

Quoted 7 lines
drivers/iio/adc/mt6370-adc.c new file +7 -0
+               if (reg_val < MT6370_ICHG_500_mA)
+                       *val1 = 2375;
+               else if (reg_val >= MT6370_ICHG_500_mA &&
+                        reg_val < MT6370_ICHG_900_mA)
+                       *val1 = 2680;
+               else
+                       *val1 = 5000;

...and especially here it is so counterintuitive to have an if-else chain because the values are not ordered by semantic meaning.

What if the new standard/hardware decides to use 0x7 for 100mA (hypothetically)?

So, please use switch cases or other robust methods.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
author
#22 lore raw

PATCH v6 10/13 power: supply: mt6370: Add MediaTek MT6370 charger driver

In reply to ChiaEn Wu

From: ChiaEn Wu <[email protected]>

MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight driver, display bias voltage supply, one general purpose LDO, and the USB Type-C & PD controller complies with the latest USB Type-C and PD standards.

This adds MediaTek MT6370 Charger driver support. The charger module of MT6370 supports High-Accuracy Voltage/Current Regulation, Average Input Current Regulation, Battery Temperature Sensing, Over-Temperature Protection, DPDM Detection for BC1.2.

---

v6
- Remove the varable (*psy_desc) of struct mt6370_priv
- Remove the deprecated usb type (POWER_SUPPLY_TYPE_USB_CDP and POWER_SUPPLY_TYPE_USB_DCP)
- Remove useless remove()
- Revise all units from mini- to micro-
- Revise get/set power_supply_prop (change to directly return get/set regmap_field)
- Revise probe() and use devm_add_action_or_reset() for handling of the workqueue/delayed_work/mutex
- Revise mt6370_chg_psy_desc
- Add '.name = "mt6370-charger"'
- Use 'static const'

---

uevent dump:
vim3l:/sys/class/power_supply/mt6370-charger # cat uevent POWER_SUPPLY_NAME=mt6370-charger POWER_SUPPLY_TYPE=USB
POWER_SUPPLY_ONLINE=0 POWER_SUPPLY_STATUS=Discharging POWER_SUPPLY_CHARGE_TYPE=N/A POWER_SUPPLY_CONSTANT_CHARGE_CURRENT=900000 POWER_SUPPLY_CONSTANT_CHARGE_CURRENT_MAX=5000000 POWER_SUPPLY_CONSTANT_CHARGE_VOLTAGE=4200000 POWER_SUPPLY_CONSTANT_CHARGE_VOLTAGE_MAX=4710000 POWER_SUPPLY_INPUT_CURRENT_LIMIT=500000 POWER_SUPPLY_INPUT_VOLTAGE_LIMIT=4400000 POWER_SUPPLY_PRECHARGE_CURRENT=150000 POWER_SUPPLY_CHARGE_TERM_CURRENT=250000 POWER_SUPPLY_USB_TYPE=[Unknown] SDP CDP DCP

---
 drivers/power/supply/Kconfig          |  14 +
 drivers/power/supply/Makefile         |   1 +
 drivers/power/supply/mt6370-charger.c | 973 ++++++++++++++++++++++++++++++++++
 3 files changed, 988 insertions(+)
 create mode 100644 drivers/power/supply/mt6370-charger.c
drivers/power/supply/Kconfig +14 -0
index 1aa8323..591deb8 100644
@@ -619,6 +619,20 @@ config CHARGER_MT6360
 	  Average Input Current Regulation, Battery Temperature Sensing,
 	  Over-Temperature Protection, DPDM Detection for BC1.2.
 
+config CHARGER_MT6370
+	tristate "MediaTek MT6370 Charger Driver"
+	depends on MFD_MT6370
+	depends on REGULATOR
+	select LINEAR_RANGES
+	help
+	  Say Y here to enable MT6370 Charger Part.
+	  The device supports High-Accuracy Voltage/Current Regulation,
+	  Average Input Current Regulation, Battery Temperature Sensing,
+	  Over-Temperature Protection, DPDM Detection for BC1.2.
+
+	  This driver can also be built as a module. If so, the module
+	  will be called "mt6370-charger".
+
 config CHARGER_QCOM_SMBB
 	tristate "Qualcomm Switch-Mode Battery Charger and Boost"
 	depends on MFD_SPMI_PMIC || COMPILE_TEST
drivers/power/supply/Makefile +1 -0
index 7f02f36..8c95276 100644
@@ -82,6 +82,7 @@ obj-$(CONFIG_CHARGER_MAX8997)	+= max8997_charger.o
 obj-$(CONFIG_CHARGER_MAX8998)	+= max8998_charger.o
 obj-$(CONFIG_CHARGER_MP2629)	+= mp2629_charger.o
 obj-$(CONFIG_CHARGER_MT6360)	+= mt6360_charger.o
+obj-$(CONFIG_CHARGER_MT6370)	+= mt6370-charger.o
 obj-$(CONFIG_CHARGER_QCOM_SMBB)	+= qcom_smbb.o
 obj-$(CONFIG_CHARGER_BQ2415X)	+= bq2415x_charger.o
 obj-$(CONFIG_CHARGER_BQ24190)	+= bq24190_charger.o
drivers/power/supply/mt6370-charger.c new file +973 -0

973 lines not on this page · raw message

Signature · 1 line
2.7.4
#23 lore raw

Re: [PATCH v6 10/13] power: supply: mt6370: Add MediaTek MT6370 charger driver

Quoted 13 lines · ChiaEn Wu

From: ChiaEn Wu <[email protected]>

MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight driver, display bias voltage supply, one general purpose LDO, and the USB Type-C & PD controller complies with the latest USB Type-C and PD standards.

This adds MediaTek MT6370 Charger driver support. The charger module of MT6370 supports High-Accuracy Voltage/Current Regulation, Average Input Current Regulation, Battery Temperature Sensing, Over-Temperature Protection, DPDM Detection for BC1.2.

...

drivers/power/supply/mt6370-charger.c line 318

Quoted 7 lines
drivers/power/supply/mt6370-charger.c new file +7 -0
+static inline void mt6370_chg_enable_irq(struct mt6370_priv *priv,
+                                        const char *irq_name, bool en)
+{
+       int irq_num;
+       struct platform_device *pdev = to_platform_device(priv->dev);
+
+       irq_num = platform_get_irq_byname(pdev, irq_name);

Every time the IRQ is not found you will get an error message printed here.
1) Is IRQ optional?
2) If not, can't you do validation only once?

Quoted 8 lines
drivers/power/supply/mt6370-charger.c new file +8 -0
+       if (irq_num < 0)
+               return;
+
+       if (en)
+               enable_irq(irq_num);
+       else
+               disable_irq_nosync(irq_num);
+}

...

drivers/power/supply/mt6370-charger.c line 733

Quoted 8 lines
drivers/power/supply/mt6370-charger.c new file +6 -0
+       ret = mt6370_chg_field_set(priv, F_USBCHGEN, 0);
+       if (ret < 0) {
 
+       ret = mt6370_chg_field_set(priv, F_ICHG, 900000);
+       if (ret < 0) {
 
+       ret = mt6370_chg_field_set(priv, F_IINLMTSEL, 3);
+       if (ret < 0) {

Do all these ' < 0' parts make sense?
(Not only these cases, but in many in the entire driver)

...

Quoted 1 line

+ /* Check in otg mode or not */

OTG

...

drivers/power/supply/mt6370-charger.c line 873

Quoted 6 lines
drivers/power/supply/mt6370-charger.c new file +5 -0
+               ret = devm_request_threaded_irq(priv->dev, ret, NULL,
+                                               mt6370_chg_irqs[i].handler,
+                                               IRQF_TRIGGER_FALLING,
+                                               dev_name(priv->dev), priv);
 
+

Redundant blank line.

Quoted 5 lines
drivers/power/supply/mt6370-charger.c new file +5 -0
+               if (ret < 0)
+                       return dev_err_probe(priv->dev, ret,
+                                            "Failed to request irq %s\n",
+                                            mt6370_chg_irqs[i].name);
+       }
Signature · 2 lines
With Best Regards,
Andy Shevchenko
author
#24 lore raw

PATCH v6 11/13 leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

In reply to ChiaEn Wu

From: ChiYuan Huang <[email protected]>

The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

In MediaTek MT6370, there are four channel current-sink RGB LEDs that support hardware pattern for constant current, PWM, and breath mode. Isink4 channel can also be used as a CHG_VIN power good indicator.

---

v6
- Remove the 'ko' from mt6370 led Kconfig description.
- Add both authors for Alice and ChiYuan.
- Use pdata to distinguish the code from mt6370/71 to mt6372.
- Instead of 'state' define, use the 'state' enum.
- Fix the typo for 'MT6372_PMW_DUTY'.
- For pwm_duty define, replace with bit macro - 1.
- Refine all the labels from 'out' to 'out_unlock'.
- Use struct 'dev' variable and 'dev_err_probe' to optimize the LOC.
- Revise for the array initialization from {0} to {}.
- Move into rgb folder and rename file name to 'leds-mt6370-rgb'.
- Refine the 'comma' usage in struct/enum.

---
 drivers/leds/rgb/Kconfig           |   13 +
 drivers/leds/rgb/Makefile          |    1 +
 drivers/leds/rgb/leds-mt6370-rgb.c | 1004 ++++++++++++++++++++++++++++++++++++
 3 files changed, 1018 insertions(+)
 create mode 100644 drivers/leds/rgb/leds-mt6370-rgb.c
drivers/leds/rgb/Kconfig +13 -0
index 204cf47..d6ad875 100644
@@ -26,4 +26,17 @@ config LEDS_QCOM_LPG
 
 	  If compiled as a module, the module will be named leds-qcom-lpg.
 
+config LEDS_MT6370_RGB
+	tristate "LED Support for MediaTek MT6370 PMIC"
+	depends on MFD_MT6370
+	select LINEAR_RANGE
+	help
+	  Say Y here to enable support for MT6370_RGB LED device.
+	  In MT6370, there are four channel current-sink LED drivers that
+	  support hardware pattern for constant current, PWM, and breath mode.
+	  Isink4 channel can also be used as a CHG_VIN power good indicator.
+
+	  This driver can also be built as a module. If so, the module
+	  will be called "leds-mt6370-rgb".
+
 endif # LEDS_CLASS_MULTICOLOR
drivers/leds/rgb/Makefile +1 -0
index 0675bc0..8c01daf 100644
@@ -2,3 +2,4 @@
 
 obj-$(CONFIG_LEDS_PWM_MULTICOLOR)	+= leds-pwm-multicolor.o
 obj-$(CONFIG_LEDS_QCOM_LPG)		+= leds-qcom-lpg.o
+obj-$(CONFIG_LEDS_MT6370_RGB)		+= leds-mt6370-rgb.o
drivers/leds/rgb/leds-mt6370-rgb.c new file +1004 -0

1,004 lines not on this page · raw message

Signature · 1 line
2.7.4
maintainer Reviewed-by on v6 11/13
#25 lore raw

Re: [PATCH v6 11/13] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

Il 22/07/22 12:24, ChiaEn Wu ha scritto:

Quoted 8 lines

From: ChiYuan Huang <[email protected]>

The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

Quoted 6 lines

In MediaTek MT6370, there are four channel current-sink RGB LEDs that support hardware pattern for constant current, PWM, and breath mode. Isink4 channel can also be used as a CHG_VIN power good indicator.

Quoted 21 lines

---

v6
- Remove the 'ko' from mt6370 led Kconfig description.
- Add both authors for Alice and ChiYuan.
- Use pdata to distinguish the code from mt6370/71 to mt6372.
- Instead of 'state' define, use the 'state' enum.
- Fix the typo for 'MT6372_PMW_DUTY'.
- For pwm_duty define, replace with bit macro - 1.
- Refine all the labels from 'out' to 'out_unlock'.
- Use struct 'dev' variable and 'dev_err_probe' to optimize the LOC.
- Revise for the array initialization from {0} to {}.
- Move into rgb folder and rename file name to 'leds-mt6370-rgb'.
- Refine the 'comma' usage in struct/enum.

---
  drivers/leds/rgb/Kconfig           |   13 +
  drivers/leds/rgb/Makefile          |    1 +
  drivers/leds/rgb/leds-mt6370-rgb.c | 1004 ++++++++++++++++++++++++++++++++++++
  3 files changed, 1018 insertions(+)

create mode 100644 drivers/leds/rgb/leds-mt6370-rgb.c

#26 lore raw

Re: [PATCH v6 11/13] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

In reply to ChiaEn Wu
Quoted 2 lines · ChiaEn Wu

From: ChiYuan Huang <[email protected]>

^^^^ (Note this and read below)

Quoted 7 lines

The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

Quoted 6 lines

In MediaTek MT6370, there are four channel current-sink RGB LEDs that support hardware pattern for constant current, PWM, and breath mode. Isink4 channel can also be used as a CHG_VIN power good indicator.

In conjunction with above what SoB of Alice means?

You really need to take your time and (re-)read
https://www.kernel.org/doc/html/latest/process/submitting-patches.html.

...

Quoted 2 lines

+ * Author: Alice Chen <[email protected]>
+ * Author: ChiYuan Huang <[email protected]>

Would
* Authors:
* Name_of_Author 1
* Name_of_Author 2

work for you?

...

drivers/leds/rgb/leds-mt6370-rgb.c line 120

Quoted 5 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +5 -0
+struct mt6370_led {
+       union {
+               struct led_classdev isink;
+               struct led_classdev_mc mc;
+       };

Where is the field that makes union work?

Quoted 4 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +4 -0
+       struct mt6370_priv *priv;
+       u32 default_state;
+       u32 index;
+};

...

Quoted 24 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +24 -0
+static int mt6370_gen_breath_pattern(struct mt6370_priv *priv,
+                                    struct led_pattern *pattern, u32 len,
+                                    u8 *pattern_val, u32 val_len)
+{
+       enum mt6370_led_ranges sel_range;
+       struct led_pattern *curr;
+       unsigned int sel;
+       u8 val[P_MAX_PATTERNS / 2] = {};
+       int i;
+
+       if (len < P_MAX_PATTERNS && val_len < P_MAX_PATTERNS / 2)
+               return -EINVAL;
+
+       /*
+        * Pattern list
+        * tr1: byte 0, b'[7: 4]
+        * tr2: byte 0, b'[3: 0]
+        * tf1: byte 1, b'[7: 4]
+        * tf2: byte 1, b'[3: 0]
+        * ton: byte 2, b'[7: 4]
+        * toff: byte 2, b'[3: 0]
+        */
+       for (i = 0; i < P_MAX_PATTERNS; i++) {
+               curr = pattern + i;

drivers/leds/rgb/leds-mt6370-rgb.c line 380

Quoted 10 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +10 -0
+
+               sel_range = i == P_LED_TOFF ? R_LED_TOFF : R_LED_TRFON;
+
+               linear_range_get_selector_within(priv->ranges + sel_range,
+                                                curr->delta_t, &sel);
+
+               val[i / 2] |= sel << (4 * ((i + 1) % 2));
+       }
+
+       memcpy(pattern_val, val, 3);

Isn't it something like put_unaligned_be24()/put_unaligned_le24()?

Quoted 2 lines
(quoted diff) +2 -0
+       return 0;
+}

...

drivers/leds/rgb/leds-mt6370-rgb.c line 587

Quoted 8 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +7 -0
+static inline int mt6370_mc_pattern_clear(struct led_classdev *lcdev)
+{
+       struct led_classdev_mc *mccdev = lcdev_to_mccdev(lcdev);
+       struct mt6370_led *led = container_of(mccdev, struct mt6370_led, mc);
+       struct mt6370_priv *priv = led->priv;
+       struct mc_subled *subled;
 
+       int i, ret = 0;

Redundant assignment.

Quoted 15 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +15 -0
+       mutex_lock(&led->priv->lock);
+
+       for (i = 0; i < mccdev->num_colors; i++) {
+               subled = mccdev->subled_info + i;
+
+               ret = mt6370_set_led_mode(priv, subled->channel,
+                                         MT6370_LED_REG_MODE);
+               if (ret)
+                       break;
+       }
+
+       mutex_unlock(&led->priv->lock);
+
+       return ret;
+}

...

drivers/leds/rgb/leds-mt6370-rgb.c line 802

Quoted 2 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +2 -0
+       if (!fwnode_property_read_string(init_data->fwnode, "default-state",
+                                        &stat_str)) {

ret = fwnode_...(...);
if (!ret)

Quoted 6 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +6 -0
+               ret = match_string(states, ARRAY_SIZE(states), stat_str);
+               if (ret < 0)
+                       ret = STATE_OFF;
+
+               led->default_state = ret;
+       }

...

Quoted 1 line

+ int i = 0, ret;

unsigned int i = 0;
int ret;

Signature · 2 lines
With Best Regards,
Andy Shevchenko
author
#27 lore raw

Re: [PATCH v6 11/13] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

On Mon, Jul 25, 2022 at 4:41 PM Andy Shevchenko
<[email protected]> wrote:
...

Quoted 3 lines
Quoted 1 line

From: ChiYuan Huang <[email protected]>

^^^^ (Note this and read below)

...

Quoted 4 lines

In conjunction with above what SoB of Alice means?

You really need to take your time and (re-)read
https://www.kernel.org/doc/html/latest/process/submitting-patches.html.

Hi Andy,

Thanks for your reply.
We are very sorry for this mistake. We will revise it in the next patch.

Quoted 6 lines

...

Quoted 2 lines

+ * Author: Alice Chen <[email protected]>
+ * Author: ChiYuan Huang <[email protected]>

Quoted 6 lines

Would
* Authors:
* Name_of_Author 1
* Name_of_Author 2

work for you?

It looks good, thanks! We will apply this in the next patch.

...

Quoted 7 lines

drivers/leds/rgb/leds-mt6370-rgb.c line 120

Quoted 5 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +5 -0
+struct mt6370_led {
+       union {
+               struct led_classdev isink;
+               struct led_classdev_mc mc;
+       };

Where is the field that makes union work?

Just for saving memory space.
Because these led_classdevs do not be used at the same time. Or do you think it would be better to rewrite it as follows?
-------------------------------------------------------------------------------------

struct mt6370_led {
       struct led_classdev isink;
       struct led_classdev_mc mc;
       struct mt6370_priv *priv;
       u32 default_state;
       u32 index;
};

-------------------------------------------------------------------------------------

...

Quoted 28 lines
Quoted 28 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +28 -0
+static int mt6370_gen_breath_pattern(struct mt6370_priv *priv,
+                                    struct led_pattern *pattern, u32 len,
+                                    u8 *pattern_val, u32 val_len)
+{
+       enum mt6370_led_ranges sel_range;
+       struct led_pattern *curr;
+       unsigned int sel;
+       u8 val[P_MAX_PATTERNS / 2] = {};
+       int i;
+
+       if (len < P_MAX_PATTERNS && val_len < P_MAX_PATTERNS / 2)
+               return -EINVAL;
+
+       /*
+        * Pattern list
+        * tr1: byte 0, b'[7: 4]
+        * tr2: byte 0, b'[3: 0]
+        * tf1: byte 1, b'[7: 4]
+        * tf2: byte 1, b'[3: 0]
+        * ton: byte 2, b'[7: 4]
+        * toff: byte 2, b'[3: 0]
+        */
+       for (i = 0; i < P_MAX_PATTERNS; i++) {
+               curr = pattern + i;
+
+               sel_range = i == P_LED_TOFF ? R_LED_TOFF : R_LED_TRFON;
+
+               linear_range_get_selector_within(priv->ranges + sel_range,
Quoted 8 lines

drivers/leds/rgb/leds-mt6370-rgb.c line 380

Quoted 6 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +6 -0
+                                                curr->delta_t, &sel);
+
+               val[i / 2] |= sel << (4 * ((i + 1) % 2));
+       }
+
+       memcpy(pattern_val, val, 3);

Isn't it something like put_unaligned_be24()/put_unaligned_le24()?

OK, we will try to apply this method in the next patch. Thank you so much for reviewing our patches so many times and providing so many great suggestions!

Signature · 2 lines
Best Regards,
ChiaEn Wu
#28 lore raw

Re: [PATCH v6 11/13] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

Quoted 2 lines · ChiaEn Wu

On Mon, Jul 25, 2022 at 4:41 PM Andy Shevchenko
<[email protected]> wrote:

...

Quoted 12 lines
Quoted 7 lines

drivers/leds/rgb/leds-mt6370-rgb.c line 120

Quoted 5 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +5 -0
+struct mt6370_led {
+       union {
+               struct led_classdev isink;
+               struct led_classdev_mc mc;
+       };

Where is the field that makes union work?

Just for saving memory space.
Because these led_classdevs do not be used at the same time. Or do you think it would be better to rewrite it as follows?
-------------------------------------------------------------------------------------

Quoted 8 lines
struct mt6370_led {
       struct led_classdev isink;
       struct led_classdev_mc mc;
       struct mt6370_priv *priv;
       u32 default_state;
       u32 index;
};

-------------------------------------------------------------------------------------

You obviously didn't get what I'm talking about...
Each union to work properly should have an associated variable that holds the information of which field of the union is in use. Do you have such a variable? If not, how does your code know which one to use? If yes, add a proper comment there.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
author
#29 lore raw

Re: [PATCH v6 11/13] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

On Tue, Jul 26, 2022 at 8:18 PM Andy Shevchenko
<[email protected]> wrote:

...

Quoted 13 lines
Quoted 4 lines

Just for saving memory space.
Because these led_classdevs do not be used at the same time. Or do you think it would be better to rewrite it as follows?
-------------------------------------------------------------------------------------

Quoted 8 lines
struct mt6370_led {
       struct led_classdev isink;
       struct led_classdev_mc mc;
       struct mt6370_priv *priv;
       u32 default_state;
       u32 index;
};

-------------------------------------------------------------------------------------

Quoted 6 lines

You obviously didn't get what I'm talking about...
Each union to work properly should have an associated variable that holds the information of which field of the union is in use. Do you have such a variable? If not, how does your code know which one to use? If yes, add a proper comment there.

Ummm... from my understanding,
if the colors of these four LEDs are set to 'LED_COLOR_ID_RGB' or 'LED_COLOR_ID_MULTI' in DT,
their 'led->index' will be set to 'MT6370_VIRTUAL_MULTICOLOR' in 'mt6370_leds_probe()'.
If so, these led devices will be set as 'struct led_classdev_mc' and use related ops functions in 'mt6370_init_led_properties()'. Instead, they whose 'led->index' is not 'MT6370_VIRTUAL_MULTICOLOR' will be set as 'struct led_classdev'.
So, maybe the member 'index' of the 'struct mt6370_led' is what you describe the information of which field of the union is in use? I will add the proper comment here to describe this thing. I'm so sorry for misunderstanding your mean last time.
Thanks again for your review.

Signature · 2 lines
Best Regards,
ChiaEn Wu
#30 lore raw

Re: [PATCH v6 11/13] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

Quoted 25 lines · ChiaEn Wu

On Tue, Jul 26, 2022 at 8:18 PM Andy Shevchenko
<[email protected]> wrote:

...

Quoted 13 lines
Quoted 4 lines

Just for saving memory space.
Because these led_classdevs do not be used at the same time. Or do you think it would be better to rewrite it as follows?
-------------------------------------------------------------------------------------

Quoted 8 lines
struct mt6370_led {
       struct led_classdev isink;
       struct led_classdev_mc mc;
       struct mt6370_priv *priv;
       u32 default_state;
       u32 index;
};

-------------------------------------------------------------------------------------

Quoted 6 lines

You obviously didn't get what I'm talking about...
Each union to work properly should have an associated variable that holds the information of which field of the union is in use. Do you have such a variable? If not, how does your code know which one to use? If yes, add a proper comment there.

Quoted 11 lines

Ummm... from my understanding,
if the colors of these four LEDs are set to 'LED_COLOR_ID_RGB' or 'LED_COLOR_ID_MULTI' in DT,
their 'led->index' will be set to 'MT6370_VIRTUAL_MULTICOLOR' in 'mt6370_leds_probe()'.
If so, these led devices will be set as 'struct led_classdev_mc' and use related ops functions in 'mt6370_init_led_properties()'. Instead, they whose 'led->index' is not 'MT6370_VIRTUAL_MULTICOLOR' will be set as 'struct led_classdev'.
So, maybe the member 'index' of the 'struct mt6370_led' is what you describe the information of which field of the union is in use?

From this description it sounds like it is.

Quoted 2 lines

I will add the proper comment here to describe this thing. I'm so sorry for misunderstanding your mean last time.

Yes, please add a compressed version of what you said above to the code.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#31 lore raw

Re: [PATCH v6 11/13] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

In reply to ChiaEn Wu

Hi!

Quoted 14 lines

From: ChiYuan Huang <[email protected]>

The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

In MediaTek MT6370, there are four channel current-sink RGB LEDs that support hardware pattern for constant current, PWM, and breath mode. Isink4 channel can also be used as a CHG_VIN power good indicator.

drivers/leds/rgb/Kconfig +1 -0
+config LEDS_MT6370_RGB

drivers/leds/rgb/Kconfig config LEDS_QCOM_LPG · line 37

Quoted 10 lines
drivers/leds/rgb/Kconfig +8 -0
+	tristate "LED Support for MediaTek MT6370 PMIC"
+	depends on MFD_MT6370
+	select LINEAR_RANGE
+	help
+	  Say Y here to enable support for MT6370_RGB LED device.
+	  In MT6370, there are four channel current-sink LED drivers that
+	  support hardware pattern for constant current, PWM, and breath mode.
 
 
+	  Isink4 channel can also be used as a CHG_VIN power good  indicator.

That does not really belong here.

drivers/leds/rgb/leds-mt6370-rgb.c line 136

Quoted 3 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +3 -0
+struct mt6370_priv {
+	/* Per LED access lock */
+	struct mutex lock;

Do we really need per-led locking?

Quoted 27 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +27 -0
+static int mt6370_gen_breath_pattern(struct mt6370_priv *priv,
+				     struct led_pattern *pattern, u32 len,
+				     u8 *pattern_val, u32 val_len)
+{
+	enum mt6370_led_ranges sel_range;
+	struct led_pattern *curr;
+	unsigned int sel;
+	u8 val[P_MAX_PATTERNS / 2] = {};
+	int i;
+
+	if (len < P_MAX_PATTERNS && val_len < P_MAX_PATTERNS / 2)
+		return -EINVAL;
+
+	/*
+	 * Pattern list
+	 * tr1:	byte 0, b'[7: 4]
+	 * tr2:	byte 0, b'[3: 0]
+	 * tf1:	byte 1, b'[7: 4]
+	 * tf2:	byte 1, b'[3: 0]
+	 * ton:	byte 2, b'[7: 4]
+	 * toff: byte 2, b'[3: 0]
+	 */
+	for (i = 0; i < P_MAX_PATTERNS; i++) {
+		curr = pattern + i;
+
+		sel_range = i == P_LED_TOFF ? R_LED_TOFF : R_LED_TRFON;
+

drivers/leds/rgb/leds-mt6370-rgb.c line 383

Quoted 10 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +10 -0
+		linear_range_get_selector_within(priv->ranges + sel_range,
+						 curr->delta_t, &sel);
+
+		val[i / 2] |= sel << (4 * ((i + 1) % 2));
+	}
+
+	memcpy(pattern_val, val, 3);
+
+	return 0;
+}

I wonder how this works... you are not creating private sysfs interface, are you?

drivers/leds/rgb/leds-mt6370-rgb.c line 726

Quoted 10 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +10 -0
+static int mt6370_init_led_properties(struct mt6370_led *led,
+				      struct led_init_data *init_data)
+{
+	struct mt6370_priv *priv = led->priv;
+	struct device *dev = priv->dev;
+	struct led_classdev *lcdev;
+	struct fwnode_handle *child;
+	enum mt6370_led_ranges sel_range;
+	u32 max_uA, max_level;
+	const char * const states[] = { "off", "keep", "on" };

We'd really preffer not to add "keep" / "on" support unless you need it.

drivers/leds/rgb/leds-mt6370-rgb.c line 751

Quoted 4 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +4 -0
+			if (ret)
+				return dev_err_probe(dev, ret,
+						     "led %d, no color specified\n",
+						     led->index);

led->LED.

Quoted 4 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +3 -0
+		if (num_color < 2)
+			return dev_err_probe(dev, -EINVAL,
+					     "Multicolor must include

2 or more led channel\n");

"LED channels".

Quoted 6 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +6 -0
+static int mt6370_isnk_init_default_state(struct mt6370_led *led)
+{
+	struct mt6370_priv *priv = led->priv;
+	unsigned int enable, level;
+	int ret;
+

drivers/leds/rgb/leds-mt6370-rgb.c line 828

Quoted 10 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +10 -0
+	ret = mt6370_get_led_brightness(priv, led->index, &level);
+	if (ret)
+		return ret;
+
+	ret = regmap_field_read(priv->fields[F_RGB_EN], &enable);
+	if (ret)
+		return ret;
+
+	if (!(enable & MT6370_CHEN_BIT(led->index)))
+		level = LED_OFF;

Just use 0 instead of LED_OFF.

Best regards,
Pavel

Signature · 1 line
People of Russia, stop Putin before his war on Ukraine escalates.
#32 lore raw

Re: [PATCH v6 11/13] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

Hi Pavel,
Sorry for resending the mail, I add all reviewers this time.

Pavel Machek <[email protected]> 於 2022年7月31日 週日 清晨5:39寫道:

Quoted 3 lines

Hi!

...

Quoted 11 lines
Quoted 9 lines
drivers/leds/rgb/Kconfig +8 -0
+config LEDS_MT6370_RGB
+     tristate "LED Support for MediaTek MT6370 PMIC"
+     depends on MFD_MT6370
+     select LINEAR_RANGE
+     help
+       Say Y here to enable support for MT6370_RGB LED device.
+       In MT6370, there are four channel current-sink LED drivers that
+       support hardware pattern for constant current, PWM, and breath mode.
Quoted 4 lines
Quoted 1 line

+ Isink4 channel can also be used as a CHG_VIN power good indicator.

That does not really belong here.

Should we just remove it, or describe Isink4 in another position?

Quoted 6 lines

drivers/leds/rgb/leds-mt6370-rgb.c line 136

Quoted 3 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +3 -0
+struct mt6370_priv {
+     /* Per LED access lock */
+     struct mutex lock;

Do we really need per-led locking?

Sorry, maybe the comment is not precise.
The lock is used to prevent LEDs from accessing the HW at the same time.

If I use
/* LED access lock, only one LED can access the HW at the same time */ will it look better?
No, we aren't.
There are six steps tr1, tr2, tf1, tf2, ton, and toff in MT6370 led breath mode. We parse duration settings from node "hw_pattern" and set them to the registers.

This function is used to generate duration settings from hw_pattern.

The brightness of the six steps mentioned above in breath mode is limited to the node "brightness".
The target brightness of tr1 and tf1 is 25% of node "brightness", and they are automatically set by HW.

Quoted 5 lines
Quoted 5 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +5 -0
+static int mt6370_init_led_properties(struct mt6370_led *led,
+                                   struct led_init_data *init_data)
+{
+     struct mt6370_priv *priv = led->priv;
+     struct device *dev = priv->dev;
Quoted 9 lines

drivers/leds/rgb/leds-mt6370-rgb.c line 726

Quoted 5 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +5 -0
+     struct led_classdev *lcdev;
+     struct fwnode_handle *child;
+     enum mt6370_led_ranges sel_range;
+     u32 max_uA, max_level;
+     const char * const states[] = { "off", "keep", "on" };

We'd really preffer not to add "keep" / "on" support unless you need it.

Forgive me, but I would like to know why "keep" / "on" is not preferred. We think the users might have some conditions that need them.

Best Regards,
Alice

Pavel Machek <[email protected]> 於 2022年7月31日 週日 清晨5:39寫道:

Quoted 129 lines

Hi!

Quoted 14 lines

From: ChiYuan Huang <[email protected]>

The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

In MediaTek MT6370, there are four channel current-sink RGB LEDs that support hardware pattern for constant current, PWM, and breath mode. Isink4 channel can also be used as a CHG_VIN power good indicator.

drivers/leds/rgb/Kconfig +1 -0
+config LEDS_MT6370_RGB

drivers/leds/rgb/Kconfig config LEDS_QCOM_LPG · line 37

Quoted 10 lines
drivers/leds/rgb/Kconfig +8 -0
+     tristate "LED Support for MediaTek MT6370 PMIC"
+     depends on MFD_MT6370
+     select LINEAR_RANGE
+     help
+       Say Y here to enable support for MT6370_RGB LED device.
+       In MT6370, there are four channel current-sink LED drivers that
+       support hardware pattern for constant current, PWM, and breath mode.
 
 
+       Isink4 channel can also be used as a CHG_VIN power good  indicator.

That does not really belong here.

drivers/leds/rgb/leds-mt6370-rgb.c line 136

Quoted 3 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +3 -0
+struct mt6370_priv {
+     /* Per LED access lock */
+     struct mutex lock;

Do we really need per-led locking?

Quoted 27 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +27 -0
+static int mt6370_gen_breath_pattern(struct mt6370_priv *priv,
+                                  struct led_pattern *pattern, u32 len,
+                                  u8 *pattern_val, u32 val_len)
+{
+     enum mt6370_led_ranges sel_range;
+     struct led_pattern *curr;
+     unsigned int sel;
+     u8 val[P_MAX_PATTERNS / 2] = {};
+     int i;
+
+     if (len < P_MAX_PATTERNS && val_len < P_MAX_PATTERNS / 2)
+             return -EINVAL;
+
+     /*
+      * Pattern list
+      * tr1: byte 0, b'[7: 4]
+      * tr2: byte 0, b'[3: 0]
+      * tf1: byte 1, b'[7: 4]
+      * tf2: byte 1, b'[3: 0]
+      * ton: byte 2, b'[7: 4]
+      * toff: byte 2, b'[3: 0]
+      */
+     for (i = 0; i < P_MAX_PATTERNS; i++) {
+             curr = pattern + i;
+
+             sel_range = i == P_LED_TOFF ? R_LED_TOFF : R_LED_TRFON;
+

drivers/leds/rgb/leds-mt6370-rgb.c line 383

Quoted 10 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +10 -0
+             linear_range_get_selector_within(priv->ranges + sel_range,
+                                              curr->delta_t, &sel);
+
+             val[i / 2] |= sel << (4 * ((i + 1) % 2));
+     }
+
+     memcpy(pattern_val, val, 3);
+
+     return 0;
+}

I wonder how this works... you are not creating private sysfs interface, are you?

drivers/leds/rgb/leds-mt6370-rgb.c line 726

Quoted 10 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +10 -0
+static int mt6370_init_led_properties(struct mt6370_led *led,
+                                   struct led_init_data *init_data)
+{
+     struct mt6370_priv *priv = led->priv;
+     struct device *dev = priv->dev;
+     struct led_classdev *lcdev;
+     struct fwnode_handle *child;
+     enum mt6370_led_ranges sel_range;
+     u32 max_uA, max_level;
+     const char * const states[] = { "off", "keep", "on" };

We'd really preffer not to add "keep" / "on" support unless you need it.

drivers/leds/rgb/leds-mt6370-rgb.c line 751

Quoted 4 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +4 -0
+                     if (ret)
+                             return dev_err_probe(dev, ret,
+                                                  "led %d, no color specified\n",
+                                                  led->index);

led->LED.

Quoted 4 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +3 -0
+             if (num_color < 2)
+                     return dev_err_probe(dev, -EINVAL,
+                                          "Multicolor must include

2 or more led channel\n");

"LED channels".

Quoted 6 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +6 -0
+static int mt6370_isnk_init_default_state(struct mt6370_led *led)
+{
+     struct mt6370_priv *priv = led->priv;
+     unsigned int enable, level;
+     int ret;
+

drivers/leds/rgb/leds-mt6370-rgb.c line 828

Quoted 10 lines
drivers/leds/rgb/leds-mt6370-rgb.c new file +10 -0
+     ret = mt6370_get_led_brightness(priv, led->index, &level);
+     if (ret)
+             return ret;
+
+     ret = regmap_field_read(priv->fields[F_RGB_EN], &enable);
+     if (ret)
+             return ret;
+
+     if (!(enable & MT6370_CHEN_BIT(led->index)))
+             level = LED_OFF;

Just use 0 instead of LED_OFF.

Best regards,
Pavel

--
People of Russia, stop Putin before his war on Ukraine escalates.

author
#33 lore raw

PATCH v6 12/13 leds: flash: mt6370: Add MediaTek MT6370 flashlight support

In reply to ChiaEn Wu

From: Alice Chen <[email protected]>

The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

The Flash LED in MT6370 has 2 channels and support torch/strobe mode. Add the support of MT6370 FLASH LED.

---

v6
- Use 'GENMASK' instead of 'BIT'.
- Use dev_err_probe to decrease LOC.
- Use 'dev' variable to make probe function more clean.
- Refine the return of _mt6370_flash_brightness_set function.
- Refine the descriptions.
- Use mt6370_clamp() instead of clamp_align().
- Use device resource managed API for v4l2 flash_release.

---
 drivers/leds/flash/Kconfig             |  12 +
 drivers/leds/flash/Makefile            |   1 +
 drivers/leds/flash/leds-mt6370-flash.c | 633 +++++++++++++++++++++++++++++++++
 3 files changed, 646 insertions(+)
 create mode 100644 drivers/leds/flash/leds-mt6370-flash.c
drivers/leds/flash/Kconfig +12 -0
index d3eb689..d5761ed 100644
@@ -90,4 +90,16 @@ config LEDS_SGM3140
 	  This option enables support for the SGM3140 500mA Buck/Boost Charge
 	  Pump LED Driver.
 
+config LEDS_MT6370_FLASHLIGHT
+	tristate "Flash LED Support for MediaTek MT6370 PMIC"
+	depends on LEDS_CLASS
+	depends on MFD_MT6370
+	help
+	  Support 2 channels and torch/strobe mode.
+	  Say Y here to enable support for
+	  MT6370_FLASH_LED device.
+
+	  This driver can also be built as a module. If so, the module
+	  will be called "leds-mt6370-flash".
+
 endif # LEDS_CLASS_FLASH
drivers/leds/flash/Makefile +1 -0
index 0acbddc..4c4c171 100644
@@ -9,3 +9,4 @@ obj-$(CONFIG_LEDS_MAX77693)	+= leds-max77693.o
 obj-$(CONFIG_LEDS_RT4505)	+= leds-rt4505.o
 obj-$(CONFIG_LEDS_RT8515)	+= leds-rt8515.o
 obj-$(CONFIG_LEDS_SGM3140)	+= leds-sgm3140.o
+obj-$(CONFIG_LEDS_MT6370_FLASHLIGHT)	+= leds-mt6370-flash.o
drivers/leds/flash/leds-mt6370-flash.c new file +633 -0

633 lines not on this page · raw message

Signature · 1 line
2.7.4
#34 lore raw

Re: [PATCH v6 12/13] leds: flash: mt6370: Add MediaTek MT6370 flashlight support

Il 22/07/22 12:24, ChiaEn Wu ha scritto:

Quoted 89 lines

From: Alice Chen <[email protected]>

The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

The Flash LED in MT6370 has 2 channels and support torch/strobe mode. Add the support of MT6370 FLASH LED.

---

v6
- Use 'GENMASK' instead of 'BIT'.
- Use dev_err_probe to decrease LOC.
- Use 'dev' variable to make probe function more clean.
- Refine the return of _mt6370_flash_brightness_set function.
- Refine the descriptions.
- Use mt6370_clamp() instead of clamp_align().
- Use device resource managed API for v4l2 flash_release.

---
  drivers/leds/flash/Kconfig             |  12 +
  drivers/leds/flash/Makefile            |   1 +
  drivers/leds/flash/leds-mt6370-flash.c | 633 +++++++++++++++++++++++++++++++++
  3 files changed, 646 insertions(+)

create mode 100644 drivers/leds/flash/leds-mt6370-flash.c

drivers/leds/flash/Kconfig +12 -0
index d3eb689..d5761ed 100644
@@ -90,4 +90,16 @@ config LEDS_SGM3140
  	  This option enables support for the SGM3140 500mA Buck/Boost Charge
  	  Pump LED Driver.
 
+config LEDS_MT6370_FLASHLIGHT
+	tristate "Flash LED Support for MediaTek MT6370 PMIC"
+	depends on LEDS_CLASS
+	depends on MFD_MT6370
+	help
+	  Support 2 channels and torch/strobe mode.
+	  Say Y here to enable support for
+	  MT6370_FLASH_LED device.
+
+	  This driver can also be built as a module. If so, the module
+	  will be called "leds-mt6370-flash".
+
  endif # LEDS_CLASS_FLASH
drivers/leds/flash/Makefile +1 -0
index 0acbddc..4c4c171 100644
@@ -9,3 +9,4 @@ obj-$(CONFIG_LEDS_MAX77693)	+= leds-max77693.o
  obj-$(CONFIG_LEDS_RT4505)	+= leds-rt4505.o
  obj-$(CONFIG_LEDS_RT8515)	+= leds-rt8515.o
  obj-$(CONFIG_LEDS_SGM3140)	+= leds-sgm3140.o
+obj-$(CONFIG_LEDS_MT6370_FLASHLIGHT)	+= leds-mt6370-flash.o
drivers/leds/flash/leds-mt6370-flash.c new file +24 -0
new file mode 100644
index 0000000..fe439ee
@@ -0,0 +1,633 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2022 Richtek Technology Corp.
+ *
+ * Author: Alice Chen <[email protected]
+ */
+
+#include <linux/bitops.h>
+#include <linux/delay.h>
+#include <linux/init.h>
+#include <linux/interrupt.h>
+#include <linux/kernel.h>
+#include <linux/led-class-flash.h>
+#include <linux/module.h>
+#include <linux/mutex.h>
+#include <linux/platform_device.h>
+#include <linux/property.h>
+#include <linux/regmap.h>
+
+#include <media/v4l2-flash-led-class.h>
+
+enum {
+	MT6370_LED_FLASH1,
+	MT6370_LED_FLASH2,

drivers/leds/flash/leds-mt6370-flash.c line 34

Quoted 10 lines
drivers/leds/flash/leds-mt6370-flash.c new file +10 -0
+	MT6370_MAX_LEDS
+};
+
+/* Virtual definition for multicolor */
+
+#define MT6370_REG_FLEDEN		0x17E
+#define MT6370_REG_STRBTO		0x173
+#define MT6370_REG_CHGSTAT2		0x1D1
+#define MT6370_REG_FLEDSTAT1		0x1D9
+#define	MT6370_REG_FLEDISTRB(_id)	(0x174 + 4 * _id)

Please fix the indentation.

Quoted 5 lines
drivers/leds/flash/leds-mt6370-flash.c new file +5 -0
+#define MT6370_REG_FLEDITOR(_id)	(0x175 + 4 * _id)
+#define MT6370_ITORCH_MASK		GENMASK(4, 0)
+#define MT6370_ISTROBE_MASK		GENMASK(6, 0)
+#define MT6370_STRBTO_MASK		GENMASK(6, 0)
+#define MT6370_TORCHEN_MASK		BIT(3)

..snip..

Quoted 27 lines
drivers/leds/flash/leds-mt6370-flash.c new file +27 -0
+
+static int mt6370_init_flash_properties(struct mt6370_led *led,
+					struct led_init_data *init_data)
+{
+	struct led_classdev_flash *flash = &led->flash;
+	struct led_classdev *lcdev = &flash->led_cdev;
+	struct mt6370_priv *priv = led->priv;
+	struct led_flash_setting *s;
+	u32 sources[MT6370_MAX_LEDS];
+	u32 max_uA, val;
+	int i, ret, num;
+
+	num = fwnode_property_count_u32(init_data->fwnode, "led-sources");
+	if (num < 1 || num > MT6370_MAX_LEDS)
+		return dev_err_probe(priv->dev, -EINVAL,
+				     "Not specified or wrong number of led-sources\n");
+
+	ret = fwnode_property_read_u32_array(init_data->fwnode, "led-sources", sources, num);
+	if (ret)
+		return ret;
+
+	for (i = 0; i < num; i++) {
+		if (sources[i] >= MT6370_MAX_LEDS)
+			return -EINVAL;
+		if (priv->leds_active & BIT(sources[i]))
+			return -EINVAL;
+		priv->leds_active |= BIT(sources[i]);

drivers/leds/flash/leds-mt6370-flash.c line 495

Quoted 10 lines
drivers/leds/flash/leds-mt6370-flash.c new file +10 -0
+
+	}
+	led->led_no = (num == MT6370_MAX_LEDS) ? MT6370_LED_JOINT :
+		       sources[0];
+
+	max_uA = (num == 2) ? MT6370_ITORCH_DOUBLE_MAX_UA : MT6370_ITORCH_MAX_UA;
+	ret = fwnode_property_read_u32(init_data->fwnode, "led-max-microamp", &val);
+	if (ret) {
+		dev_warn(priv->dev,
+			 "Not specified led-max-microamp, config to the minimum\n");

This should be a dev_info() instead.

Quoted 6 lines
drivers/leds/flash/leds-mt6370-flash.c new file +6 -0
+		val = MT6370_ITORCH_MIN_UA;
+	} else {
+		val = mt6370_clamp(val, MT6370_ITORCH_MIN_UA, max_uA,
+				  MT6370_ITORCH_STEP_UA);
+	}
+

drivers/leds/flash/leds-mt6370-flash.c line 511

Quoted 10 lines
drivers/leds/flash/leds-mt6370-flash.c new file +10 -0
+	lcdev->max_brightness = (val - MT6370_ITORCH_MIN_UA) /
+				MT6370_ITORCH_STEP_UA + 1;
+	lcdev->brightness_set_blocking = mt6370_torch_brightness_set;
+	lcdev->flags |= LED_DEV_CAP_FLASH;
+
+	max_uA = (num == 2) ? MT6370_ISTRB_DOUBLE_MAX_UA : MT6370_ISTRB_MAX_UA;
+	ret = fwnode_property_read_u32(init_data->fwnode, "flash-max-microamp", &val);
+	if (ret) {
+		dev_warn(priv->dev,
+		   "Not specified flash-max-microamp, config to the minimum\n");

same here

Quoted 14 lines
drivers/leds/flash/leds-mt6370-flash.c new file +14 -0
+		val = MT6370_ISTRB_MIN_UA;
+	} else {
+		val = mt6370_clamp(val, MT6370_ISTRB_MIN_UA, max_uA,
+				  MT6370_ISTRB_STEP_UA);
+	}
+
+	s = &flash->brightness;
+	s->min = MT6370_ISTRB_MIN_UA;
+	s->step = MT6370_ISTRB_STEP_UA;
+	s->val = s->max = val;
+
+	/*
+	 * Always configure as min level when off to
+	 * prevent flash current spike

drivers/leds/flash/leds-mt6370-flash.c line 535

Quoted 10 lines
drivers/leds/flash/leds-mt6370-flash.c new file +10 -0
+	 */
+	ret = _mt6370_flash_brightness_set(flash, s->min);
+	if (ret)
+		return ret;
+
+	ret = fwnode_property_read_u32(init_data->fwnode,
+				       "flash-max-timeout-us", &val);
+	if (ret) {
+		dev_warn(priv->dev,
+			 "Not specified flash-max-timeout-us, config to the minimum\n");

and same here

Quoted 57 lines
drivers/leds/flash/leds-mt6370-flash.c new file +57 -0
+		val = MT6370_STRBTO_MIN_US;
+	} else {
+		val = mt6370_clamp(val, MT6370_STRBTO_MIN_US,
+				   MT6370_STRBTO_MAX_US, MT6370_STRBTO_STEP_US);
+	}
+
+	s = &flash->timeout;
+	s->min = MT6370_STRBTO_MIN_US;
+	s->step = MT6370_STRBTO_STEP_US;
+	s->val = s->max = val;
+
+	flash->ops = &mt6370_flash_ops;
+
+	return 0;
+}
+
+static int mt6370_init_common_properties(struct mt6370_led *led,
+					 struct led_init_data *init_data)
+{
+	const char * const states[] = { "off", "keep", "on" };
+	const char *str = states[STATE_OFF];
+	int ret;
+
+	fwnode_property_read_string(init_data->fwnode, "default-state", &str);
+	ret = match_string(states, ARRAY_SIZE(states), str);
+	if (ret >= 0)
+		led->default_state = ret;
+
+	return 0;
+}
+
+static int mt6370_led_probe(struct platform_device *pdev)
+{
+	struct device *dev = &pdev->dev;
+	struct mt6370_priv *priv;
+	struct fwnode_handle *child;
+	size_t count;
+	int i = 0, ret;
+
+	count = device_get_child_node_count(dev);
+	if (!count || count > MT6370_MAX_LEDS)
+		return dev_err_probe(dev, -EINVAL,
+		       "No child node or node count over max led number %zu\n", count);
+
+	priv = devm_kzalloc(dev, struct_size(priv, leds, count), GFP_KERNEL);
+	if (!priv)
+		return -ENOMEM;
+
+	priv->leds_count = count;
+	priv->dev = dev;
+	mutex_init(&priv->lock);
+
+	priv->regmap = dev_get_regmap(dev->parent, NULL);
+	if (!priv->regmap)
+		return dev_err_probe(dev, -ENODEV, "Failed to get parent regmap\n");
+
+	device_for_each_child_node(dev, child) {

drivers/leds/flash/leds-mt6370-flash.c line 602

Quoted 10 lines
drivers/leds/flash/leds-mt6370-flash.c new file +10 -0
+		struct mt6370_led *led = priv->leds + i;
+		struct led_init_data init_data = { .fwnode = child, };
+
+		led->priv = priv;
+		ret = mt6370_init_common_properties(led, &init_data);
+		if (ret)
+			return ret;
+
+		ret = mt6370_init_flash_properties(led, &init_data);
+

Unnecessary blank line here.

Quoted 5 lines
drivers/leds/flash/leds-mt6370-flash.c new file +5 -0
+		if (ret)
+			return ret;
+
+		ret = mt6370_led_register(dev, led, &init_data);
+		if (ret)

drivers/leds/flash/leds-mt6370-flash.c line 617

Quoted 10 lines
drivers/leds/flash/leds-mt6370-flash.c new file +10 -0
+			return ret;
+
+		i++;
+	}
+
+	return 0;
+}
+
+static const struct of_device_id mt6370_led_of_id[] = {
+	{ .compatible = "mediatek,mt6370-flashlight" },

As common practice, write that the last element is a sentinel.

	{ /* sentinel */ },

Everything else looks good.

Regards,
Angelo

#35 lore raw

Re: [PATCH v6 12/13] leds: flash: mt6370: Add MediaTek MT6370 flashlight support

In reply to ChiaEn Wu
Quoted 9 lines · ChiaEn Wu

From: Alice Chen <[email protected]>

The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

Quoted 4 lines

The Flash LED in MT6370 has 2 channels and support torch/strobe mode. Add the support of MT6370 FLASH LED.

This SoB chain is wrong. Prioritize and read Submitting Patches!

...

drivers/leds/flash/leds-mt6370-flash.c line 101

Quoted 12 lines
drivers/leds/flash/leds-mt6370-flash.c new file +11 -0
+static int mt6370_torch_brightness_set(struct led_classdev *lcdev,
+                                      enum led_brightness level)
+{
+       struct mt6370_led *led = to_mt6370_led(lcdev, flash.led_cdev);
+       struct mt6370_priv *priv = led->priv;
+       u32 led_enable_mask = (led->led_no == MT6370_LED_JOINT) ?
+                             MT6370_FLCSEN_MASK_ALL :
+                             MT6370_FLCSEN_MASK(led->led_no);
+       u32 enable_mask = MT6370_TORCHEN_MASK | led_enable_mask;
+       u32 val = level ? led_enable_mask : 0;
 
+       u32 prev = priv->fled_torch_used, curr;

Here and in the other functions with similar variables it seems you never use prev after assigning curr.
Just define a single variable and use it accordingly.

Quoted 57 lines
drivers/leds/flash/leds-mt6370-flash.c new file +57 -0
+       int ret, i;
+
+       mutex_lock(&priv->lock);
+
+       /*
+        * Only one set of flash control logic,
+        * use the flag to avoid strobe is currently used.
+        */
+       if (priv->fled_strobe_used) {
+               dev_warn(lcdev->dev, "Please disable strobe first [%d]\n",
+                        priv->fled_strobe_used);
+               ret = -EBUSY;
+               goto unlock;
+       }
+
+       if (level)
+               curr = prev | BIT(led->led_no);
+       else
+               curr = prev & ~BIT(led->led_no);
+
+       if (curr)
+               val |= MT6370_TORCHEN_MASK;
+
+       if (level) {
+               level -= 1;
+               if (led->led_no == MT6370_LED_JOINT) {
+                       int flevel[MT6370_MAX_LEDS];
+
+                       flevel[0] = level / 2;
+                       flevel[1] = level - flevel[0];
+                       for (i = 0; i < MT6370_MAX_LEDS; i++) {
+                               ret = regmap_update_bits(priv->regmap,
+                                               MT6370_REG_FLEDITOR(i),
+                                               MT6370_ITORCH_MASK, flevel[i]);
+                               if (ret)
+                                       goto unlock;
+                       }
+               } else {
+                       ret = regmap_update_bits(priv->regmap,
+                                       MT6370_REG_FLEDITOR(led->led_no),
+                                       MT6370_ITORCH_MASK, level);
+                       if (ret)
+                               goto unlock;
+               }
+       }
+
+       ret = regmap_update_bits(priv->regmap, MT6370_REG_FLEDEN,
+                                enable_mask, val);
+       if (ret)
+               goto unlock;
+
+       priv->fled_torch_used = curr;
+
+unlock:
+       mutex_unlock(&priv->lock);
+       return ret;
+}

...

Quoted 1 line

+ struct v4l2_flash_config v4l2_config = {0};

0 is not needed.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#36 lore raw

Re: [PATCH v6 12/13] leds: flash: mt6370: Add MediaTek MT6370 flashlight support

Andy Shevchenko <[email protected]> 於 2022年7月25日 週一 下午4:51寫道:

Quoted 11 lines · ChiaEn Wu
Quoted 9 lines

From: Alice Chen <[email protected]>

The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

Quoted 7 lines
Quoted 4 lines

The Flash LED in MT6370 has 2 channels and support torch/strobe mode. Add the support of MT6370 FLASH LED.

This SoB chain is wrong. Prioritize and read Submitting Patches!

Hi Andy,

After reading the Submitted Patches,
ChiaEn Wu wasn't involved in the development but he submitted the patch, So, ChiaEn Wu <[email protected]> should be the last SoB, right? I will revise SoB to

If there is anything else I need to fix, please let me know. Thank you.

Best Regards,
Szuni Chen

#37 lore raw

Re: [PATCH v6 12/13] leds: flash: mt6370: Add MediaTek MT6370 flashlight support

Quoted 4 lines · szuni chen

Andy Shevchenko <[email protected]> 於 2022年7月25日 週一 下午4:51寫道:

Quoted 3 lines · ChiaEn Wu
Quoted 2 lines

From: Alice Chen <[email protected]>

...

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

This SoB chain is wrong. Prioritize and read Submitting Patches!

After reading the Submitted Patches,
ChiaEn Wu wasn't involved in the development but he submitted the patch, So, ChiaEn Wu <[email protected]> should be the last SoB, right?

Right. Submitter's SoB is the last SoB in the chain.

Quoted 3 lines

I will revise SoB to

Not sure I understand the SzuNi <--> Alice transformation...

Quoted 3 lines

If there is anything else I need to fix, please let me know. Thank you.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#38 lore raw

Re: [PATCH v6 12/13] leds: flash: mt6370: Add MediaTek MT6370 flashlight support

In reply to ChiaEn Wu

On Fri, Jul 22, 2022 at 12:25 PM ChiaEn Wu <[email protected]> wrote:

Forgot to add a couple of things...

...

drivers/leds/flash/leds-mt6370-flash.c line 61

Quoted 8 lines
drivers/leds/flash/leds-mt6370-flash.c new file +8 -0
+#define MT6370_ITORCH_MIN_UA           25000
+#define MT6370_ITORCH_STEP_UA          12500
+#define MT6370_ITORCH_MAX_UA           400000
+#define MT6370_ITORCH_DOUBLE_MAX_UA    800000
+#define MT6370_ISTRB_MIN_UA            50000
+#define MT6370_ISTRB_STEP_UA           12500
+#define MT6370_ISTRB_MAX_UA            1500000
+#define MT6370_ISTRB_DOUBLE_MAX_UA     3000000

Perhaps _uA would be better and consistent across your series regarding current units.

...

Review

Quoted 2 lines
(quoted diff) +2 -0
+       /*
+        * For the flash to turn on/off, need to wait HW ramping up/down time

we need

drivers/leds/flash/leds-mt6370-flash.c line 261

Quoted 6 lines
drivers/leds/flash/leds-mt6370-flash.c new file +6 -0
+        * 5ms/500us to prevent the unexpected problem.
+        */
+       if (!prev && curr)
+               usleep_range(5000, 6000);
+       else if (prev && !curr)
+               udelay(500);

This still remains unanswered, why in the first place we allow switching, and a busy loop in the other place?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#39 lore raw

Re: [PATCH v6 12/13] leds: flash: mt6370: Add MediaTek MT6370 flashlight support

Hi Andy,

Quoted 13 lines

drivers/leds/flash/leds-mt6370-flash.c line 61

Quoted 9 lines
drivers/leds/flash/leds-mt6370-flash.c new file +8 -0
+#define MT6370_ITORCH_MIN_UA           25000
+#define MT6370_ITORCH_STEP_UA          12500
+#define MT6370_ITORCH_MAX_UA           400000
+#define MT6370_ITORCH_DOUBLE_MAX_UA    800000
+#define MT6370_ISTRB_MIN_UA            50000
+#define MT6370_ISTRB_STEP_UA           12500
+#define MT6370_ISTRB_MAX_UA            1500000
+#define MT6370_ISTRB_DOUBLE_MAX_UA     3000000

Perhaps _uA would be better and consistent across your series regarding current units.

Yes, _uA will be more consistent, but in general, using upper case in the define macro is a convention, doesn't it?

Quoted 13 lines

Review

Quoted 3 lines
(quoted diff) +2 -0
+       /*
+        * For the flash to turn on/off, need to wait for HW ramping up/down time

we need

drivers/leds/flash/leds-mt6370-flash.c line 261

Quoted 6 lines
drivers/leds/flash/leds-mt6370-flash.c new file +6 -0
+        * 5ms/500us to prevent the unexpected problem.
+        */
+       if (!prev && curr)
+               usleep_range(5000, 6000);
+       else if (prev && !curr)
+               udelay(500);
Quoted 2 lines

This still remains unanswered, why in the first place we allow switching, and a busy loop in the other place?

If I refine the description to
"For the flash to turn on/off, need to wait for 5ms/500us analog settling time. If any flash led is already used, then the analog is settled done, we don't need to wait again."
is it answer the question?

Best regards,
Alice

#40 lore raw

Re: [PATCH v6 12/13] leds: flash: mt6370: Add MediaTek MT6370 flashlight support

On Tue, Jul 26, 2022 at 6:15 AM szuni chen <[email protected]> wrote:

...

Quoted 12 lines
Quoted 11 lines

drivers/leds/flash/leds-mt6370-flash.c line 61

Quoted 8 lines
drivers/leds/flash/leds-mt6370-flash.c new file +8 -0
+#define MT6370_ITORCH_MIN_UA           25000
+#define MT6370_ITORCH_STEP_UA          12500
+#define MT6370_ITORCH_MAX_UA           400000
+#define MT6370_ITORCH_DOUBLE_MAX_UA    800000
+#define MT6370_ISTRB_MIN_UA            50000
+#define MT6370_ISTRB_STEP_UA           12500
+#define MT6370_ISTRB_MAX_UA            1500000
+#define MT6370_ISTRB_DOUBLE_MAX_UA     3000000

Perhaps _uA would be better and consistent across your series regarding current units.

Quoted 2 lines

Yes, _uA will be more consistent, but in general, using upper case in the define macro is a convention, doesn't it?

There is general convention, but there are also:
1) common sense;
2) usage in practice (e.g. _US, etc for *seconds and _HZ for *frequency).

My common sense tells me that it is convenient to use mA,uA, etc. Plus "in practice" it's related to use as in your series and elsewhere.

But of course it's minor to me, decide yourself.

...

Quoted 12 lines
Quoted 12 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+       /*
+        * For the flash to turn on/off, need to wait for HW ramping up/down time

we need

Quoted 6 lines
drivers/leds/flash/leds-mt6370-flash.c new file +6 -0
+        * 5ms/500us to prevent the unexpected problem.
+        */
+       if (!prev && curr)
+               usleep_range(5000, 6000);
+       else if (prev && !curr)
+               udelay(500);
Quoted 8 lines
Quoted 2 lines

This still remains unanswered, why in the first place we allow switching, and a busy loop in the other place?

If I refine the description to
"For the flash to turn on/off, need to wait for 5ms/500us analog settling time. If any flash led is already used, then the analog is settled done, we don't need to wait again."
is it answer the question?

No. I'm talking from the Linux APIs perspective. There is a huge difference between those branches. Please, conduct research, read documentation to understand what my question is about.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#41 lore raw

Re: [PATCH v6 12/13] leds: flash: mt6370: Add MediaTek MT6370 flashlight support

In reply to ChiaEn Wu

Hi!

Quoted 13 lines

From: Alice Chen <[email protected]>

The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

The Flash LED in MT6370 has 2 channels and support torch/strobe mode. Add the support of MT6370 FLASH LED.

drivers/leds/flash/Kconfig config LEDS_SGM3140 · line 95

Quoted 3 lines
drivers/leds/flash/Kconfig +3 -0
+config LEDS_MT6370_FLASHLIGHT
+	tristate "Flash LED Support for MediaTek MT6370 PMIC"
+	depends on LEDS_CLASS

I'd name it just LEDS_MT6370_FLASH.

drivers/leds/flash/leds-mt6370-flash.c line 5

Quoted 5 lines
drivers/leds/flash/leds-mt6370-flash.c new file +5 -0
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2022 Richtek Technology Corp.
+ *
+ * Author: Alice Chen <[email protected]

Add ">" at end of line.

The series is quite big, would it be possible to submit LED changes in separate series?

Thanks,
Pavel

Signature · 1 line
People of Russia, stop Putin before his war on Ukraine escalates.
#42 lore raw

Re: [PATCH v6 12/13] leds: flash: mt6370: Add MediaTek MT6370 flashlight support

Pavel Machek <[email protected]> 於 2022年7月31日 週日 清晨5:42寫道:

Quoted 11 lines

drivers/leds/flash/leds-mt6370-flash.c line 5

Quoted 5 lines
drivers/leds/flash/leds-mt6370-flash.c new file +5 -0
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2022 Richtek Technology Corp.
+ *
+ * Author: Alice Chen <[email protected]

Add ">" at end of line.

The series is quite big, would it be possible to submit LED changes in separate series?

Hi Pavel,

Our mfd dt-bindings depends on flash and LED dt-bindings, but our flash and LED config depend on mfd config. For the dependency consideration,
we think submitting them in a patch series is better.

Best Regards,
Alice

author
#43 lore raw

PATCH v6 13/13 video: backlight: mt6370: Add MediaTek MT6370 support

In reply to ChiaEn Wu

From: ChiaEn Wu <[email protected]>

MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight driver, display bias voltage supply, one general purpose LDO, and the USB Type-C & PD controller complies with the latest USB Type-C and PD standards.

This adds support for MediaTek MT6370 Backlight driver. It's commonly used to drive the display WLED. There are 4 channels inside, and each channel supports up to 30mA of current capability with 2048 current steps in exponential or linear mapping curves.

---
 drivers/video/backlight/Kconfig            |  12 +
 drivers/video/backlight/Makefile           |   1 +
 drivers/video/backlight/mt6370-backlight.c | 339 +++++++++++++++++++++++++++++
 3 files changed, 352 insertions(+)
 create mode 100644 drivers/video/backlight/mt6370-backlight.c
drivers/video/backlight/Kconfig +12 -0
index a003e02..846dbe7 100644
@@ -268,6 +268,18 @@ config BACKLIGHT_MAX8925
 	  If you have a LCD backlight connected to the WLED output of MAX8925
 	  WLED output, say Y here to enable this driver.
 
+config BACKLIGHT_MT6370
+	tristate "MediaTek MT6370 Backlight Driver"
+	depends on MFD_MT6370
+	help
+	  This enables support for Mediatek MT6370 Backlight driver.
+	  It's commonly used to drive the display WLED. There are 4 channels
+	  inside, and each channel supports up to 30mA of current capability
+	  with 2048 current steps in exponential or linear mapping curves.
+
+	  This driver can also be built as a module. If so, the module
+	  will be called "mt6370-backlight".
+
 config BACKLIGHT_APPLE
 	tristate "Apple Backlight Driver"
 	depends on X86 && ACPI
drivers/video/backlight/Makefile +1 -0
index cae2c83..e815f3f 100644
@@ -44,6 +44,7 @@ obj-$(CONFIG_BACKLIGHT_LP855X)		+= lp855x_bl.o
 obj-$(CONFIG_BACKLIGHT_LP8788)		+= lp8788_bl.o
 obj-$(CONFIG_BACKLIGHT_LV5207LP)	+= lv5207lp.o
 obj-$(CONFIG_BACKLIGHT_MAX8925)		+= max8925_bl.o
+obj-$(CONFIG_BACKLIGHT_MT6370)		+= mt6370-backlight.o
 obj-$(CONFIG_BACKLIGHT_OMAP1)		+= omap1_bl.o
 obj-$(CONFIG_BACKLIGHT_PANDORA)		+= pandora_bl.o
 obj-$(CONFIG_BACKLIGHT_PCF50633)	+= pcf50633-backlight.o
drivers/video/backlight/mt6370-backlight.c new file +339 -0

339 lines not on this page · raw message

Signature · 1 line
2.7.4
#44 lore raw

Re: [PATCH v6 13/13] video: backlight: mt6370: Add MediaTek MT6370 support

Quoted 10 lines · ChiaEn Wu

From: ChiaEn Wu <[email protected]>

MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight driver, display bias voltage supply, one general purpose LDO, and the USB Type-C & PD controller complies with the latest USB Type-C and PD standards.

This adds support for MediaTek MT6370 Backlight driver. It's commonly used

Read Submitting Patches, please!

(In this case, find "This patch" in the above mentioned document, read and act accordingly)

Quoted 3 lines

to drive the display WLED. There are 4 channels inside, and each channel supports up to 30mA of current capability with 2048 current steps in exponential or linear mapping curves.

...

Quoted 1 line

+ brightness_val[1] = (brightness - 1) >> fls(MT6370_BL_DIM2_MASK);

(see below)

...

drivers/video/backlight/mt6370-backlight.c line 81

Quoted 5 lines
drivers/video/backlight/mt6370-backlight.c new file +5 -0
+               /*
+                * To make MT6372 using 14 bits to control the brightness
+                * backward compatible with 11 bits brightness control
+                * (like MT6370 and MT6371 do), we left shift the value
+                * and pad with 1 to remaining bits. Hence, the MT6372's

to the remaining

drivers/video/backlight/mt6370-backlight.c line 88

Quoted 7 lines
drivers/video/backlight/mt6370-backlight.c new file +7 -0
+                * backlight brightness will be almost the same as MT6370's
+                * and MT6371's.
+                */
+               if (priv->vid_type == MT6370_VID_6372) {
+                       brightness_val[0] <<= MT6370_BL_DIM2_6372_SHIFT;
+                       brightness_val[0] |= MT6370_BL_DUMMY_6372_MASK;
+               }

Nice! Why not...

...

Quoted 1 line

+ gpiod_set_value(priv->enable_gpio, brightness ? 1 : 0);

!!brightness will do as well.

...

drivers/video/backlight/mt6370-backlight.c line 232

Quoted 9 lines
drivers/video/backlight/mt6370-backlight.c new file +5 -0
+       brightness = brightness_val[1] << fls(MT6370_BL_DIM2_MASK);
 
+               val |= prop_val << (ffs(MT6370_BL_PWM_HYS_SEL_MASK) - 1);
 
+               val |= ovp_uV << (ffs(MT6370_BL_OVP_SEL_MASK) - 1);
 
+               val |= ocp_uA << (ffs(MT6370_BL_OC_SEL_MASK) - 1);
 
+       val = prop_val << (ffs(MT6370_BL_CH_MASK) - 1);

...to use respective _SHIFTs in all these?

...

drivers/video/backlight/mt6370-backlight.c line 291

Quoted 4 lines
drivers/video/backlight/mt6370-backlight.c new file +4 -0
+       priv->enable_gpio = devm_gpiod_get_optional(dev, "enable",
+                                                   GPIOD_OUT_HIGH);
+       if (IS_ERR(priv->enable_gpio))
+               dev_err(dev, "Failed to get 'enable' gpio\n");

What does this mean? Shouldn't be

return dev_err_probe()?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#45 lore raw

Re: [PATCH v6 13/13] video: backlight: mt6370: Add MediaTek MT6370 support

In reply to ChiaEn Wu
Quoted 6 lines · ChiaEn Wu
drivers/video/backlight/Kconfig +0 -0
index a003e02..846dbe7 100644
@@ -268,6 +268,18 @@ config BACKLIGHT_MAX8925
 	  If you have a LCD backlight connected to the WLED output of MAX8925

drivers/video/backlight/Kconfig config BACKLIGHT_MAX8925 · line 278

Quoted 10 lines
drivers/video/backlight/Kconfig +8 -0
 	  WLED output, say Y here to enable this driver.
 
+config BACKLIGHT_MT6370
+	tristate "MediaTek MT6370 Backlight Driver"
+	depends on MFD_MT6370
+	help
+	  This enables support for Mediatek MT6370 Backlight driver.
+	  It's commonly used to drive the display WLED. There are 4 channels
+	  inside, and each channel supports up to 30mA of current capability
+	  with 2048 current steps in exponential or linear mapping curves.

Does the MT6372 support more steps than this? In other words does it use a fourteen bit scale or does it use an 11-bit scale at a different register location?

Quoted 25 lines
drivers/video/backlight/Kconfig +4 -0
+
+	  This driver can also be built as a module. If so, the module
+	  will be called "mt6370-backlight".
+
[...]
drivers/video/backlight/mt6370-backlight.c new file +14 -0
new file mode 100644
index 0000000..ba00a8f
[...]
+static int mt6370_bl_update_status(struct backlight_device *bl_dev)
+{
+	struct mt6370_priv *priv = bl_get_data(bl_dev);
+	int brightness = backlight_get_brightness(bl_dev);
+	unsigned int enable_val;
+	u8 brightness_val[2];
+	int ret;
+
+	if (brightness) {
+		brightness_val[0] = (brightness - 1) & MT6370_BL_DIM2_MASK;
+		brightness_val[1] = (brightness - 1) >> fls(MT6370_BL_DIM2_MASK);
+
+		/*
+		 * To make MT6372 using 14 bits to control the brightness

drivers/video/backlight/mt6370-backlight.c line 88

Quoted 10 lines
drivers/video/backlight/mt6370-backlight.c new file +10 -0
+		 * backward compatible with 11 bits brightness control
+		 * (like MT6370 and MT6371 do), we left shift the value
+		 * and pad with 1 to remaining bits. Hence, the MT6372's
+		 * backlight brightness will be almost the same as MT6370's
+		 * and MT6371's.
+		 */
+		if (priv->vid_type == MT6370_VID_6372) {
+			brightness_val[0] <<= MT6370_BL_DIM2_6372_SHIFT;
+			brightness_val[0] |= MT6370_BL_DUMMY_6372_MASK;
+		}

This somewhat depends on the answer to the first question above, but what is the point of this shifting? If the range is 14-bit then the driver should set max_brightness to 16384 and present the full range of the MT6372 to the user.

Especially when using linear mappings (which are a totally pointless scale to use for a backlight) the extra steps are useful for backlight animation.

Daniel.

author
#46 lore raw

Re: [PATCH v6 13/13] video: backlight: mt6370: Add MediaTek MT6370 support

Quoted 10 lines · Daniel Thompson
Quoted 8 lines · ChiaEn Wu
drivers/video/backlight/Kconfig +0 -0
index a003e02..846dbe7 100644
@@ -268,6 +268,18 @@ config BACKLIGHT_MAX8925
        If you have a LCD backlight connected to the WLED output of MAX8925
        WLED output, say Y here to enable this driver.
 
Quoted 12 lines

drivers/video/backlight/Kconfig config BACKLIGHT_MAX8925 · line 278

Quoted 8 lines
drivers/video/backlight/Kconfig +8 -0
+config BACKLIGHT_MT6370
+     tristate "MediaTek MT6370 Backlight Driver"
+     depends on MFD_MT6370
+     help
+       This enables support for Mediatek MT6370 Backlight driver.
+       It's commonly used to drive the display WLED. There are 4 channels
+       inside, and each channel supports up to 30mA of current capability
+       with 2048 current steps in exponential or linear mapping curves.

Does the MT6372 support more steps than this? In other words does it use a fourteen bit scale or does it use an 11-bit scale at a different register location?

Hi Daniel,

Thanks for your reply.
Yes, MT6372 can support 16384 steps and uses a 14-bit scale register location. But the maximum current of each
channel of MT6372 is the same as MT6370 and MT6371, both 30mA. The main reason why MT6372 is designed this way is that one of the customers asked for a more delicate
adjustment of the backlight brightness. But other customers actually do not have such requirements.
Therefore, we designed it this way for maximum compatibility in software.

Quoted 34 lines
Quoted 34 lines
drivers/video/backlight/Kconfig +4 -0
+
+       This driver can also be built as a module. If so, the module
+       will be called "mt6370-backlight".
+
[...]
drivers/video/backlight/mt6370-backlight.c new file +21 -0
new file mode 100644
index 0000000..ba00a8f
[...]
+static int mt6370_bl_update_status(struct backlight_device *bl_dev)
+{
+     struct mt6370_priv *priv = bl_get_data(bl_dev);
+     int brightness = backlight_get_brightness(bl_dev);
+     unsigned int enable_val;
+     u8 brightness_val[2];
+     int ret;
+
+     if (brightness) {
+             brightness_val[0] = (brightness - 1) & MT6370_BL_DIM2_MASK;
+             brightness_val[1] = (brightness - 1) >> fls(MT6370_BL_DIM2_MASK);
+
+             /*
+              * To make MT6372 using 14 bits to control the brightness
+              * backward compatible with 11 bits brightness control
+              * (like MT6370 and MT6371 do), we left shift the value
+              * and pad with 1 to remaining bits. Hence, the MT6372's
+              * backlight brightness will be almost the same as MT6370's
+              * and MT6371's.
+              */
+             if (priv->vid_type == MT6370_VID_6372) {
Quoted 8 lines

drivers/video/backlight/mt6370-backlight.c line 88

Quoted 3 lines
drivers/video/backlight/mt6370-backlight.c new file +3 -0
+                     brightness_val[0] <<= MT6370_BL_DIM2_6372_SHIFT;
+                     brightness_val[0] |= MT6370_BL_DUMMY_6372_MASK;
+             }

This somewhat depends on the answer to the first question above, but what is the point of this shifting? If the range is 14-bit then the driver should set max_brightness to 16384 and present the full range of the MT6372 to the user.

So should we make all 16384 steps of MT6372 available to users? Does that mean the DTS needs to be modified as well?
Or, for the reasons, I have just explained (just one customer has this requirement), then we do not make any changes for compatibility reasons?
Thanks.

Quoted 7 lines

Especially when using linear mappings (which are a totally pointless scale to use for a backlight) the extra steps are useful for backlight animation.

Daniel.

Signature · 2 lines
Best Regards,
ChiaEn Wu
#47 lore raw

Re: [PATCH v6 13/13] video: backlight: mt6370: Add MediaTek MT6370 support

Quoted 27 lines · ChiaEn Wu
Quoted 10 lines · Daniel Thompson
Quoted 8 lines · ChiaEn Wu
drivers/video/backlight/Kconfig +0 -0
index a003e02..846dbe7 100644
@@ -268,6 +268,18 @@ config BACKLIGHT_MAX8925
        If you have a LCD backlight connected to the WLED output of MAX8925
        WLED output, say Y here to enable this driver.
 
Quoted 12 lines

drivers/video/backlight/Kconfig config BACKLIGHT_MAX8925 · line 278

Quoted 8 lines
drivers/video/backlight/Kconfig +8 -0
+config BACKLIGHT_MT6370
+     tristate "MediaTek MT6370 Backlight Driver"
+     depends on MFD_MT6370
+     help
+       This enables support for Mediatek MT6370 Backlight driver.
+       It's commonly used to drive the display WLED. There are 4 channels
+       inside, and each channel supports up to 30mA of current capability
+       with 2048 current steps in exponential or linear mapping curves.

Does the MT6372 support more steps than this? In other words does it use a fourteen bit scale or does it use an 11-bit scale at a different register location?

Hi Daniel,

Quoted 9 lines

Thanks for your reply.
Yes, MT6372 can support 16384 steps and uses a 14-bit scale register location. But the maximum current of each
channel of MT6372 is the same as MT6370 and MT6371, both 30mA. The main reason why MT6372 is designed this way is that one of the customers asked for a more delicate
adjustment of the backlight brightness. But other customers actually do not have such requirements.
Therefore, we designed it this way for maximum compatibility in software.

I don't think that is an acceptable approach for the upstream kernel.

To be "compatible" with (broken) software this driver ends up reducing the capability of the upstream kernel to the point it becomes unable to meet requirements for delicate adjustment (requirements that were sufficiently important to change the hardware design so you could meet them).

Quoted 41 lines
Quoted 32 lines
Quoted 32 lines
drivers/video/backlight/Kconfig +4 -0
+
+       This driver can also be built as a module. If so, the module
+       will be called "mt6370-backlight".
+
[...]
drivers/video/backlight/mt6370-backlight.c new file +21 -0
new file mode 100644
index 0000000..ba00a8f
[...]
+static int mt6370_bl_update_status(struct backlight_device *bl_dev)
+{
+     struct mt6370_priv *priv = bl_get_data(bl_dev);
+     int brightness = backlight_get_brightness(bl_dev);
+     unsigned int enable_val;
+     u8 brightness_val[2];
+     int ret;
+
+     if (brightness) {
+             brightness_val[0] = (brightness - 1) & MT6370_BL_DIM2_MASK;
+             brightness_val[1] = (brightness - 1) >> fls(MT6370_BL_DIM2_MASK);
+
+             /*
+              * To make MT6372 using 14 bits to control the brightness
+              * backward compatible with 11 bits brightness control
+              * (like MT6370 and MT6371 do), we left shift the value
+              * and pad with 1 to remaining bits. Hence, the MT6372's
+              * backlight brightness will be almost the same as MT6370's
+              * and MT6371's.
+              */
+             if (priv->vid_type == MT6370_VID_6372) {
Quoted 8 lines

drivers/video/backlight/mt6370-backlight.c line 88

Quoted 3 lines
drivers/video/backlight/mt6370-backlight.c new file +3 -0
+                     brightness_val[0] <<= MT6370_BL_DIM2_6372_SHIFT;
+                     brightness_val[0] |= MT6370_BL_DUMMY_6372_MASK;
+             }

This somewhat depends on the answer to the first question above, but what is the point of this shifting? If the range is 14-bit then the driver should set max_brightness to 16384 and present the full range of the MT6372 to the user.

Quoted 1 line

So should we make all 16384 steps of MT6372 available to users?

Yes.

Quoted 1 line

Does that mean the DTS needs to be modified as well?

Yes... the property to set initial brightness needs a 14-bit range.

It would also be a good idea to discuss with the DT maintainers whether you should introduce a second compatible string (ending 6372) in order to allow the DT validation checks to detect accidental use of MT6372 ranges on MT6370 hardware.

Quoted 3 lines

Or, for the reasons, I have just explained (just one customer has this requirement), then we do not make any changes for compatibility reasons?

I'd be curious what the compatiblity reasons are. In other words what software breaks?

Normally the userspace backlight code reads the max_brightness property and configures things accordingly (and therefore if you the component that breaks is something like an Android HAL then fix the HAL instead).

Daniel.

author
#48 lore raw

Re: [PATCH v6 13/13] video: backlight: mt6370: Add MediaTek MT6370 support

On Tue, Jul 26, 2022 at 5:31 PM Daniel Thompson
<[email protected]> wrote:
...

Quoted 6 lines
Quoted 6 lines
Quoted 3 lines

Does the MT6372 support more steps than this? In other words does it use a fourteen bit scale or does it use an 11-bit scale at a different register location?

Hi Daniel,

Quoted 9 lines
Quoted 9 lines

Thanks for your reply.
Yes, MT6372 can support 16384 steps and uses a 14-bit scale register location. But the maximum current of each
channel of MT6372 is the same as MT6370 and MT6371, both 30mA. The main reason why MT6372 is designed this way is that one of the customers asked for a more delicate
adjustment of the backlight brightness. But other customers actually do not have such requirements.
Therefore, we designed it this way for maximum compatibility in software.

Sorry for I used of the wrong word, I mean is 'driver', not higher-level software

Quoted 8 lines

I don't think that is an acceptable approach for the upstream kernel.

To be "compatible" with (broken) software this driver ends up reducing the capability of the upstream kernel to the point it becomes unable to meet requirements for delicate adjustment (requirements that were sufficiently important to change the hardware design so you could meet them).

Originally, we just wanted to use one version of the driver to cover all the SubPMIC of the 6370 series(6370~6372).
And, the users who use this series SubPMIC can directly apply this driver to drive the backlight device without knowing the underlying hardware.
To achieve this goal, we have designed it to look like this.

Quoted 2 lines

...

Quoted 28 lines
Quoted 23 lines
Quoted 14 lines
Quoted 14 lines
drivers/video/backlight/mt6370-backlight.c new file +14 -0
+
+     if (brightness) {
+             brightness_val[0] = (brightness - 1) & MT6370_BL_DIM2_MASK;
+             brightness_val[1] = (brightness - 1) >> fls(MT6370_BL_DIM2_MASK);
+
+             /*
+              * To make MT6372 using 14 bits to control the brightness
+              * backward compatible with 11 bits brightness control
+              * (like MT6370 and MT6371 do), we left shift the value
+              * and pad with 1 to remaining bits. Hence, the MT6372's
+              * backlight brightness will be almost the same as MT6370's
+              * and MT6371's.
+              */
+             if (priv->vid_type == MT6370_VID_6372) {
Quoted 8 lines

drivers/video/backlight/mt6370-backlight.c line 88

Quoted 3 lines
drivers/video/backlight/mt6370-backlight.c new file +3 -0
+                     brightness_val[0] <<= MT6370_BL_DIM2_6372_SHIFT;
+                     brightness_val[0] |= MT6370_BL_DUMMY_6372_MASK;
+             }

This somewhat depends on the answer to the first question above, but what is the point of this shifting? If the range is 14-bit then the driver should set max_brightness to 16384 and present the full range of the MT6372 to the user.

Quoted 1 line

So should we make all 16384 steps of MT6372 available to users?

Yes.

Quoted 8 lines
Quoted 1 line

Does that mean the DTS needs to be modified as well?

Yes... the property to set initial brightness needs a 14-bit range.

It would also be a good idea to discuss with the DT maintainers whether you should introduce a second compatible string (ending 6372) in order to allow the DT validation checks to detect accidental use of MT6372 ranges on MT6370 hardware.

hmmm... I have just thought about it,
maybe I can just modify the maximum value of default-brightness and max-brightness in DT to 16384,
modify the description and add some comments.

And then on the driver side,
we can use mt6370_check_vendor_info( ) to determine whether it is MT6372. If no, then in mt6370_bl_update_status(), first brightness_val / 8 and then set. In mt6370_bl_get_brightness(), first brightness_val * 8 and then return;

If I do this change, does this meet your requirements?

Quoted 8 lines
Quoted 5 lines

Or, for the reasons, I have just explained (just one customer has this requirement), then we do not make any changes for compatibility reasons?

I'd be curious what the compatiblity reasons are. In other words what software breaks?

The reason is as above. We just hope the users who use this series SubPMIC can directly apply this driver to drive the backlight device without knowing the underlying hardware.
Not software breaks.

Thanks!

Quoted 7 lines

Normally the userspace backlight code reads the max_brightness property and configures things accordingly (and therefore if you the component that breaks is something like an Android HAL then fix the HAL instead).

Daniel.

Signature · 2 lines
Best Regards,
ChiaEn Wu
#49 lore raw

Re: [PATCH v6 13/13] video: backlight: mt6370: Add MediaTek MT6370 support

Quoted 31 lines · ChiaEn Wu

On Tue, Jul 26, 2022 at 5:31 PM Daniel Thompson
<[email protected]> wrote:
...

Quoted 6 lines
Quoted 6 lines
Quoted 3 lines

Does the MT6372 support more steps than this? In other words does it use a fourteen bit scale or does it use an 11-bit scale at a different register location?

Hi Daniel,

Quoted 9 lines
Quoted 9 lines

Thanks for your reply.
Yes, MT6372 can support 16384 steps and uses a 14-bit scale register location. But the maximum current of each
channel of MT6372 is the same as MT6370 and MT6371, both 30mA. The main reason why MT6372 is designed this way is that one of the customers asked for a more delicate
adjustment of the backlight brightness. But other customers actually do not have such requirements.
Therefore, we designed it this way for maximum compatibility in software.

Sorry for I used of the wrong word, I mean is 'driver', not higher-level software

Quoted 8 lines

I don't think that is an acceptable approach for the upstream kernel.

To be "compatible" with (broken) software this driver ends up reducing the capability of the upstream kernel to the point it becomes unable to meet requirements for delicate adjustment (requirements that were sufficiently important to change the hardware design so you could meet them).

Quoted 6 lines

Originally, we just wanted to use one version of the driver to cover all the SubPMIC of the 6370 series(6370~6372).
And, the users who use this series SubPMIC can directly apply this driver to drive the backlight device without knowing the underlying hardware.
To achieve this goal, we have designed it to look like this.

You don't need a second driver to support two different values for max-brightness. The same driver can support both ranges with nothing but a small tweak during the driver probe function.

Quoted 38 lines

...

Quoted 28 lines
Quoted 23 lines
Quoted 14 lines
Quoted 14 lines
drivers/video/backlight/mt6370-backlight.c new file +14 -0
+
+     if (brightness) {
+             brightness_val[0] = (brightness - 1) & MT6370_BL_DIM2_MASK;
+             brightness_val[1] = (brightness - 1) >> fls(MT6370_BL_DIM2_MASK);
+
+             /*
+              * To make MT6372 using 14 bits to control the brightness
+              * backward compatible with 11 bits brightness control
+              * (like MT6370 and MT6371 do), we left shift the value
+              * and pad with 1 to remaining bits. Hence, the MT6372's
+              * backlight brightness will be almost the same as MT6370's
+              * and MT6371's.
+              */
+             if (priv->vid_type == MT6370_VID_6372) {
Quoted 8 lines

drivers/video/backlight/mt6370-backlight.c line 88

Quoted 3 lines
drivers/video/backlight/mt6370-backlight.c new file +3 -0
+                     brightness_val[0] <<= MT6370_BL_DIM2_6372_SHIFT;
+                     brightness_val[0] |= MT6370_BL_DUMMY_6372_MASK;
+             }

This somewhat depends on the answer to the first question above, but what is the point of this shifting? If the range is 14-bit then the driver should set max_brightness to 16384 and present the full range of the MT6372 to the user.

Quoted 1 line

So should we make all 16384 steps of MT6372 available to users?

Yes.

Quoted 8 lines
Quoted 1 line

Does that mean the DTS needs to be modified as well?

Yes... the property to set initial brightness needs a 14-bit range.

It would also be a good idea to discuss with the DT maintainers whether you should introduce a second compatible string (ending 6372) in order to allow the DT validation checks to detect accidental use of MT6372 ranges on MT6370 hardware.

Quoted 4 lines

hmmm... I have just thought about it,
maybe I can just modify the maximum value of default-brightness and max-brightness in DT to 16384,
modify the description and add some comments.

What for?

All the other backlight drivers (there are >130 of them) expose the hardware range[1]. Most userspaces will already know how to handle that (by reading the max_brightness and, if it is recent enough, also the scale properties in sysfs).

I'm still don't understand why one should fix a bug in the userspace by implementing a hack in the driver.

[1] Well almost. The PWM backlight driver does contain support for dead-spot avoidance and to allow the adoption of exponential scale. However this purpose of these is based on how PWM backlights work

Quoted 6 lines

And then on the driver side,
we can use mt6370_check_vendor_info( ) to determine whether it is MT6372. If no, then in mt6370_bl_update_status(), first brightness_val / 8 and then set. In mt6370_bl_get_brightness(), first brightness_val * 8 and then return;

If I do this change, does this meet your requirements?

Not really.

It's still misleading a sophisticated userspace, which may make bad rounding decisions for backlight animation, in order to support a broken one.

Quoted 11 lines
Quoted 6 lines
Quoted 3 lines

Or, for the reasons, I have just explained (just one customer has this requirement), then we do not make any changes for compatibility reasons?

I'd be curious what the compatiblity reasons are. In other words what software breaks?

The reason is as above. We just hope the users who use this series SubPMIC can directly apply this driver to drive the backlight device without knowing the underlying hardware.
Not software breaks.

As above, ignoring the max_brightness property is a bug in the userspace. I'm still unclear why sending faked ranges to userspace it a better solution than fixing the userspace.

Daniel.

author
#50 lore raw

Re: [PATCH v6 13/13] video: backlight: mt6370: Add MediaTek MT6370 support

On Tue, Jul 26, 2022 at 7:59 PM Daniel Thompson
<[email protected]> wrote:

...

Quoted 119 lines
Quoted 28 lines
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines

Does the MT6372 support more steps than this? In other words does it use a fourteen bit scale or does it use an 11-bit scale at a different register location?

Hi Daniel,

Quoted 9 lines
Quoted 9 lines

Thanks for your reply.
Yes, MT6372 can support 16384 steps and uses a 14-bit scale register location. But the maximum current of each
channel of MT6372 is the same as MT6370 and MT6371, both 30mA. The main reason why MT6372 is designed this way is that one of the customers asked for a more delicate
adjustment of the backlight brightness. But other customers actually do not have such requirements.
Therefore, we designed it this way for maximum compatibility in software.

Sorry for I used of the wrong word, I mean is 'driver', not higher-level software

Quoted 8 lines

I don't think that is an acceptable approach for the upstream kernel.

To be "compatible" with (broken) software this driver ends up reducing the capability of the upstream kernel to the point it becomes unable to meet requirements for delicate adjustment (requirements that were sufficiently important to change the hardware design so you could meet them).

Quoted 6 lines

Originally, we just wanted to use one version of the driver to cover all the SubPMIC of the 6370 series(6370~6372).
And, the users who use this series SubPMIC can directly apply this driver to drive the backlight device without knowing the underlying hardware.
To achieve this goal, we have designed it to look like this.

You don't need a second driver to support two different values for max-brightness. The same driver can support both ranges with nothing but a small tweak during the driver probe function.

Quoted 38 lines

...

Quoted 28 lines
Quoted 23 lines
Quoted 14 lines
Quoted 14 lines
drivers/video/backlight/mt6370-backlight.c new file +14 -0
+
+     if (brightness) {
+             brightness_val[0] = (brightness - 1) & MT6370_BL_DIM2_MASK;
+             brightness_val[1] = (brightness - 1) >> fls(MT6370_BL_DIM2_MASK);
+
+             /*
+              * To make MT6372 using 14 bits to control the brightness
+              * backward compatible with 11 bits brightness control
+              * (like MT6370 and MT6371 do), we left shift the value
+              * and pad with 1 to remaining bits. Hence, the MT6372's
+              * backlight brightness will be almost the same as MT6370's
+              * and MT6371's.
+              */
+             if (priv->vid_type == MT6370_VID_6372) {
Quoted 8 lines

drivers/video/backlight/mt6370-backlight.c line 88

Quoted 3 lines
drivers/video/backlight/mt6370-backlight.c new file +3 -0
+                     brightness_val[0] <<= MT6370_BL_DIM2_6372_SHIFT;
+                     brightness_val[0] |= MT6370_BL_DUMMY_6372_MASK;
+             }

This somewhat depends on the answer to the first question above, but what is the point of this shifting? If the range is 14-bit then the driver should set max_brightness to 16384 and present the full range of the MT6372 to the user.

Quoted 1 line

So should we make all 16384 steps of MT6372 available to users?

Yes.

Quoted 8 lines
Quoted 1 line

Does that mean the DTS needs to be modified as well?

Yes... the property to set initial brightness needs a 14-bit range.

It would also be a good idea to discuss with the DT maintainers whether you should introduce a second compatible string (ending 6372) in order to allow the DT validation checks to detect accidental use of MT6372 ranges on MT6370 hardware.

Quoted 4 lines

hmmm... I have just thought about it,
maybe I can just modify the maximum value of default-brightness and max-brightness in DT to 16384,
modify the description and add some comments.

What for?

All the other backlight drivers (there are >130 of them) expose the hardware range[1]. Most userspaces will already know how to handle that (by reading the max_brightness and, if it is recent enough, also the scale properties in sysfs).

I'm still don't understand why one should fix a bug in the userspace by implementing a hack in the driver.

[1] Well almost. The PWM backlight driver does contain support for dead-spot avoidance and to allow the adoption of exponential scale. However this purpose of these is based on how PWM backlights work

Quoted 6 lines

And then on the driver side,
we can use mt6370_check_vendor_info() to determine whether it is MT6372. If no, then in mt6370_bl_update_status(), first brightness_val / 8 and then set. In mt6370_bl_get_brightness(), first brightness_val * 8 and then return;

If I do this change, does this meet your requirements?

Not really.

It's still misleading a sophisticated userspace, which may make bad rounding decisions for backlight animation, in order to support a broken one.

Quoted 7 lines
Quoted 6 lines
Quoted 3 lines

Or, for the reasons, I have just explained (just one customer has this requirement), then we do not make any changes for compatibility reasons?

I'd be curious what the compatiblity reasons are. In other words what software breaks?

Quoted 8 lines
Quoted 4 lines

The reason is as above. We just hope the users who use this series SubPMIC can directly apply this driver to drive the backlight device without knowing the underlying hardware.
Not software breaks.

As above, ignoring the max_brightness property is a bug in the userspace. I'm still unclear why sending faked ranges to userspace it a better solution than fixing the userspace.

Ok, I got it!
If I add a second compatible string (like 'mediatek,mt6372-backlight') in the DT section,
and append 'if-then-else' to determine the correct maximum value of 'default-brightness' and 'max-brightness',
Also, I will append 'bled exponential mode' to make user control using linear or exponential mode.
These changes I will explain to DT's maintainer again.

Back to the driver section,
do I still need to use the register to confirm again whether this SubPMIC used now is MT6372 and record this information? (using 'mt6370_check_vendor_info()')
I am afraid that the user who uses the MT6370 hardware, but the DT compatible string is set to 'mediatek,mt6372-backlight'. This may cause errors when update/get brightness values. So I hope the driver here can check again to make sure the 'default-brightness', 'max-brightness', can be updated/got correctly. I don't know if this will make you feel redundant if I do this??

Thank you so much!

Signature · 2 lines
Best Regards,
ChiaEn Wu
#51 lore raw

Re: [PATCH v6 13/13] video: backlight: mt6370: Add MediaTek MT6370 support

Quoted 15 lines · ChiaEn Wu
Quoted 13 lines · Daniel Thompson
Quoted 13 lines
Quoted 13 lines
Quoted 1 line

So should we make all 16384 steps of MT6372 available to users?

Yes.

Quoted 1 line

Does that mean the DTS needs to be modified as well?

Yes... the property to set initial brightness needs a 14-bit range.

It would also be a good idea to discuss with the DT maintainers whether you should introduce a second compatible string (ending 6372) in order to allow the DT validation checks to detect accidental use of MT6372 ranges on MT6370 hardware.

[snip]

Quoted 12 lines
Quoted 11 lines
Quoted 7 lines
Quoted 2 lines

I'd be curious what the compatiblity reasons are. In other words what software breaks?

The reason is as above. We just hope the users who use this series SubPMIC can directly apply this driver to drive the backlight device without knowing the underlying hardware.
Not software breaks.

As above, ignoring the max_brightness property is a bug in the userspace. I'm still unclear why sending faked ranges to userspace it a better solution than fixing the userspace.

Quoted 7 lines

Ok, I got it!
If I add a second compatible string (like 'mediatek,mt6372-backlight') in the DT section,
and append 'if-then-else' to determine the correct maximum value of 'default-brightness' and 'max-brightness',
Also, I will append 'bled exponential mode' to make user control using linear or exponential mode.

I'd be very pleased to see support for exponential mode added: it's a much better way to control LEDs and backlights.

Quoted 1 line

These changes I will explain to DT's maintainer again.

Excellent. I know DT maintainers are copied into this thread but they will probably not be following this patch's thread so it is better to discuss in the mail thread for the DT bindings!

Quoted 10 lines

Back to the driver section,
do I still need to use the register to confirm again whether this SubPMIC used now is MT6372 and record this information? (using 'mt6370_check_vendor_info()')
I am afraid that the user who uses the MT6370 hardware, but the DT compatible string is set to 'mediatek,mt6372-backlight'. This may cause errors when update/get brightness values. So I hope the driver here can check again to make sure the 'default-brightness', 'max-brightness', can be updated/got correctly. I don't know if this will make you feel redundant if I do this??

Yes, it's good idea to check the hardware model during probe. I'd suggest just reporting this as an error ("Buggy DT, wrong compatible string") rather than trying to re-intepret the parameters.

Daniel.