Skip to contentSkip to conversation

meta-security: Add recipe for libhoth

PATCH In review [email protected] 3 participants 5 messages Jul 22, 2022 – Jul 30, 2022

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 meta-security: Add recipe for libhoth

From: John Edward Broadbent <[email protected]>

Libhoth is usb protocol implementation which is required for hoth class devices

---
 meta-tpm/recipes-tpm/hoth/libhoth_git.bb | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 meta-tpm/recipes-tpm/hoth/libhoth_git.bb
meta-tpm/recipes-tpm/hoth/libhoth_git.bb new file +17 -0
new file mode 100644
index 0000000..a3ebce7
@@ -0,0 +1,17 @@
+SUMMARY = "Google Hoth USB library"
+DESCRIPTION = "Libraries and example programs for interacting with a \
+               hoth-class root of trust."
+HOMEPAGE = "https://github.com/google/libhoth"
+
+LICENSE = "Apache-2.0"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
+
+SRC_URI = "git://github.com/google/libhoth;protocol=https;branch=main"
+SRCREV = "1622e8a040d21dd564fdc1cb4df5eda01688c197"
+
+DEPENDS += "libusb1"
+
+S = "${WORKDIR}/git"
+
+inherit pkgconfig meson
+
Signature · 1 line
2.37.1.359.gd136c6c3e2-goog
#1 lore raw
Quoted 18 lines · John Broadbent via lists.yoctoproject.org

From: John Edward Broadbent <[email protected]>

Libhoth is usb protocol implementation which is required for hoth class devices

---
 meta-tpm/recipes-tpm/hoth/libhoth_git.bb | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 meta-tpm/recipes-tpm/hoth/libhoth_git.bb
meta-tpm/recipes-tpm/hoth/libhoth_git.bb new file +0 -0
new file mode 100644
index 0000000..a3ebce7

meta-tpm/recipes-tpm/hoth/libhoth_git.bb line 10

Quoted 10 lines
meta-tpm/recipes-tpm/hoth/libhoth_git.bb new file +10 -0
@@ -0,0 +1,17 @@
+SUMMARY = "Google Hoth USB library"
+DESCRIPTION = "Libraries and example programs for interacting with a \
+               hoth-class root of trust."
+HOMEPAGE = "https://github.com/google/libhoth"
+
+LICENSE = "Apache-2.0"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
+
+SRC_URI = "git://github.com/google/libhoth;protocol=https;branch=main"
+SRCREV = "1622e8a040d21dd564fdc1cb4df5eda01688c197"

it still has the musl related issue, that I pointed out

Quoted 20 lines
meta-tpm/recipes-tpm/hoth/libhoth_git.bb new file +7 -1
+
+DEPENDS += "libusb1"
+
+S = "${WORKDIR}/git"
+
+inherit pkgconfig meson
+
--

2.37.1.359.gd136c6c3e2-goog

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
You automatically follow any topics you start or reply to. View/Reply Online (#57624): https://lists.yoctoproject.org/g/yocto/message/57624
Mute This Topic: https://lists.yoctoproject.org/mt/92551443/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#2 lore raw

That is unexpected.

The sha change should have changed the PAGE_SIZE to SPI_PAGE_SIZE, correcting the macro shadowing issue.
See:
https://github.com/google/libhoth/commit/1622e8a040d21dd564fdc1cb4df5eda01688c197

Thanks for very quick review
John Broadbent

Quoted 54 lines · Khem Raj
Quoted 18 lines · John Broadbent via lists.yoctoproject.org

From: John Edward Broadbent <[email protected]>

Libhoth is usb protocol implementation which is required for hoth class devices

---
 meta-tpm/recipes-tpm/hoth/libhoth_git.bb | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 meta-tpm/recipes-tpm/hoth/libhoth_git.bb
meta-tpm/recipes-tpm/hoth/libhoth_git.bb new file +0 -0
new file mode 100644
index 0000000..a3ebce7

meta-tpm/recipes-tpm/hoth/libhoth_git.bb line 10

Quoted 10 lines
meta-tpm/recipes-tpm/hoth/libhoth_git.bb new file +10 -0
@@ -0,0 +1,17 @@
+SUMMARY = "Google Hoth USB library"
+DESCRIPTION = "Libraries and example programs for interacting with a \
+               hoth-class root of trust."
+HOMEPAGE = "https://github.com/google/libhoth"
+
+LICENSE = "Apache-2.0"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
+
+SRC_URI = "git://github.com/google/libhoth;protocol=https;branch=main"
+SRCREV = "1622e8a040d21dd564fdc1cb4df5eda01688c197"

it still has the musl related issue, that I pointed out

Quoted 20 lines
meta-tpm/recipes-tpm/hoth/libhoth_git.bb new file +7 -1
+
+DEPENDS += "libusb1"
+
+S = "${WORKDIR}/git"
+
+inherit pkgconfig meson
+
--

2.37.1.359.gd136c6c3e2-goog

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
You automatically follow any topics you start or reply to. View/Reply Online (#57624): https://lists.yoctoproject.org/g/yocto/message/57624
Mute This Topic: https://lists.yoctoproject.org/mt/92551443/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#3 lore raw
Quoted 8 lines · John Broadbent

That is unexpected.

The sha change should have changed the PAGE_SIZE to SPI_PAGE_SIZE, correcting the macro shadowing issue.
See:
https://github.com/google/libhoth/commit/1622e8a040d21dd564fdc1cb4df5eda01688c197

right, I missed that in this v3 the SRCREV is bumped too which should address the issue.

Quoted 58 lines

Thanks for very quick review
John Broadbent

Quoted 54 lines · Khem Raj
Quoted 18 lines · John Broadbent via lists.yoctoproject.org

From: John Edward Broadbent <[email protected]>

Libhoth is usb protocol implementation which is required for hoth class devices

---
 meta-tpm/recipes-tpm/hoth/libhoth_git.bb | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 meta-tpm/recipes-tpm/hoth/libhoth_git.bb
meta-tpm/recipes-tpm/hoth/libhoth_git.bb new file +0 -0
new file mode 100644
index 0000000..a3ebce7

meta-tpm/recipes-tpm/hoth/libhoth_git.bb line 10

Quoted 10 lines
meta-tpm/recipes-tpm/hoth/libhoth_git.bb new file +10 -0
@@ -0,0 +1,17 @@
+SUMMARY = "Google Hoth USB library"
+DESCRIPTION = "Libraries and example programs for interacting with a \
+               hoth-class root of trust."
+HOMEPAGE = "https://github.com/google/libhoth"
+
+LICENSE = "Apache-2.0"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
+
+SRC_URI = "git://github.com/google/libhoth;protocol=https;branch=main"
+SRCREV = "1622e8a040d21dd564fdc1cb4df5eda01688c197"

it still has the musl related issue, that I pointed out

Quoted 20 lines
meta-tpm/recipes-tpm/hoth/libhoth_git.bb new file +7 -1
+
+DEPENDS += "libusb1"
+
+S = "${WORKDIR}/git"
+
+inherit pkgconfig meson
+
--

2.37.1.359.gd136c6c3e2-goog

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
You automatically follow any topics you start or reply to. View/Reply Online (#57624): https://lists.yoctoproject.org/g/yocto/message/57624
Mute This Topic: https://lists.yoctoproject.org/mt/92551443/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#4 lore raw
In reply to [email protected]

merged.

Quoted 43 lines · John Broadbent via lists.yoctoproject.org

From: John Edward Broadbent <[email protected]>

Libhoth is usb protocol implementation which is required for hoth class devices

---
  meta-tpm/recipes-tpm/hoth/libhoth_git.bb | 17 +++++++++++++++++
  1 file changed, 17 insertions(+)

create mode 100644 meta-tpm/recipes-tpm/hoth/libhoth_git.bb

meta-tpm/recipes-tpm/hoth/libhoth_git.bb new file +17 -1
new file mode 100644
index 0000000..a3ebce7
@@ -0,0 +1,17 @@
+SUMMARY = "Google Hoth USB library"
+DESCRIPTION = "Libraries and example programs for interacting with a \
+               hoth-class root of trust."
+HOMEPAGE = "https://github.com/google/libhoth"
+
+LICENSE = "Apache-2.0"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
+
+SRC_URI = "git://github.com/google/libhoth;protocol=https;branch=main"
+SRCREV = "1622e8a040d21dd564fdc1cb4df5eda01688c197"
+
+DEPENDS += "libusb1"
+
+S = "${WORKDIR}/git"
+
+inherit pkgconfig meson
+
 
-=-=-=-=-=-=-=-=-=-=-=-

Links: You receive all messages sent to this group.
View/Reply Online (#57624): https://lists.yoctoproject.org/g/yocto/message/57624
Mute This Topic: https://lists.yoctoproject.org/mt/92551443/3616698
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-