irqchip/mmp: fix missing extern init code
Subsystems (3)
PATCH v2 1/1 irqchip/mmp: fix missing extern init code
The functions icu_init_irq and mmp2_init_icu are exported from this code, so declare them in the header file to avoid the following sparse warnings:
drivers/irqchip/irq-mmp.c:248:13: warning: symbol 'icu_init_irq' was not declared. Should it be static? drivers/irqchip/irq-mmp.c:271:13: warning: symbol 'mmp2_init_icu' was not declared. Should it be static?
--
- v2: added pxa machine includes into this patch
--- arch/arm/mach-mmp/mmp2.h | 2 +- arch/arm/mach-mmp/pxa168.h | 2 +- arch/arm/mach-mmp/pxa910.h | 2 +- include/linux/irqchip/mmp.h | 3 +++ 4 files changed, 6 insertions(+), 3 deletions(-)
arch/arm/mach-mmp/mmp2.h +1 -1
@@ -5,13 +5,13 @@#include <linux/platform_data/pxa_sdhci.h> extern void mmp2_timer_init (void ); -extern void __init mmp2_init_icu (void );extern void __init mmp2_init_irq (void );extern void mmp2_clear_pmic_int (void );#include <linux/i2c.h> #include <linux/platform_data/i2c-pxa.h> #include <linux/platform_data/dma-mmp_tdma.h> +#include <linux/irqchip/mmp.h> #include "devices.h"
arch/arm/mach-mmp/pxa168.h +1 -1
@@ -5,7 +5,6 @@#include <linux/reboot.h> extern void pxa168_timer_init (void ); -extern void __init icu_init_irq (void );extern void __init pxa168_init_irq (void );extern void pxa168_restart (enum reboot_mode ,const char *);extern void pxa168_clear_keypad_wakeup (void );
@@ -18,6 +17,7 @@ extern void pxa168_clear_keypad_wakeup(void);#include <linux/pxa168_eth.h> #include <linux/platform_data/mv_usb.h> #include <linux/soc/mmp/cputype.h> +#include <linux/irqchip/mmp.h> #include "devices.h"
arch/arm/mach-mmp/pxa910.h +1 -1
@@ -3,13 +3,13 @@#define __ASM_MACH_PXA910_Hextern void pxa910_timer_init (void ); -extern void __init icu_init_irq (void );extern void __init pxa910_init_irq (void );#include <linux/i2c.h> #include <linux/platform_data/i2c-pxa.h> #include <linux/platform_data/mtd-nand-pxa3xx.h> #include <video/mmp_disp.h> +#include <linux/irqchip/mmp.h> #include "devices.h"
include/linux/irqchip/mmp.h +3 -0
@@ -4,4 +4,7 @@extern struct irq_chip icu_irq_chip; +extern void icu_init_irq (void ); +extern void mmp2_init_icu (void ); +#endif /* __IRQCHIP_MMP_H */
Signature · 1 line
2.35.1
[irqchip: irq/irqchip-next] irqchip/mmp: Declare init functions in common header file
The following commit has been merged into the irq/irqchip-next branch of irqchip:
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: 9d9b010f12cc4e254bbba32d79c965b564a8957f Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/9d9b010f12cc4e254bbba32d79c965b564a8957f Author: Ben Dooks <[email protected]> AuthorDate: Sun, 24 Jul 2022 23:21:52 +01:00 Committer: Marc Zyngier <[email protected]> CommitterDate: Mon, 25 Jul 2022 09:42:24 +01:00
irqchip/mmp: Declare init functions in common header file
The functions icu_init_irq and mmp2_init_icu are exported from this code, so declare them in the header file to avoid the following sparse warnings:
drivers/irqchip/irq-mmp.c:248:13: warning: symbol 'icu_init_irq' was not declared. Should it be static? drivers/irqchip/irq-mmp.c:271:13: warning: symbol 'mmp2_init_icu' was not declared. Should it be static?
--- arch/arm/mach-mmp/mmp2.h | 2 +- arch/arm/mach-mmp/pxa168.h | 2 +- arch/arm/mach-mmp/pxa910.h | 2 +- include/linux/irqchip/mmp.h | 3 +++ 4 files changed, 6 insertions(+), 3 deletions(-)
arch/arm/mach-mmp/mmp2.h +1 -1
@@ -5,13 +5,13 @@#include <linux/platform_data/pxa_sdhci.h> extern void mmp2_timer_init (void ); -extern void __init mmp2_init_icu (void );extern void __init mmp2_init_irq (void );extern void mmp2_clear_pmic_int (void );#include <linux/i2c.h> #include <linux/platform_data/i2c-pxa.h> #include <linux/platform_data/dma-mmp_tdma.h> +#include <linux/irqchip/mmp.h> #include "devices.h"
arch/arm/mach-mmp/pxa168.h +1 -1
@@ -5,7 +5,6 @@#include <linux/reboot.h> extern void pxa168_timer_init (void ); -extern void __init icu_init_irq (void );extern void __init pxa168_init_irq (void );extern void pxa168_restart (enum reboot_mode ,const char *);extern void pxa168_clear_keypad_wakeup (void );
@@ -18,6 +17,7 @@ extern void pxa168_clear_keypad_wakeup(void);#include <linux/pxa168_eth.h> #include <linux/platform_data/mv_usb.h> #include <linux/soc/mmp/cputype.h> +#include <linux/irqchip/mmp.h> #include "devices.h"
arch/arm/mach-mmp/pxa910.h +1 -1
@@ -3,13 +3,13 @@#define __ASM_MACH_PXA910_Hextern void pxa910_timer_init (void ); -extern void __init icu_init_irq (void );extern void __init pxa910_init_irq (void );#include <linux/i2c.h> #include <linux/platform_data/i2c-pxa.h> #include <linux/platform_data/mtd-nand-pxa3xx.h> #include <video/mmp_disp.h> +#include <linux/irqchip/mmp.h> #include "devices.h"
include/linux/irqchip/mmp.h +3 -0
@@ -4,4 +4,7 @@extern struct irq_chip icu_irq_chip; +extern void icu_init_irq (void ); +extern void mmp2_init_icu (void ); +#endif /* __IRQCHIP_MMP_H */