Skip to contentSkip to conversation

drm/amdgpu: add declaration of function ‘drm_need_swiotlb’ in gmc10.0

PATCH In review Aaron Liu 2 participants 2 messages Jul 25, 2022

Subsystems (2)
lore
Share & tools
lore

Aaron Liu

author
#0 lore raw

PATCH 1/1 drm/amdgpu: add declaration of function ‘drm_need_swiotlb’ in gmc10.0

Fixing compiling error:
drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c: In function ‘gmc_v10_0_sw_init’:
drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c:983:23: error: implicit declaration of function ‘drm_need_swiotlb’ [-Werror=implicit-function-declaration]
983 | adev->need_swiotlb = drm_need_swiotlb(44);

---
 drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c +3 -0
index f8fa27b7b53b..9ae8cdaa033e 100644
@@ -22,6 +22,9 @@
  */
 #include <linux/firmware.h>
 #include <linux/pci.h>
+
+#include <drm/drm_cache.h>
+
 #include "amdgpu.h"
 #include "amdgpu_atomfirmware.h"
 #include "gmc_v10_0.h"
Signature · 1 line
2.37.0
#1 lore raw
Quoted 6 lines · Aaron

Fixing compiling error:
drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c: In function ‘gmc_v10_0_sw_init’:
drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c:983:23: error: implicit declaration of function ‘drm_need_swiotlb’ [-Werror=implicit-function-declaration]
983 | adev->need_swiotlb = drm_need_swiotlb(44);

Please revert the one in the amd-staging-drm-next, and squeeze it into the last one. We would better not separate them as two.

Please make sure the patch can be built successfully at least before push it.

Thanks,
Ray

Quoted 21 lines
---
 drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c +3 -0
index f8fa27b7b53b..9ae8cdaa033e 100644
@@ -22,6 +22,9 @@
  */
 #include <linux/firmware.h>
 #include <linux/pci.h>
+
+#include <drm/drm_cache.h>
+
 #include "amdgpu.h"
 #include "amdgpu_atomfirmware.h"
 #include "gmc_v10_0.h"
Signature · 1 line
2.37.0