Skip to contentSkip to conversation

dt-bindings: spmi: add compatible for mt8188

PATCH In review Sen Chu 3 participants 5 messages Jul 26, 2022 – Jul 28, 2022

Subsystems (3)
lore
Share & tools
lore

Sen Chu

author
#0 lore raw

PATCH 1/1 dt-bindings: spmi: add compatible for mt8188

Add dt-binding documentation of spmi for Mediatek MT8188 SoC platform.

---
 Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml +1 -0
index 2445c5e0b0ef..05801e0199f9 100644
@@ -20,6 +20,7 @@ properties:
   compatible:
     enum:
       - mediatek,mt6873-spmi
+      - mediatek,mt8188-spmi
       - mediatek,mt8195-spmi
 
   reg:
Signature · 1 line
2.25.1
#3 lore raw
In reply to Sen Chu

Il 26/07/22 12:37, Sen Chu ha scritto:

Quoted 13 lines

Add dt-binding documentation of spmi for Mediatek MT8188 SoC platform.

---
  Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml | 1 +
  1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml +0 -0
index 2445c5e0b0ef..05801e0199f9 100644

Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml properties: · line 23

Quoted 4 lines
Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml +1 -0
@@ -20,6 +20,7 @@ properties:
    compatible:
      enum:
        - mediatek,mt6873-spmi
+      - mediatek,mt8188-spmi

I think that you'll be adding a SPMI node that will have:

compatible = "mediatek,mt8188-spmi", "mediatek,mt8195-spmi";

Which means that this is actually wrong, so, please fix it by adding items...

Regards,
Angelo

Quoted 4 lines
Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml +0 -0
        - mediatek,mt8195-spmi
 
    reg:
#4 lore raw
Quoted 21 lines · AngeloGioacchino Del Regno

Il 26/07/22 12:37, Sen Chu ha scritto:

Quoted 13 lines

Add dt-binding documentation of spmi for Mediatek MT8188 SoC platform.

---
  Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml | 1 +
  1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml +0 -0
index 2445c5e0b0ef..05801e0199f9 100644

Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml properties: · line 23

Quoted 4 lines
Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml +1 -0
@@ -20,6 +20,7 @@ properties:
    compatible:
      enum:
        - mediatek,mt6873-spmi
+      - mediatek,mt8188-spmi

I think that you'll be adding a SPMI node that will have:

Quoted 4 lines

compatible = "mediatek,mt8188-spmi", "mediatek,mt8195-spmi";

Which means that this is actually wrong, so, please fix it by adding items...

I wished bindings were not coming along but with DTS so we can check if submitter understands what he/she/they are coding...

I also wished bindings in schema were used for testing their own DTBS without sending.

Ehh.... :(
Best regards,
Krzysztof