Skip to contentSkip to conversation

drm/i915/gt: remove redundant pointer sseu

PATCH New Colin Ian King 2 participants 3 messages Jul 26, 2022 – Aug 4, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/gt: remove redundant pointer sseu

Pointer sseu is being assigned a value that is never read. The pointer is redundant and can be removed. Cleans up clang scan warning:

drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c:300:2: warning: Value stored to 'sseu' is never read [deadcode.DeadStores]

---
 drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c +0 -2
index 75257bd20ff0..c0578194ab16 100644
@@ -286,7 +286,6 @@ guc_capture_alloc_steered_lists_xe_lpd(struct intel_guc *guc,
 	const struct __guc_mmio_reg_descr_group *list;
 	struct __guc_mmio_reg_descr_group *extlists;
 	struct __guc_mmio_reg_descr *extarray;
-	struct sseu_dev_info *sseu;
 
 	/* In XE_LPD we only have steered registers for the render-class */
 	list = guc_capture_get_one_list(lists, GUC_CAPTURE_LIST_INDEX_PF,
@@ -297,7 +296,6 @@ guc_capture_alloc_steered_lists_xe_lpd(struct intel_guc *guc,
 
 	num_steer_regs = ARRAY_SIZE(xe_extregs);
 
-	sseu = &gt->info.sseu;
 	for_each_ss_steering(iter, gt, slice, subslice)
 		num_tot_regs += num_steer_regs;
 
Signature · 1 line
2.35.3
#1 lore raw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: remove redundant pointer sseu

== Series Details ==

== Series Details ==

Series: drm/i915/gt: remove redundant pointer sseu
URL : https://patchwork.freedesktop.org/series/106982/
State : warning

== Summary ==

Error: dim checkpatch failed
d471c966d875 drm/i915/gt: remove redundant pointer sseu
-:33: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Colin Ian King <[email protected]>' != 'Signed-off-by: Colin Ian King <[email protected]>'

total: 0 errors, 1 warnings, 0 checks, 14 lines checked

#2 lore raw

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: remove redundant pointer sseu

In reply to Colin Ian King
== Series Details ==

== Series Details ==

Series: drm/i915/gt: remove redundant pointer sseu
URL : https://patchwork.freedesktop.org/series/106982/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11967 -> Patchwork_106982v1
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_106982v1 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_106982v1, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106982v1/index.html

Participating hosts (42 -> 41)
------------------------------

Additional (1): fi-bsw-n3050
Missing (2): fi-hsw-4770 fi-bdw-samus

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_106982v1:

### IGT changes ###

#### Possible regressions ####

* igt@core_hotunplug@unbind-rebind:
- fi-skl-6700k2: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11967/fi-skl-6700k2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106982v1/fi-skl-6700k2/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_106982v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_tiled_blits@basic:
- fi-bsw-n3050: NOTRUN -> [SKIP][3] ([fdo#109271]) +19 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106982v1/fi-bsw-n3050/igt@[email protected]

* igt@i915_selftest@live@gem:
- fi-pnv-d510: NOTRUN -> [DMESG-FAIL][4] ([i915#4528])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106982v1/fi-pnv-d510/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@hangcheck:
- bat-dg1-5: [PASS][5] -> [DMESG-FAIL][6] ([i915#4494] / [i915#4957])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11967/bat-dg1-5/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106982v1/bat-dg1-5/igt@i915_selftest@[email protected]

* igt@i915_suspend@basic-s2idle-without-i915:
- fi-bdw-gvtdvm: NOTRUN -> [INCOMPLETE][7] ([i915#4817])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106982v1/fi-bdw-gvtdvm/igt@[email protected]

* igt@kms_chamelium@hdmi-edid-read:
- fi-bsw-n3050: NOTRUN -> [SKIP][8] ([fdo#109271] / [fdo#111827]) +8 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106982v1/fi-bsw-n3050/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s0@smem:
- {bat-rplp-1}: [DMESG-WARN][9] ([i915#2867]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11967/bat-rplp-1/igt@gem_exec_suspend@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106982v1/bat-rplp-1/igt@gem_exec_suspend@[email protected]

* igt@gem_exec_suspend@basic-s3@smem:
- {bat-adlm-1}: [DMESG-WARN][11] ([i915#2867]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11967/bat-adlm-1/igt@gem_exec_suspend@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106982v1/bat-adlm-1/igt@gem_exec_suspend@[email protected]

* igt@i915_selftest@live@execlists:
- fi-bdw-gvtdvm: [INCOMPLETE][13] ([i915#2940]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11967/fi-bdw-gvtdvm/igt@i915_selftest@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106982v1/fi-bdw-gvtdvm/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@guc:
- {bat-rpls-1}: [DMESG-WARN][15] ([i915#6471]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11967/bat-rpls-1/igt@i915_selftest@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106982v1/bat-rpls-1/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@requests:
- {bat-rpls-1}: [DMESG-FAIL][17] ([i915#5087] / [i915#6257]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11967/bat-rpls-1/igt@i915_selftest@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106982v1/bat-rpls-1/igt@i915_selftest@[email protected]
- fi-pnv-d510: [DMESG-FAIL][19] ([i915#4528]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11967/fi-pnv-d510/igt@i915_selftest@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106982v1/fi-pnv-d510/igt@i915_selftest@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
- fi-bsw-kefka: [FAIL][21] ([i915#6298]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11967/fi-bsw-kefka/igt@kms_cursor_legacy@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106982v1/fi-bsw-kefka/igt@kms_cursor_legacy@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#5087]: https://gitlab.freedesktop.org/drm/intel/issues/5087
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6471]: https://gitlab.freedesktop.org/drm/intel/issues/6471

Build changes
-------------

* Linux: CI_DRM_11967 -> Patchwork_106982v1

CI-20190529: 20190529
CI_DRM_11967: 2dbea6ff1c1059cd5b0b74b903fb7ff9875cc381 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6613: 209230467200f2fa63a6f71fe6299996470dd813 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_106982v1: 2dbea6ff1c1059cd5b0b74b903fb7ff9875cc381 @ git://anongit.freedesktop.org/gfx-ci/linux

### Linux commits

dc858537bb9a drm/i915/gt: remove redundant pointer sseu

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106982v1/index.html