Skip to contentSkip to conversation

ptp: ocp: Select CRC16 in the Kconfig.

PATCH Applied Jonathan Lemon 3 participants 3 messages Jul 26, 2022 – Jul 28, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ptp: ocp: Select CRC16 in the Kconfig.

The crc16() function is used to check the firmware validity, but the library was not explicitly selected.

Fixes 3c3673bde50c ("ptp: ocp: Add firmware header checks")

---
CC: Richard Cochran <[email protected]>
CC: Vadim Fedorenko <[email protected]>

---
 drivers/ptp/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/ptp/Kconfig +1 -0
index 458218f88c5e..fe4971b65c64 100644
@@ -176,6 +176,7 @@ config PTP_1588_CLOCK_OCP
 	depends on !S390
 	depends on COMMON_CLK
 	select NET_DEVLINK
+	select CRC16
 	help
 	  This driver adds support for an OpenCompute time card.
 
Signature · 1 line
2.34.3
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Jonathan Lemon

The crc16() function is used to check the firmware validity, but the library was not explicitly selected.

Fixes 3c3673bde50c ("ptp: ocp: Add firmware header checks")
Quoted 7 lines

---
CC: Richard Cochran <[email protected]>
CC: Vadim Fedorenko <[email protected]>

---
  drivers/ptp/Kconfig | 1 +
  1 file changed, 1 insertion(+)
#2 lore raw
In reply to Jonathan Lemon
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Tue, 26 Jul 2022 15:06:04 -0700 you wrote:

The crc16() function is used to check the firmware validity, but the library was not explicitly selected.

Fixes 3c3673bde50c ("ptp: ocp: Add firmware header checks")

[...]

Here is the summary with links:
- [net] ptp: ocp: Select CRC16 in the Kconfig.

    https://git.kernel.org/netdev/net/c/0c1045562672

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html