ARM: dts: turris-omnia: Add ethernet aliases
PATCH 1/1 ARM: dts: turris-omnia: Add ethernet aliases
This allows bootloader to correctly pass MAC addresses used by bootloader to individual interfaces into kernel device tree.
--- arch/arm/boot/dts/armada-385-turris-omnia.dts | 6 ++++++ 1 file changed, 6 insertions(+)
arch/arm/boot/dts/armada-385-turris-omnia.dts +6 -0
@@ -23,6 +23,12 @@ stdout-path = &uart0; }; + aliases { + ethernet0 = ð0; + ethernet1 = ð1; + ethernet2 = ð2; + }; + memory { device_type = "memory"; reg = <0x00000000 0x40000000>; /* 1024 MB */
Signature · 1 line
2.20.1
Quoted 5 lines · On Wednesday 27 July 2022 15:09:26 Pali Rohár wrote:
This allows bootloader to correctly pass MAC addresses used by bootloader to individual interfaces into kernel device tree.
Signed-off-by Pali Rohár <[email protected]>---
Maybe this should have Fixes line?
Quoted 23 lines
arch/arm/boot/dts/armada-385-turris-omnia.dts | 6 ++++++ 1 file changed, 6 insertions(+)arch/arm/boot/dts/armada-385-turris-omnia.dts +6
-0@@ -23,6 +23,12 @@ stdout-path = &uart0; }; + aliases { + ethernet0 = ð0; + ethernet1 = ð1; + ethernet2 = ð2; + }; + memory { device_type = "memory"; reg = <0x00000000 0x40000000>; /* 1024 MB */Signature · 1 line
2.20.1
Quoted 10 lines · Pali Rohár
Quoted 5 lines · On Wednesday 27 July 2022 15:09:26 Pali Rohár wrote:
This allows bootloader to correctly pass MAC addresses used by bootloader to individual interfaces into kernel device tree.
Signed-off-by Pali Rohár <[email protected]>---
Maybe this should have Fixes line?
Fixes 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
Is it broken with older kernels? That is a big part of Fixes: to indicate it needs back porting. Is this a new u-boot feature?
Andrew
Quoted 8 lines · On Tuesday 09 August 2022 22:28:51 Andrew Lunn wrote:
Quoted 7 lines · Pali Rohár
Quoted 5 lines · On Wednesday 27 July 2022 15:09:26 Pali Rohár wrote:
This allows bootloader to correctly pass MAC addresses used by bootloader to individual interfaces into kernel device tree.
Signed-off-by Pali Rohár <[email protected]>---
Quoted 8 lines
Quoted 3 lines
Maybe this should have Fixes line?
Fixes 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")Is it broken with older kernels? That is a big part of Fixes: to indicate it needs back porting. Is this a new u-boot feature?
Andrew
This is old u-boot feature. I was investigating why u-boot is not able to correctly modify loaded omnia dtb file when booting linux kernel and I found out that it is because it cannot due to missing ethernet aliases.
Also there is a new u-boot feature for omnia to correctly put phy-reset-gpios property into eth 2 node based on board hw revision. So this is another purpose for which we should have those aliases, to allow kernel to correctly reset wan (eth 2) PHY.
I would suggest this change for backporting into stable.
PING?
Quoted 28 lines · On Wednesday 27 July 2022 15:09:26 Pali Rohár wrote:
This allows bootloader to correctly pass MAC addresses used by bootloader to individual interfaces into kernel device tree.
Signed-off-by Pali Rohár <[email protected]>--- arch/arm/boot/dts/armada-385-turris-omnia.dts | 6 ++++++ 1 file changed, 6 insertions(+)arch/arm/boot/dts/armada-385-turris-omnia.dts +6
-0@@ -23,6 +23,12 @@ stdout-path = &uart0; }; + aliases { + ethernet0 = ð0; + ethernet1 = ð1; + ethernet2 = ð2; + }; + memory { device_type = "memory"; reg = <0x00000000 0x40000000>; /* 1024 MB */Signature · 1 line
2.20.1
Gregory: PING?
Quoted 31 lines · On Saturday 24 September 2022 14:13:02 Pali Rohár wrote:
PING?
Quoted 28 lines · On Wednesday 27 July 2022 15:09:26 Pali Rohár wrote:
This allows bootloader to correctly pass MAC addresses used by bootloader to individual interfaces into kernel device tree.
Signed-off-by Pali Rohár <[email protected]>--- arch/arm/boot/dts/armada-385-turris-omnia.dts | 6 ++++++ 1 file changed, 6 insertions(+)arch/arm/boot/dts/armada-385-turris-omnia.dts +6
-0@@ -23,6 +23,12 @@ stdout-path = &uart0; }; + aliases { + ethernet0 = ð0; + ethernet1 = ð1; + ethernet2 = ð2; + }; + memory { device_type = "memory"; reg = <0x00000000 0x40000000>; /* 1024 MB */Signature · 1 line
2.20.1
PING?
Quoted 34 lines · On Sunday 09 October 2022 13:46:59 Pali Rohár wrote:
Gregory: PING?
Quoted 31 lines · On Saturday 24 September 2022 14:13:02 Pali Rohár wrote:
PING?
Quoted 28 lines · On Wednesday 27 July 2022 15:09:26 Pali Rohár wrote:
This allows bootloader to correctly pass MAC addresses used by bootloader to individual interfaces into kernel device tree.
Signed-off-by Pali Rohár <[email protected]>--- arch/arm/boot/dts/armada-385-turris-omnia.dts | 6 ++++++ 1 file changed, 6 insertions(+)arch/arm/boot/dts/armada-385-turris-omnia.dts +6
-0@@ -23,6 +23,12 @@ stdout-path = &uart0; }; + aliases { + ethernet0 = ð0; + ethernet1 = ð1; + ethernet2 = ð2; + }; + memory { device_type = "memory"; reg = <0x00000000 0x40000000>; /* 1024 MB */Signature · 1 line
2.20.1
Quoted 4 lines · Pali Rohár
This allows bootloader to correctly pass MAC addresses used by bootloader to individual interfaces into kernel device tree.
Signed-off-by Pali Rohár <[email protected]>
Applied on mvebu/dt
Thanks,
Gregory
Quoted 24 lines
--- arch/arm/boot/dts/armada-385-turris-omnia.dts | 6 ++++++ 1 file changed, 6 insertions(+)arch/arm/boot/dts/armada-385-turris-omnia.dts +6
-0@@ -23,6 +23,12 @@ stdout-path = &uart0; }; + aliases { + ethernet0 = ð0; + ethernet1 = ð1; + ethernet2 = ð2; + }; + memory { device_type = "memory"; reg = <0x00000000 0x40000000>; /* 1024 MB */Signature · 1 line
2.20.1
Signature · 3 lines
Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com