Skip to contentSkip to conversation

cmd: part: Add partition-related type command

PATCH Superseded Enric Balletbo i Serra 3 participants 3 messages Jul 27, 2022

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cmd: part: Add partition-related type command

This implements the following command:

part type mmc 0:1
-> print partittion type UUID
part type mmc 0:1 uuid
-> set environment variable to partition type UUID

"part type" can be useful when writing a bootcmd which searches for a specific partition type to enable automatic discovery of partitions and their intended usage or mount point.

---

 cmd/part.c | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)
cmd/part.c +29 -0
index 9d419c967c..26b0cc84fe 100644
@@ -182,6 +182,29 @@ static int do_part_number(int argc, char *const argv[])
 	return do_part_info(argc, argv, CMD_PART_INFO_NUMBER);
 }
 
+static int do_part_type(int argc, char *const argv[])
+{
+	int part;
+	struct blk_desc *dev_desc;
+	struct disk_partition info;
+
+	if (argc < 2)
+		return CMD_RET_USAGE;
+	if (argc > 3)
+		return CMD_RET_USAGE;
+
+	part = blk_get_device_part_str(argv[0], argv[1], &dev_desc, &info, 0);
+	if (part < 0)
+		return 1;
+
+	if (argc > 2)
+		env_set(argv[2], info.type_guid);
+	else
+		printf("%s\n", info.type_guid);
+
+	return 0;
+}
+
 static int do_part_types(int argc, char * const argv[])
 {
 	struct part_driver *drv = ll_entry_start(struct part_driver,
@@ -218,6 +241,8 @@ static int do_part(struct cmd_tbl *cmdtp, int flag, int argc,
 		return do_part_size(argc - 2, argv + 2);
 	else if (!strcmp(argv[1], "number"))
 		return do_part_number(argc - 2, argv + 2);
+	else if (!strcmp(argv[1], "type"))
+		return do_part_type(argc - 2, argv + 2);
 	else if (!strcmp(argv[1], "types"))
 		return do_part_types(argc - 2, argv + 2);
 	return CMD_RET_USAGE;
@@ -244,6 +269,10 @@ U_BOOT_CMD(
 	"part number <interface> <dev> <part> <varname>\n"
 	"    - set environment variable to the partition number using the partition name\n"
 	"      part must be specified as partition name\n"
+	"part type <interface> <dev>:<part>\n"
+	"    - print partition type\n"
+	"part type <interface> <dev>:<part> <varname>\n"
+	"    - set environment variable to partition type\n"
 	"part types\n"
 	"    - list supported partition table types"
 );
Signature · 1 line
2.37.1
#1 lore raw
Quoted 11 lines · Enric Balletbo i Serra

This implements the following command:

part type mmc 0:1
-> print partittion type UUID
part type mmc 0:1 uuid
-> set environment variable to partition type UUID

"part type" can be useful when writing a bootcmd which searches for a specific partition type to enable automatic discovery of partitions and their intended usage or mount point.

Quoted 5 lines

---

 cmd/part.c | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

Seems reasonable. Please update some of the existing tests (I don't know if test/py/tests/test_gpt.py or test/py/tests/test_part.py or perhaps both would be easier) for v2.

Signature · 1 line
Tom
#2 lore raw
In reply to Enric Balletbo i Serra
Quoted 4 lines · Enric Balletbo i Serra

This implements the following command:

part type mmc 0:1
-> print partittion type UUID

%s/partittion/partition/

Quoted 4 lines

part type mmc 0:1 uuid
-> set environment variable to partition type UUID

"part type" can be useful when writing a bootcmd which searches for a

Does such a command exist? Do you plan to implement such a command?

Quoted 53 lines

specific partition type to enable automatic discovery of partitions and their intended usage or mount point.

---

  cmd/part.c | 29 +++++++++++++++++++++++++++++
  1 file changed, 29 insertions(+)
cmd/part.c +25 -0
index 9d419c967c..26b0cc84fe 100644
@@ -182,6 +182,29 @@ static int do_part_number(int argc, char *const argv[])
  	return do_part_info(argc, argv, CMD_PART_INFO_NUMBER);
  }
 
+static int do_part_type(int argc, char *const argv[])
+{
+	int part;
+	struct blk_desc *dev_desc;
+	struct disk_partition info;
+
+	if (argc < 2)
+		return CMD_RET_USAGE;
+	if (argc > 3)
+		return CMD_RET_USAGE;
+
+	part = blk_get_device_part_str(argv[0], argv[1], &dev_desc, &info, 0);
+	if (part < 0)
+		return 1;
+
+	if (argc > 2)
+		env_set(argv[2], info.type_guid);
+	else
+		printf("%s\n", info.type_guid);
+
+	return 0;
+}
+
  static int do_part_types(int argc, char * const argv[])
  {
  	struct part_driver *drv = ll_entry_start(struct part_driver,
@@ -218,6 +241,8 @@ static int do_part(struct cmd_tbl *cmdtp, int flag, int argc,
  		return do_part_size(argc - 2, argv + 2);
  	else if (!strcmp(argv[1], "number"))
  		return do_part_number(argc - 2, argv + 2);
+	else if (!strcmp(argv[1], "type"))
+		return do_part_type(argc - 2, argv + 2);
  	else if (!strcmp(argv[1], "types"))
  		return do_part_types(argc - 2, argv + 2);
  	return CMD_RET_USAGE;

cmd/part.c U_BOOT_CMD( · line 275

Quoted 7 lines
cmd/part.c +4 -0
@@ -244,6 +269,10 @@ U_BOOT_CMD(
  	"part number <interface> <dev> <part> <varname>\n"
  	"    - set environment variable to the partition number using the partition name\n"
  	"      part must be specified as partition name\n"
+	"part type <interface> <dev>:<part>\n"
+	"    - print partition type\n"
+	"part type <interface> <dev>:<part> <varname>\n"
+	"    - set environment variable to partition type\n"

For each command we want a man-page in doc/usage/cmd. I miss a corresponding change in /doc.

Best regards

Heinrich

Quoted 3 lines
cmd/part.c +0 -0
  	"part types\n"
  	"    - list supported partition table types"
  );