Skip to contentSkip to conversation

iio: Whitespace cleanup

PATCH In review Joe Simmons-Talbott 2 participants 4 messages Jul 27, 2022 – Jul 31, 2022 IIO

lore
Share & tools
lore
#0 lore raw

cover iio: Whitespace cleanup

Fix whitespace warnings reported by checkpatch.pl.

Joe Simmons-Talbott (2):
iio: Add blank lines after declarations.
iio: Fix indentation for multiline conditional.

 drivers/iio/industrialio-buffer.c  | 5 +++--
 drivers/iio/industrialio-core.c    | 7 +++++++
 drivers/iio/industrialio-trigger.c | 1 +
 3 files changed, 11 insertions(+), 2 deletions(-)
Signature · 1 line
2.36.1
#1 lore raw

PATCH 1/2 iio: Add blank lines after declarations.

As reported by checkpatch.pl add blank lines after declarations.

---
 drivers/iio/industrialio-buffer.c  | 1 +
 drivers/iio/industrialio-core.c    | 7 +++++++
 drivers/iio/industrialio-trigger.c | 1 +
 3 files changed, 9 insertions(+)
drivers/iio/industrialio-buffer.c +1 -0
index acc2b6c05d57..47a6e97f8e48 100644
@@ -940,6 +940,7 @@ struct iio_demux_table {
 static void iio_buffer_demux_free(struct iio_buffer *buffer)
 {
 	struct iio_demux_table *p, *q;
+
 	list_for_each_entry_safe(p, q, &buffer->demux_list, l) {
 		list_del(&p->l);
 		kfree(p);
drivers/iio/industrialio-core.c +7 -0
index 0f4dbda3b9d3..40ebc63b7919 100644
@@ -236,6 +236,7 @@ static int iio_sysfs_match_string_with_gaps(const char * const *array, size_t n,
 struct dentry *iio_get_debugfs_dentry(struct iio_dev *indio_dev)
 {
 	struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);
+
 	return iio_dev_opaque->debugfs_dentry;
 }
 EXPORT_SYMBOL_GPL(iio_get_debugfs_dentry);
@@ -447,6 +448,7 @@ static const struct file_operations iio_debugfs_reg_fops = {
 static void iio_device_unregister_debugfs(struct iio_dev *indio_dev)
 {
 	struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);
+
 	debugfs_remove_recursive(iio_dev_opaque->debugfs_dentry);
 }
 
@@ -1021,6 +1023,7 @@ int __iio_device_attr_init(struct device_attribute *dev_attr,
 	int ret = 0;
 	char *name = NULL;
 	char *full_postfix;
+
 	sysfs_attr_init(&dev_attr->attr);
 
 	/* Build up postfix of <extend_name>_<modifier>_postfix */
@@ -1355,6 +1358,7 @@ static int iio_device_add_channel_sysfs(struct iio_dev *indio_dev,
 
 	if (chan->ext_info) {
 		unsigned int i = 0;
+
 		for (ext_info = chan->ext_info; ext_info->name; ext_info++) {
 			ret = __iio_add_chan_devattr(ext_info->name,
 					chan,
@@ -1403,6 +1407,7 @@ static ssize_t name_show(struct device *dev, struct device_attribute *attr,
 			 char *buf)
 {
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
+
 	return sysfs_emit(buf, "%s\n", indio_dev->name);
 }
 
@@ -1412,6 +1417,7 @@ static ssize_t label_show(struct device *dev, struct device_attribute *attr,
 			  char *buf)
 {
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
+
 	return sysfs_emit(buf, "%s\n", indio_dev->label);
 }
 
@@ -1777,6 +1783,7 @@ static int iio_chrdev_release(struct inode *inode, struct file *filp)
 	struct iio_dev_opaque *iio_dev_opaque =
 		container_of(inode->i_cdev, struct iio_dev_opaque, chrdev);
 	struct iio_dev *indio_dev = &iio_dev_opaque->indio_dev;
+
 	kfree(ib);
 	clear_bit(IIO_BUSY_BIT_POS, &iio_dev_opaque->flags);
 	iio_device_put(indio_dev);
drivers/iio/industrialio-trigger.c +1 -0
index b78814d869b7..6885a186fe27 100644
@@ -50,6 +50,7 @@ static ssize_t name_show(struct device *dev, struct device_attribute *attr,
 			 char *buf)
 {
 	struct iio_trigger *trig = to_iio_trigger(dev);
+
 	return sysfs_emit(buf, "%s\n", trig->name);
 }
 
Signature · 1 line
2.36.1
#2 lore raw

PATCH 2/2 iio: Fix indentation for multiline conditional.

In reply to Joe Simmons-Talbott

As reported by checkpatch.pl make indentation match previous conditional.

---
 drivers/iio/industrialio-buffer.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/industrialio-buffer.c +2 -2
index 47a6e97f8e48..228598b82a2f 100644
@@ -843,8 +843,8 @@ static int iio_verify_update(struct iio_dev *indio_dev,
 	 * to verify.
 	 */
 	if (remove_buffer && !insert_buffer &&
-		list_is_singular(&iio_dev_opaque->buffer_list))
-			return 0;
+	    list_is_singular(&iio_dev_opaque->buffer_list))
+		return 0;
 
 	modes = indio_dev->modes;
 
Signature · 1 line
2.36.1
maintainer
#3 lore raw
In reply to Joe Simmons-Talbott
Quoted 1 line · On Wed, 27 Jul 2022 14:18:53 -0400 Joe Simmons-Talbott <[email protected]>…

Fix whitespace warnings reported by checkpatch.pl.

Hi Joe,

Series applied to the togreg branch of iio.git and pushed out as testing. Note I'll rebase that branch on rc1 once available and not push out as togreg until after that.

Thanks,

Jonathan

Quoted 10 lines

Joe Simmons-Talbott (2):
iio: Add blank lines after declarations.
iio: Fix indentation for multiline conditional.

 drivers/iio/industrialio-buffer.c  | 5 +++--
 drivers/iio/industrialio-core.c    | 7 +++++++
 drivers/iio/industrialio-trigger.c | 1 +
 3 files changed, 11 insertions(+), 2 deletions(-)