Skip to contentSkip to conversation

fpga: microchip-spi: add missing module author entry

PATCH Applied Conor Dooley 4 participants 5 messages Jul 28, 2022 – Aug 15, 2022

Subsystems (2)
lore
Share & tools
lore

Conor Dooley

author maintainer
#0 lore raw

PATCH 1/1 fpga: microchip-spi: add missing module author entry

Add the missing MODULE_AUTHOR entry for the Microchip spi-slave FPGA programming driver.

---
 drivers/fpga/microchip-spi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/fpga/microchip-spi.c +1 -0
index bd284c7b8dc9..7436976ea904 100644
@@ -395,4 +395,5 @@ static struct spi_driver mpf_driver = {
 module_spi_driver(mpf_driver);
 
 MODULE_DESCRIPTION("Microchip Polarfire SPI FPGA Manager");
+MODULE_AUTHOR("Ivan Bornyakov <[email protected]>");
 MODULE_LICENSE("GPL");
Signature · 1 line
2.36.1
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Conor Dooley

Add the missing MODULE_AUTHOR entry for the Microchip spi-slave FPGA programming driver.

Quoted 14 lines
---
  drivers/fpga/microchip-spi.c | 1 +
  1 file changed, 1 insertion(+)
drivers/fpga/microchip-spi.c +1 -0
index bd284c7b8dc9..7436976ea904 100644
@@ -395,4 +395,5 @@ static struct spi_driver mpf_driver = {
  module_spi_driver(mpf_driver);
 
  MODULE_DESCRIPTION("Microchip Polarfire SPI FPGA Manager");
+MODULE_AUTHOR("Ivan Bornyakov <[email protected]>");
  MODULE_LICENSE("GPL");
maintainer Acked-by Applied
#2 lore raw
Quoted 7 lines · Tom Rix
Quoted 4 lines · Conor Dooley

Add the missing MODULE_AUTHOR entry for the Microchip spi-slave FPGA programming driver.

Applied to for-next

Quoted 14 lines
Quoted 13 lines
---
  drivers/fpga/microchip-spi.c | 1 +
  1 file changed, 1 insertion(+)
drivers/fpga/microchip-spi.c +1 -0
index bd284c7b8dc9..7436976ea904 100644
@@ -395,4 +395,5 @@ static struct spi_driver mpf_driver = {
  module_spi_driver(mpf_driver);
  MODULE_DESCRIPTION("Microchip Polarfire SPI FPGA Manager");
+MODULE_AUTHOR("Ivan Bornyakov <[email protected]>");
  MODULE_LICENSE("GPL");
Acked-by on v1 1/1
#3 lore raw
In reply to Conor Dooley
Quoted 21 lines · Conor Dooley

Add the missing MODULE_AUTHOR entry for the Microchip spi-slave FPGA programming driver.

---
 drivers/fpga/microchip-spi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/fpga/microchip-spi.c +1 -0
index bd284c7b8dc9..7436976ea904 100644
@@ -395,4 +395,5 @@ static struct spi_driver mpf_driver = {
 module_spi_driver(mpf_driver);
 
 MODULE_DESCRIPTION("Microchip Polarfire SPI FPGA Manager");
+MODULE_AUTHOR("Ivan Bornyakov <[email protected]>");
 MODULE_LICENSE("GPL");
Signature · 1 line
2.36.1

Yet, I'm wondering in what situations MODULE_AUTHOR is needed? I've submitted a couple of other drivers without it, should I fix them?

author maintainer
#4 lore raw
Quoted 25 lines · Ivan Bornyakov
Quoted 21 lines · Conor Dooley

Add the missing MODULE_AUTHOR entry for the Microchip spi-slave FPGA programming driver.

---
 drivers/fpga/microchip-spi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/fpga/microchip-spi.c +1 -0
index bd284c7b8dc9..7436976ea904 100644
@@ -395,4 +395,5 @@ static struct spi_driver mpf_driver = {
 module_spi_driver(mpf_driver);
 
 MODULE_DESCRIPTION("Microchip Polarfire SPI FPGA Manager");
+MODULE_AUTHOR("Ivan Bornyakov <[email protected]>");
 MODULE_LICENSE("GPL");
Signature · 1 line
2.36.1
Quoted 3 lines

Yet, I'm wondering in what situations MODULE_AUTHOR is needed? I've submitted a couple of other drivers without it, should I fix them?

It'll show up in modinfo. I don't think it's a big deal though. /shrug
Conor.