Skip to contentSkip to conversation

tests: acpi: silence applesmc warning about invalid key

PATCH In review Igor Mammedov 3 participants 4 messages Jul 28, 2022 – Aug 9, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests: acpi: silence applesmc warning about invalid key

OSK value is irrelevant for ACPI test case.
Supply fake OSK explicitly to prevent QEMU complaining about invalid key when it fallbacks to default_osk.

---
 tests/qtest/bios-tables-test.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
tests/qtest/bios-tables-test.c +3 -1
index 359916c228..7c5f736b51 100644
@@ -1632,7 +1632,9 @@ static void test_acpi_q35_applesmc(void)
         .variant = ".applesmc",
     };
 
-    test_acpi_one("-device isa-applesmc", &data);
+    /* supply fake 64-byte OSK to silence missing key warning */
+    test_acpi_one("-device isa-applesmc,osk=any64characterfakeoskisenough"
+                  "topreventinvalidkeywarningsonstderr", &data);
     free_test_data(&data);
 }
 
Signature · 1 line
2.31.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 15 lines · Igor Mammedov

OSK value is irrelevant for ACPI test case.
Supply fake OSK explicitly to prevent QEMU complaining about invalid key when it fallbacks to default_osk.

---
 tests/qtest/bios-tables-test.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
tests/qtest/bios-tables-test.c +0 -0
index 359916c228..7c5f736b51 100644

tests/qtest/bios-tables-test.c static void test_acpi_q35_applesmc(void) · line 1639

Quoted 9 lines
tests/qtest/bios-tables-test.c +3 -1
@@ -1632,7 +1632,9 @@ static void test_acpi_q35_applesmc(void)
         .variant = ".applesmc",
     };
 
-    test_acpi_one("-device isa-applesmc", &data);
+    /* supply fake 64-byte OSK to silence missing key warning */
+    test_acpi_one("-device isa-applesmc,osk=any64characterfakeoskisenough"
+                  "topreventinvalidkeywarningsonstderr", &data);
     free_test_data(&data);
 }

All 64 chars present and correct.

With regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
#2 lore raw
In reply to Igor Mammedov
Quoted 6 lines · On Thu, 28 Jul 2022 09:37:13 -0400 Igor Mammedov <[email protected]> wrote:

OSK value is irrelevant for ACPI test case.
Supply fake OSK explicitly to prevent QEMU complaining about invalid key when it fallbacks to default_osk.

Michael,
can you pick it up?

Quoted 19 lines
---
 tests/qtest/bios-tables-test.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
tests/qtest/bios-tables-test.c +3 -1
index 359916c228..7c5f736b51 100644
@@ -1632,7 +1632,9 @@ static void test_acpi_q35_applesmc(void)
         .variant = ".applesmc",
     };
 
-    test_acpi_one("-device isa-applesmc", &data);
+    /* supply fake 64-byte OSK to silence missing key warning */
+    test_acpi_one("-device isa-applesmc,osk=any64characterfakeoskisenough"
+                  "topreventinvalidkeywarningsonstderr", &data);
     free_test_data(&data);
 }
 
#3 lore raw
Quoted 7 lines · Igor Mammedov
Quoted 4 lines · On Thu, 28 Jul 2022 09:37:13 -0400 Igor Mammedov <[email protected]> wrote:

OSK value is irrelevant for ACPI test case.
Supply fake OSK explicitly to prevent QEMU complaining about invalid key when it fallbacks to default_osk.

Quoted 5 lines
Quoted 2 lines

Michael,
can you pick it up?

Yes! In the next pull. I was hoping the linux seed thing will settle but apparently no luck ...

Quoted 19 lines
Quoted 19 lines
---
 tests/qtest/bios-tables-test.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
tests/qtest/bios-tables-test.c +3 -1
index 359916c228..7c5f736b51 100644
@@ -1632,7 +1632,9 @@ static void test_acpi_q35_applesmc(void)
         .variant = ".applesmc",
     };
 
-    test_acpi_one("-device isa-applesmc", &data);
+    /* supply fake 64-byte OSK to silence missing key warning */
+    test_acpi_one("-device isa-applesmc,osk=any64characterfakeoskisenough"
+                  "topreventinvalidkeywarningsonstderr", &data);
     free_test_data(&data);
 }