Skip to contentSkip to conversation

dt-bindings: remove the dead code in cmd_mk_schema

PATCH In review Masahiro Yamada 2 participants 2 messages Jul 29, 2022 – Aug 1, 2022 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: remove the dead code in cmd_mk_schema

Since commit 2783a7f56f99 ("dt-bindings: kbuild: Pass DT_SCHEMA_FILES to dt-validate"), the processed schema takes all the YAML files.

Remove the dead code.

---

 Documentation/devicetree/bindings/Makefile | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/Makefile +2 -4
index c9953f86b19d..223df2a023fd 100644
@@ -42,10 +42,8 @@ quiet_cmd_chk_bindings = CHKDT   $@
 
 quiet_cmd_mk_schema = SCHEMA  $@
       cmd_mk_schema = f=$$(mktemp) ; \
-                      $(if $(DT_MK_SCHEMA_FLAGS), \
-                           printf '%s\n' $(real-prereqs), \
-                           $(find_all_cmd)) > $$f ; \
-                      $(DT_MK_SCHEMA) -j $(DT_MK_SCHEMA_FLAGS) @$$f > $@ ; \
+		      $(find_all_cmd) > $$f ; \
+		      $(DT_MK_SCHEMA) -j @$$f > $@ ; \
 		      rm -f $$f
 
 define rule_chkdt
Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 10 lines · Masahiro Yamada

Since commit 2783a7f56f99 ("dt-bindings: kbuild: Pass DT_SCHEMA_FILES to dt-validate"), the processed schema takes all the YAML files.

Remove the dead code.

---

 Documentation/devicetree/bindings/Makefile | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

I also sent out a similar patch[1].

Quoted 6 lines
Documentation/devicetree/bindings/Makefile +0 -0
index c9953f86b19d..223df2a023fd 100644

Documentation/devicetree/bindings/Makefile quiet_cmd_chk_bindings = CHKDT $@ · line 46

Quoted 9 lines
Documentation/devicetree/bindings/Makefile +2 -4
@@ -42,10 +42,8 @@ quiet_cmd_chk_bindings = CHKDT   $@
 
 quiet_cmd_mk_schema = SCHEMA  $@
       cmd_mk_schema = f=$$(mktemp) ; \
-                      $(if $(DT_MK_SCHEMA_FLAGS), \
-                           printf '%s\n' $(real-prereqs), \
-                           $(find_all_cmd)) > $$f ; \
-                      $(DT_MK_SCHEMA) -j $(DT_MK_SCHEMA_FLAGS) @$$f > $@ ; \
+		      $(find_all_cmd) > $$f ; \
+		      $(DT_MK_SCHEMA) -j @$$f > $@ ; \

I want to keep DT_MK_SCHEMA_FLAGS because I'm working on a new optional flag to pass.

Rob

[1] https://lore.kernel.org/all/[email protected]/