Skip to contentSkip to conversation

toolchain/Config.in: improve gcc bug 43744 condition

PATCH In review Giulio Benetti 2 participants 3 messages Jul 29, 2022 – Jul 30, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 toolchain/Config.in: improve gcc bug 43744 condition

This makes the condition easier to read and it's easier to maintain the gcc bug too because we don't have to take care about new gcc versions.

---
 toolchain/Config.in | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
toolchain/Config.in +3 -6
index 3cc747c1cc..d2fc347d36 100644
@@ -113,12 +113,9 @@ config BR2_TOOLCHAIN_SUPPORTS_VARIADIC_MI_THUNK
 # reappeared on gcc 9.x and is still not fixed on gcc 11.x
 config BR2_TOOLCHAIN_HAS_GCC_BUG_43744
 	bool
-	default y if BR2_sh4
-	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8 || \
-		BR2_TOOLCHAIN_GCC_AT_LEAST_9 || \
-		BR2_TOOLCHAIN_GCC_AT_LEAST_10 || \
-		BR2_TOOLCHAIN_GCC_AT_LEAST_11 || \
-		BR2_TOOLCHAIN_GCC_AT_LEAST_12
+	default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8
+	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_9
+	depends on BR2_sh4
 
 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63261. This bug no
 # longer exists in gcc 8.x.
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH 1/1 toolchain/Config.in: improve gcc bug 83143 condition

This makes the condition easier to read and it's easier to maintain the gcc bug too because we don't have to take care about new gcc versions.

---
 toolchain/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
toolchain/Config.in +3 -3
index d2fc347d36..507075a351 100644
@@ -147,9 +147,9 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_68485
 # it still not been fixed yet.
 config BR2_TOOLCHAIN_HAS_GCC_BUG_83143
 	bool
-	default y if BR2_sh
-	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_10 || BR2_TOOLCHAIN_GCC_AT_LEAST_11 || \
-		   BR2_TOOLCHAIN_GCC_AT_LEAST_12
+	default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_10
+	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_11
+	depends on BR2_sh
 
 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180. This bug no
 # longer exists in gcc 8.x.
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw
In reply to Giulio Benetti

Giulio, All,

On 2022-07-29 22:44 +0200, Giulio Benetti spake thusly:

Quoted 4 lines

This makes the condition easier to read and it's easier to maintain the gcc bug too because we don't have to take care about new gcc versions.

Series of two patches applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 31 lines
---
 toolchain/Config.in | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
toolchain/Config.in +3 -6
index 3cc747c1cc..d2fc347d36 100644
@@ -113,12 +113,9 @@ config BR2_TOOLCHAIN_SUPPORTS_VARIADIC_MI_THUNK
 # reappeared on gcc 9.x and is still not fixed on gcc 11.x
 config BR2_TOOLCHAIN_HAS_GCC_BUG_43744
 	bool
-	default y if BR2_sh4
-	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8 || \
-		BR2_TOOLCHAIN_GCC_AT_LEAST_9 || \
-		BR2_TOOLCHAIN_GCC_AT_LEAST_10 || \
-		BR2_TOOLCHAIN_GCC_AT_LEAST_11 || \
-		BR2_TOOLCHAIN_GCC_AT_LEAST_12
+	default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8
+	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_9
+	depends on BR2_sh4
 
 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63261. This bug no
 # longer exists in gcc 8.x.
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot