Skip to contentSkip to conversation

kernel-hung_task-fix-address-space-of-proc_dohung_task_timeout_secs.patch removed from -mm tree

merged mm-nonmm-stable Andrew Morton 1 participant 1 message Jul 30, 2022

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: kernel/hung_task: fix address space of proc_dohung_task_timeout_secs
has been removed from the -mm tree. Its filename was
kernel-hung_task-fix-address-space-of-proc_dohung_task_timeout_secs.patch

This patch was dropped because it was merged into the mm-nonmm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Ben Dooks <[email protected]>
Subject: kernel/hung_task: fix address space of proc_dohung_task_timeout_secs
Date: Thu, 14 Jul 2022 08:47:44 +0100

The proc_dohung_task_timeout_secs() function is incorrectly marked as having a __user buffer as argument 3. However this is not the case and it is casing multiple sparse warnings. Fix the following warnings by removing __user from the argument:

kernel/hung_task.c:237:52: warning: incorrect type in argument 3 (different address spaces)
kernel/hung_task.c:237:52: expected void *
kernel/hung_task.c:237:52: got void [noderef] __user *buffer
kernel/hung_task.c:287:35: warning: incorrect type in initializer (incompatible argument 3 (different address spaces))
kernel/hung_task.c:287:35: expected int ( [usertype] *proc_handler )( ... )
kernel/hung_task.c:287:35: got int ( * )( ... )
kernel/hung_task.c:295:35: warning: incorrect type in initializer (incompatible argument 3 (different address spaces))
kernel/hung_task.c:295:35: expected int ( [usertype] *proc_handler )( ... )
kernel/hung_task.c:295:35: got int ( * )( ... )

---

 kernel/hung_task.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/hung_task.c renamed from kernel/hung_task.c~kernel-hung_task-fix-address-space-of-proc_dohung_task_timeout_secs +1 -1
@@ -229,7 +229,7 @@ static long hung_timeout_jiffies(unsigne
  * Process updating of timeout sysctl
  */
 static int proc_dohung_task_timeout_secs(struct ctl_table *table, int write,
-				  void __user *buffer,
+				  void *buffer,
 				  size_t *lenp, loff_t *ppos)
 {
 	int ret;

_

Patches currently in -mm which might be from [email protected] are