Skip to contentSkip to conversation

ARM: dts: qcom: msm8960: add reference to sleep_clk

PATCH In review Shinjo Park 4 participants 7 messages Jul 28, 2022 – Aug 2, 2022

Subsystems (2)
Device tree bindings Arm Qualcomm mailing list
lore
Share & tools
lore

Shinjo Park

author
#0 lore raw

PATCH 1/3 ARM: dts: qcom: msm8960: add reference to sleep_clk

Change the reference of sleep_clk to the same as qcom-apq8064.dtsi.

Signed-off-by Shinjo Park <[email protected]>
Reviewed-by David Heidelberg <[email protected]>
---
 arch/arm/boot/dts/qcom-msm8960.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/qcom-msm8960.dtsi +1 -1
index e8cd1c9c0..991eb1948 100644
@@ -71,7 +71,7 @@ pxo_board: pxo_board {
 			clock-output-names = "pxo_board";
 		};
 
-		sleep_clk {
+		sleep_clk: sleep_clk {
 			compatible = "fixed-clock";
 			#clock-cells = <0>;
 			clock-frequency = <32768>;
Signature · 1 line
2.34.1
#1 lore raw
Quoted 1 line · Shinjo Park

Change the reference of sleep_clk to the same as qcom-apq8064.dtsi.

You add label, not change something.

Quoted 12 lines
Signed-off-by Shinjo Park <[email protected]>
Reviewed-by David Heidelberg <[email protected]>
---
 arch/arm/boot/dts/qcom-msm8960.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/qcom-msm8960.dtsi +0 -0
index e8cd1c9c0..991eb1948 100644

arch/arm/boot/dts/qcom-msm8960.dtsi pxo_board: pxo_board { · line 74

Quoted 5 lines
arch/arm/boot/dts/qcom-msm8960.dtsi +1 -1
@@ -71,7 +71,7 @@ pxo_board: pxo_board {
 			clock-output-names = "pxo_board";
 		};
 
-		sleep_clk {
+		sleep_clk: sleep_clk {

Since you touch the line, make the device node sleep-clk (device node names should not have underscores) and mention this in commit msg.

Best regards,
Krzysztof

#2 lore raw
Quoted 20 lines · Krzysztof Kozlowski
Quoted 1 line · Shinjo Park

Change the reference of sleep_clk to the same as qcom-apq8064.dtsi.

You add label, not change something.

Quoted 15 lines
Signed-off-by Shinjo Park <[email protected]>
Reviewed-by David Heidelberg <[email protected]>
---
  arch/arm/boot/dts/qcom-msm8960.dtsi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/qcom-msm8960.dtsi +0 -0
index e8cd1c9c0..991eb1948 100644
@@ -71,7 +71,7 @@ pxo_board: pxo_board {
  			clock-output-names = "pxo_board";
  		};
Quoted 5 lines

arch/arm/boot/dts/qcom-msm8960.dtsi pxo_board: pxo_board { · line 74

Quoted 2 lines
arch/arm/boot/dts/qcom-msm8960.dtsi +1 -1
-		sleep_clk {
+		sleep_clk: sleep_clk {

Since you touch the line, make the device node sleep-clk (device node names should not have underscores) and mention this in commit msg.

Then we are back to the compat issues, since the gcc expects the 'sleep_clk' clock.

Signature · 2 lines
With best wishes
Dmitry
#3 lore raw
Quoted 27 lines · Dmitry Baryshkov
Quoted 12 lines · Krzysztof Kozlowski
Quoted 1 line · Shinjo Park

Change the reference of sleep_clk to the same as qcom-apq8064.dtsi.

You add label, not change something.

Quoted 7 lines
Signed-off-by Shinjo Park <[email protected]>
Reviewed-by David Heidelberg <[email protected]>

---
  arch/arm/boot/dts/qcom-msm8960.dtsi | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 12 lines

arch/arm/boot/dts/qcom-msm8960.dtsi pxo_board: pxo_board { · line 74

Quoted 9 lines
arch/arm/boot/dts/qcom-msm8960.dtsi +1 -0
index e8cd1c9c0..991eb1948 100644
@@ -71,7 +71,7 @@ pxo_board: pxo_board {
               clock-output-names = "pxo_board";
           };
   -        sleep_clk {
+        sleep_clk: sleep_clk {

Since you touch the line, make the device node sleep-clk (device node names should not have underscores) and mention this in commit msg.

Quoted 1 line

Then we are back to the compat issues, since the gcc expects the 'sleep_clk' clock.

clock-output-names = "sleep_clk";

Konrad

Quoted 2 lines
#4 lore raw
Quoted 30 lines · Konrad Dybcio
Quoted 27 lines · Dmitry Baryshkov
Quoted 24 lines · Krzysztof Kozlowski
Quoted 1 line · Shinjo Park

Change the reference of sleep_clk to the same as qcom-apq8064.dtsi.

You add label, not change something.

Quoted 12 lines
Signed-off-by Shinjo Park <[email protected]>
Reviewed-by David Heidelberg <[email protected]>
---
   arch/arm/boot/dts/qcom-msm8960.dtsi | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/qcom-msm8960.dtsi +0 -0
index e8cd1c9c0..991eb1948 100644

arch/arm/boot/dts/qcom-msm8960.dtsi pxo_board: pxo_board { · line 74

Quoted 4 lines
arch/arm/boot/dts/qcom-msm8960.dtsi +1 -0
@@ -71,7 +71,7 @@ pxo_board: pxo_board {
               clock-output-names = "pxo_board";
           };
   -        sleep_clk {
+        sleep_clk: sleep_clk {

Since you touch the line, make the device node sleep-clk (device node names should not have underscores) and mention this in commit msg.

Quoted 2 lines
Quoted 1 line

Then we are back to the compat issues, since the gcc expects the 'sleep_clk' clock.

clock-output-names = "sleep_clk";

Ack then. Didn't notice that msm8960 has one.

Signature · 2 lines
With best wishes
Dmitry
author
#5 lore raw

PATCH v2 1/3 ARM: dts: qcom: msm8960: change the device node of sleep_clk

In reply to Konrad Dybcio

Change the device node of sleep_clk to sleep-clk, and add a label. This follows the similar convention as qcom-apq8064.dtsi.

Signed-off-by Shinjo Park <[email protected]>
Reviewed-by David Heidelberg <[email protected]>

---

v2:
- Rewrite commit message
- Rename device node to not contain underscore

 arch/arm/boot/dts/qcom-msm8960.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/qcom-msm8960.dtsi +1 -1
index e8cd1c9c0924..e1f010c9643e 100644
@@ -71,7 +71,7 @@ pxo_board: pxo_board {
 			clock-output-names = "pxo_board";
 		};
 
-		sleep_clk {
+		sleep_clk: sleep-clk {
 			compatible = "fixed-clock";
 			#clock-cells = <0>;
 			clock-frequency = <32768>;
Signature · 1 line
2.34.1
Reviewed-by on v2 1/3
#6 lore raw

Re: [PATCH v2 1/3] ARM: dts: qcom: msm8960: change the device node of sleep_clk

Quoted 10 lines · Shinjo Park

Change the device node of sleep_clk to sleep-clk, and add a label. This follows the similar convention as qcom-apq8064.dtsi.

Signed-off-by Shinjo Park <[email protected]>
Reviewed-by David Heidelberg <[email protected]>

---

v2:
- Rewrite commit message
- Rename device node to not contain underscore

Reviewed-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof