scsi: megaraid_sas: remove redundant variable cmd_type
Subsystems (3)
PATCH 1/1 scsi: megaraid_sas: remove redundant variable cmd_type
The variable cmd_type is assigned a value but it is never read. The variable and the assignment are redundant and can be removed.
Cleans up clang scan build warning:drivers/scsi/megaraid/megaraid_sas_fusion.c:3228:10: warning: Although the value stored to 'cmd_type' is used in the enclosing expression, the value is never actually read from 'cmd_type' [deadcode.DeadStores]
Signed-off-by Colin Ian King <[email protected]>
--- drivers/scsi/megaraid/megaraid_sas_fusion.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/scsi/megaraid/megaraid_sas_fusion.c +1 -2
@@ -3199,7 +3199,6 @@ megasas_build_io_fusion(struct megasas_instance *instance, struct megasas_cmd_fusion *cmd) {int sge_count; -u8 cmd_type;u16 pd_index =0 ;u8 drive_type =0 ;struct MPI2_RAID_SCSI_IO_REQUEST *io_request = cmd->io_request;
@@ -3225,7 +3224,7 @@ megasas_build_io_fusion(struct megasas_instance *instance,*/ io_request->IoFlags =cpu_to_le16 (scp->cmd_len); -switch (cmd_type =megasas_cmd_type (scp)) { +switch (megasas_cmd_type (scp)) {case READ_WRITE_LDIO :megasas_build_ldio_fusion (instance, scp, cmd);break ;
Signature · 1 line
2.35.3
Martin K. Petersen
AppliedColin,
Quoted 2 lines
The variable
cmd_typeis assigned a value but it is never read. The variable and the assignment are redundant and can be removed.
Applied to 5.20/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering