ARM: crypto: comment out gcc warning that breaks clang builds
Subsystems (2)
Greg Kroah-Hartman
maintainerPATCH 1/1 ARM: crypto: comment out gcc warning that breaks clang builds
From: Greg Kroah-Hartman <[email protected]>
The gcc build warning prevents all clang-built kernels from working properly, so comment it out to fix the build.
This is a -stable kernel only patch for now, it will be resolved differently in mainline releases in the future.
--- arch/arm/lib/xor-neon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/lib/xor-neon.c +2 -1
@@ -26,8 +26,9 @@ MODULE_LICENSE("GPL");* While older versions of GCC do not generate incorrect code, they fail to * recognize the parallel nature of these functions, and emit plain ARM code, * which is known to be slower than the optimized ARM code in asm-arm/xor.h. +* +* #warning This code requires at least version 4.6 of GCC */ -#warning This code requires at least version 4.6 of GCC#endif #pragma GCC diagnostic ignored "-Wunused-variable"
Signature · 1 line
2.37.1
Quoted 26 lines · Greg Kroah-Hartman
From: Greg Kroah-Hartman <[email protected]>
The gcc build warning prevents all clang-built kernels from working properly, so comment it out to fix the build.
This is a -stable kernel only patch for now, it will be resolved differently in mainline releases in the future.
Cc "Jason A. Donenfeld" <[email protected]>Cc "Justin M. Forbes" <[email protected]>Cc Ard Biesheuvel <[email protected]>Cc Arnd Bergmann <[email protected]>Cc Nicolas Pitre <[email protected]>Cc Nathan Chancellor <[email protected]>Cc Nick Desaulniers <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>--- arch/arm/lib/xor-neon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)arch/arm/lib/xor-neon.c +0
-0
arch/arm/lib/xor-neon.c MODULE_LICENSE("GPL"); · line 34
Quoted 10 lines
arch/arm/lib/xor-neon.c +2
-1@@ -26,8 +26,9 @@ MODULE_LICENSE("GPL");* While older versions of GCC do not generate incorrect code, they fail to * recognize the parallel nature of these functions, and emit plain ARM code, * which is known to be slower than the optimized ARM code in asm-arm/xor.h. +* +* #warning This code requires at least version 4.6 of GCC */ -#warning This code requires at least version 4.6 of GCC#endif #pragma GCC diagnostic ignored "-Wunused-variable"
LGTM but doesn't Clang also complain about the GCC specific pragma?
Greg Kroah-Hartman
maintainerQuoted 37 lines · Ard Biesheuvel
Quoted 35 lines · Greg Kroah-Hartman
From: Greg Kroah-Hartman <[email protected]>
The gcc build warning prevents all clang-built kernels from working properly, so comment it out to fix the build.
This is a -stable kernel only patch for now, it will be resolved differently in mainline releases in the future.
Cc "Jason A. Donenfeld" <[email protected]>Cc "Justin M. Forbes" <[email protected]>Cc Ard Biesheuvel <[email protected]>Cc Arnd Bergmann <[email protected]>Cc Nicolas Pitre <[email protected]>Cc Nathan Chancellor <[email protected]>Cc Nick Desaulniers <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>--- arch/arm/lib/xor-neon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)arch/arm/lib/xor-neon.c +2
-1@@ -26,8 +26,9 @@ MODULE_LICENSE("GPL");* While older versions of GCC do not generate incorrect code, they fail to * recognize the parallel nature of these functions, and emit plain ARM code, * which is known to be slower than the optimized ARM code in asm-arm/xor.h. +* +* #warning This code requires at least version 4.6 of GCC */ -#warning This code requires at least version 4.6 of GCC#endif
Quoted 3 lines
arch/arm/lib/xor-neon.c MODULE_LICENSE("GPL"); · line 34
Quoted 1 line
arch/arm/lib/xor-neon.c +0
-0#pragma GCC diagnostic ignored "-Wunused-variable"LGTM but doesn't Clang also complain about the GCC specific pragma?
I don't know, all clang builds always failed at the first #warning line :)
Quoted 39 lines · Greg Kroah-Hartman
Quoted 37 lines · Ard Biesheuvel
Quoted 35 lines · Greg Kroah-Hartman
From: Greg Kroah-Hartman <[email protected]>
The gcc build warning prevents all clang-built kernels from working properly, so comment it out to fix the build.
This is a -stable kernel only patch for now, it will be resolved differently in mainline releases in the future.
Cc "Jason A. Donenfeld" <[email protected]>Cc "Justin M. Forbes" <[email protected]>Cc Ard Biesheuvel <[email protected]>Cc Arnd Bergmann <[email protected]>Cc Nicolas Pitre <[email protected]>Cc Nathan Chancellor <[email protected]>Cc Nick Desaulniers <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>--- arch/arm/lib/xor-neon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)arch/arm/lib/xor-neon.c +2
-1@@ -26,8 +26,9 @@ MODULE_LICENSE("GPL");* While older versions of GCC do not generate incorrect code, they fail to * recognize the parallel nature of these functions, and emit plain ARM code, * which is known to be slower than the optimized ARM code in asm-arm/xor.h. +* +* #warning This code requires at least version 4.6 of GCC */ -#warning This code requires at least version 4.6 of GCC#endif
Quoted 5 lines
Quoted 3 lines
arch/arm/lib/xor-neon.c MODULE_LICENSE("GPL"); · line 34
Quoted 1 line
arch/arm/lib/xor-neon.c +0
-0#pragma GCC diagnostic ignored "-Wunused-variable"LGTM but doesn't Clang also complain about the GCC specific pragma?
I don't know, all clang builds always failed at the first #warning line :)
Just tried it, and it appears to ignore the #pragma so we're all good.
Greg Kroah-Hartman
maintainerQuoted 41 lines · Ard Biesheuvel
Quoted 39 lines · Greg Kroah-Hartman
Quoted 37 lines · Ard Biesheuvel
Quoted 35 lines · Greg Kroah-Hartman
From: Greg Kroah-Hartman <[email protected]>
The gcc build warning prevents all clang-built kernels from working properly, so comment it out to fix the build.
This is a -stable kernel only patch for now, it will be resolved differently in mainline releases in the future.
Cc "Jason A. Donenfeld" <[email protected]>Cc "Justin M. Forbes" <[email protected]>Cc Ard Biesheuvel <[email protected]>Cc Arnd Bergmann <[email protected]>Cc Nicolas Pitre <[email protected]>Cc Nathan Chancellor <[email protected]>Cc Nick Desaulniers <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>--- arch/arm/lib/xor-neon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)arch/arm/lib/xor-neon.c +2
-1@@ -26,8 +26,9 @@ MODULE_LICENSE("GPL");* While older versions of GCC do not generate incorrect code, they fail to * recognize the parallel nature of these functions, and emit plain ARM code, * which is known to be slower than the optimized ARM code in asm-arm/xor.h. +* +* #warning This code requires at least version 4.6 of GCC */ -#warning This code requires at least version 4.6 of GCC#endif
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
arch/arm/lib/xor-neon.c MODULE_LICENSE("GPL"); · line 34
Quoted 1 line
arch/arm/lib/xor-neon.c +0
-0#pragma GCC diagnostic ignored "-Wunused-variable"LGTM but doesn't Clang also complain about the GCC specific pragma?
I don't know, all clang builds always failed at the first #warning line :)
Just tried it, and it appears to ignore the #pragma so we're all good.
Wonderful, thanks for testing.
greg k-h
Quoted 9 lines · Greg Kroah-Hartman
From: Greg Kroah-Hartman <[email protected]>
The gcc build warning prevents all clang-built kernels from working properly, so comment it out to fix the build.
This is a -stable kernel only patch for now, it will be resolved differently in mainline releases in the future.
Quoted 8 lines
Cc "Jason A. Donenfeld" <[email protected]>Cc "Justin M. Forbes" <[email protected]>Cc Ard Biesheuvel <[email protected]>Cc Arnd Bergmann <[email protected]>Cc Nicolas Pitre <[email protected]>Cc Nathan Chancellor <[email protected]>Cc Nick Desaulniers <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
I always resisted this from going into mainline without actually making the code work
as intended on clang, but now that mainline kernels get it right and we have decided not to backport the new version, this is the best we can do for LTS backports.
Arnd