Skip to contentSkip to conversation

net/tls: Remove redundant workqueue flush before destroy

PATCH Applied Tariq Toukan 2 participants 2 messages Aug 1, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/tls: Remove redundant workqueue flush before destroy

destroy_workqueue() safely destroys the workqueue after draining it. No need for the explicit call to flush_workqueue(). Remove it.

---
 net/tls/tls_device.c | 1 -
 1 file changed, 1 deletion(-)
net/tls/tls_device.c +0 -1
index 18c7e5c6d228..e3e6cf75aa03 100644
@@ -1449,7 +1449,6 @@ int __init tls_device_init(void)
 void __exit tls_device_cleanup(void)
 {
 	unregister_netdevice_notifier(&tls_dev_notifier);
-	flush_workqueue(destruct_wq);
 	destroy_workqueue(destruct_wq);
 	clean_acked_data_flush();
 }
Signature · 1 line
2.21.3
#1 lore raw
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:

Quoted 7 lines · On Mon, 1 Aug 2022 14:24:44 +0300 you wrote:

destroy_workqueue() safely destroys the workqueue after draining it. No need for the explicit call to flush_workqueue(). Remove it.

---
 net/tls/tls_device.c | 1 -
 1 file changed, 1 deletion(-)

Here is the summary with links:
- [net-next] net/tls: Remove redundant workqueue flush before destroy

    https://git.kernel.org/netdev/net-next/c/d81c7cdd7a6d

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html