Skip to contentSkip to conversation

dt-bindings: PCI: mediatek-gen3: Add support for MT8188 and MT8195

PATCH Applied Jianjun Wang 3 participants 6 messages Aug 2, 2022 – Aug 23, 2022

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 dt-bindings: PCI: mediatek-gen3: Add support for MT8188 and MT8195

MT8188 and MT8195 are ARM platform SoCs with the same PCIe IP as MT8192.

Also add new clock name "peri_mem" since the MT8188 and MT8195 use clock "peri_mem" instead of "top_133m".

---
Changes in v4:
Remove "items" for "mediatek,mt8192-pcie" since it only have one item.

Changes in v3:
Use enum property to add the new clock name.

Changes in v2:
Merge two patches into one.

---
 .../devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml +11 -2
index 0499b94627ae..c00be39af64e 100644
@@ -48,7 +48,13 @@ allOf:
 
 properties:
   compatible:
-    const: mediatek,mt8192-pcie
+    oneOf:
+      - items:
+          - enum:
+              - mediatek,mt8188-pcie
+              - mediatek,mt8195-pcie
+          - const: mediatek,mt8192-pcie
+      - const: mediatek,mt8192-pcie
 
   reg:
     maxItems: 1
@@ -84,7 +90,9 @@ properties:
       - const: tl_96m
       - const: tl_32k
       - const: peri_26m
-      - const: top_133m
+      - enum:
+          - top_133m        # for MT8192
+          - peri_mem        # for MT8188/MT8195
 
   assigned-clocks:
     maxItems: 1
@@ -126,6 +134,7 @@ required:
   - interrupts
   - ranges
   - clocks
+  - clock-names
   - '#interrupt-cells'
   - interrupt-controller
 
Signature · 1 line
2.18.0
#2 lore raw
Quoted 6 lines · Krzysztof Kozlowski
Quoted 5 lines · Jianjun Wang

MT8188 and MT8195 are ARM platform SoCs with the same PCIe IP as MT8192.

Also add new clock name "peri_mem" since the MT8188 and MT8195 use clock "peri_mem" instead of "top_133m".

Quoted 7 lines
Quoted 4 lines

---
Changes in v4:
Remove "items" for "mediatek,mt8192-pcie" since it only have one item.

Should I pick this up ?

Thanks,
Lorenzo

#3 lore raw
Quoted 13 lines · Lorenzo Pieralisi
Quoted 12 lines · Krzysztof Kozlowski
Quoted 9 lines · Jianjun Wang

MT8188 and MT8195 are ARM platform SoCs with the same PCIe IP as MT8192.

Also add new clock name "peri_mem" since the MT8188 and MT8195 use clock "peri_mem" instead of "top_133m".

---
Changes in v4:
Remove "items" for "mediatek,mt8192-pcie" since it only have one item.

Quoted 3 lines
Quoted 1 line

Should I pick this up ?

Yes, go ahead. Thanks!

Best regards,
Krzysztof

#4 lore raw
In reply to Jianjun Wang

Hi Maintainers,

Gentle ping for this patch, if there is anything I need to modify, please kindly let me know.

Thanks.

Quoted 63 lines · Jianjun Wang

MT8188 and MT8195 are ARM platform SoCs with the same PCIe IP as MT8192.

Also add new clock name "peri_mem" since the MT8188 and MT8195 use clock
"peri_mem" instead of "top_133m".

---
Changes in v4:
Remove "items" for "mediatek,mt8192-pcie" since it only have one item.

Changes in v3:
Use enum property to add the new clock name.

Changes in v2:
Merge two patches into one.

---
 .../devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 13
+++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie- gen3.yaml
index 0499b94627ae..c00be39af64e 100644

Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml +11 -2
@@ -48,7 +48,13 @@ allOf:
 
 properties:
   compatible:
-    const: mediatek,mt8192-pcie
+    oneOf:
+      - items:
+          - enum:
+              - mediatek,mt8188-pcie
+              - mediatek,mt8195-pcie
+          - const: mediatek,mt8192-pcie
+      - const: mediatek,mt8192-pcie
 
   reg:
     maxItems: 1
@@ -84,7 +90,9 @@ properties:
       - const: tl_96m
       - const: tl_32k
       - const: peri_26m
-      - const: top_133m
+      - enum:
+          - top_133m        # for MT8192
+          - peri_mem        # for MT8188/MT8195
 
   assigned-clocks:
     maxItems: 1
@@ -126,6 +134,7 @@ required:
   - interrupts
   - ranges
   - clocks
+  - clock-names
   - '#interrupt-cells'
   - interrupt-controller